Sanitize Reg Entries in SerialPort.GetPortNames (Issue 93240) by ctacke · Pull Request #93242 · dotnet/runtime

ctacke · 2023-10-09T16:56:21Z

Edit (@krwq): Using correct syntax so that issue linking works

ghost · 2023-10-09T16:56:34Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

Author:	ctacke
Assignees:	-
Labels:	`area-System.IO`, `community-contribution`
Milestone:	-

ghost · 2023-10-10T21:24:17Z

Tagging subscribers to this area: @dotnet/area-system-io-ports
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`community-contribution`, `area-System.IO.Ports`
Milestone:	-

adamsitnik

@ctacke thank you for your contribution!

The main owner of System.IO.Ports is currently offline, in the meantime I've tagged the owners of Microsoft.Win32.Registry to verify whether it should be fixed here or in the API that IO Ports is simply calling.

adamsitnik · 2023-11-03T08:05:24Z

- result[i] = (string)serialKey.GetValue(result[i]);
+ // Replace the name in the array with its value, trimming at the first null character if it exists
+ var temp = (string)serialKey.GetValue(result[i]);
+ var end = temp.IndexOf('\0');


I am not sure whether we should try to workaround the null characters here. Ideally RegistryKey.GetValueNames should do it out of the box.
@dotnet/area-microsoft-win32 thoughts?

GetValueNames looks like better choice to me. can you please give it try @ctacke ?

I'm not sure what the suggestion is. The Value Name is not the issue, the Value itself is. I can't "try GetValueNames" as a resolution, because it doesn't give the data I need.
You could certainly argue that Registry.GetValue should be stopping at the first null, but I don't know if there are other instances where a null-containing string might be valid data. If null-containing strings are generally considered invalid data for registry entries, then yes, the bug would be in Registry.GetValue

I may be wrong but it seems like this is what the method does e.g. terminates on null (while the GetValue does not)
https://learn.microsoft.com/en-us/dotnet/api/microsoft.win32.registrykey.getvaluenames?view=net-8.0#microsoft-win32-registrykey-getvaluenames
Perhaps @adamsitnik can explain more.

krwq · 2024-01-22T11:58:33Z

@ctacke could you please investigate if the recommended API is suitable for usage? I don't have any hardware where I could try this out

ghost · 2024-02-05T15:01:44Z

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

ghost · 2024-02-19T18:01:05Z

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

ctacke · 2023-10-09T16:56:21Z

Fixes: #93240

Edit (@krwq): Using correct syntax so that issue linking works

ghost · 2023-10-09T16:56:34Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`area-System.IO`, `community-contribution`
Milestone:	-

ghost · 2023-10-10T21:24:17Z

Tagging subscribers to this area: @dotnet/area-system-io-ports
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`community-contribution`, `area-System.IO.Ports`
Milestone:	-

adamsitnik

@ctacke thank you for your contribution!

The main owner of System.IO.Ports is currently offline, in the meantime I've tagged the owners of Microsoft.Win32.Registry to verify whether it should be fixed here or in the API that IO Ports is simply calling.

adamsitnik · 2023-11-03T08:05:24Z

- result[i] = (string)serialKey.GetValue(result[i]);
+ // Replace the name in the array with its value, trimming at the first null character if it exists
+ var temp = (string)serialKey.GetValue(result[i]);
+ var end = temp.IndexOf('\0');


I am not sure whether we should try to workaround the null characters here. Ideally RegistryKey.GetValueNames should do it out of the box.
@dotnet/area-microsoft-win32 thoughts?

GetValueNames looks like better choice to me. can you please give it try @ctacke ?

I'm not sure what the suggestion is. The Value Name is not the issue, the Value itself is. I can't "try GetValueNames" as a resolution, because it doesn't give the data I need.
You could certainly argue that Registry.GetValue should be stopping at the first null, but I don't know if there are other instances where a null-containing string might be valid data. If null-containing strings are generally considered invalid data for registry entries, then yes, the bug would be in Registry.GetValue

I may be wrong but it seems like this is what the method does e.g. terminates on null (while the GetValue does not)
https://learn.microsoft.com/en-us/dotnet/api/microsoft.win32.registrykey.getvaluenames?view=net-8.0#microsoft-win32-registrykey-getvaluenames
Perhaps @adamsitnik can explain more.

krwq · 2024-01-22T11:58:33Z

@ctacke could you please investigate if the recommended API is suitable for usage? I don't have any hardware where I could try this out

ghost · 2024-02-05T15:01:44Z

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

ghost · 2024-02-19T18:01:05Z

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

ctacke · 2023-10-09T16:56:21Z

Fixes: #93240

Edit (@krwq): Using correct syntax so that issue linking works

ghost · 2023-10-09T16:56:34Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`area-System.IO`, `community-contribution`
Milestone:	-

ghost · 2023-10-10T21:24:17Z

Tagging subscribers to this area: @dotnet/area-system-io-ports
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`community-contribution`, `area-System.IO.Ports`
Milestone:	-

adamsitnik

@ctacke thank you for your contribution!

The main owner of System.IO.Ports is currently offline, in the meantime I've tagged the owners of Microsoft.Win32.Registry to verify whether it should be fixed here or in the API that IO Ports is simply calling.

adamsitnik · 2023-11-03T08:05:24Z

- result[i] = (string)serialKey.GetValue(result[i]);
+ // Replace the name in the array with its value, trimming at the first null character if it exists
+ var temp = (string)serialKey.GetValue(result[i]);
+ var end = temp.IndexOf('\0');


I am not sure whether we should try to workaround the null characters here. Ideally RegistryKey.GetValueNames should do it out of the box.
@dotnet/area-microsoft-win32 thoughts?

GetValueNames looks like better choice to me. can you please give it try @ctacke ?

I'm not sure what the suggestion is. The Value Name is not the issue, the Value itself is. I can't "try GetValueNames" as a resolution, because it doesn't give the data I need.
You could certainly argue that Registry.GetValue should be stopping at the first null, but I don't know if there are other instances where a null-containing string might be valid data. If null-containing strings are generally considered invalid data for registry entries, then yes, the bug would be in Registry.GetValue

I may be wrong but it seems like this is what the method does e.g. terminates on null (while the GetValue does not)
https://learn.microsoft.com/en-us/dotnet/api/microsoft.win32.registrykey.getvaluenames?view=net-8.0#microsoft-win32-registrykey-getvaluenames
Perhaps @adamsitnik can explain more.

krwq · 2024-01-22T11:58:33Z

@ctacke could you please investigate if the recommended API is suitable for usage? I don't have any hardware where I could try this out

ghost · 2024-02-05T15:01:44Z

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

ghost · 2024-02-19T18:01:05Z

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

ctacke · 2023-10-09T16:56:21Z

Fixes: #93240

Edit (@krwq): Using correct syntax so that issue linking works

ghost · 2023-10-09T16:56:34Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`area-System.IO`, `community-contribution`
Milestone:	-

ghost · 2023-10-10T21:24:17Z

Tagging subscribers to this area: @dotnet/area-system-io-ports
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`community-contribution`, `area-System.IO.Ports`
Milestone:	-

adamsitnik

@ctacke thank you for your contribution!

The main owner of System.IO.Ports is currently offline, in the meantime I've tagged the owners of Microsoft.Win32.Registry to verify whether it should be fixed here or in the API that IO Ports is simply calling.

adamsitnik · 2023-11-03T08:05:24Z

- result[i] = (string)serialKey.GetValue(result[i]);
+ // Replace the name in the array with its value, trimming at the first null character if it exists
+ var temp = (string)serialKey.GetValue(result[i]);
+ var end = temp.IndexOf('\0');


I am not sure whether we should try to workaround the null characters here. Ideally RegistryKey.GetValueNames should do it out of the box.
@dotnet/area-microsoft-win32 thoughts?

GetValueNames looks like better choice to me. can you please give it try @ctacke ?

I'm not sure what the suggestion is. The Value Name is not the issue, the Value itself is. I can't "try GetValueNames" as a resolution, because it doesn't give the data I need.
You could certainly argue that Registry.GetValue should be stopping at the first null, but I don't know if there are other instances where a null-containing string might be valid data. If null-containing strings are generally considered invalid data for registry entries, then yes, the bug would be in Registry.GetValue

I may be wrong but it seems like this is what the method does e.g. terminates on null (while the GetValue does not)
https://learn.microsoft.com/en-us/dotnet/api/microsoft.win32.registrykey.getvaluenames?view=net-8.0#microsoft-win32-registrykey-getvaluenames
Perhaps @adamsitnik can explain more.

krwq · 2024-01-22T11:58:33Z

@ctacke could you please investigate if the recommended API is suitable for usage? I don't have any hardware where I could try this out

ghost · 2024-02-05T15:01:44Z

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

ghost · 2024-02-19T18:01:05Z

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

ctacke · 2023-10-09T16:56:21Z

Fixes: #93240

Edit (@krwq): Using correct syntax so that issue linking works

ghost · 2023-10-09T16:56:34Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`area-System.IO`, `community-contribution`
Milestone:	-

ghost · 2023-10-10T21:24:17Z

Tagging subscribers to this area: @dotnet/area-system-io-ports
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`community-contribution`, `area-System.IO.Ports`
Milestone:	-

adamsitnik

@ctacke thank you for your contribution!

The main owner of System.IO.Ports is currently offline, in the meantime I've tagged the owners of Microsoft.Win32.Registry to verify whether it should be fixed here or in the API that IO Ports is simply calling.

adamsitnik · 2023-11-03T08:05:24Z

- result[i] = (string)serialKey.GetValue(result[i]);
+ // Replace the name in the array with its value, trimming at the first null character if it exists
+ var temp = (string)serialKey.GetValue(result[i]);
+ var end = temp.IndexOf('\0');


I am not sure whether we should try to workaround the null characters here. Ideally RegistryKey.GetValueNames should do it out of the box.
@dotnet/area-microsoft-win32 thoughts?

GetValueNames looks like better choice to me. can you please give it try @ctacke ?

I'm not sure what the suggestion is. The Value Name is not the issue, the Value itself is. I can't "try GetValueNames" as a resolution, because it doesn't give the data I need.
You could certainly argue that Registry.GetValue should be stopping at the first null, but I don't know if there are other instances where a null-containing string might be valid data. If null-containing strings are generally considered invalid data for registry entries, then yes, the bug would be in Registry.GetValue

I may be wrong but it seems like this is what the method does e.g. terminates on null (while the GetValue does not)
https://learn.microsoft.com/en-us/dotnet/api/microsoft.win32.registrykey.getvaluenames?view=net-8.0#microsoft-win32-registrykey-getvaluenames
Perhaps @adamsitnik can explain more.

krwq · 2024-01-22T11:58:33Z

@ctacke could you please investigate if the recommended API is suitable for usage? I don't have any hardware where I could try this out

ghost · 2024-02-05T15:01:44Z

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

ghost · 2024-02-19T18:01:05Z

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

ctacke · 2023-10-09T16:56:21Z

Fixes: #93240

Edit (@krwq): Using correct syntax so that issue linking works

ghost · 2023-10-09T16:56:34Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`area-System.IO`, `community-contribution`
Milestone:	-

ghost · 2023-10-10T21:24:17Z

Tagging subscribers to this area: @dotnet/area-system-io-ports
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`community-contribution`, `area-System.IO.Ports`
Milestone:	-

adamsitnik

@ctacke thank you for your contribution!

The main owner of System.IO.Ports is currently offline, in the meantime I've tagged the owners of Microsoft.Win32.Registry to verify whether it should be fixed here or in the API that IO Ports is simply calling.

adamsitnik · 2023-11-03T08:05:24Z

- result[i] = (string)serialKey.GetValue(result[i]);
+ // Replace the name in the array with its value, trimming at the first null character if it exists
+ var temp = (string)serialKey.GetValue(result[i]);
+ var end = temp.IndexOf('\0');


I am not sure whether we should try to workaround the null characters here. Ideally RegistryKey.GetValueNames should do it out of the box.
@dotnet/area-microsoft-win32 thoughts?

GetValueNames looks like better choice to me. can you please give it try @ctacke ?

I'm not sure what the suggestion is. The Value Name is not the issue, the Value itself is. I can't "try GetValueNames" as a resolution, because it doesn't give the data I need.
You could certainly argue that Registry.GetValue should be stopping at the first null, but I don't know if there are other instances where a null-containing string might be valid data. If null-containing strings are generally considered invalid data for registry entries, then yes, the bug would be in Registry.GetValue

I may be wrong but it seems like this is what the method does e.g. terminates on null (while the GetValue does not)
https://learn.microsoft.com/en-us/dotnet/api/microsoft.win32.registrykey.getvaluenames?view=net-8.0#microsoft-win32-registrykey-getvaluenames
Perhaps @adamsitnik can explain more.

krwq · 2024-01-22T11:58:33Z

@ctacke could you please investigate if the recommended API is suitable for usage? I don't have any hardware where I could try this out

ghost · 2024-02-05T15:01:44Z

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

ghost · 2024-02-19T18:01:05Z

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

ctacke · 2023-10-09T16:56:21Z

Fixes: #93240

Edit (@krwq): Using correct syntax so that issue linking works

ghost · 2023-10-09T16:56:34Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`area-System.IO`, `community-contribution`
Milestone:	-

ghost · 2023-10-10T21:24:17Z

Tagging subscribers to this area: @dotnet/area-system-io-ports
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`community-contribution`, `area-System.IO.Ports`
Milestone:	-

adamsitnik

@ctacke thank you for your contribution!

The main owner of System.IO.Ports is currently offline, in the meantime I've tagged the owners of Microsoft.Win32.Registry to verify whether it should be fixed here or in the API that IO Ports is simply calling.

adamsitnik · 2023-11-03T08:05:24Z

- result[i] = (string)serialKey.GetValue(result[i]);
+ // Replace the name in the array with its value, trimming at the first null character if it exists
+ var temp = (string)serialKey.GetValue(result[i]);
+ var end = temp.IndexOf('\0');


I am not sure whether we should try to workaround the null characters here. Ideally RegistryKey.GetValueNames should do it out of the box.
@dotnet/area-microsoft-win32 thoughts?

GetValueNames looks like better choice to me. can you please give it try @ctacke ?

I'm not sure what the suggestion is. The Value Name is not the issue, the Value itself is. I can't "try GetValueNames" as a resolution, because it doesn't give the data I need.
You could certainly argue that Registry.GetValue should be stopping at the first null, but I don't know if there are other instances where a null-containing string might be valid data. If null-containing strings are generally considered invalid data for registry entries, then yes, the bug would be in Registry.GetValue

I may be wrong but it seems like this is what the method does e.g. terminates on null (while the GetValue does not)
https://learn.microsoft.com/en-us/dotnet/api/microsoft.win32.registrykey.getvaluenames?view=net-8.0#microsoft-win32-registrykey-getvaluenames
Perhaps @adamsitnik can explain more.

krwq · 2024-01-22T11:58:33Z

@ctacke could you please investigate if the recommended API is suitable for usage? I don't have any hardware where I could try this out

ghost · 2024-02-05T15:01:44Z

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

ghost · 2024-02-19T18:01:05Z

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

ctacke · 2023-10-09T16:56:21Z

Fixes: #93240

Edit (@krwq): Using correct syntax so that issue linking works

ghost · 2023-10-09T16:56:34Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`area-System.IO`, `community-contribution`
Milestone:	-

ghost · 2023-10-10T21:24:17Z

Tagging subscribers to this area: @dotnet/area-system-io-ports
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix for Issue 93240

#93240

Author:	ctacke
Assignees:	-
Labels:	`community-contribution`, `area-System.IO.Ports`
Milestone:	-

adamsitnik

@ctacke thank you for your contribution!

The main owner of System.IO.Ports is currently offline, in the meantime I've tagged the owners of Microsoft.Win32.Registry to verify whether it should be fixed here or in the API that IO Ports is simply calling.

adamsitnik · 2023-11-03T08:05:24Z

- result[i] = (string)serialKey.GetValue(result[i]);
+ // Replace the name in the array with its value, trimming at the first null character if it exists
+ var temp = (string)serialKey.GetValue(result[i]);
+ var end = temp.IndexOf('\0');


I am not sure whether we should try to workaround the null characters here. Ideally RegistryKey.GetValueNames should do it out of the box.
@dotnet/area-microsoft-win32 thoughts?

GetValueNames looks like better choice to me. can you please give it try @ctacke ?

I'm not sure what the suggestion is. The Value Name is not the issue, the Value itself is. I can't "try GetValueNames" as a resolution, because it doesn't give the data I need.
You could certainly argue that Registry.GetValue should be stopping at the first null, but I don't know if there are other instances where a null-containing string might be valid data. If null-containing strings are generally considered invalid data for registry entries, then yes, the bug would be in Registry.GetValue

I may be wrong but it seems like this is what the method does e.g. terminates on null (while the GetValue does not)
https://learn.microsoft.com/en-us/dotnet/api/microsoft.win32.registrykey.getvaluenames?view=net-8.0#microsoft-win32-registrykey-getvaluenames
Perhaps @adamsitnik can explain more.

krwq · 2024-01-22T11:58:33Z

@ctacke could you please investigate if the recommended API is suitable for usage? I don't have any hardware where I could try this out

ghost · 2024-02-05T15:01:44Z

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

ghost · 2024-02-19T18:01:05Z

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

Sanitize Reg Entries in SerialPort.GetPortNames
b1aad53

ghost added area-System.IO community-contribution Indicates that the PR has been added by a community member labels Oct 9, 2023

ctacke mentioned this pull request Oct 9, 2023
SerialPort.GetPortNames not handling poor registry data #93240
Open

build-analysisBot mentioned this pull request Oct 9, 2023
Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter fails occasionally #93229
Closed

jozkee added area-System.IO.Ports and removed area-System.IO labels Oct 10, 2023

adamsitnik assigned krwq Nov 3, 2023

adamsitnik requested a review from krwq November 3, 2023 08:00

adamsitnik reviewed Nov 3, 2023
View reviewed changes

krwq added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 22, 2024

ghost added the no-recent-activity label Feb 5, 2024

ghost closed this Feb 19, 2024

github-actionsBot locked and limited conversation to collaborators Mar 21, 2024

This pull request was closed.

Sanitize Reg Entries in SerialPort.GetPortNames
b1aad53

ghost added area-System.IO community-contribution Indicates that the PR has been added by a community member labels Oct 9, 2023

ctacke mentioned this pull request Oct 9, 2023
SerialPort.GetPortNames not handling poor registry data #93240
Open

build-analysisBot mentioned this pull request Oct 9, 2023
Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter fails occasionally #93229
Closed

jozkee added area-System.IO.Ports and removed area-System.IO labels Oct 10, 2023

adamsitnik assigned krwq Nov 3, 2023

adamsitnik requested a review from krwq November 3, 2023 08:00

adamsitnik reviewed Nov 3, 2023
View reviewed changes

krwq added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 22, 2024

ghost added the no-recent-activity label Feb 5, 2024

ghost closed this Feb 19, 2024

github-actionsBot locked and limited conversation to collaborators Mar 21, 2024

This pull request was closed.

Sanitize Reg Entries in SerialPort.GetPortNames
b1aad53

ghost added area-System.IO community-contribution Indicates that the PR has been added by a community member labels Oct 9, 2023

ctacke mentioned this pull request Oct 9, 2023
SerialPort.GetPortNames not handling poor registry data #93240
Open

build-analysisBot mentioned this pull request Oct 9, 2023
Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter fails occasionally #93229
Closed

jozkee added area-System.IO.Ports and removed area-System.IO labels Oct 10, 2023

adamsitnik assigned krwq Nov 3, 2023

adamsitnik requested a review from krwq November 3, 2023 08:00

adamsitnik reviewed Nov 3, 2023
View reviewed changes

krwq added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 22, 2024

ghost added the no-recent-activity label Feb 5, 2024

ghost closed this Feb 19, 2024

github-actionsBot locked and limited conversation to collaborators Mar 21, 2024

This pull request was closed.

Sanitize Reg Entries in SerialPort.GetPortNames
b1aad53

ghost added area-System.IO community-contribution Indicates that the PR has been added by a community member labels Oct 9, 2023

ctacke mentioned this pull request Oct 9, 2023
SerialPort.GetPortNames not handling poor registry data #93240
Open

build-analysisBot mentioned this pull request Oct 9, 2023
Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter fails occasionally #93229
Closed

jozkee added area-System.IO.Ports and removed area-System.IO labels Oct 10, 2023

adamsitnik assigned krwq Nov 3, 2023

adamsitnik requested a review from krwq November 3, 2023 08:00

adamsitnik reviewed Nov 3, 2023
View reviewed changes

krwq added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 22, 2024

ghost added the no-recent-activity label Feb 5, 2024

ghost closed this Feb 19, 2024

github-actionsBot locked and limited conversation to collaborators Mar 21, 2024

This pull request was closed.

Sanitize Reg Entries in SerialPort.GetPortNames
b1aad53

ghost added area-System.IO community-contribution Indicates that the PR has been added by a community member labels Oct 9, 2023

ctacke mentioned this pull request Oct 9, 2023
SerialPort.GetPortNames not handling poor registry data #93240
Open

build-analysisBot mentioned this pull request Oct 9, 2023
Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter fails occasionally #93229
Closed

jozkee added area-System.IO.Ports and removed area-System.IO labels Oct 10, 2023

adamsitnik assigned krwq Nov 3, 2023

adamsitnik requested a review from krwq November 3, 2023 08:00

adamsitnik reviewed Nov 3, 2023
View reviewed changes

krwq added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 22, 2024

ghost added the no-recent-activity label Feb 5, 2024

ghost closed this Feb 19, 2024

github-actionsBot locked and limited conversation to collaborators Mar 21, 2024

This pull request was closed.

Sanitize Reg Entries in SerialPort.GetPortNames
b1aad53

ghost added area-System.IO community-contribution Indicates that the PR has been added by a community member labels Oct 9, 2023

ctacke mentioned this pull request Oct 9, 2023
SerialPort.GetPortNames not handling poor registry data #93240
Open

build-analysisBot mentioned this pull request Oct 9, 2023
Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter fails occasionally #93229
Closed

jozkee added area-System.IO.Ports and removed area-System.IO labels Oct 10, 2023

adamsitnik assigned krwq Nov 3, 2023

adamsitnik requested a review from krwq November 3, 2023 08:00

adamsitnik reviewed Nov 3, 2023
View reviewed changes

krwq added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 22, 2024

ghost added the no-recent-activity label Feb 5, 2024

ghost closed this Feb 19, 2024

github-actionsBot locked and limited conversation to collaborators Mar 21, 2024

This pull request was closed.

Sanitize Reg Entries in SerialPort.GetPortNames
b1aad53

ghost added area-System.IO community-contribution Indicates that the PR has been added by a community member labels Oct 9, 2023

ctacke mentioned this pull request Oct 9, 2023
SerialPort.GetPortNames not handling poor registry data #93240
Open

build-analysisBot mentioned this pull request Oct 9, 2023
Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter fails occasionally #93229
Closed

jozkee added area-System.IO.Ports and removed area-System.IO labels Oct 10, 2023

adamsitnik assigned krwq Nov 3, 2023

adamsitnik requested a review from krwq November 3, 2023 08:00

adamsitnik reviewed Nov 3, 2023
View reviewed changes

krwq added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 22, 2024

ghost added the no-recent-activity label Feb 5, 2024

ghost closed this Feb 19, 2024

github-actionsBot locked and limited conversation to collaborators Mar 21, 2024

This pull request was closed.

Sanitize Reg Entries in SerialPort.GetPortNames
b1aad53

ghost added area-System.IO community-contribution Indicates that the PR has been added by a community member labels Oct 9, 2023

ctacke mentioned this pull request Oct 9, 2023
SerialPort.GetPortNames not handling poor registry data #93240
Open

build-analysisBot mentioned this pull request Oct 9, 2023
Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter fails occasionally #93229
Closed

jozkee added area-System.IO.Ports and removed area-System.IO labels Oct 10, 2023

adamsitnik assigned krwq Nov 3, 2023

adamsitnik requested a review from krwq November 3, 2023 08:00

adamsitnik reviewed Nov 3, 2023
View reviewed changes

krwq added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 22, 2024

ghost added the no-recent-activity label Feb 5, 2024

ghost closed this Feb 19, 2024

github-actionsBot locked and limited conversation to collaborators Mar 21, 2024

This pull request was closed.

Uh oh!

Conversation

ctacke commented Oct 9, 2023• edited by krwq Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 9, 2023

Uh oh!

ghost commented Oct 10, 2023

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

krwq commented Jan 22, 2024

Uh oh!

ghost commented Feb 5, 2024

Uh oh!

ghost commented Feb 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

ctacke commented Oct 9, 2023• edited by krwq Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 9, 2023

Uh oh!

ghost commented Oct 10, 2023

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

krwq commented Jan 22, 2024

Uh oh!

ghost commented Feb 5, 2024

Uh oh!

ghost commented Feb 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

ctacke commented Oct 9, 2023• edited by krwq Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 9, 2023

Uh oh!

ghost commented Oct 10, 2023

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

ctacke commented Oct 9, 2023•
edited by krwq
Loading

ctacke commented Oct 9, 2023•
edited by krwq
Loading

ctacke commented Oct 9, 2023•
edited by krwq
Loading

ctacke commented Oct 9, 2023•
edited by krwq
Loading