Reference live ILLink analyzer by sbomer · Pull Request #93259 · dotnet/runtime

sbomer · 2023-10-09T21:25:06Z

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

ghost · 2023-10-09T21:25:25Z

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

Author:	sbomer
Assignees:	sbomer
Labels:	`area-Tools-ILLink`
Milestone:	-

sbomer · 2023-10-12T22:14:10Z

CI uncovered another assert, which I'm fixing separately in #93420.

#93259 uncovered an issue around how the analyzer tracks arrays. It hit an analyzer assert while trying to create an l-value flow capture of another flow capture reference, which should never happen as far as I understand. The assert was firing for https://github.com/dotnet/runtime/blob/946c5245aea149d9ece53fd0debc18328c29083b/src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs#L511 Now tested in TestNullCoalescingAssignment: ```csharp (arr ??= arr2)[0] = typeof (V); ``` The CFG had three flow captures: - capture 0: an l-value flow capture of `arr`. Used later in the branch that assigns `arr2` to `arr`. - capture 1: an r-value flow capture of capture 0. This was checked for null. - capture 2: an l-value flow capture representing `arr ??= arr2`, used to write index 0 of the array. - In the == null branch, this captured the result of an assignment (capture 0 = `arr2`) - In the other branch, it captured "capture 1". This is where the assert was hit. The bug, I believe, is that capture 2 should have been an r-value flow capture instead. Even though it's used for writing to the array, the assignment doesn't modify the array pointer represented by this capture - it dereferences this pointer and modifies the array. This was introduced by my modifications to the l-value detection logic in #90287. This undoes that portion of the change so that capture 2 is now treated as an r-value capture. This simplifies the array element assignment logic so that it no longer can see an assignment where the array is an l-value. Fixes#93420 by adding an explicit check for `IsInitialization` so that we don't hit the related asserts for string interpolation handlers.

sbomer · 2023-10-19T18:20:00Z

I fixed a few more asserts that came up after #93420:

Assert inside GetFlowCaptureValue for the LHS of a compound assignment. I couldn't think of a case yet where we actually need to model the result of the assignment, so I implemented support for at least visiting the LHS by going through the same path as normal assignments (avoiding GetFlowCaptureValue).
Assert inside GetFlowCaptureValue for a flow capture reference passed as an out param.
Added a test for deconstruction assignment to flow capture reference.

ViktorHofer

Also verified that this change doesn't require updating our solution files again in src/libraries.

sbomer · 2023-10-20T16:41:50Z

Test failure looks like #90019

sbomer · 2023-10-09T21:25:06Z

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

ghost · 2023-10-09T21:25:25Z

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

Author:	sbomer
Assignees:	sbomer
Labels:	`area-Tools-ILLink`
Milestone:	-

sbomer · 2023-10-12T22:14:10Z

CI uncovered another assert, which I'm fixing separately in #93420.

#93259 uncovered an issue around how the analyzer tracks arrays. It hit an analyzer assert while trying to create an l-value flow capture of another flow capture reference, which should never happen as far as I understand. The assert was firing for https://github.com/dotnet/runtime/blob/946c5245aea149d9ece53fd0debc18328c29083b/src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs#L511 Now tested in TestNullCoalescingAssignment: ```csharp (arr ??= arr2)[0] = typeof (V); ``` The CFG had three flow captures: - capture 0: an l-value flow capture of `arr`. Used later in the branch that assigns `arr2` to `arr`. - capture 1: an r-value flow capture of capture 0. This was checked for null. - capture 2: an l-value flow capture representing `arr ??= arr2`, used to write index 0 of the array. - In the == null branch, this captured the result of an assignment (capture 0 = `arr2`) - In the other branch, it captured "capture 1". This is where the assert was hit. The bug, I believe, is that capture 2 should have been an r-value flow capture instead. Even though it's used for writing to the array, the assignment doesn't modify the array pointer represented by this capture - it dereferences this pointer and modifies the array. This was introduced by my modifications to the l-value detection logic in #90287. This undoes that portion of the change so that capture 2 is now treated as an r-value capture. This simplifies the array element assignment logic so that it no longer can see an assignment where the array is an l-value. Fixes#93420 by adding an explicit check for `IsInitialization` so that we don't hit the related asserts for string interpolation handlers.

sbomer · 2023-10-19T18:20:00Z

I fixed a few more asserts that came up after #93420:

Assert inside GetFlowCaptureValue for the LHS of a compound assignment. I couldn't think of a case yet where we actually need to model the result of the assignment, so I implemented support for at least visiting the LHS by going through the same path as normal assignments (avoiding GetFlowCaptureValue).
Assert inside GetFlowCaptureValue for a flow capture reference passed as an out param.
Added a test for deconstruction assignment to flow capture reference.

ViktorHofer

Also verified that this change doesn't require updating our solution files again in src/libraries.

sbomer · 2023-10-20T16:41:50Z

Test failure looks like #90019

sbomer · 2023-10-09T21:25:06Z

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

ghost · 2023-10-09T21:25:25Z

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

Author:	sbomer
Assignees:	sbomer
Labels:	`area-Tools-ILLink`
Milestone:	-

sbomer · 2023-10-12T22:14:10Z

CI uncovered another assert, which I'm fixing separately in #93420.

#93259 uncovered an issue around how the analyzer tracks arrays. It hit an analyzer assert while trying to create an l-value flow capture of another flow capture reference, which should never happen as far as I understand. The assert was firing for https://github.com/dotnet/runtime/blob/946c5245aea149d9ece53fd0debc18328c29083b/src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs#L511 Now tested in TestNullCoalescingAssignment: ```csharp (arr ??= arr2)[0] = typeof (V); ``` The CFG had three flow captures: - capture 0: an l-value flow capture of `arr`. Used later in the branch that assigns `arr2` to `arr`. - capture 1: an r-value flow capture of capture 0. This was checked for null. - capture 2: an l-value flow capture representing `arr ??= arr2`, used to write index 0 of the array. - In the == null branch, this captured the result of an assignment (capture 0 = `arr2`) - In the other branch, it captured "capture 1". This is where the assert was hit. The bug, I believe, is that capture 2 should have been an r-value flow capture instead. Even though it's used for writing to the array, the assignment doesn't modify the array pointer represented by this capture - it dereferences this pointer and modifies the array. This was introduced by my modifications to the l-value detection logic in #90287. This undoes that portion of the change so that capture 2 is now treated as an r-value capture. This simplifies the array element assignment logic so that it no longer can see an assignment where the array is an l-value. Fixes#93420 by adding an explicit check for `IsInitialization` so that we don't hit the related asserts for string interpolation handlers.

sbomer · 2023-10-19T18:20:00Z

I fixed a few more asserts that came up after #93420:

Assert inside GetFlowCaptureValue for the LHS of a compound assignment. I couldn't think of a case yet where we actually need to model the result of the assignment, so I implemented support for at least visiting the LHS by going through the same path as normal assignments (avoiding GetFlowCaptureValue).
Assert inside GetFlowCaptureValue for a flow capture reference passed as an out param.
Added a test for deconstruction assignment to flow capture reference.

ViktorHofer

Also verified that this change doesn't require updating our solution files again in src/libraries.

sbomer · 2023-10-20T16:41:50Z

Test failure looks like #90019

sbomer · 2023-10-09T21:25:06Z

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

ghost · 2023-10-09T21:25:25Z

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

Author:	sbomer
Assignees:	sbomer
Labels:	`area-Tools-ILLink`
Milestone:	-

sbomer · 2023-10-12T22:14:10Z

CI uncovered another assert, which I'm fixing separately in #93420.

#93259 uncovered an issue around how the analyzer tracks arrays. It hit an analyzer assert while trying to create an l-value flow capture of another flow capture reference, which should never happen as far as I understand. The assert was firing for https://github.com/dotnet/runtime/blob/946c5245aea149d9ece53fd0debc18328c29083b/src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs#L511 Now tested in TestNullCoalescingAssignment: ```csharp (arr ??= arr2)[0] = typeof (V); ``` The CFG had three flow captures: - capture 0: an l-value flow capture of `arr`. Used later in the branch that assigns `arr2` to `arr`. - capture 1: an r-value flow capture of capture 0. This was checked for null. - capture 2: an l-value flow capture representing `arr ??= arr2`, used to write index 0 of the array. - In the == null branch, this captured the result of an assignment (capture 0 = `arr2`) - In the other branch, it captured "capture 1". This is where the assert was hit. The bug, I believe, is that capture 2 should have been an r-value flow capture instead. Even though it's used for writing to the array, the assignment doesn't modify the array pointer represented by this capture - it dereferences this pointer and modifies the array. This was introduced by my modifications to the l-value detection logic in #90287. This undoes that portion of the change so that capture 2 is now treated as an r-value capture. This simplifies the array element assignment logic so that it no longer can see an assignment where the array is an l-value. Fixes#93420 by adding an explicit check for `IsInitialization` so that we don't hit the related asserts for string interpolation handlers.

sbomer · 2023-10-19T18:20:00Z

I fixed a few more asserts that came up after #93420:

Assert inside GetFlowCaptureValue for the LHS of a compound assignment. I couldn't think of a case yet where we actually need to model the result of the assignment, so I implemented support for at least visiting the LHS by going through the same path as normal assignments (avoiding GetFlowCaptureValue).
Assert inside GetFlowCaptureValue for a flow capture reference passed as an out param.
Added a test for deconstruction assignment to flow capture reference.

ViktorHofer

Also verified that this change doesn't require updating our solution files again in src/libraries.

sbomer · 2023-10-20T16:41:50Z

Test failure looks like #90019

sbomer · 2023-10-09T21:25:06Z

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

ghost · 2023-10-09T21:25:25Z

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

Author:	sbomer
Assignees:	sbomer
Labels:	`area-Tools-ILLink`
Milestone:	-

sbomer · 2023-10-12T22:14:10Z

CI uncovered another assert, which I'm fixing separately in #93420.

#93259 uncovered an issue around how the analyzer tracks arrays. It hit an analyzer assert while trying to create an l-value flow capture of another flow capture reference, which should never happen as far as I understand. The assert was firing for https://github.com/dotnet/runtime/blob/946c5245aea149d9ece53fd0debc18328c29083b/src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs#L511 Now tested in TestNullCoalescingAssignment: ```csharp (arr ??= arr2)[0] = typeof (V); ``` The CFG had three flow captures: - capture 0: an l-value flow capture of `arr`. Used later in the branch that assigns `arr2` to `arr`. - capture 1: an r-value flow capture of capture 0. This was checked for null. - capture 2: an l-value flow capture representing `arr ??= arr2`, used to write index 0 of the array. - In the == null branch, this captured the result of an assignment (capture 0 = `arr2`) - In the other branch, it captured "capture 1". This is where the assert was hit. The bug, I believe, is that capture 2 should have been an r-value flow capture instead. Even though it's used for writing to the array, the assignment doesn't modify the array pointer represented by this capture - it dereferences this pointer and modifies the array. This was introduced by my modifications to the l-value detection logic in #90287. This undoes that portion of the change so that capture 2 is now treated as an r-value capture. This simplifies the array element assignment logic so that it no longer can see an assignment where the array is an l-value. Fixes#93420 by adding an explicit check for `IsInitialization` so that we don't hit the related asserts for string interpolation handlers.

sbomer · 2023-10-19T18:20:00Z

I fixed a few more asserts that came up after #93420:

Assert inside GetFlowCaptureValue for the LHS of a compound assignment. I couldn't think of a case yet where we actually need to model the result of the assignment, so I implemented support for at least visiting the LHS by going through the same path as normal assignments (avoiding GetFlowCaptureValue).
Assert inside GetFlowCaptureValue for a flow capture reference passed as an out param.
Added a test for deconstruction assignment to flow capture reference.

ViktorHofer

Also verified that this change doesn't require updating our solution files again in src/libraries.

sbomer · 2023-10-20T16:41:50Z

Test failure looks like #90019

sbomer · 2023-10-09T21:25:06Z

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

ghost · 2023-10-09T21:25:25Z

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

Author:	sbomer
Assignees:	sbomer
Labels:	`area-Tools-ILLink`
Milestone:	-

sbomer · 2023-10-12T22:14:10Z

CI uncovered another assert, which I'm fixing separately in #93420.

#93259 uncovered an issue around how the analyzer tracks arrays. It hit an analyzer assert while trying to create an l-value flow capture of another flow capture reference, which should never happen as far as I understand. The assert was firing for https://github.com/dotnet/runtime/blob/946c5245aea149d9ece53fd0debc18328c29083b/src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs#L511 Now tested in TestNullCoalescingAssignment: ```csharp (arr ??= arr2)[0] = typeof (V); ``` The CFG had three flow captures: - capture 0: an l-value flow capture of `arr`. Used later in the branch that assigns `arr2` to `arr`. - capture 1: an r-value flow capture of capture 0. This was checked for null. - capture 2: an l-value flow capture representing `arr ??= arr2`, used to write index 0 of the array. - In the == null branch, this captured the result of an assignment (capture 0 = `arr2`) - In the other branch, it captured "capture 1". This is where the assert was hit. The bug, I believe, is that capture 2 should have been an r-value flow capture instead. Even though it's used for writing to the array, the assignment doesn't modify the array pointer represented by this capture - it dereferences this pointer and modifies the array. This was introduced by my modifications to the l-value detection logic in #90287. This undoes that portion of the change so that capture 2 is now treated as an r-value capture. This simplifies the array element assignment logic so that it no longer can see an assignment where the array is an l-value. Fixes#93420 by adding an explicit check for `IsInitialization` so that we don't hit the related asserts for string interpolation handlers.

sbomer · 2023-10-19T18:20:00Z

I fixed a few more asserts that came up after #93420:

Assert inside GetFlowCaptureValue for the LHS of a compound assignment. I couldn't think of a case yet where we actually need to model the result of the assignment, so I implemented support for at least visiting the LHS by going through the same path as normal assignments (avoiding GetFlowCaptureValue).
Assert inside GetFlowCaptureValue for a flow capture reference passed as an out param.
Added a test for deconstruction assignment to flow capture reference.

ViktorHofer

Also verified that this change doesn't require updating our solution files again in src/libraries.

sbomer · 2023-10-20T16:41:50Z

Test failure looks like #90019

sbomer · 2023-10-09T21:25:06Z

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

ghost · 2023-10-09T21:25:25Z

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

Author:	sbomer
Assignees:	sbomer
Labels:	`area-Tools-ILLink`
Milestone:	-

sbomer · 2023-10-12T22:14:10Z

CI uncovered another assert, which I'm fixing separately in #93420.

#93259 uncovered an issue around how the analyzer tracks arrays. It hit an analyzer assert while trying to create an l-value flow capture of another flow capture reference, which should never happen as far as I understand. The assert was firing for https://github.com/dotnet/runtime/blob/946c5245aea149d9ece53fd0debc18328c29083b/src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs#L511 Now tested in TestNullCoalescingAssignment: ```csharp (arr ??= arr2)[0] = typeof (V); ``` The CFG had three flow captures: - capture 0: an l-value flow capture of `arr`. Used later in the branch that assigns `arr2` to `arr`. - capture 1: an r-value flow capture of capture 0. This was checked for null. - capture 2: an l-value flow capture representing `arr ??= arr2`, used to write index 0 of the array. - In the == null branch, this captured the result of an assignment (capture 0 = `arr2`) - In the other branch, it captured "capture 1". This is where the assert was hit. The bug, I believe, is that capture 2 should have been an r-value flow capture instead. Even though it's used for writing to the array, the assignment doesn't modify the array pointer represented by this capture - it dereferences this pointer and modifies the array. This was introduced by my modifications to the l-value detection logic in #90287. This undoes that portion of the change so that capture 2 is now treated as an r-value capture. This simplifies the array element assignment logic so that it no longer can see an assignment where the array is an l-value. Fixes#93420 by adding an explicit check for `IsInitialization` so that we don't hit the related asserts for string interpolation handlers.

sbomer · 2023-10-19T18:20:00Z

I fixed a few more asserts that came up after #93420:

Assert inside GetFlowCaptureValue for the LHS of a compound assignment. I couldn't think of a case yet where we actually need to model the result of the assignment, so I implemented support for at least visiting the LHS by going through the same path as normal assignments (avoiding GetFlowCaptureValue).
Assert inside GetFlowCaptureValue for a flow capture reference passed as an out param.
Added a test for deconstruction assignment to flow capture reference.

ViktorHofer

Also verified that this change doesn't require updating our solution files again in src/libraries.

sbomer · 2023-10-20T16:41:50Z

Test failure looks like #90019

sbomer · 2023-10-09T21:25:06Z

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

ghost · 2023-10-09T21:25:25Z

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

In #91233 I inadvertently turned off the trim analyzer for libraries, because the analyzer bits don't flow to the consuming project with the ILLink.Tasks ProjectReference. This adds a separate ProjectReference to use the live analyzer. This addresses #88901 for the ILLink analyzers.

Using the live analyzer uncovered some bugs that are fixed in this change:

Invalid assert for field initializers with throw statements
Invalid cast to IMethodSymbol for the ContainingSymbol of a local. Locals can occur in field initializers, when created from out params.
Wrong warning code produced for assignment to annotated property in an initializer. This was being treated as a call to the setter instead of an assignment to the underlying field:
Type AnnotatedPropertyWithSetter { get; set; } = GetUnknown ();
(IIRC I hit this one when investigating some related behavior, not via a new warning produced when analyzing runtime)
Invalid assert for delegate creation where the delegate is created from anything other than a method (for example, a field that has an Action or Func type).

Author:	sbomer
Assignees:	sbomer
Labels:	`area-Tools-ILLink`
Milestone:	-

sbomer · 2023-10-12T22:14:10Z

CI uncovered another assert, which I'm fixing separately in #93420.

#93259 uncovered an issue around how the analyzer tracks arrays. It hit an analyzer assert while trying to create an l-value flow capture of another flow capture reference, which should never happen as far as I understand. The assert was firing for https://github.com/dotnet/runtime/blob/946c5245aea149d9ece53fd0debc18328c29083b/src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs#L511 Now tested in TestNullCoalescingAssignment: ```csharp (arr ??= arr2)[0] = typeof (V); ``` The CFG had three flow captures: - capture 0: an l-value flow capture of `arr`. Used later in the branch that assigns `arr2` to `arr`. - capture 1: an r-value flow capture of capture 0. This was checked for null. - capture 2: an l-value flow capture representing `arr ??= arr2`, used to write index 0 of the array. - In the == null branch, this captured the result of an assignment (capture 0 = `arr2`) - In the other branch, it captured "capture 1". This is where the assert was hit. The bug, I believe, is that capture 2 should have been an r-value flow capture instead. Even though it's used for writing to the array, the assignment doesn't modify the array pointer represented by this capture - it dereferences this pointer and modifies the array. This was introduced by my modifications to the l-value detection logic in #90287. This undoes that portion of the change so that capture 2 is now treated as an r-value capture. This simplifies the array element assignment logic so that it no longer can see an assignment where the array is an l-value. Fixes#93420 by adding an explicit check for `IsInitialization` so that we don't hit the related asserts for string interpolation handlers.

sbomer · 2023-10-19T18:20:00Z

I fixed a few more asserts that came up after #93420:

Assert inside GetFlowCaptureValue for the LHS of a compound assignment. I couldn't think of a case yet where we actually need to model the result of the assignment, so I implemented support for at least visiting the LHS by going through the same path as normal assignments (avoiding GetFlowCaptureValue).
Assert inside GetFlowCaptureValue for a flow capture reference passed as an out param.
Added a test for deconstruction assignment to flow capture reference.

ViktorHofer

Also verified that this change doesn't require updating our solution files again in src/libraries.

sbomer · 2023-10-20T16:41:50Z

Test failure looks like #90019

sbomer added 2 commits October 6, 2023 00:52

Reference live ILLink.RoslynAnalyzer
cdc1149
- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

Add tests for delegate creation assert
adb72b7

sbomer requested review from ViktorHofer, agocke and vitek-karas October 9, 2023 21:25

sbomer requested a review from marek-safar as a code owner October 9, 2023 21:25

ghost assigned sbomer Oct 9, 2023

ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Oct 9, 2023

ViktorHofer reviewed Oct 10, 2023
View reviewed changes

Comment threadeng/liveILLink.targets

vitek-karas approved these changes Oct 10, 2023
View reviewed changes

Comment threadsrc/tools/illink/src/ILLink.RoslynAnalyzer/DataFlow/LocalDataFlowVisitor.cs Outdated

sbomer added 2 commits October 10, 2023 15:49

Fix issue link
4a70945

Fix analyzer treatment of flow captures of arrays
01dc9b7

sbomer mentioned this pull request Oct 12, 2023
Fix analyzer treatment of flow captures of arrays #93420
Merged

sbomer added 4 commits October 12, 2023 22:04

Add back comment
daca428

Fix expected warning
3627e69

Set Private="false"
8cb1ba5

Merge branch 'fixArrayCapture' into liveAnalyzer
3f1c294

Add interpolated string handler test, fix asserts
51e3b1e

sbomer added 4 commits October 18, 2023 17:49

Merge remote-tracking branch 'origin/main' into liveAnalyzer
4afefcf

Fix assert for compound assignment
fe57230

Fix assert for flow capture representing out param
6ce3903

Test deconstruction assignment to flow capture ref
7ff2f10

sbomer requested a review from vitek-karas October 19, 2023 18:20

Fix test
ee5e62a

This was referenced Oct 20, 2023
[wasm] Runtime tests failing - _Vector2_3_4::Vector2_3_4Test.RunVector*Tests because of missing support for native libraries #93669
Closed
Tracking issue for CI build timeouts #76454
Closed

vitek-karas approved these changes Oct 20, 2023
View reviewed changes

ViktorHofer approved these changes Oct 20, 2023
View reviewed changes

sbomer merged commit de011df into dotnet:mainOct 20, 2023

sbomer mentioned this pull request Oct 21, 2023
Report Requires diagnostics from dataflow analyzer #92724
Merged

sbomer deleted the liveAnalyzer branch November 3, 2023 18:39

ghost locked as resolved and limited conversation to collaborators Dec 3, 2023

sbomer added 2 commits October 6, 2023 00:52

Reference live ILLink.RoslynAnalyzer
cdc1149
- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

Add tests for delegate creation assert
adb72b7

sbomer requested review from ViktorHofer, agocke and vitek-karas October 9, 2023 21:25

sbomer requested a review from marek-safar as a code owner October 9, 2023 21:25

ghost assigned sbomer Oct 9, 2023

ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Oct 9, 2023

ViktorHofer reviewed Oct 10, 2023
View reviewed changes

Comment threadeng/liveILLink.targets

vitek-karas approved these changes Oct 10, 2023
View reviewed changes

Comment threadsrc/tools/illink/src/ILLink.RoslynAnalyzer/DataFlow/LocalDataFlowVisitor.cs Outdated

sbomer added 2 commits October 10, 2023 15:49

Fix issue link
4a70945

Fix analyzer treatment of flow captures of arrays
01dc9b7

sbomer mentioned this pull request Oct 12, 2023
Fix analyzer treatment of flow captures of arrays #93420
Merged

sbomer added 4 commits October 12, 2023 22:04

Add back comment
daca428

Fix expected warning
3627e69

Set Private="false"
8cb1ba5

Merge branch 'fixArrayCapture' into liveAnalyzer
3f1c294

Add interpolated string handler test, fix asserts
51e3b1e

sbomer added 4 commits October 18, 2023 17:49

Merge remote-tracking branch 'origin/main' into liveAnalyzer
4afefcf

Fix assert for compound assignment
fe57230

Fix assert for flow capture representing out param
6ce3903

Test deconstruction assignment to flow capture ref
7ff2f10

sbomer requested a review from vitek-karas October 19, 2023 18:20

Fix test
ee5e62a

This was referenced Oct 20, 2023
[wasm] Runtime tests failing - _Vector2_3_4::Vector2_3_4Test.RunVector*Tests because of missing support for native libraries #93669
Closed
Tracking issue for CI build timeouts #76454
Closed

vitek-karas approved these changes Oct 20, 2023
View reviewed changes

ViktorHofer approved these changes Oct 20, 2023
View reviewed changes

sbomer merged commit de011df into dotnet:mainOct 20, 2023

sbomer mentioned this pull request Oct 21, 2023
Report Requires diagnostics from dataflow analyzer #92724
Merged

sbomer deleted the liveAnalyzer branch November 3, 2023 18:39

ghost locked as resolved and limited conversation to collaborators Dec 3, 2023

sbomer added 2 commits October 6, 2023 00:52

Reference live ILLink.RoslynAnalyzer
cdc1149
- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

Add tests for delegate creation assert
adb72b7

sbomer requested review from ViktorHofer, agocke and vitek-karas October 9, 2023 21:25

sbomer requested a review from marek-safar as a code owner October 9, 2023 21:25

ghost assigned sbomer Oct 9, 2023

ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Oct 9, 2023

ViktorHofer reviewed Oct 10, 2023
View reviewed changes

Comment threadeng/liveILLink.targets

vitek-karas approved these changes Oct 10, 2023
View reviewed changes

Comment threadsrc/tools/illink/src/ILLink.RoslynAnalyzer/DataFlow/LocalDataFlowVisitor.cs Outdated

sbomer added 2 commits October 10, 2023 15:49

Fix issue link
4a70945

Fix analyzer treatment of flow captures of arrays
01dc9b7

sbomer mentioned this pull request Oct 12, 2023
Fix analyzer treatment of flow captures of arrays #93420
Merged

sbomer added 4 commits October 12, 2023 22:04

Add back comment
daca428

Fix expected warning
3627e69

Set Private="false"
8cb1ba5

Merge branch 'fixArrayCapture' into liveAnalyzer
3f1c294

Add interpolated string handler test, fix asserts
51e3b1e

sbomer added 4 commits October 18, 2023 17:49

Merge remote-tracking branch 'origin/main' into liveAnalyzer
4afefcf

Fix assert for compound assignment
fe57230

Fix assert for flow capture representing out param
6ce3903

Test deconstruction assignment to flow capture ref
7ff2f10

sbomer requested a review from vitek-karas October 19, 2023 18:20

Fix test
ee5e62a

This was referenced Oct 20, 2023
[wasm] Runtime tests failing - _Vector2_3_4::Vector2_3_4Test.RunVector*Tests because of missing support for native libraries #93669
Closed
Tracking issue for CI build timeouts #76454
Closed

vitek-karas approved these changes Oct 20, 2023
View reviewed changes

ViktorHofer approved these changes Oct 20, 2023
View reviewed changes

sbomer merged commit de011df into dotnet:mainOct 20, 2023

sbomer mentioned this pull request Oct 21, 2023
Report Requires diagnostics from dataflow analyzer #92724
Merged

sbomer deleted the liveAnalyzer branch November 3, 2023 18:39

ghost locked as resolved and limited conversation to collaborators Dec 3, 2023

sbomer added 2 commits October 6, 2023 00:52

Reference live ILLink.RoslynAnalyzer
cdc1149
- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

Add tests for delegate creation assert
adb72b7

sbomer requested review from ViktorHofer, agocke and vitek-karas October 9, 2023 21:25

sbomer requested a review from marek-safar as a code owner October 9, 2023 21:25

ghost assigned sbomer Oct 9, 2023

ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Oct 9, 2023

ViktorHofer reviewed Oct 10, 2023
View reviewed changes

Comment threadeng/liveILLink.targets

vitek-karas approved these changes Oct 10, 2023
View reviewed changes

Comment threadsrc/tools/illink/src/ILLink.RoslynAnalyzer/DataFlow/LocalDataFlowVisitor.cs Outdated

sbomer added 2 commits October 10, 2023 15:49

Fix issue link
4a70945

Fix analyzer treatment of flow captures of arrays
01dc9b7

sbomer mentioned this pull request Oct 12, 2023
Fix analyzer treatment of flow captures of arrays #93420
Merged

sbomer added 4 commits October 12, 2023 22:04

Add back comment
daca428

Fix expected warning
3627e69

Set Private="false"
8cb1ba5

Merge branch 'fixArrayCapture' into liveAnalyzer
3f1c294

Add interpolated string handler test, fix asserts
51e3b1e

sbomer added 4 commits October 18, 2023 17:49

Merge remote-tracking branch 'origin/main' into liveAnalyzer
4afefcf

Fix assert for compound assignment
fe57230

Fix assert for flow capture representing out param
6ce3903

Test deconstruction assignment to flow capture ref
7ff2f10

sbomer requested a review from vitek-karas October 19, 2023 18:20

Fix test
ee5e62a

This was referenced Oct 20, 2023
[wasm] Runtime tests failing - _Vector2_3_4::Vector2_3_4Test.RunVector*Tests because of missing support for native libraries #93669
Closed
Tracking issue for CI build timeouts #76454
Closed

vitek-karas approved these changes Oct 20, 2023
View reviewed changes

ViktorHofer approved these changes Oct 20, 2023
View reviewed changes

sbomer merged commit de011df into dotnet:mainOct 20, 2023

sbomer mentioned this pull request Oct 21, 2023
Report Requires diagnostics from dataflow analyzer #92724
Merged

sbomer deleted the liveAnalyzer branch November 3, 2023 18:39

ghost locked as resolved and limited conversation to collaborators Dec 3, 2023

sbomer added 2 commits October 6, 2023 00:52

Reference live ILLink.RoslynAnalyzer
cdc1149
- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

Add tests for delegate creation assert
adb72b7

sbomer requested review from ViktorHofer, agocke and vitek-karas October 9, 2023 21:25

sbomer requested a review from marek-safar as a code owner October 9, 2023 21:25

ghost assigned sbomer Oct 9, 2023

ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Oct 9, 2023

ViktorHofer reviewed Oct 10, 2023
View reviewed changes

Comment threadeng/liveILLink.targets

vitek-karas approved these changes Oct 10, 2023
View reviewed changes

Comment threadsrc/tools/illink/src/ILLink.RoslynAnalyzer/DataFlow/LocalDataFlowVisitor.cs Outdated

sbomer added 2 commits October 10, 2023 15:49

Fix issue link
4a70945

Fix analyzer treatment of flow captures of arrays
01dc9b7

sbomer mentioned this pull request Oct 12, 2023
Fix analyzer treatment of flow captures of arrays #93420
Merged

sbomer added 4 commits October 12, 2023 22:04

Add back comment
daca428

Fix expected warning
3627e69

Set Private="false"
8cb1ba5

Merge branch 'fixArrayCapture' into liveAnalyzer
3f1c294

Add interpolated string handler test, fix asserts
51e3b1e

sbomer added 4 commits October 18, 2023 17:49

Merge remote-tracking branch 'origin/main' into liveAnalyzer
4afefcf

Fix assert for compound assignment
fe57230

Fix assert for flow capture representing out param
6ce3903

Test deconstruction assignment to flow capture ref
7ff2f10

sbomer requested a review from vitek-karas October 19, 2023 18:20

Fix test
ee5e62a

This was referenced Oct 20, 2023
[wasm] Runtime tests failing - _Vector2_3_4::Vector2_3_4Test.RunVector*Tests because of missing support for native libraries #93669
Closed
Tracking issue for CI build timeouts #76454
Closed

vitek-karas approved these changes Oct 20, 2023
View reviewed changes

ViktorHofer approved these changes Oct 20, 2023
View reviewed changes

sbomer merged commit de011df into dotnet:mainOct 20, 2023

sbomer mentioned this pull request Oct 21, 2023
Report Requires diagnostics from dataflow analyzer #92724
Merged

sbomer deleted the liveAnalyzer branch November 3, 2023 18:39

ghost locked as resolved and limited conversation to collaborators Dec 3, 2023

sbomer added 2 commits October 6, 2023 00:52

Reference live ILLink.RoslynAnalyzer
cdc1149
- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

Add tests for delegate creation assert
adb72b7

sbomer requested review from ViktorHofer, agocke and vitek-karas October 9, 2023 21:25

sbomer requested a review from marek-safar as a code owner October 9, 2023 21:25

ghost assigned sbomer Oct 9, 2023

ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Oct 9, 2023

ViktorHofer reviewed Oct 10, 2023
View reviewed changes

Comment threadeng/liveILLink.targets

vitek-karas approved these changes Oct 10, 2023
View reviewed changes

Comment threadsrc/tools/illink/src/ILLink.RoslynAnalyzer/DataFlow/LocalDataFlowVisitor.cs Outdated

sbomer added 2 commits October 10, 2023 15:49

Fix issue link
4a70945

Fix analyzer treatment of flow captures of arrays
01dc9b7

sbomer mentioned this pull request Oct 12, 2023
Fix analyzer treatment of flow captures of arrays #93420
Merged

sbomer added 4 commits October 12, 2023 22:04

Add back comment
daca428

Fix expected warning
3627e69

Set Private="false"
8cb1ba5

Merge branch 'fixArrayCapture' into liveAnalyzer
3f1c294

Add interpolated string handler test, fix asserts
51e3b1e

sbomer added 4 commits October 18, 2023 17:49

Merge remote-tracking branch 'origin/main' into liveAnalyzer
4afefcf

Fix assert for compound assignment
fe57230

Fix assert for flow capture representing out param
6ce3903

Test deconstruction assignment to flow capture ref
7ff2f10

sbomer requested a review from vitek-karas October 19, 2023 18:20

Fix test
ee5e62a

This was referenced Oct 20, 2023
[wasm] Runtime tests failing - _Vector2_3_4::Vector2_3_4Test.RunVector*Tests because of missing support for native libraries #93669
Closed
Tracking issue for CI build timeouts #76454
Closed

vitek-karas approved these changes Oct 20, 2023
View reviewed changes

ViktorHofer approved these changes Oct 20, 2023
View reviewed changes

sbomer merged commit de011df into dotnet:mainOct 20, 2023

sbomer mentioned this pull request Oct 21, 2023
Report Requires diagnostics from dataflow analyzer #92724
Merged

sbomer deleted the liveAnalyzer branch November 3, 2023 18:39

ghost locked as resolved and limited conversation to collaborators Dec 3, 2023

sbomer added 2 commits October 6, 2023 00:52

Reference live ILLink.RoslynAnalyzer
cdc1149
- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

Add tests for delegate creation assert
adb72b7

sbomer requested review from ViktorHofer, agocke and vitek-karas October 9, 2023 21:25

sbomer requested a review from marek-safar as a code owner October 9, 2023 21:25

ghost assigned sbomer Oct 9, 2023

ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Oct 9, 2023

ViktorHofer reviewed Oct 10, 2023
View reviewed changes

Comment threadeng/liveILLink.targets

vitek-karas approved these changes Oct 10, 2023
View reviewed changes

Comment threadsrc/tools/illink/src/ILLink.RoslynAnalyzer/DataFlow/LocalDataFlowVisitor.cs Outdated

sbomer added 2 commits October 10, 2023 15:49

Fix issue link
4a70945

Fix analyzer treatment of flow captures of arrays
01dc9b7

sbomer mentioned this pull request Oct 12, 2023
Fix analyzer treatment of flow captures of arrays #93420
Merged

sbomer added 4 commits October 12, 2023 22:04

Add back comment
daca428

Fix expected warning
3627e69

Set Private="false"
8cb1ba5

Merge branch 'fixArrayCapture' into liveAnalyzer
3f1c294

Add interpolated string handler test, fix asserts
51e3b1e

sbomer added 4 commits October 18, 2023 17:49

Merge remote-tracking branch 'origin/main' into liveAnalyzer
4afefcf

Fix assert for compound assignment
fe57230

Fix assert for flow capture representing out param
6ce3903

Test deconstruction assignment to flow capture ref
7ff2f10

sbomer requested a review from vitek-karas October 19, 2023 18:20

Fix test
ee5e62a

This was referenced Oct 20, 2023
[wasm] Runtime tests failing - _Vector2_3_4::Vector2_3_4Test.RunVector*Tests because of missing support for native libraries #93669
Closed
Tracking issue for CI build timeouts #76454
Closed

vitek-karas approved these changes Oct 20, 2023
View reviewed changes

ViktorHofer approved these changes Oct 20, 2023
View reviewed changes

sbomer merged commit de011df into dotnet:mainOct 20, 2023

sbomer mentioned this pull request Oct 21, 2023
Report Requires diagnostics from dataflow analyzer #92724
Merged

sbomer deleted the liveAnalyzer branch November 3, 2023 18:39

ghost locked as resolved and limited conversation to collaborators Dec 3, 2023

sbomer added 2 commits October 6, 2023 00:52

Reference live ILLink.RoslynAnalyzer
cdc1149
- Fix some analyzer asserts - Reference local analyzer - Fix property initializer behavior

Add tests for delegate creation assert
adb72b7

sbomer requested review from ViktorHofer, agocke and vitek-karas October 9, 2023 21:25

sbomer requested a review from marek-safar as a code owner October 9, 2023 21:25

ghost assigned sbomer Oct 9, 2023

ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Oct 9, 2023

ViktorHofer reviewed Oct 10, 2023
View reviewed changes

Comment threadeng/liveILLink.targets

vitek-karas approved these changes Oct 10, 2023
View reviewed changes

Comment threadsrc/tools/illink/src/ILLink.RoslynAnalyzer/DataFlow/LocalDataFlowVisitor.cs Outdated

sbomer added 2 commits October 10, 2023 15:49

Fix issue link
4a70945

Fix analyzer treatment of flow captures of arrays
01dc9b7

sbomer mentioned this pull request Oct 12, 2023
Fix analyzer treatment of flow captures of arrays #93420
Merged

sbomer added 4 commits October 12, 2023 22:04

Add back comment
daca428

Fix expected warning
3627e69

Set Private="false"
8cb1ba5

Merge branch 'fixArrayCapture' into liveAnalyzer
3f1c294

Add interpolated string handler test, fix asserts
51e3b1e

sbomer added 4 commits October 18, 2023 17:49

Merge remote-tracking branch 'origin/main' into liveAnalyzer
4afefcf

Fix assert for compound assignment
fe57230

Fix assert for flow capture representing out param
6ce3903

Test deconstruction assignment to flow capture ref
7ff2f10

sbomer requested a review from vitek-karas October 19, 2023 18:20

Fix test
ee5e62a

This was referenced Oct 20, 2023
[wasm] Runtime tests failing - _Vector2_3_4::Vector2_3_4Test.RunVector*Tests because of missing support for native libraries #93669
Closed
Tracking issue for CI build timeouts #76454
Closed

vitek-karas approved these changes Oct 20, 2023
View reviewed changes

ViktorHofer approved these changes Oct 20, 2023
View reviewed changes

sbomer merged commit de011df into dotnet:mainOct 20, 2023

sbomer mentioned this pull request Oct 21, 2023
Report Requires diagnostics from dataflow analyzer #92724
Merged

sbomer deleted the liveAnalyzer branch November 3, 2023 18:39

ghost locked as resolved and limited conversation to collaborators Dec 3, 2023

Uh oh!

Conversation

sbomer commented Oct 9, 2023

Uh oh!

ghost commented Oct 9, 2023

Uh oh!

Uh oh!

Uh oh!

sbomer commented Oct 12, 2023

Uh oh!

sbomer commented Oct 19, 2023

Uh oh!

ViktorHofer left a comment

Choose a reason for hiding this comment

Uh oh!

sbomer commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sbomer commented Oct 9, 2023

Uh oh!

ghost commented Oct 9, 2023

Uh oh!

Uh oh!

Uh oh!

sbomer commented Oct 12, 2023

Uh oh!

sbomer commented Oct 19, 2023

Uh oh!

ViktorHofer left a comment

Choose a reason for hiding this comment

Uh oh!

sbomer commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sbomer commented Oct 9, 2023

Uh oh!

ghost commented Oct 9, 2023

Uh oh!

Uh oh!

Uh oh!

sbomer commented Oct 12, 2023

Uh oh!

sbomer commented Oct 19, 2023

Uh oh!

ViktorHofer left a comment

Choose a reason for hiding this comment

Uh oh!

sbomer commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sbomer commented Oct 9, 2023

Uh oh!

ghost commented Oct 9, 2023