Uh oh!
There was an error while loading. Please reload this page.
CI Test: Enable /O2 for MSVC Release - #93336
Closed
EgorBo wants to merge 2 commits into
Closed
Conversation
ghost
commented
Oct 11, 2023
Tagging subscribers to this area: @hoyosjs Issue Detailsnull
|
jkotas
commented
Oct 11, 2023
Member
Was this with PGO data? |
EgorBo
commented
Oct 11, 2023
MemberAuthor
Yes. I was actually expecting to see TP diffs from this, not sure why there is none (I was testing -Ox vs -O2 by switching directly in VS) |
EgorBo
commented
Oct 11, 2023
MemberAuthor
Looks correct, going to close then since I can't prove it's useful via TP diffs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: