Skip to content

JIT: make bbID available in release, use it for pred list ordering - #93636

Closed
AndyAyersMS wants to merge 1 commit into
dotnet:mainfrom
AndyAyersMS:LeverageBBID
Closed

JIT: make bbID available in release, use it for pred list ordering#93636
AndyAyersMS wants to merge 1 commit into
dotnet:mainfrom
AndyAyersMS:LeverageBBID

Conversation

@AndyAyersMS

@AndyAyersMSAndyAyersMS commented Oct 17, 2023

Copy link
Copy Markdown
Member

Avoid needing to reorder pred lists (in most cases) by relying on bbID for a persistent stable ordering.

@AndyAyersMS
JIT: make bbID available in release, use it for pred list ordering
bf4ac8e
Avoid needing to reorder pred lists (in most cases) by relying on `bbID`
for a persistent stable ordering.
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 17, 2023
@ghost

ghost commented Oct 17, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Avoid needing to reorder pred lists (in most cases) by relying on bbID for a persistent stable ordering.

Author:AndyAyersMS
Assignees:AndyAyersMS
Labels:

area-CodeGen-coreclr

Milestone:-

@AndyAyersMS

AndyAyersMS commented Oct 17, 2023

Copy link
Copy Markdown
MemberAuthor

@kunalspathak FYI.

Locally this didn't help much with TP; let's see what CI says.

@build-analysisbuild-analysisBot mentioned this pull request Oct 18, 2023
Closed
@kunalspathak

kunalspathak commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

@kunalspathak FYI.

Locally this didn't help much with TP; let's see what CI says.

Seems like a nice TP win except that Arm64 shows more regressions. I glanced at few of the diffs and seems to be coming out of resolution moves, so perhaps happening because the block reordering, like we see in #93371.

@ghostghost closed this Nov 17, 2023
@ghost

ghost commented Nov 17, 2023

Copy link
Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 18, 2023
This pull request was closed.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyAyersMS@kunalspathak