Skip to content

[browser][MT] enable MT PLINQ - #94214

Merged
lewing merged 9 commits into
dotnet:mainfrom
pavelsavara:browser_plinq_MT2
Nov 6, 2023
Merged

[browser][MT] enable MT PLINQ#94214
lewing merged 9 commits into
dotnet:mainfrom
pavelsavara:browser_plinq_MT2

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Oct 31, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Use normal threads in MT build of PLINQ rather than

  • SinglePartitionMode => false; when FEATURE_WASM_THREADS
  • enabled more unit tests, which are no longer failing. There are still few which deadlock or have trouble.

@pavelsavarapavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Oct 31, 2023
@pavelsavarapavelsavara added this to the 9.0.0 milestone Oct 31, 2023
@pavelsavarapavelsavara self-assigned this Oct 31, 2023
@ghost

ghost commented Oct 31, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:pavelsavara
Assignees:pavelsavara
Labels:

arch-wasm, area-VM-threading-mono, os-browser

Milestone:9.0.0

@pavelsavara

pavelsavara commented Oct 31, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Oct 31, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Oct 31, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Oct 31, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

ilonatommy
ilonatommy approved these changes Oct 31, 2023
View reviewed changes

@ilonatommyilonatommy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks logical

campersau
campersau reviewed Oct 31, 2023
View reviewed changes
Comment threadsrc/libraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/Parallel.cs Outdated
@pavelsavara

pavelsavara commented Oct 31, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Oct 31, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Oct 31, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Oct 31, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

kg
kg reviewed Oct 31, 2023
View reviewed changes
Comment thread...libraries/System.Threading.Tasks.Parallel/tests/System.Threading.Tasks.Parallel.Tests.csproj Outdated
This was referenced Oct 31, 2023
Open
Closed
Closed
Closed
@pavelsavara

pavelsavara commented Nov 1, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Nov 1, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Nov 1, 2023
Closed
Closed
Closed
@pavelsavara

pavelsavara commented Nov 1, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@pavelsavara

pavelsavara commented Nov 3, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Nov 3, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
pavelsavara marked this pull request as ready for review November 3, 2023 12:09
@pavelsavara

pavelsavara commented Nov 3, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Nov 3, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Nov 6, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Nov 6, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Nov 6, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Nov 6, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Nov 6, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Nov 6, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Nov 6, 2023

Copy link
Copy Markdown
MemberAuthor

image

@pavelsavara
pavelsavara requested a review from kgNovember 6, 2023 17:29
kg
kg reviewed Nov 6, 2023
View reviewed changes
Comment thread...libraries/System.Threading.Tasks.Parallel/tests/System.Threading.Tasks.Parallel.Tests.csproj Outdated
kg
kg approved these changes Nov 6, 2023
View reviewed changes
@pavelsavara

pavelsavara commented Nov 6, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Nov 6, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lewing
lewing merged commit c4d5505 into dotnet:mainNov 6, 2023
This was referenced Nov 8, 2023
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 7, 2023
@pavelsavara
pavelsavara deleted the browser_plinq_MT2 branch September 2, 2024 15:34
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ilonatommyilonatommyilonatommy approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
+2 more reviewers
@campersaucampersaucampersau left review comments
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-VM-threading-monoos-browserBrowser variant of arch-wasm

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@pavelsavara@kg@campersau@ilonatommy@lewing