Skip to content

Add EventSource event for WaitHandle waits - #94737

Merged
kouvel merged 36 commits into
dotnet:mainfrom
verdie-g:verdie-g-issue-94264
Dec 7, 2023
Merged

Add EventSource event for WaitHandle waits#94737
kouvel merged 36 commits into
dotnet:mainfrom
verdie-g:verdie-g-issue-94264

Conversation

@verdie-g

@verdie-gverdie-g commented Nov 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Context: #94264

@ghostghost added area-VM-coreclr community-contribution Indicates that the PR has been added by a community member labels Nov 14, 2023
@verdie-gverdie-g mentioned this pull request Nov 14, 2023
Closed
@jkotas
jkotas requested a review from kouvelNovember 14, 2023 22:23
@ghost

ghost commented Nov 14, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Context: #94264

Implementation details that need validation:

  • I've named the event just Wait. MonitorWait doesn't really fit because there name Monitor is not used where the event is emitted. ContentionWait could be confused with Contention.
  • It seems like event versions start at 0 with no suffix in the name. I've started this event at 1 and added a prefix, tell me if I need to change that
  • The start event includes the same properties as ContentionStart: ClrInstanceID, LockID, AssociatedObjectId but no ContentionFlags or LockOwnerThreadID
  • It could be interesting to add a ThreadID property. It would also help to have a IsThreadPoolThread but I don't think there is a concept of thread pool at that level
  • The new event is under the keyword contention (0x400). I think it makes sense to collect it whenever the contention events are collected
  • No changes are required on the Lock class because it doesn't support the wait operation
Author:verdie-g
Assignees:-
Labels:

area-System.Threading, area-VM-coreclr, community-contribution

Milestone:-

verdie-g
verdie-g commented Nov 14, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/ClrEtwAll.man Outdated
Comment threadsrc/coreclr/vm/ClrEtwAll.man Outdated
Comment threadsrc/coreclr/vm/ClrEtwAll.man Outdated
Comment threadsrc/coreclr/vm/ClrEtwAll.man Outdated
Comment threadsrc/coreclr/vm/ClrEtwAll.man Outdated
@verdie-g
verdie-g marked this pull request as ready for review November 14, 2023 23:47
@verdie-gverdie-g mentioned this pull request Nov 15, 2023
Closed
danmoseley
danmoseley reviewed Nov 17, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/syncblk.cpp Outdated
@verdie-gverdie-g changed the title Add etw event for Monitor.WaitAdd EventSource event for WaitHandle waitsNov 17, 2023
This was referenced Nov 17, 2023
Closed
Open
Closed
jkotas
jkotas reviewed Nov 17, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/syncblk.cpp Outdated
kouvel
kouvel reviewed Nov 17, 2023
View reviewed changes
Comment threadsrc/coreclr/inc/eventtracebase.h Outdated
Comment threadsrc/coreclr/vm/ClrEtwAll.man Outdated
Comment threadsrc/coreclr/vm/ClrEtwAll.man Outdated
Comment threadsrc/coreclr/vm/ClrEtwAll.man Outdated
@verdie-g

verdie-g commented Nov 18, 2023

Copy link
Copy Markdown
ContributorAuthor

It doesn't compile, the FireEtwWaitHandleWaitStart function is not generated. I'll continue tomorrow.

This was referenced Nov 18, 2023
Open
Closed
@verdie-g
verdie-g marked this pull request as draft November 18, 2023 18:01
@build-analysisbuild-analysisBot mentioned this pull request Nov 18, 2023
Closed
vargaz
vargaz reviewed Nov 19, 2023
View reviewed changes
Comment threadsrc/mono/mono/metadata/icall-decl.h Outdated
@verdie-g
verdie-g marked this pull request as ready for review November 20, 2023 22:06
verdie-gand others added 21 commits December 7, 2023 13:37
@verdie-g
Add existing event name to exception
f52bfc9
@verdie-g
Address comments
a743853
@verdie-g
Remove this as associated object in Condition
235774f
@verdie-g
Disable wait handle event geneneration
88d96ac
@verdie-g
Fix mono build
b554d49
@verdie-g
Pass associated object in Condition
45d4628
@verdie-g
Rename user data
8bdf215
@verdie-g
Adjust wait source in native wait
909bccc
@verdie-g
Fix task name
f1cf600
@verdie-g
Add test
e0d77ca
@verdie-g
Only emit event in native code
c6b1f6f
@verdie-g
Disable test for mono
e83a522
@verdie-g
Fix test
7c82bc4
@verdie-g
Assert.NotEqual doesn't support custom error message
500455a
@verdie-g
Make test more robust
3730b7f
@verdie-g
Make test even more robust
81b689f
@verdie-g
Revert "Only emit event in native code"
22ffb48
This reverts commit 49c270a.
@verdie-g
Remove unrelated changes
c514edb
Koundinya Veluri@verdie-g
Raise the events in NativeAOT and Mono, some other updates
a5443af
- Updated to send the events only for nonzero-timeout alertable waits
- Updated to try a zero-timeout wait first for waits other than Monitor.Wait before sending events
- Updated WaitHandle.cs to send events for WaitOne and WaitMultiple cases for NativeAOT/Mono
- Updated NativeAOT's and Mono's Monitor.Wait to pass in the associated object
- Some minor changes to the test, and some other miscellaneous fixes
@verdie-g
Fix merge
e868b0e
@verdie-g
Fix merge
e29adcf
kouvel
kouvel approved these changes Dec 7, 2023
View reviewed changes

@kouvelkouvel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@verdie-g

verdie-g commented Dec 7, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for all the help @kouvel! What should I do about the failed action?

@verdie-gverdie-g mentioned this pull request Dec 7, 2023
Merged
@build-analysisbuild-analysisBot mentioned this pull request Dec 7, 2023
Open
@kouvel

kouvel commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

The console log for the failure is almost empty, not sure what might have happened. Previous failures of the test didn't look similar. It seems to have passed on rerun.

@kouvel
kouvel merged commit 7bbfcc4 into dotnet:mainDec 7, 2023
brianrob pushed a commit to microsoft/perfview that referenced this pull request Dec 8, 2023
@verdie-g
Support WaitHandleWait events (#1958)
dbf41bd
* Add WaitHandleWaitStart to AnyStacks
New event introduced in dotnet/runtime#94737
* Fix compilation
* Reorder generated members
* Address PR comment
verdie-g added a commit to criteo-forks/runtime that referenced this pull request Dec 12, 2023
@verdie-g
Add EventSource event for WaitHandle waits (dotnet#94737)
a04deb4
Add start/stop events for WaitHandle waits
Context: dotnet#94264
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 7, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noahfalknoahfalknoahfalk left review comments
@jkotasjkotasjkotas left review comments
@lateralusXlateralusXlateralusX left review comments
@marek-safarmarek-safarAwaiting requested review from marek-safar
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
+4 more reviewers
@vargazvargazvargaz left review comments
@ezsilmarezsilmarezsilmar left review comments
@danmoseleydanmoseleydanmoseley left review comments
@kouvelkouvelkouvel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Threadingcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@verdie-g@kouvel@lateralusX@jkotas@vargaz@ezsilmar@noahfalk@danmoseley@MichalStrehovsky