Skip to content

[workloads] Add the wasi-wasm cross compilers to the workload targets - #95170

Merged
lewing merged 2 commits into
dotnet:mainfrom
lewing:wasi-msi
Nov 23, 2023
Merged

[workloads] Add the wasi-wasm cross compilers to the workload targets#95170
lewing merged 2 commits into
dotnet:mainfrom
lewing:wasi-msi

Conversation

@lewing

@lewinglewing commented Nov 23, 2023

Copy link
Copy Markdown
Member

so that the msi.nupkg get published

@ghostghost added the area-Build-mono label Nov 23, 2023
@ghostghost assigned lewingNov 23, 2023
@lewing
lewing requested a review from radicalNovember 23, 2023 09:08
@lewinglewing changed the title [workloads] Add the wasi-wasm cross compilers to the worklaod targets[workloads] Add the wasi-wasm cross compilers to the worklodd targetsNov 23, 2023
@lewinglewing changed the title [workloads] Add the wasi-wasm cross compilers to the worklodd targets[workloads] Add the wasi-wasm cross compilers to the workload targetsNov 23, 2023
@silesmo

Copy link
Copy Markdown

Thanks @lewing!

@lewing
lewing merged commit 8c1399d into dotnet:mainNov 23, 2023
@lewing
lewing deleted the wasi-msi branch November 23, 2023 16:30
@directhex

directhex commented Nov 23, 2023 via email

Copy link
Copy Markdown
Contributor

@lewing

lewing commented Nov 23, 2023

Copy link
Copy Markdown
MemberAuthor

Does this also need updating for the musl cross compilers? Or is it only relevant on Windows?Sent from my iPhoneOn Nov 23, 2023, at 11:29 AM, Larry Ewing @.***> wrote:

Merged #95170 into main.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

i believe this is the stage that does the windows specific repackaging for VS and the admin installer and doesn't need the cross compiler hosts for other platforms

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@lewing@silesmo@directhex@radical@steveisok