Skip to content

[iOS][non-icu] HybridGlobalization implement GetSortKey on hybrid mode - #95260

Merged
mkhamoyan merged 13 commits into
mainfrom
get_sort_key_hybrid
Dec 6, 2023
Merged

[iOS][non-icu] HybridGlobalization implement GetSortKey on hybrid mode#95260
mkhamoyan merged 13 commits into
mainfrom
get_sort_key_hybrid

Conversation

@mkhamoyan

@mkhamoyanmkhamoyan commented Nov 27, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Implements #94216

Contributes to #80689
cc @SamMonoRT

@ghost

ghost commented Nov 27, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Implement GetSortKeyNative on hybrid mode.

Contributes to #80689

Author:mkhamoyan
Assignees:-
Labels:

area-System.Globalization, os-ios

Milestone:-

@ghostghost assigned mkhamoyanNov 27, 2023
This was referenced Nov 27, 2023
Closed
Closed
@mkhamoyanmkhamoyan mentioned this pull request Nov 28, 2023
Open
4 tasks
@mkhamoyan

mkhamoyan commented Nov 28, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Nov 28, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

mkhamoyan commented Nov 28, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-maccatalyst

@azure-pipelines

azure-pipelinesBot commented Nov 28, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

mkhamoyan commented Nov 28, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslikesimulator

@azure-pipelines

azure-pipelinesBot commented Nov 28, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan
mkhamoyan marked this pull request as ready for review November 28, 2023 14:53
akoeplinger
akoeplinger approved these changes Nov 28, 2023
View reviewed changes

@akoeplingerakoeplinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, looks good otherwise

Comment threadsrc/native/libs/System.Globalization.Native/pal_collation.m Outdated
This was referenced Nov 28, 2023
Open
Closed
Closed
Closed
mdh1418
mdh1418 reviewed Nov 28, 2023
View reviewed changes
Comment threadsrc/libraries/Common/tests/Tests/System/StringTests.cs Outdated
Comment threadsrc/libraries/Common/tests/Tests/System/StringTests.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/CompareInfo.Icu.cs Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_collation.m
@build-analysisbuild-analysisBot mentioned this pull request Nov 29, 2023
Closed
@mkhamoyan

mkhamoyan commented Nov 29, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@build-analysisbuild-analysisBot mentioned this pull request Nov 30, 2023
Closed
@mkhamoyan

mkhamoyan commented Nov 30, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Nov 30, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Nov 30, 2023
Closed
@mkhamoyan

mkhamoyan commented Dec 4, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Dec 4, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

mdh1418
mdh1418 reviewed Dec 4, 2023
View reviewed changes

@mdh1418mdh1418 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And as discussed offline, I think it would be good to note somewhere that this implementation does not construct SortKeys like ucol_getSortKey does, and might not adhere to the specifications specifications of SortKey such as SortKeys from different collators not being comparable and merging sortkeys.

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/CompareInfo.Icu.cs Outdated
Comment threadsrc/libraries/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.cs
@mkhamoyan@mdh1418
Update src/libraries/System.Private.CoreLib/src/System/Globalization/…
32cc7f1
…CompareInfo.Icu.cs
Co-authored-by: Mitchell Hwang <16830051+mdh1418@users.noreply.github.com>
@mkhamoyan

mkhamoyan commented Dec 4, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Dec 4, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

mkhamoyan commented Dec 5, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Dec 5, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

mkhamoyan commented Dec 6, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@mkhamoyan

mkhamoyan commented Dec 6, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-maccatalyst

@azure-pipelines

azure-pipelinesBot commented Dec 6, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelinesBot commented Dec 6, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

mkhamoyan commented Dec 6, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslikesimulator

@azure-pipelines

azure-pipelinesBot commented Dec 6, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

mkhamoyan commented Dec 6, 2023

Copy link
Copy Markdown
ContributorAuthor

@dotnet-policy-service rerun

@mkhamoyan

mkhamoyan commented Dec 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Failures are not related.

@mkhamoyan
mkhamoyan merged commit b345e2d into mainDec 6, 2023
@mkhamoyan
mkhamoyan deleted the get_sort_key_hybrid branch December 6, 2023 10:50
This was referenced Dec 15, 2023
Closed
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 6, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@mdh1418mdh1418mdh1418 left review comments
@steveisoksteveisokAwaiting requested review from steveisok

Assignees

@mkhamoyanmkhamoyan

Labels

area-System.Globalizationos-iosApple iOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkhamoyan@akoeplinger@mdh1418