Use managed ntlm on linux-bionic by rzikm · Pull Request #95274 · dotnet/runtime

rzikm · 2023-11-27T16:31:05Z

ghost · 2023-11-27T16:31:20Z

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #93104.

Author:	rzikm
Assignees:	-
Labels:	`area-System.Net.Security`
Milestone:	-

rzikm · 2023-11-27T16:31:28Z

/azp run runtime-linuxbionic

azure-pipelines · 2023-11-27T16:31:37Z

Azure Pipelines successfully started running 1 pipeline(s).

wfurt

LGTM

rzikm · 2023-11-28T12:51:55Z

/azp run runtime-linuxbionic

azure-pipelines · 2023-11-28T12:52:04Z

Azure Pipelines successfully started running 1 pipeline(s).

rzikm · 2023-11-28T15:32:33Z

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-95274-merge-c4a195fd94144e029e/System.Net.Security.Unit.Tests/1/console.d9c12e57.log?helixlogtype=result

[05:14:46] info: Running command System.Net.Security.Unit.Tests.sh took 2.6011403 seconds
[05:14:46] dbug: Exit code: 0
Std out:
Discovering: System.Net.Security.Unit.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Net.Security.Unit.Tests (found 75 of 78 test cases)
Starting: System.Net.Security.Unit.Tests (parallel test collections = on, max threads = 8)
System.Net.Security.Tests.NegotiateAuthenticationTests.Package_Unsupported_NTLM [SKIP]
Condition(s) not met: "IsNtlmUnavailable"
Finished: System.Net.Security.Unit.Tests
=== TEST EXECUTION SUMMARY ===
System.Net.Security.Unit.Tests Total: 97, Errors: 0, Failed: 0, Skipped: 1, Time: 1.251s

CI looks good

bartonjs

It should either be StartsWith("linux-bionic-") or, if it's sometimes Equals and sometimes has a hyphen, should change to regex. But StartsWith ending with an "unterminated" string isn't good in production code.

filipnavara

LGTM in general. I agree with the StartsWith("linux-bionic-") comment.

MichalStrehovsky · 2023-11-29T09:19:34Z

Can this test exclusion be also removed? Looks like it has been there since Bionic was initially added.

runtime/src/libraries/tests.proj

Line 175 in 7543b05

 <ProjectExclusionsInclude="$(MSBuildThisFileDirectory)System.Net.Security\tests\FunctionalTests\System.Net.Security.Tests.csproj" /> 

rzikm · 2023-11-29T09:45:40Z

Can this test exclusion be also removed? Looks like it has been there since Bionic was initially added.

I don't think this is related to this change. NTLM tests are in the UnitTests project, not FunctionalTests.

rzikm · 2023-11-29T09:45:58Z

/azp run runtime-linuxbionic

azure-pipelines · 2023-11-29T09:46:12Z

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit 82c1136.

rzikm · 2023-11-29T09:54:06Z

/azp run runtime-linuxbionic

azure-pipelines · 2023-11-29T09:54:18Z

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

rzikm · 2023-11-29T13:03:46Z

/azp run runtime-linuxbionic

azure-pipelines · 2023-11-29T13:03:55Z

Azure Pipelines successfully started running 1 pipeline(s).

rzikm · 2023-11-29T17:11:59Z

CI looks good https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-95274-merge-01c93e7798af48e0a3/System.Net.Security.Unit.Tests/1/console.a6959422.log?helixlogtype=result

[13:52:45] dbug: Exit code: 0
Std out:
Discovering: System.Net.Security.Unit.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Net.Security.Unit.Tests (found 75 of 78 test cases)
Starting: System.Net.Security.Unit.Tests (parallel test collections = on, max threads = 1)
System.Net.Security.Tests.NegotiateAuthenticationTests.Package_Unsupported_NTLM [SKIP]
Condition(s) not met: "IsNtlmUnavailable"
Finished: System.Net.Security.Unit.Tests
=== TEST EXECUTION SUMMARY ===
System.Net.Security.Unit.Tests Total: 97, Errors: 0, Failed: 0, Skipped: 1, Time: 4.565s

rzikm · 2023-11-29T17:12:22Z

All CI failures are known build errors.

Use managed ntlm on linux-bionic
d79ebf5

ghost added the area-System.Net.Security label Nov 27, 2023

ghost assigned rzikm Nov 27, 2023

wfurt approved these changes Nov 27, 2023
View reviewed changes

bartonjs reviewed Nov 27, 2023
View reviewed changes

Comment threadsrc/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs Outdated

bartonjs reviewed Nov 27, 2023
View reviewed changes

Comment threadsrc/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs Outdated

wfurt mentioned this pull request Nov 28, 2023
Things needing System.Net.Security.Native may not work on Bionic #87665
Closed

rzikm added 3 commits November 28, 2023 12:39

Fix failing unit test
415c61a

Fix compilation
ddf00d4

Enable more tests on ubuntu-bionic
6b21cb1

bartonjs requested changes Nov 28, 2023
View reviewed changes

ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Nov 28, 2023

filipnavara reviewed Nov 28, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/Interop/Unix/System.Net.Security.Native/Interop.GssApiException.cs

filipnavara approved these changes Nov 28, 2023
View reviewed changes

jkotas reviewed Nov 29, 2023
View reviewed changes

Comment threadsrc/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs

build-analysisBot mentioned this pull request Nov 29, 2023
WritingShouldUpdateWriteTime_After_SetLastAccessTime [FAIL] #95378
Closed

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Nov 29, 2023

Change runtime identifier check to regex
82c1136

filipnavara reviewed Nov 29, 2023
View reviewed changes

Comment threadsrc/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs Outdated

rzikm added 2 commits November 29, 2023 10:53

Revert "Change runtime identifier check to regex"
19dd5ed
This reverts commit 82c1136.

add hyphen to startswith
c837778

This was referenced Nov 29, 2023
Tracking issue for CI build timeouts #76454
Closed
[wasm] Unhandled System.PlatformNotSupportedException for crypto tests #94820
Closed

am11 reviewed Nov 29, 2023
View reviewed changes

Comment threadsrc/libraries/Common/tests/System/Net/Capability.Security.Unix.cs Outdated

Update src/libraries/Common/tests/System/Net/Capability.Security.Unix.cs
1ede567
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

rzikm requested a review from bartonjs November 29, 2023 13:03

bartonjs approved these changes Nov 29, 2023
View reviewed changes

rzikm merged commit c0dfcfd into dotnet:mainNov 29, 2023

build-analysisBot mentioned this pull request Nov 29, 2023
[HTTP3] [outerloop] Requesting HTTP version 3.0 with version policy RequestVersionExact while unable to establish HTTP/3 connection #95413
Closed

github-actionsBot locked and limited conversation to collaborators Dec 30, 2023

karelz added this to the 9.0.0 milestone May 14, 2024

Uh oh!

Conversation

rzikm commented Nov 27, 2023• edited by akoeplinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Nov 27, 2023

Uh oh!

rzikm commented Nov 27, 2023

Uh oh!

azure-pipelinesBot commented Nov 27, 2023

Uh oh!

wfurt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rzikm commented Nov 28, 2023

Uh oh!

azure-pipelinesBot commented Nov 28, 2023

Uh oh!

rzikm commented Nov 28, 2023

Uh oh!

bartonjs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

filipnavara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MichalStrehovsky commented Nov 29, 2023

Uh oh!

rzikm commented Nov 29, 2023

Uh oh!

rzikm commented Nov 29, 2023

Uh oh!

azure-pipelinesBot commented Nov 29, 2023

Uh oh!

Uh oh!

rzikm commented Nov 29, 2023

Uh oh!

azure-pipelinesBot commented Nov 29, 2023

Uh oh!

Uh oh!

rzikm commented Nov 29, 2023

Uh oh!

azure-pipelinesBot commented Nov 29, 2023

Uh oh!

rzikm commented Nov 29, 2023

Uh oh!

rzikm commented Nov 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

rzikm commented Nov 27, 2023•
edited by akoeplinger
Loading