Skip to content

[wasi] Fix incremental, and aot/single-file builds - #95307

Merged
lewing merged 1 commit into
dotnet:mainfrom
radical:wasi-incremental
Nov 28, 2023
Merged

[wasi] Fix incremental, and aot/single-file builds#95307
lewing merged 1 commit into
dotnet:mainfrom
radical:wasi-incremental

Conversation

@radical

@radicalradical commented Nov 28, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This follows the convention from WasmApp.*targets of writing to .rsp
files, and then adding them to the dependencies to trigger native
relinking.

Fixes#95192 .
Fixes#95273 .

@radicalradical added arch-wasm WebAssembly architecture area-Build-mono labels Nov 28, 2023
@ghost

ghost commented Nov 28, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • [wasm] Move LocalBuild, and aot targets to wasm/shared
  • Runner scripts: honor $PREPEND_PATH
  • Add support for AOT projects on helix, for wasi
  • CI: Add wasi aot smoke test projects
  • misc fixes
  • Add WasiRunnerAOTTemplate.sh
  • CI: Add jobs for wasi aot/smoke tests
  • CI: Add wasi/aot jobs on runtime-wasm
  • CI: fix wasi tests list
  • Fix wasi/windows builds where WasmAssemblyFileName contains the path also
  • Remove failing tests
  • [wasm] WBT: Set RID explicitly only for library tests
  • [wasi] Fix incremental build
Author:radical
Assignees:-
Labels:

arch-wasm, area-Build-mono

Milestone:-

@ghostghost assigned radicalNov 28, 2023
@radicalradical changed the title [wasm] Move LocalBuild, and aot targets to wasm/shared[wasi] Fix incremental, and aot/single-file buildsNov 28, 2023
@build-analysisbuild-analysisBot mentioned this pull request Nov 28, 2023
Closed
@radical
[wasi] Fix incremental build
9b68d75
This follows the convention from `WasmApp.*targets` of writing to `.rsp`
files, and then adding them to the dependencies to trigger native
relinking.
Fixesdotnet#95192 .
Fixesdotnet#95273 .
@radical
radical requested review from lewing and marafNovember 28, 2023 16:59
@radical
radical marked this pull request as ready for review November 28, 2023 16:59
@lewing
lewing merged commit e07f80a into dotnet:mainNov 28, 2023
@radical
radical deleted the wasi-incremental branch November 28, 2023 19:58
@build-analysisbuild-analysisBot mentioned this pull request Nov 29, 2023
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 29, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
@ilonatommyilonatommyAwaiting requested review from ilonatommy
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasi] Single file build fails with AOT [wasm] Changing DllImport does not result in a new wasm module

2 participants

@radical@lewing