Skip to content

Add regression testing for the STJv8 source generator. - #95352

Merged
eiriktsarpalis merged 1 commit into
dotnet:mainfrom
eiriktsarpalis:stj-sg-regressiontests-v8
Nov 29, 2023
Merged

Add regression testing for the STJv8 source generator.#95352
eiriktsarpalis merged 1 commit into
dotnet:mainfrom
eiriktsarpalis:stj-sg-regressiontests-v8

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Nov 28, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Adds .NET 8 source generated sources to complement the existing .NET 6 and .NET 7 regression suites.

@eiriktsarpaliseiriktsarpalis self-assigned this Nov 28, 2023
@ghost

ghost commented Nov 28, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:eiriktsarpalis
Assignees:eiriktsarpalis
Labels:

area-System.Text.Json

Milestone:-

@eiriktsarpaliseiriktsarpalis added this to the 9.0.0 milestone Nov 28, 2023
@eiriktsarpaliseiriktsarpalis added the test-enhancement Improvements of test source code label Nov 28, 2023
This was referenced Nov 28, 2023
Closed
Closed
jozkee
jozkee approved these changes Nov 29, 2023
View reviewed changes

@jozkeejozkee left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Net70RegressionTests.cs is identical to Net80RegressionTests.cs, is this only a snapshot of some generated types on 8.0? Will we continue adding them each release indiscriminately?

@build-analysisbuild-analysisBot mentioned this pull request Nov 29, 2023
Closed
@eiriktsarpalis

eiriktsarpalis commented Nov 29, 2023

Copy link
Copy Markdown
MemberAuthor

Given that Net70RegressionTests.cs is identical to Net80RegressionTests.cs, is this only a snapshot of some generated types on 8.0?

Correct, this is smoke testing functionality of the source generated baselines against the current runtime bits, so what tests are being run doesn't change much.

Will we continue adding them each release indiscriminately?

It depends on whether a particular release makes substantial changes to how it generates code. We have been updating the SG on every release so it made sense to include new regression tests every time.

@eiriktsarpalis
eiriktsarpalis merged commit 642c868 into dotnet:mainNov 29, 2023
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 29, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekghtarekghtarekgh approved these changes
@jozkeejozkeejozkee approved these changes

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.Jsontest-enhancementImprovements of test source code

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@eiriktsarpalis@tarekgh@jozkee