Clear IconHandle when we fold compares

[MichalStrehovsky]

Fixes#95367.

Relevant part of the JitDump:

Using `if true` assertions from pred BB02
Assertions in: #01
fgMorphTree BB04, STMT00021 (before)
[000070] DA--------- * STORE_LCL_VAR ubyte V10 tmp9
[000057] ----------- \--* CAST int <- ubyte <- int
[000006] ----------- \--* EQ int
[000004] ----------- +--* LCL_VAR ref V02 tmp1 (last use)
[000055] H---------- \--* CNS_INT(h) ref 'Frozen EmptyPartition`1<Int32> object'
Assertion prop for index #01 in BB04:
[000006] ----------- * EQ int
GenTreeNode creates assertion:
[000070] DA---+----- * STORE_LCL_VAR ubyte V10 tmp9
In BB04 New Local Constant Assertion: V10 == [0000000000000001], index = #02
fgMorphTree BB04, STMT00021 (after)
[000070] DA---+----- * STORE_LCL_VAR ubyte V10 tmp9
[000055] H----+----- \--* CNS_INT(h) int

The JitDump is unfinished because the compiler crashes when trying to dump the last line. Clearly, the CNS_INT is no longer a handle at that point because we just bashed it to a constant 1, but JitInterface gets a question about it that crashes with the same exception as reported in the issue number this is fixing.

Cc @dotnet/ilc-contrib

@dotnet/jit-contrib PTAL

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #95367.

Relevant part of the JitDump:

Using `if true` assertions from pred BB02
Assertions in: #01
fgMorphTree BB04, STMT00021 (before)
[000070] DA--------- * STORE_LCL_VAR ubyte V10 tmp9
[000057] ----------- \--* CAST int <- ubyte <- int
[000006] ----------- \--* EQ int
[000004] ----------- +--* LCL_VAR ref V02 tmp1 (last use)
[000055] H---------- \--* CNS_INT(h) ref 'Frozen EmptyPartition`1<Int32> object'
Assertion prop for index #01 in BB04:
[000006] ----------- * EQ int
GenTreeNode creates assertion:
[000070] DA---+----- * STORE_LCL_VAR ubyte V10 tmp9
In BB04 New Local Constant Assertion: V10 == [0000000000000001], index = #02
fgMorphTree BB04, STMT00021 (after)
[000070] DA---+----- * STORE_LCL_VAR ubyte V10 tmp9
[000055] H----+----- \--* CNS_INT(h) int

The JitDump is unfinished because the compiler crashes when trying to dump the last line. Clearly, the CNS_INT is no longer a handle at that point because we just bashed it to a constant 1, but JitInterface gets a question about it that crashes with the same exception as reported in the issue number this is fixing.

Cc @dotnet/ilc-contrib

@dotnet/jit-contrib PTAL

Author:	MichalStrehovsky
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[MichalStrehovsky]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[EgorBo]

Thanks!