JIT: Port VN and loop hoisting to new loop representation by jakobbotsch · Pull Request #95589 · dotnet/runtime

jakobbotsch · 2023-12-04T16:22:46Z

Switch VN to use the new loop representation for the limited amount of
stuff it does. This is mainly computing loop side effects and using it
for some more precision, in addition to storing some memory dependencies
around loops.
It requires us to have a block -> loop mapping, so add a
BlockToNaturalLoopMap class to do this. We really do not need this
functionality for much, so we may consider seeing if we can remove it in
the future (and remove BasicBlock::bbNatLoopNum).

In loop hoisting move a few members out of LoopDsc and into
LoopHoistContext; in particular the counts of hoisted variables, which
we use for profitability checks and which gets updated while hoisting is
going on for a single loop. We do not need to refer to the information
from other loops.

Record separate postorder numbers for the old and new DFS since we need
to use both simultaneously after loop unrolling. We will be able to get
rid of this again soon.

A small number of diffs are expected because the loop side effects
computation is now more precise, since the old loop code includes some
blocks in loops that are not actually part of the loop. For example,
blocks that always throw can be in the lexical range and would
previously cause the side effect computation to believe there was a
memory havoc. Also, the side effect computation does some limited value
tracking of assignment, which is more precise now since it is running in
RPO instead of based on loop order before.

Run the new loop recognition at the same time as old loop recognition and cross validate that the information matches the old loop information. Implement induction analysis on the new representation. Validate that it matches the old loop induction analysis. Add a few quirks to ensure this. Port loop cloning to run on the new loop representation. Add a number of quirks to keep the logic close to the old cloning. One notable difference is that the old loop recognition considers some blocks to be part of the loops that actually are not; for example, blocks that return or break out from the loop are not part of the loop's SCC, but can be part of the lexical range. This means that the old loop cloning will clone those blocks and apply static optimizations to them, while the new loop cloning won't. However, this does not seem to cause a significant number of regressions. A few diffs are expected due to considering fewer blocks to be part of the loop and thus cloning fewer blocks. Also, throughput regressions are expected since we are doing both loop identifications for now. I expect to incrementally work towards replacing everything with the new representation, at which point we can get rid of the old loop identification and hopefully most of the reachability/dominator computations. I expect us to make back the TP at that point.

…representation

…-representation

Switch VN to use the new loop representation for the limited amount of stuff it does. This is mainly computing loop side effects and using it for some more precision, in addition to storing some memory dependencies around loops. It requires us to have a block -> loop mapping, so add a `BlockToNaturalLoopMap` class to do this. We really do not need this functionality for much, so we may consider seeing if we can remove it in the future (and remove `BasicBlock::bbNatLoopNum`). In loop hoisting move a few members out of `LoopDsc` and into `LoopHoistContext`; in particular the counts of hoisted variables, which we use for profitability checks and which gets updated while hoisting is going on for a single loop. We do not need to refer to the information from other loops. Record separate postorder numbers for the old and new DFS since we need to use both simultaneously after loop unrolling. We will be able to get rid of this again soon. A small number of diffs are expected because the loop side effects computation is now more precise, since the old loop code includes some blocks in loops that are not actually part of the loop. For example, blocks that always throw can be in the lexical range and would previously cause the side effect computation to believe there was a memory havoc. Also, the side effect computation does some limited value tracking of assignment, which is more precise now since it is running in RPO instead of based on loop order before.

ghost · 2023-12-04T16:22:59Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Switch VN to use the new loop representation for the limited amount of
stuff it does. This is mainly computing loop side effects and using it
for some more precision, in addition to storing some memory dependencies
around loops.
It requires us to have a block -> loop mapping, so add a
BlockToNaturalLoopMap class to do this. We really do not need this
functionality for much, so we may consider seeing if we can remove it in
the future (and remove BasicBlock::bbNatLoopNum).

In loop hoisting move a few members out of LoopDsc and into
LoopHoistContext; in particular the counts of hoisted variables, which
we use for profitability checks and which gets updated while hoisting is
going on for a single loop. We do not need to refer to the information
from other loops.

Record separate postorder numbers for the old and new DFS since we need
to use both simultaneously after loop unrolling. We will be able to get
rid of this again soon.

A small number of diffs are expected because the loop side effects
computation is now more precise, since the old loop code includes some
blocks in loops that are not actually part of the loop. For example,
blocks that always throw can be in the lexical range and would
previously cause the side effect computation to believe there was a
memory havoc. Also, the side effect computation does some limited value
tracking of assignment, which is more precise now since it is running in
RPO instead of based on loop order before.

Based on #95326.

Author:	jakobbotsch
Assignees:	jakobbotsch
Labels:	`area-CodeGen-coreclr`
Milestone:	-

…-representation

jakobbotsch · 2023-12-05T21:15:14Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

azure-pipelines · 2023-12-05T21:15:36Z

Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch · 2023-12-06T08:37:28Z

TP regressions:

Base:115669398234, Diff:115827060902, +0.1363%60716940:NA:15.70%:+0.0525%:public: unsigned int __cdecl ValueNumStore::VNForExpr(struct BasicBlock*, enumvar_types) 53395839:NA:13.80%:+0.0462%:private: void __cdecl Compiler::optComputeLoopSideEffectsOfBlock(struct BasicBlock*, classFlowGraphNaturalLoop*) 33827472:NA:8.74%:+0.0292%:protected: void __cdecl Compiler::AddContainsCallAllContainingLoops(classFlowGraphNaturalLoop*) 24380889:+596.76%:6.30%:+0.0211%:protected: void __cdecl Compiler::optComputeLoopSideEffects(void) 20125631:NA:5.20%:+0.0174%:protected: bool __cdecl Compiler::optVNIsLoopInvariant(unsigned int, classFlowGraphNaturalLoop*, classJitHashTable<unsigned int, struct JitSmallPrimitiveKeyFuncs<unsigned int>, bool, classCompAllocator, classJitHashTableBehavior>*)
10564925:NA:2.73%:+0.0091%:public: static classBlockToNaturalLoopMap* __cdecl BlockToNaturalLoopMap::Build(classFlowGraphNaturalLoops*) 8714325:+4.76%:2.25%:+0.0075%:public: static struct BasicBlock* __cdecl BasicBlock::New(classCompiler*) 8096425:+1.19%:2.09%:+0.0070%:public: void __cdecl Compiler::fgValueNumberTree(struct GenTree*) 7373669:NA:1.91%:+0.0064%:public: unsigned int __cdecl ValueNumStore::VNForMapStore(unsigned int, unsigned int, unsigned int) 7322133:+38.09%:1.89%:+0.0063%:public: unsigned int __cdecl ValueNumStore::VNForMapSelectInner(enumValueNumKind, enumvar_types, unsigned int, unsigned int) 5431101:+0.61%:1.40%:+0.0047%: memset 4280844:+1.48%:1.11%:+0.0037%:public: void __cdecl Compiler::fgValueNumberBlock(struct BasicBlock*) 4204838:NA:1.09%:+0.0036%:protected: void __cdecl Compiler::optHoistLoopBlocks(classFlowGraphNaturalLoop*, classArrayStack<struct BasicBlock *> *, struct Compiler::LoopHoistContext*) 4124325:+2.51%:1.07%:+0.0036%:public: void __cdecl Compiler::compInit(classArenaAllocator*, struct CORINFO_METHOD_STRUCT_*, classICorJitInfo*, struct CORINFO_METHOD_INFO*, struct InlineInfo*) 3321557:NA:0.86%:+0.0029%:protected: bool __cdecl Compiler::optHoistThisLoop(classFlowGraphNaturalLoop*, struct Compiler::LoopHoistContext*) 2852281:NA:0.74%:+0.0025%:public: void __cdecl Compiler::optFindNewLoops(void) 2337736:+1170.99%:0.60%:+0.0020%:public: bool __cdecl FlowGraphNaturalLoop::ContainsBlock(struct BasicBlock*) 2197805:+0.09%:0.57%:+0.0019%:public: void * __cdecl ArenaAllocator::allocateMemory(unsigned __int64) 1423528:+2.27%:0.37%:+0.0012%:public: static classFlowGraphNaturalLoops* __cdecl FlowGraphNaturalLoops::Find(classFlowGraphDfsTree const *) 1129028:+0.34%:0.29%:+0.0010%:private: void __cdecl SsaBuilder::BlockRenameVariables(struct BasicBlock*) 1127779:NA:0.29%:+0.0010%:public: unsigned int __cdecl Compiler::fgMemoryVNForLoopSideEffects(enumMemoryKind, struct BasicBlock*, classFlowGraphNaturalLoop*) 982049:+0.36%:0.25%:+0.0008%: `Compiler::fgComputeDfs'::`2'::<lambda_1>::operator() 863690:NA:0.22%:+0.0007%:protected: void __cdecl Compiler::optHoistCandidate(struct GenTree*, struct BasicBlock*, classFlowGraphNaturalLoop*, struct Compiler::LoopHoistContext*) 639173:NA:0.17%:+0.0006%:private: void __cdecl Compiler::optPerformHoistExpr(struct GenTree*, struct BasicBlock*, classFlowGraphNaturalLoop*) 503193:+69.49%:0.13%:+0.0004%:public: void __cdecl Compiler::optRecordLoopMemoryDependence(struct GenTree*, struct BasicBlock*, unsigned int) -475395:-15.05%:0.12%:-0.0004%:public: void __cdecl Compiler::fgValueNumberArrayElemLoad(struct GenTree*, struct VNFuncApp*) -492997:-100.00%:0.13%:-0.0004%:protected: void __cdecl Compiler::AddModifiedFieldAllContainingLoops(unsigned int, struct CORINFO_FIELD_STRUCT_*, enumCompiler::FieldKindForVN) -543196:-28.05%:0.14%:-0.0005%:public: void __cdecl Compiler::fgValueNumberArrayElemStore(struct GenTree*, struct VNFuncApp*, unsigned int, unsigned int) -662618:-100.00%:0.17%:-0.0006%:private: void __cdecl Compiler::optPerformHoistExpr(struct GenTree*, struct BasicBlock*, unsigned int) -925938:-100.00%:0.24%:-0.0008%:protected: void __cdecl Compiler::optHoistCandidate(struct GenTree*, struct BasicBlock*, unsigned int, struct Compiler::LoopHoistContext*) -935385:-1.85%:0.24%:-0.0008%: `Compiler::optHoistLoopBlocks'::`2'::HoistVisitor::PostOrderVisit-1028653:-14.12%:0.27%:-0.0009%:public: void __cdecl Compiler::fgValueNumberFieldStore(struct GenTree*, struct GenTree*, classFieldSeq*, __int64, unsigned int, unsigned int) -1279178:-100.00%:0.33%:-0.0011%:protected: void __cdecl Compiler::AddContainsCallAllContainingLoops(unsigned int) -1914799:-100.00%:0.49%:-0.0017%:public: unsigned int __cdecl Compiler::fgMemoryVNForLoopSideEffects(enumMemoryKind, struct BasicBlock*, unsigned int) -2128688:-100.00%:0.55%:-0.0018%:private: void __cdecl Compiler::optRecordLoopNestsMemoryHavoc(unsigned int, unsigned int) -2249218:-77.42%:0.58%:-0.0019%:public: enumPhaseStatus __cdecl Compiler::optFindLoopsPhase(void) -2348262:-11.82%:0.61%:-0.0020%:public: void __cdecl Compiler::fgValueNumberFieldLoad(struct GenTree*, struct GenTree*, classFieldSeq*, __int64) -2733873:-14.67%:0.71%:-0.0024%:public: void __cdecl Compiler::fgValueNumberCall(struct GenTreeCall*) -3219484:-100.00%:0.83%:-0.0028%:protected: bool __cdecl Compiler::optHoistThisLoop(unsigned int, struct Compiler::LoopHoistContext*) -4207077:-100.00%:1.09%:-0.0036%:protected: void __cdecl Compiler::optHoistLoopBlocks(unsigned int, classArrayStack<struct BasicBlock *> *, struct Compiler::LoopHoistContext*) -4276316:-31.33%:1.11%:-0.0037%:public: void __cdecl Compiler::fgMutateGcHeap(struct GenTree*) -13184191:-100.00%:3.41%:-0.0114%:public: void __cdecl Compiler::recordGcHeapStore(struct GenTree*, unsigned int) -20002426:-100.00%:5.17%:-0.0173%:protected: bool __cdecl Compiler::optVNIsLoopInvariant(unsigned int, unsigned int, classJitHashTable<unsigned int, struct JitSmallPrimitiveKeyFuncs<unsigned int>, bool, classCompAllocator, classJitHashTableBehavior>*) -50043441:-100.00%:12.94%:-0.0433%:private: bool __cdecl Compiler::optComputeLoopSideEffectsOfBlock(struct BasicBlock*)

So (1) In VNForExpr it is a bit more expensive to extract the loop containing the block; (2) AddContainsCallAllContainingLoops is more expensive; it should be switched to use FlowGraphNaturalLoop::GetChild(); (3) I switched optComputeLoopSideEffects to iterate over all blocks, whereas it previously iterated top-level loops and then their loop blocks. Will switch this back.

Also looks like there is a related jitstress failure, so will look at that.

jakobbotsch · 2023-12-06T08:59:51Z

TP regression is a bit smaller now (with local changes I haven't pushed yet), but I think we'll have to live with it. It mainly comes from being a bit more expensive to do the loop number <-> block queries.

Base:115669398234, Diff:115791952713, +0.1060%60288105:NA:17.15%:+0.0521%:public: unsigned int __cdecl ValueNumStore::VNForExpr(struct BasicBlock*, enumvar_types) 53395839:NA:15.19%:+0.0462%:private: void __cdecl Compiler::optComputeLoopSideEffectsOfBlock(struct BasicBlock*, classFlowGraphNaturalLoop*) 20125631:NA:5.73%:+0.0174%:protected: bool __cdecl Compiler::optVNIsLoopInvariant(unsigned int, classFlowGraphNaturalLoop*, classJitHashTable<unsigned int, struct JitSmallPrimitiveKeyFuncs<unsigned int>, bool, classCompAllocator, classJitHashTableBehavior>*)
14648945:NA:4.17%:+0.0127%:public: static classBlockToNaturalLoopMap* __cdecl BlockToNaturalLoopMap::Build(classFlowGraphNaturalLoops*) 14159157:NA:4.03%:+0.0122%:BitSetOps<unsigned __int64 *,1,BitVecTraits *,BitVecTraits>::VisitBits<`FlowGraphNaturalLoop::VisitLoopBlocksReversePostOrder<`Compiler::optComputeLoopSideEffects'::`10'::<lambda_1> >'::`2'::<lambda_1>>8714325:+4.76%:2.48%:+0.0075%:public: static struct BasicBlock* __cdecl BasicBlock::New(classCompiler*) 8096425:+1.19%:2.30%:+0.0070%:public: void __cdecl Compiler::fgValueNumberTree(struct GenTree*) 7114922:+37.01%:2.02%:+0.0062%:public: unsigned int __cdecl ValueNumStore::VNForMapSelectInner(enumValueNumKind, enumvar_types, unsigned int, unsigned int) 7066803:NA:2.01%:+0.0061%:public: unsigned int __cdecl ValueNumStore::VNForMapStore(unsigned int, unsigned int, unsigned int) 6795126:NA:1.93%:+0.0059%:protected: void __cdecl Compiler::AddContainsCallAllContainingLoops(classFlowGraphNaturalLoop*) 4204838:NA:1.20%:+0.0036%:protected: void __cdecl Compiler::optHoistLoopBlocks(classFlowGraphNaturalLoop*, classArrayStack<struct BasicBlock *> *, struct Compiler::LoopHoistContext*) 4141024:+1.43%:1.18%:+0.0036%:public: void __cdecl Compiler::fgValueNumberBlock(struct BasicBlock*) 4124325:+2.51%:1.17%:+0.0036%:public: void __cdecl Compiler::compInit(classArenaAllocator*, struct CORINFO_METHOD_STRUCT_*, classICorJitInfo*, struct CORINFO_METHOD_INFO*, struct InlineInfo*) 3908060:+0.44%:1.11%:+0.0034%: memset 3321557:NA:0.94%:+0.0029%:protected: bool __cdecl Compiler::optHoistThisLoop(classFlowGraphNaturalLoop*, struct Compiler::LoopHoistContext*) 2852281:NA:0.81%:+0.0025%:public: void __cdecl Compiler::optFindNewLoops(void) 2337736:+1170.99%:0.67%:+0.0020%:public: bool __cdecl FlowGraphNaturalLoop::ContainsBlock(struct BasicBlock*) 2198509:+0.09%:0.63%:+0.0019%:public: void * __cdecl ArenaAllocator::allocateMemory(unsigned __int64) 1423528:+2.27%:0.40%:+0.0012%:public: static classFlowGraphNaturalLoops* __cdecl FlowGraphNaturalLoops::Find(classFlowGraphDfsTree const *) 1129028:+0.34%:0.32%:+0.0010%:private: void __cdecl SsaBuilder::BlockRenameVariables(struct BasicBlock*) 1127779:NA:0.32%:+0.0010%:public: unsigned int __cdecl Compiler::fgMemoryVNForLoopSideEffects(enumMemoryKind, struct BasicBlock*, classFlowGraphNaturalLoop*) 982049:+0.36%:0.28%:+0.0008%: `Compiler::fgComputeDfs'::`2'::<lambda_1>::operator() 863690:NA:0.25%:+0.0007%:protected: void __cdecl Compiler::optHoistCandidate(struct GenTree*, struct BasicBlock*, classFlowGraphNaturalLoop*, struct Compiler::LoopHoistContext*) 639229:NA:0.18%:+0.0006%:private: void __cdecl Compiler::optPerformHoistExpr(struct GenTree*, struct BasicBlock*, classFlowGraphNaturalLoop*) 503013:+69.46%:0.14%:+0.0004%:public: void __cdecl Compiler::optRecordLoopMemoryDependence(struct GenTree*, struct BasicBlock*, unsigned int) -475395:-15.05%:0.14%:-0.0004%:public: void __cdecl Compiler::fgValueNumberArrayElemLoad(struct GenTree*, struct VNFuncApp*) -492997:-100.00%:0.14%:-0.0004%:protected: void __cdecl Compiler::AddModifiedFieldAllContainingLoops(unsigned int, struct CORINFO_FIELD_STRUCT_*, enumCompiler::FieldKindForVN) -543196:-28.05%:0.15%:-0.0005%:public: void __cdecl Compiler::fgValueNumberArrayElemStore(struct GenTree*, struct VNFuncApp*, unsigned int, unsigned int) -662618:-100.00%:0.19%:-0.0006%:private: void __cdecl Compiler::optPerformHoistExpr(struct GenTree*, struct BasicBlock*, unsigned int) -925938:-100.00%:0.26%:-0.0008%:protected: void __cdecl Compiler::optHoistCandidate(struct GenTree*, struct BasicBlock*, unsigned int, struct Compiler::LoopHoistContext*) -935385:-1.85%:0.27%:-0.0008%: `Compiler::optHoistLoopBlocks'::`2'::HoistVisitor::PostOrderVisit-1028653:-14.12%:0.29%:-0.0009%:public: void __cdecl Compiler::fgValueNumberFieldStore(struct GenTree*, struct GenTree*, classFieldSeq*, __int64, unsigned int, unsigned int) -1279178:-100.00%:0.36%:-0.0011%:protected: void __cdecl Compiler::AddContainsCallAllContainingLoops(unsigned int) -1914799:-100.00%:0.54%:-0.0017%:public: unsigned int __cdecl Compiler::fgMemoryVNForLoopSideEffects(enumMemoryKind, struct BasicBlock*, unsigned int) -2128688:-100.00%:0.61%:-0.0018%:private: void __cdecl Compiler::optRecordLoopNestsMemoryHavoc(unsigned int, unsigned int) -2249218:-77.42%:0.64%:-0.0019%:public: enumPhaseStatus __cdecl Compiler::optFindLoopsPhase(void) -2348262:-11.82%:0.67%:-0.0020%:public: void __cdecl Compiler::fgValueNumberFieldLoad(struct GenTree*, struct GenTree*, classFieldSeq*, __int64) -2733873:-14.67%:0.78%:-0.0024%:public: void __cdecl Compiler::fgValueNumberCall(struct GenTreeCall*) -3219484:-100.00%:0.92%:-0.0028%:protected: bool __cdecl Compiler::optHoistThisLoop(unsigned int, struct Compiler::LoopHoistContext*) -4207077:-100.00%:1.20%:-0.0036%:protected: void __cdecl Compiler::optHoistLoopBlocks(unsigned int, classArrayStack<struct BasicBlock *> *, struct Compiler::LoopHoistContext*) -4276316:-31.33%:1.22%:-0.0037%:public: void __cdecl Compiler::fgMutateGcHeap(struct GenTree*) -13184191:-100.00%:3.75%:-0.0114%:public: void __cdecl Compiler::recordGcHeapStore(struct GenTree*, unsigned int) -20002426:-100.00%:5.69%:-0.0173%:protected: bool __cdecl Compiler::optVNIsLoopInvariant(unsigned int, unsigned int, classJitHashTable<unsigned int, struct JitSmallPrimitiveKeyFuncs<unsigned int>, bool, classCompAllocator, classJitHashTableBehavior>*) -50043441:-100.00%:14.24%:-0.0433%:private: bool __cdecl Compiler::optComputeLoopSideEffectsOfBlock(struct BasicBlock*)

I wanted to share this anyway because it shows the cost of switching from the lexical LoopDsc::LoopBlocks() iteration to the bit vector based VisitLoopBlocks; in the side effect code the cost of that appears to be about 0.0122% TP, so that's probably not a place we need to optimize significantly.

jakobbotsch · 2023-12-06T09:27:03Z

jitstress failure was in a test with DOTNET_JitOptRepeat=*. I'd forgotten to recompute the new loop information in RecomputeLoopInfo.

jakobbotsch · 2023-12-06T09:27:41Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

azure-pipelines · 2023-12-06T09:27:55Z

Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch · 2023-12-06T15:55:43Z

cc @dotnet/jit-contrib PTAL @BruceForstall

Diffs. See above for why.

This passed jitstress and libraries-jitstress on the previous commit (before I added a quirk).

BruceForstall

LGTM. Thanks for all the renamings.

BruceForstall · 2023-12-07T02:23:50Z

+ struct LoopSideEffects* m_loopSideEffects;
+ struct HoistCounts* m_loopHoistCounts;


nit: can you put forward declarations at the top of this file with the others
Suggested change
structLoopSideEffects*m_loopSideEffects;
structHoistCounts*m_loopHoistCounts;
LoopSideEffects*m_loopSideEffects;
HoistCounts*m_loopHoistCounts;

I moved LoopSideEffects above Compiler so no forward declaration is needed, and removed m_loopHoistCounts entirely (I added that before I realized we could move those fields inside the HoistContext)

LoopDsc is a nested class defined below this field so it needs the nested forward declaration, but we will be able to get rid of that soon anyway.

BruceForstall · 2023-12-07T02:27:34Z


+typedef JitHashTable<CORINFO_FIELD_HANDLE, JitPtrKeyFuncs<struct CORINFO_FIELD_STRUCT_>, FieldKindForVN> FieldHandleSet;
+
+typedef JitHashTable<CORINFO_CLASS_HANDLE, JitPtrKeyFuncs<struct CORINFO_CLASS_STRUCT_>, bool> ClassHandleSet;


It always seems like we could use a dedicated "set" type instead of overloading JitHashTable like this... (no request here; and not unique to this PR)

Agreed, this seems wasteful.

BruceForstall · 2023-12-07T03:38:49Z

 PhaseStatus optFindLoopsPhase(); // Finds loops and records them in the loop table

 void optFindLoops();
+ void optFindNewLoops();


This name is unfortunately confusing: when not in context, I thought it meant "find newly created loops, after some initial loop finding pass".
Maybe this is temporary and we'll get rid of "old" at some point and rename "new" to remove the word "new" everywhere.

Right, we should be able to get rid of these old/new distinctions soon.

BruceForstall · 2023-12-07T03:43:33Z

 assert(exprBb != nullptr);
+ assert(loop->EntryEdges().size() == 1);

+ BasicBlock* preheader = loop->EntryEdges()[0]->getSourceBlock();


A nit, but I wonder if it would be nice to have convenience functions to get a particular edge/etc. from a vector, e.g.
Suggested change
BasicBlock* preheader = loop->EntryEdges()[0]->getSourceBlock();
BasicBlock* preheader = loop->EntryEdge(0)->getSourceBlock();
FlowEdge* EntryEdge(unsigned i)
{
return m_entryEdges[i];
}

BruceForstall · 2023-12-07T03:48:36Z

 }

+//------------------------------------------------------------------------
+// AddVariableLiveness: Adds the variable liveness information for 'blk' to 'this' LoopDsc


nit: no LoopDsc here
Suggested change
// AddVariableLiveness: Adds the variable liveness information for 'blk' to 'this' LoopDsc
// AddVariableLiveness: Adds the variable liveness information for 'blk' to 'this' loop

Fixed this and a few other instances of "lnum" I had missed.

…-representation

jakobbotsch · 2023-12-07T08:12:27Z

Closing and reopening to pick up #95718

jakobbotsch added 14 commits November 28, 2023 13:35

Fix clang build
1f115e0

Merge branch 'main' of github.com:dotnet/runtime into loop-clone-new-…
e59040c
…representation

Fix after merge
1893d7c

Clean up
8be981e

Set redirection block weight correctly
d9cd213

Further quirking
587a22b

Fix a bug that crept in
baaeccb

Final quirks
39bf71c

Merge branch 'main' of github.com:dotnet/runtime into loop-clone-new-…
90c9354
…representation

Actual final quirking
1235a0f

WIP
228ea40

Merge branch 'main' of github.com:dotnet/runtime into vn-hoisting-new…
11244e5
…-representation

ghost assigned jakobbotsch Dec 4, 2023

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 4, 2023

jakobbotsch added 3 commits December 4, 2023 17:24

Merge branch 'main' of github.com:dotnet/runtime into vn-hoisting-new…
0ea7789
…-representation

Fix after merge
39e6bf5

Fixes after merge, compiler fixes
cf8258a

jakobbotsch mentioned this pull request Dec 5, 2023
JIT: Port loop cloning to the new loop representation #95326
Merged

jakobbotsch added 3 commits December 5, 2023 19:39

Merge branch 'main' of github.com:dotnet/runtime into vn-hoisting-new…
8cf76cd
…-representation

Fix after merge
800e446

Rename DFS tree members
3b813ba

jakobbotsch mentioned this pull request Dec 5, 2023
Improve JIT loop optimizations (.NET 9) #93144
Closed
21 tasks

build-analysisBot mentioned this pull request Dec 6, 2023
An error occurred trying to start process 'llvm-symbolizer' #91975
Open

Fix nested loop check; iterate blocks in loops directly
fb0ffea

Recompute new loops in RecomputeLoopInfo
f1e1c59

Quirk some more
dd8f1fd

jakobbotsch marked this pull request as ready for review December 6, 2023 15:53

jakobbotsch requested a review from BruceForstall December 6, 2023 15:55

BruceForstall approved these changes Dec 7, 2023
View reviewed changes

jakobbotsch added 3 commits December 7, 2023 08:51

Address some feedback; update "lnum"
864b734

Merge branch 'main' of github.com:dotnet/runtime into vn-hoisting-new…
87f0ef8
…-representation

Convenience edge accessor functions
d0ba64d

jakobbotsch closed this Dec 7, 2023

jakobbotsch reopened this Dec 7, 2023

jakobbotsch merged commit 03c2d25 into dotnet:mainDec 7, 2023

jakobbotsch deleted the vn-hoisting-new-representation branch December 7, 2023 10:59

EgorBo mentioned this pull request Jan 4, 2024
[Perf] Linux/arm64: 5 Regressions on 12/8/2023 12:07:17 AM #96498
Closed

github-actionsBot locked and limited conversation to collaborators Jan 7, 2024

		struct LoopSideEffects* m_loopSideEffects;
		struct HoistCounts* m_loopHoistCounts;

-structLoopSideEffects*m_loopSideEffects;
-structHoistCounts*m_loopHoistCounts;
+LoopSideEffects*m_loopSideEffects;
+HoistCounts*m_loopHoistCounts;


		typedef JitHashTable<CORINFO_FIELD_HANDLE, JitPtrKeyFuncs<struct CORINFO_FIELD_STRUCT_>, FieldKindForVN> FieldHandleSet;

		typedef JitHashTable<CORINFO_CLASS_HANDLE, JitPtrKeyFuncs<struct CORINFO_CLASS_STRUCT_>, bool> ClassHandleSet;

- BasicBlock* preheader = loop->EntryEdges()[0]->getSourceBlock();
+ BasicBlock* preheader = loop->EntryEdge(0)->getSourceBlock();
+FlowEdge* EntryEdge(unsigned i)
+{
+return m_entryEdges[i];
+}

	// AddVariableLiveness: Adds the variable liveness information for 'blk' to 'this' LoopDsc
	// AddVariableLiveness: Adds the variable liveness information for 'blk' to 'this' loop

Uh oh!

Conversation

jakobbotsch commented Dec 4, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Dec 4, 2023

Uh oh!

jakobbotsch commented Dec 5, 2023

Uh oh!

azure-pipelinesBot commented Dec 5, 2023

Uh oh!

jakobbotsch commented Dec 6, 2023

Uh oh!

jakobbotsch commented Dec 6, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakobbotsch commented Dec 6, 2023

Uh oh!

jakobbotsch commented Dec 6, 2023

Uh oh!

azure-pipelinesBot commented Dec 6, 2023

Uh oh!

jakobbotsch commented Dec 6, 2023

Uh oh!

BruceForstall left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakobbotschDec 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakobbotsch commented Dec 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jakobbotsch commented Dec 4, 2023•
edited
Loading

jakobbotsch commented Dec 6, 2023•
edited
Loading

jakobbotschDec 7, 2023•
edited
Loading