Uh oh!
There was an error while loading. Please reload this page.
[browser][mt] dynamic thread create - #95702
Merged
pavelsavara merged 2 commits intoDec 13, 2023
Merged
Conversation
ghost
commented
Dec 6, 2023
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
pavelsavara
commented
Dec 7, 2023
MemberAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Dec 7, 2023
pavelsavaraforce-pushed
the
browser_mt_dynamic_thread_create
branch
2 times, most recently
from
December 8, 2023 15:55
665337b to
2f852a6Comparepavelsavara
commented
Dec 8, 2023
MemberAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavaraforce-pushed
the
browser_mt_dynamic_thread_create
branch
from
December 12, 2023 11:58
2f852a6 to
edf8e14Comparepavelsavara
commented
Dec 12, 2023
MemberAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
marked this pull request as ready for review
December 12, 2023 12:21
pavelsavara
requested review from
kg, lewing, radical and thaystg
as code ownersDecember 12, 2023 12:21
31 tasks
lewing
approved these changes
Dec 12, 2023
radical
reviewed
Dec 13, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
40to5, but floating, not just at the start<_WasmPThreadPoolSize>from project filesPTHREAD_POOL_SIZE_STRICT=0which will not throw when we run out of thread pool threads, but it will allocate more.getNewWorkerinternal and use it to trigger adding more to the emscripten's thread pool.PThreadinternalWebWorkertoJSWebWorkerJSWebWorkerawait JavaScriptImports.ThreadAvailabletoJSWebWorkerso that we are sure that the pthread is ready/loadedJSWebWorkerfrom the pool, because they have dirty JS state