Enable Windows runs of AddressSanitizer - #95758

Merged

jkoritzinsky merged 11 commits into

mainfrom

Jan 30, 2024

jkoritzinsky commented Dec 7, 2023

Member

We now have a new enough version of VS for this

jkoritzinsky added 2 commits

August 14, 2023 12:07

Run our windows legs on the scouting images (required until 17.7 ships)

2f11c4d

Add Windows legs for ASAN

2e92a28

jkoritzinsky added the area-Infrastructure label

ghost commented Dec 7, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

We now have a new enough version of VS for this

Author:	jkoritzinsky
Assignees:	-
Labels:	`area-Infrastructure`
Milestone:	-

ghost assigned jkoritzinsky

jkoritzinsky commented Dec 7, 2023

MemberAuthor

/azp run runtime-sanitized

azure-pipelinesBot commented Dec 7, 2023

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 7, 2023

JIT/jit64/opt/rngchk/RngchkStress2.cs failing to build with error CS8078: An expression is too long or complex to compile#87879

Closed

"corerun.exe" not found dotnet/dnceng#1528

Closed

jkoritzinsky added 2 commits

January 17, 2024 14:44

Merge branch 'main' into asan-win

c347bb8

Disable tests that run crossgen2 in the sanitizer modes

32b3836

jkoritzinsky force-pushed the asan-win branch from 7154b75 to 32b3836Compare

January 17, 2024 23:08

jkoritzinsky commented Jan 17, 2024

MemberAuthor

/azp run runtime-sanitized

azure-pipelinesBot commented Jan 17, 2024

Azure Pipelines successfully started running 1 pipeline(s).

Don't PGO optimize sanitized builds

3cd58df

jkoritzinsky commented Jan 17, 2024

MemberAuthor

/azp run runtime-sanitized

azure-pipelinesBot commented Jan 17, 2024

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jan 18, 2024

BasicEventSourceTests.TestsManifestGeneration test failing in CI #97103

Closed

Tracking issue for CI build timeouts #76454

Closed

ExceptionOnStartIsPropagated test failed in CI #84562

Closed

[8.0] Failing to build native components #94823

Closed

Disable custom MSBuild targets when the test target is unsupported

9259e22

jkoritzinsky commented Jan 18, 2024

MemberAuthor

/azp run runtime-sanitized

azure-pipelinesBot commented Jan 18, 2024

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jan 18, 2024

[browser][MT] various WebWorkerTest CI failures #96628

Closed

[browser][MT] GC deadlock #96190

Closed

Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049

Closed

jkoritzinsky commented Jan 19, 2024

MemberAuthor

/azp run runtime-sanitized

azure-pipelinesBot commented Jan 19, 2024

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky commented Jan 23, 2024

MemberAuthor

/azp run runtime-sanitized

azure-pipelinesBot commented Jan 23, 2024

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky added 3 commits

January 26, 2024 14:16

Copy sanitizer runtimes for NativeAOT libraries tests

54fd5f4

Double timeout for libraries tests

2f6e79a

Merge branch 'asan-win' of github.com:dotnet/runtime into asan-win

f900adb

jkoritzinsky commented Jan 26, 2024

MemberAuthor

/azp run runtime-sanitized

azure-pipelinesBot commented Jan 26, 2024

Azure Pipelines successfully started running 1 pipeline(s).

build-analysisBot mentioned this pull request

XUnitLogChecker: runtime-libraries-coreclr outerloop tests are unable to find the tool DLL #96035

Closed

Separate out the Windows libraries test runs and specify the helix qu…

beeff46

…eues manually

jkoritzinsky commented Jan 29, 2024

MemberAuthor

/azp run runtime-sanitized

azure-pipelinesBot commented Jan 29, 2024

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky commented Jan 29, 2024

MemberAuthor

/azp run runtime-sanitized

azure-pipelinesBot commented Jan 29, 2024

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky commented Jan 29, 2024

MemberAuthor

Most of the libraries failures on Windows are due to #96035.

Update runtime-sanitized.yml

88b3a5f

jkoritzinsky commented Jan 29, 2024

MemberAuthor

/azp run runtime-sanitized

azure-pipelinesBot commented Jan 29, 2024

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky requested a review from a team

January 30, 2024 03:46

agocke approved these changes

View reviewed changes

agocke left a comment

Member

LGTM, aside from failures around the XUnitLogChecker. Looks like we might need to condition that again

eng/pipelines/runtime-sanitized.yml

+ - template: /eng/pipelines/common/platform-matrix.yml
+ parameters:
+ jobTemplate: /eng/pipelines/common/global-build-job.yml
+ buildConfig: Debug

agockeJan 30, 2024

Member

Does Debug make a difference? That is, is asan supported in Release? Is it better/worse?

jkoritzinskyJan 30, 2024

MemberAuthor

ASAN is supported in release, but it can miss some checks as the instrumentation pass runs after many optimization passes, which can cause false negatives on some of the stack usage validation.

build-analysisBot mentioned this pull request

[mono][tests] System.Runtime.Caching assert fails on linux-bionic #93106

Closed

jkoritzinsky commented Jan 30, 2024

MemberAuthor

The XUnitLogChecker failures are tracked by the issue I linked above (same underlying issue in both scenarios).

jkoritzinsky merged commit a258bb9 into main

ViktorHofer deleted the asan-win branch

January 30, 2024 08:46

github-actionsBot locked and limited conversation to collaborators

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.