Skip to content

[browser][MT] enable finalizer thread, run most tests in threadpool - #95783

Merged
pavelsavara merged 4 commits into
dotnet:mainfrom
pavelsavara:mono_gc_init_finalizer_thread
Dec 12, 2023
Merged

[browser][MT] enable finalizer thread, run most tests in threadpool#95783
pavelsavara merged 4 commits into
dotnet:mainfrom
pavelsavara:mono_gc_init_finalizer_thread

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Dec 8, 2023•
edited
Loading

Copy link
Copy Markdown
Member
  • mono_wasm_init_finalizer_thread for MT runtime
  • run MT unit test from the thread pool thread, so that UI thread keeps responsive
  • -backgroundExec for Wasm test runner triggered via <_XUnitBackgroundExec>

@pavelsavarapavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Dec 8, 2023
@pavelsavarapavelsavara added this to the 9.0.0 milestone Dec 8, 2023
@pavelsavarapavelsavara self-assigned this Dec 8, 2023
@ghost

ghost commented Dec 8, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:pavelsavara
Assignees:pavelsavara
Labels:

arch-wasm, area-VM-threading-mono, os-browser

Milestone:9.0.0

@pavelsavara

pavelsavara commented Dec 8, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Dec 8, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Dec 8, 2023

Copy link
Copy Markdown
MemberAuthor

Surprisingly this change opens more opportunity for mono_thread_platform_create_thread failure in many unit tests.

System.ExecutionEngineException : mono_thread_platform_create_thread() failed
[11:14:05] info: at System.Threading.Thread.ThrowThreadStartException(Exception ex)
[11:14:05] info: at System.Threading.Thread.StartCore()

Log
Log
Log
Log
Log

This was referenced Dec 8, 2023
Open
Closed
@pavelsavara
- mono_wasm_init_finalizer_thread for MT
b331283
- -backgroundExec for Wasm test runner triggered via </_XUnitBackgroundExec>
@pavelsavara
pavelsavaraforce-pushed the mono_gc_init_finalizer_thread branch from a5838e5 to b331283CompareDecember 8, 2023 15:44
@pavelsavara

pavelsavara commented Dec 8, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Dec 8, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
pavelsavara marked this pull request as ready for review December 8, 2023 17:25
@pavelsavara

pavelsavara commented Dec 8, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Dec 8, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavarapavelsavara changed the title [browser][MT] enable finalizer thread[browser][MT] enable finalizer thread, run most tests in threadpoolDec 11, 2023
kg
kg reviewed Dec 11, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/exports-binding.ts Outdated
kg
kg reviewed Dec 11, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/startup.ts Outdated
kg
kg approved these changes Dec 11, 2023
View reviewed changes
@pavelsavara

pavelsavara commented Dec 12, 2023

Copy link
Copy Markdown
MemberAuthor

CI failures are unrelated

@pavelsavara
pavelsavara merged commit cea45aa into dotnet:mainDec 12, 2023
@pavelsavara
pavelsavara deleted the mono_gc_init_finalizer_thread branch December 12, 2023 10:10
@pavelsavarapavelsavara mentioned this pull request Dec 12, 2023
Closed
31 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewingAwaiting requested review from lewinglewing is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek
@marafmarafAwaiting requested review from maraf
1 more reviewer
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-VM-threading-monoos-browserBrowser variant of arch-wasm

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelsavara@kg