Skip to content

[RISC-V] Handle mod in SetThrowHelperBlocks - #96056

Merged
AndyAyersMS merged 1 commit into
dotnet:mainfrom
tomeksowi:fix-set-throw-helper-blocks-for-mod
Dec 15, 2023
Merged

[RISC-V] Handle mod in SetThrowHelperBlocks#96056
AndyAyersMS merged 1 commit into
dotnet:mainfrom
tomeksowi:fix-set-throw-helper-blocks-for-mod

Conversation

@tomeksowi

@tomeksowitomeksowi commented Dec 15, 2023

Copy link
Copy Markdown
Member

@tomeksowi@clamp03
[RISC-V] Handle mod in SetThrowHelperBlocks
ed4d9ba
This fixes broken CLR tests after dotnet#95379
Co-authored-by: Dong-Heon Jung <clamp03@gmail.com>
@ghostghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Dec 15, 2023
@ghost

ghost commented Dec 15, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This fixes broken CLR tests after #95379

Part of #84834
cc @wscho77@HJLeee@clamp03@JongHeonChoi@t-mustafin@gbalykov@viewizard@ashaurtaev@brucehoult@sirntar@yurai007@Bajtazar

cc @shushanhf as change touches LA as well

Author:tomeksowi
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@clamp03clamp03 added the arch-riscv Related to the RISC-V architecture label Dec 15, 2023
@AndyAyersMS

AndyAyersMS commented Dec 15, 2023

Copy link
Copy Markdown
Member

Failure was a timeout. Will ignore.

@AndyAyersMS
AndyAyersMS merged commit d2cbd1c into dotnet:mainDec 15, 2023
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 15, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes
+3 more reviewers
@clamp03clamp03clamp03 approved these changes
@yurai007yurai007yurai007 approved these changes
@BajtazarBajtazarBajtazar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tomeksowitomeksowi

Labels

arch-riscvRelated to the RISC-V architecturearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tomeksowi@AndyAyersMS@clamp03@yurai007@Bajtazar