Uh oh!
There was an error while loading. Please reload this page.
Fix hot/cold splitting - #96074
Merged
Merged
Conversation
Change dotnet#95836 removed a bit too much code, namely, a loop that set `BBF_COLD` on newly determined cold blocks. Restore that loop. Add some additional IG jump dumping. Fixesdotnet#95946
ghost
commented
Dec 15, 2023
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
BruceForstall
commented
Dec 15, 2023
ContributorAuthor
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
commented
Dec 15, 2023
ContributorAuthor
@amanasifkhalid PTAL |
amanasifkhalid
approved these changes
Dec 15, 2023
amanasifkhalid
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the fix!
BruceForstall
commented
Dec 16, 2023
ContributorAuthor
Well, the crossgen2 pipeline isn't clean, but it's better? |
Member
Thanks for fixing this, definitely looks like I deleted too much here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change #95836 removed a bit too much code, namely, a loop that set
BBF_COLDon newly determined cold blocks. Restore that loop.Add some additional IG jump dumping.
Fixes#95946