Skip to content

Revert "Revert "Error out if SelfContained is not specified for Native AOT publish"" - #96206

Merged
MichalStrehovsky merged 1 commit into
mainfrom
revert-95881-revert-95496-MichalStrehovsky-patch-1
Dec 20, 2023
Merged

Revert "Revert "Error out if SelfContained is not specified for Native AOT publish""#96206
MichalStrehovsky merged 1 commit into
mainfrom
revert-95881-revert-95496-MichalStrehovsky-patch-1

Conversation

@MichalStrehovsky

Copy link
Copy Markdown
Member

Reverts #95881

I fixed the test in the SDK repo that was failing because of this so we should be able to restore this.

Cc @dotnet/ilc-contrib

@ghostghost added linkable-framework Issues associated with delivering a linker friendly framework area-Tools-ILLink .NET linker development as well as trimming analyzers labels Dec 20, 2023
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #95881

I fixed the test in the SDK repo that was failing because of this so we should be able to restore this.

Cc @dotnet/ilc-contrib

Author:MichalStrehovsky
Assignees:-
Labels:

linkable-framework

Milestone:-

@sbomersbomer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichalStrehovsky
MichalStrehovsky merged commit 3a5bea5 into mainDec 20, 2023
@MichalStrehovsky
MichalStrehovsky deleted the revert-95881-revert-95496-MichalStrehovsky-patch-1 branch December 20, 2023 21:51
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 20, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILLink.NET linker development as well as trimming analyzerslinkable-frameworkIssues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MichalStrehovsky@sbomer