') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Update coredistools by BruceForstall · Pull Request #96286 · dotnet/runtime · GitHub
Skip to content

Update coredistools - #96286

Merged
BruceForstall merged 7 commits into
dotnet:mainfrom
BruceForstall:UpdateCoredistools
Jan 3, 2024
Merged

Update coredistools#96286
BruceForstall merged 7 commits into
dotnet:mainfrom
BruceForstall:UpdateCoredistools

Conversation

@BruceForstall

@BruceForstallBruceForstall commented Dec 23, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Update to the 1.4.0 version of the coredistools package.

Also, implement a basic late disassembler for RyuJIT based on
coredistools (previously, this depended on closed-source msvcdis).

Various changes:

  1. Remove unused AddressMap in SPMI. Removed a bunch of cases in
    the NearDiffer that were using it.
  2. Change arm64 emitter unit tests to not require verbose
  3. Always build in the late disassembler under DEBUG. It's only
    used when JitLateDisasm is set.
  4. Implement new arm32 callback mechanism for movw/movt handling
    in the NearDiffer.

@BruceForstall
Update coredistools
825547f
Update to the 1.2.0 version of the coredistools package.
Also, implement a basic late disassembler for RyuJIT based on
coredistools (previously, this depended on closed-source msvcdis).
Various changes:
1. Remove unused AddressMap in SPMI. Removed a bunch of cases in
the NearDiffer that were using it.
2. Change arm64 emitter unit tests to not require `verbose`
3. Always build in the late disassembler under DEBUG. It's only
used when `JitLateDisasm` is set.
4. Implement new arm32 callback mechanism for movw/movt handling
in the NearDiffer.
@BruceForstall
Allow fallback to coredistools 1.1.0
cea862c
@BruceForstall
BruceForstall marked this pull request as draft December 23, 2023 08:19
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 23, 2023
@ghost

ghost commented Dec 23, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Update to the 1.2.0 version of the coredistools package.

Also, implement a basic late disassembler for RyuJIT based on
coredistools (previously, this depended on closed-source msvcdis).

Various changes:

  1. Remove unused AddressMap in SPMI. Removed a bunch of cases in
    the NearDiffer that were using it.
  2. Change arm64 emitter unit tests to not require verbose
  3. Always build in the late disassembler under DEBUG. It's only
    used when JitLateDisasm is set.
  4. Implement new arm32 callback mechanism for movw/movt handling
    in the NearDiffer.
Author:BruceForstall
Assignees:BruceForstall
Labels:

area-CodeGen-coreclr

Milestone:-

This was referenced Dec 23, 2023
Closed
Open
Closed
Closed
@build-analysisbuild-analysisBot mentioned this pull request Dec 24, 2023
Closed
@BruceForstall
Fixes
39af8d8
1. Fix Risc-V build: only build LATE_DISASM for platforms where
coredistool support exists.
2. Defer load and initialization of coredistools.dll library for
LATE_DISASM until we actually need it.
3. For arm64, in late disasm, if there is a failure, try to recover
by skipping one 4-byte instruction.
@BruceForstall

BruceForstall commented Dec 29, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Dec 29, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall

BruceForstall commented Dec 30, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines

azure-pipelinesBot commented Dec 30, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall
BruceForstall marked this pull request as ready for review December 30, 2023 01:47
@BruceForstall

BruceForstall commented Dec 30, 2023

Copy link
Copy Markdown
ContributorAuthor

gcstress pipeline failure is #96364

@BruceForstallBruceForstall mentioned this pull request Dec 30, 2023
Merged
@BruceForstall

BruceForstall commented Jan 2, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@jakobbotsch @dotnet/jit-contrib PTAL

Note this includes changes to work with the 1.4.0 coredistools, but it will also work with the existing 1.1.0 coredistools.

Changing everyone to use 1.4.0 is #96291. This still has some problem with linux-x64 gcstress.

The rebuild of cordistools to 1.4.0 is dotnet/jitutils#370. This build still fails in CI with linux-x64 and linux-arm64, but those have been manually built and packaged into an uploaded 1.4.0 coredistools.

kunalspathak
kunalspathak reviewed Jan 2, 2024
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed changes in jit folder and they looks good except for few questions/suggestions.

Comment threadsrc/coreclr/jit/disasm.cpp
Comment threadsrc/coreclr/jit/disasm.cpp Outdated
Comment threadsrc/coreclr/jit/disasm.cpp Outdated
Comment threadsrc/coreclr/jit/disasm.cpp
Comment threadsrc/coreclr/jit/codegenlinear.cpp
@BruceForstall
Be smarter about initializing and uninitializing coredistools
518fc12
In particular, only load the coredistools library once, not
once per function to disassemble.
@BruceForstall
Update to 1.4.0
a4bc608
@BruceForstall

BruceForstall commented Jan 3, 2024

Copy link
Copy Markdown
ContributorAuthor

superpmi pipeline failures are due to missing osx-arm64 MCH files due to new spmi collection

@jakobbotsch

jakobbotsch commented Jan 3, 2024

Copy link
Copy Markdown
Member

/azp run runtime-coreclr superpmi-replay, runtime-coreclr superpmi-diffs

@azure-pipelines

azure-pipelinesBot commented Jan 3, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch
jakobbotsch reviewed Jan 3, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/disasm.cpp

/*****************************************************************************/

#ifdef USE_MSVCDIS

@jakobbotschjakobbotschJan 3, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we ever use MSVCDIS? Can we remove all of this?

@BruceForstallBruceForstallJan 3, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently don't, but we could resurrect the code and use it. It shouldn't be too hard to do so, and there might be benefits. The only downside is it's not open source. So I'd prefer to just leave it.

jakobbotsch
jakobbotsch reviewed Jan 3, 2024
View reviewed changes
Comment threadsrc/coreclr/tools/superpmi/superpmi/neardiffer.cpp
Comment on lines +407 to +409
#if 0
// We might want to do something similar for mov/movk/movk/movk sequences on Arm64. The following code was
// previously used, but currently is not active.

@jakobbotschjakobbotschJan 3, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the code?

@BruceForstallBruceForstallJan 3, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced yet that we don't need (or will never need) this, so I think it's worth leaving.

jakobbotsch
jakobbotsch approved these changes Jan 3, 2024
View reviewed changes

@jakobbotschjakobbotsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceForstall
BruceForstall merged commit 5455432 into dotnet:mainJan 3, 2024
@BruceForstall
BruceForstall deleted the UpdateCoredistools branch January 3, 2024 16:57
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
+1 more reviewer
@kunalspathakkunalspathakkunalspathak left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstallBruceForstall

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BruceForstall@jakobbotsch@kunalspathak