JIT: Home float parameters before integer parameters by jakobbotsch · Pull Request #96439 · dotnet/runtime

jakobbotsch · 2024-01-03T09:31:52Z

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix#96306

Parameters that are going into float registers can come from integer registers in the presence of struct promotion. We need to home those before integer parameters or the source register could have been overridden by the integer parameter homing logic. Ideally it seems like the homing logic should be unified to handle all parameters simultaneously, but this seems like a simple enough fix. I do not think we have ABIs where we have the opposite kind constraint (integer parameters coming from float registers). Fixdotnet#96306

ghost · 2024-01-03T09:32:02Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix #96306

Author:	jakobbotsch
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

jakobbotsch · 2024-01-03T12:28:57Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr outerloop, Fuzzlyn

azure-pipelines · 2024-01-03T12:29:26Z

Azure Pipelines successfully started running 4 pipeline(s).

jakobbotsch · 2024-01-04T16:05:12Z

/azp run runtime-coreclr libraries-jitstress

azure-pipelines · 2024-01-04T16:05:28Z

Azure Pipelines successfully started running 1 pipeline(s).

jakobbotsch · 2024-01-04T20:11:28Z

cc @dotnet/jit-contrib

Diffs in quite a number of contexts, as one would expect, with minor code size differences (on arm64 only, due to no longer being able to do ldp/stp optimization).

jakobbotsch · 2024-02-21T11:41:19Z

/backport to release/8.0-staging

github-actions · 2024-02-21T11:41:33Z

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7988447721

jakobbotsch · 2024-01-03T09:31:52Z

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix#96306

Parameters that are going into float registers can come from integer registers in the presence of struct promotion. We need to home those before integer parameters or the source register could have been overridden by the integer parameter homing logic. Ideally it seems like the homing logic should be unified to handle all parameters simultaneously, but this seems like a simple enough fix. I do not think we have ABIs where we have the opposite kind constraint (integer parameters coming from float registers). Fixdotnet#96306

ghost · 2024-01-03T09:32:02Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix #96306

Author:	jakobbotsch
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

jakobbotsch · 2024-01-03T12:28:57Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr outerloop, Fuzzlyn

azure-pipelines · 2024-01-03T12:29:26Z

Azure Pipelines successfully started running 4 pipeline(s).

jakobbotsch · 2024-01-04T16:05:12Z

/azp run runtime-coreclr libraries-jitstress

azure-pipelines · 2024-01-04T16:05:28Z

Azure Pipelines successfully started running 1 pipeline(s).

jakobbotsch · 2024-01-04T20:11:28Z

cc @dotnet/jit-contrib

Diffs in quite a number of contexts, as one would expect, with minor code size differences (on arm64 only, due to no longer being able to do ldp/stp optimization).

jakobbotsch · 2024-02-21T11:41:19Z

/backport to release/8.0-staging

github-actions · 2024-02-21T11:41:33Z

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7988447721

jakobbotsch · 2024-01-03T09:31:52Z

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix#96306

Parameters that are going into float registers can come from integer registers in the presence of struct promotion. We need to home those before integer parameters or the source register could have been overridden by the integer parameter homing logic. Ideally it seems like the homing logic should be unified to handle all parameters simultaneously, but this seems like a simple enough fix. I do not think we have ABIs where we have the opposite kind constraint (integer parameters coming from float registers). Fixdotnet#96306

ghost · 2024-01-03T09:32:02Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix #96306

Author:	jakobbotsch
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

jakobbotsch · 2024-01-03T12:28:57Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr outerloop, Fuzzlyn

azure-pipelines · 2024-01-03T12:29:26Z

Azure Pipelines successfully started running 4 pipeline(s).

jakobbotsch · 2024-01-04T16:05:12Z

/azp run runtime-coreclr libraries-jitstress

azure-pipelines · 2024-01-04T16:05:28Z

Azure Pipelines successfully started running 1 pipeline(s).

jakobbotsch · 2024-01-04T20:11:28Z

cc @dotnet/jit-contrib

Diffs in quite a number of contexts, as one would expect, with minor code size differences (on arm64 only, due to no longer being able to do ldp/stp optimization).

jakobbotsch · 2024-02-21T11:41:19Z

/backport to release/8.0-staging

github-actions · 2024-02-21T11:41:33Z

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7988447721

jakobbotsch · 2024-01-03T09:31:52Z

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix#96306

Parameters that are going into float registers can come from integer registers in the presence of struct promotion. We need to home those before integer parameters or the source register could have been overridden by the integer parameter homing logic. Ideally it seems like the homing logic should be unified to handle all parameters simultaneously, but this seems like a simple enough fix. I do not think we have ABIs where we have the opposite kind constraint (integer parameters coming from float registers). Fixdotnet#96306

ghost · 2024-01-03T09:32:02Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix #96306

Author:	jakobbotsch
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

jakobbotsch · 2024-01-03T12:28:57Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr outerloop, Fuzzlyn

azure-pipelines · 2024-01-03T12:29:26Z

Azure Pipelines successfully started running 4 pipeline(s).

jakobbotsch · 2024-01-04T16:05:12Z

/azp run runtime-coreclr libraries-jitstress

azure-pipelines · 2024-01-04T16:05:28Z

Azure Pipelines successfully started running 1 pipeline(s).

jakobbotsch · 2024-01-04T20:11:28Z

cc @dotnet/jit-contrib

Diffs in quite a number of contexts, as one would expect, with minor code size differences (on arm64 only, due to no longer being able to do ldp/stp optimization).

jakobbotsch · 2024-02-21T11:41:19Z

/backport to release/8.0-staging

github-actions · 2024-02-21T11:41:33Z

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7988447721

jakobbotsch · 2024-01-03T09:31:52Z

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix#96306

Parameters that are going into float registers can come from integer registers in the presence of struct promotion. We need to home those before integer parameters or the source register could have been overridden by the integer parameter homing logic. Ideally it seems like the homing logic should be unified to handle all parameters simultaneously, but this seems like a simple enough fix. I do not think we have ABIs where we have the opposite kind constraint (integer parameters coming from float registers). Fixdotnet#96306

ghost · 2024-01-03T09:32:02Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix #96306

Author:	jakobbotsch
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

jakobbotsch · 2024-01-03T12:28:57Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr outerloop, Fuzzlyn

azure-pipelines · 2024-01-03T12:29:26Z

Azure Pipelines successfully started running 4 pipeline(s).

jakobbotsch · 2024-01-04T16:05:12Z

/azp run runtime-coreclr libraries-jitstress

azure-pipelines · 2024-01-04T16:05:28Z

Azure Pipelines successfully started running 1 pipeline(s).

jakobbotsch · 2024-01-04T20:11:28Z

cc @dotnet/jit-contrib

Diffs in quite a number of contexts, as one would expect, with minor code size differences (on arm64 only, due to no longer being able to do ldp/stp optimization).

jakobbotsch · 2024-02-21T11:41:19Z

/backport to release/8.0-staging

github-actions · 2024-02-21T11:41:33Z

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7988447721

jakobbotsch · 2024-01-03T09:31:52Z

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix#96306

Parameters that are going into float registers can come from integer registers in the presence of struct promotion. We need to home those before integer parameters or the source register could have been overridden by the integer parameter homing logic. Ideally it seems like the homing logic should be unified to handle all parameters simultaneously, but this seems like a simple enough fix. I do not think we have ABIs where we have the opposite kind constraint (integer parameters coming from float registers). Fixdotnet#96306

ghost · 2024-01-03T09:32:02Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix #96306

Author:	jakobbotsch
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

jakobbotsch · 2024-01-03T12:28:57Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr outerloop, Fuzzlyn

azure-pipelines · 2024-01-03T12:29:26Z

Azure Pipelines successfully started running 4 pipeline(s).

jakobbotsch · 2024-01-04T16:05:12Z

/azp run runtime-coreclr libraries-jitstress

azure-pipelines · 2024-01-04T16:05:28Z

Azure Pipelines successfully started running 1 pipeline(s).

jakobbotsch · 2024-01-04T20:11:28Z

cc @dotnet/jit-contrib

Diffs in quite a number of contexts, as one would expect, with minor code size differences (on arm64 only, due to no longer being able to do ldp/stp optimization).

jakobbotsch · 2024-02-21T11:41:19Z

/backport to release/8.0-staging

github-actions · 2024-02-21T11:41:33Z

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7988447721

jakobbotsch · 2024-01-03T09:31:52Z

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix#96306

Parameters that are going into float registers can come from integer registers in the presence of struct promotion. We need to home those before integer parameters or the source register could have been overridden by the integer parameter homing logic. Ideally it seems like the homing logic should be unified to handle all parameters simultaneously, but this seems like a simple enough fix. I do not think we have ABIs where we have the opposite kind constraint (integer parameters coming from float registers). Fixdotnet#96306

ghost · 2024-01-03T09:32:02Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix #96306

Author:	jakobbotsch
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

jakobbotsch · 2024-01-03T12:28:57Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr outerloop, Fuzzlyn

azure-pipelines · 2024-01-03T12:29:26Z

Azure Pipelines successfully started running 4 pipeline(s).

jakobbotsch · 2024-01-04T16:05:12Z

/azp run runtime-coreclr libraries-jitstress

azure-pipelines · 2024-01-04T16:05:28Z

Azure Pipelines successfully started running 1 pipeline(s).

jakobbotsch · 2024-01-04T20:11:28Z

cc @dotnet/jit-contrib

Diffs in quite a number of contexts, as one would expect, with minor code size differences (on arm64 only, due to no longer being able to do ldp/stp optimization).

jakobbotsch · 2024-02-21T11:41:19Z

/backport to release/8.0-staging

github-actions · 2024-02-21T11:41:33Z

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7988447721

jakobbotsch · 2024-01-03T09:31:52Z

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix#96306

Parameters that are going into float registers can come from integer registers in the presence of struct promotion. We need to home those before integer parameters or the source register could have been overridden by the integer parameter homing logic. Ideally it seems like the homing logic should be unified to handle all parameters simultaneously, but this seems like a simple enough fix. I do not think we have ABIs where we have the opposite kind constraint (integer parameters coming from float registers). Fixdotnet#96306

ghost · 2024-01-03T09:32:02Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix #96306

Author:	jakobbotsch
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

jakobbotsch · 2024-01-03T12:28:57Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr outerloop, Fuzzlyn

azure-pipelines · 2024-01-03T12:29:26Z

Azure Pipelines successfully started running 4 pipeline(s).

jakobbotsch · 2024-01-04T16:05:12Z

/azp run runtime-coreclr libraries-jitstress

azure-pipelines · 2024-01-04T16:05:28Z

Azure Pipelines successfully started running 1 pipeline(s).

jakobbotsch · 2024-01-04T20:11:28Z

cc @dotnet/jit-contrib

Diffs in quite a number of contexts, as one would expect, with minor code size differences (on arm64 only, due to no longer being able to do ldp/stp optimization).

jakobbotsch · 2024-02-21T11:41:19Z

/backport to release/8.0-staging

github-actions · 2024-02-21T11:41:33Z

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7988447721

jakobbotsch added 2 commits January 3, 2024 10:17

Add test
833578d

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 3, 2024

ghost assigned jakobbotsch Jan 3, 2024

build-analysisBot mentioned this pull request Jan 3, 2024
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
2 tasks

jakobbotsch marked this pull request as ready for review January 4, 2024 20:10

BruceForstall approved these changes Jan 4, 2024
View reviewed changes

jakobbotsch merged commit 928ff30 into dotnet:mainJan 5, 2024

jakobbotsch deleted the fix-96306 branch January 5, 2024 14:23

jakobbotsch mentioned this pull request Jan 5, 2024
Corrupted function parameter value in Release configuration (overwritten by the first argument value). #96306
Closed

github-actionsBot locked and limited conversation to collaborators Feb 5, 2024

jakobbotsch mentioned this pull request Feb 21, 2024
JIT generates incorrect optimised code in .NET 8 #98748
Closed

github-actionsBot unlocked this conversation Feb 21, 2024

github-actionsBot mentioned this pull request Feb 21, 2024
[release/8.0-staging] JIT: Home float parameters before integer parameters #98749
Merged
4 tasks

github-actionsBot locked as resolved and limited conversation to collaborators Feb 21, 2024