Skip to content

JIT: Pass field's owner to getFieldType - #96794

Closed
EgorBo wants to merge 10 commits into
dotnet:mainfrom
EgorBo:exact-class-field
Closed

JIT: Pass field's owner to getFieldType#96794
EgorBo wants to merge 10 commits into
dotnet:mainfrom
EgorBo:exact-class-field

Conversation

@EgorBo

Copy link
Copy Markdown
Member

Closes#96787

Also, removes the variance check from:

privatereadonlyList<string>_list=new(){"a","b","c"};[Benchmark]publicSpan<string>AsSpan()=>CollectionsMarshal.AsSpan(_list);

Codegen diff (Main vs PR): https://www.diffchecker.com/dZnlDi91/

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 10, 2024
@ghostghost assigned EgorBoJan 10, 2024
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #96787

Also, removes the variance check from:

privatereadonlyList<string>_list=new(){"a","b","c"};[Benchmark]publicSpan<string>AsSpan()=>CollectionsMarshal.AsSpan(_list);

Codegen diff (Main vs PR): https://www.diffchecker.com/dZnlDi91/

Author:EgorBo
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

Comment threadsrc/coreclr/jit/gentree.cpp
@EgorBo

Copy link
Copy Markdown
MemberAuthor

@MihuBot

@EgorBo

Copy link
Copy Markdown
MemberAuthor

@MihuBot

@jkotas

Copy link
Copy Markdown
Member

Existing related codegen bug: #96876

@EgorBo

Copy link
Copy Markdown
MemberAuthor

@MihuBot

@EgorBo

Copy link
Copy Markdown
MemberAuthor

@MihuBot

@ghost

Copy link
Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 16, 2024
This pull request was closed.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JIT doesn't see real type of field in a shared generic type with exact context

3 participants

@EgorBo@jkotas@SingleAccretion