Implement remaining unimplemented APIs for Builder types by buyaa-n · Pull Request #96805 · dotnet/runtime

buyaa-n · 2024-01-10T19:36:03Z

Implemented DefineInitializedDataCore(...), DefineUninitializedDataCore(...), DefinePInvokeMethodCore(...) for TypeBuilerImpl.
Implemented CreateGlobalFunctionsCore(), DefineGlobalMethodCore(...), DefineInitializedDataCore(...), DefineUninitializedDataCore(...), DefinePInvokeMethodCore(...), GetMethodImpl(...), GetMethods() for ModuleBuilerImpl.
requiredCustomModifiers, optionalCustomModifiers for fields, method return type and parameters, which mostly involves Signature changes
Had to refactor type/method/field token generation logic again because of global method/fields
Fix bugs found and reported

Fixes#96436 and #97116
Contributes to #92975

…s, fix bugs found

…ctor field/method/type token logic because of global members

ghost · 2024-01-10T19:36:16Z

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

Issue Details

Implemented DefineInitializedDataCore(...), DefineUninitializedDataCore(...), DefinePInvokeMethodCore(...) for TypeBuilerImpl.
Implemented CreateGlobalFunctionsCore(), DefineGlobalMethodCore(...), DefineInitializedDataCore(...), DefineUninitializedDataCore(...), DefinePInvokeMethodCore(...), GetMethodImpl(...), GetMethods() for ModuleBuilerImpl.
requiredCustomModifiers, optionalCustomModifiers for fields, method return type and parameters, which mostly involves Signature changes
Had to refactor type/method/field token generation logic again because of global method/fields
Fix bugs found and reported

Fixes #96436
Contributes to #92975

Author:	buyaa-n
Assignees:	-
Labels:	`area-System.Reflection.Emit`
Milestone:	-

…t/TypeBuilderImpl.cs Co-authored-by: Aaron Robinson <arobins@microsoft.com>

steveharter · 2024-01-12T15:35:03Z

+ [Fact]
 public void EmitCalliBlittable()
 {
- RemoteExecutor.Invoke(() =>


Why was the use of remote executor changed?

Now using collectable ALC instead of default, the discussion is here #96805 (comment)
runtime/src/libraries/System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblySaveTools.cs
Lines 12 to 22 in e6d9333
classTestAssemblyLoadContext:AssemblyLoadContext
{
publicTestAssemblyLoadContext():base(isCollectible:true)
{
}
protectedoverrideAssembly?Load(AssemblyNamename)
{
returnnull;
}
}

steveharter · 2024-01-12T15:36:37Z


 Module m = AssemblySaveTools.LoadAssemblyFromPath(file.Path).Modules.First();
- Type[] type1Params = m.GetTypes()[2].GetGenericArguments();
+ Type[] type1Params = m.GetTypes()[0].GetGenericArguments();


Why were the items reversed before?

Before the type tokens created on TypeBuilder.CreateType() and before saving the types are ordered with the token order, the types here created in inverse order, you can see that above on row 512-514.
Now with a global type that has global methods/fields this ordering/token assignment not working anymore, now all types and its members tokens created before save (therefore in defined order no matter when TypeBuilder.CreateType() called)

Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>

…ken methods called

buyaa-n · 2024-01-19T21:32:23Z

All failures are unrelated and known, merging

* Implement 'DefinPInvokeMethod', save required/optional CustomModifiers, fix bugs found * Add global method, get method impl and tests * Implement DefineInitializedData(...) and UninitializedData(...), refactor field/method/type token logic because of global members * Update src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs Co-authored-by: Aaron Robinson <arobins@microsoft.com> * Load assemblies in unloadable context Co-authored-by: Steve Harter <steveharter@users.noreply.github.com> * Add test for DefineUninitializedData(...) * Set parameter count to 0 for RtFieldInfo * Throw when member token is not populated when Module.Get***MetadataToken methods called * Retrieving standalone signature not supported on mono * Create byte array with the size directly instead of null check --------- Co-authored-by: Aaron Robinson <arobins@microsoft.com> Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>

buyaa-n added 3 commits January 7, 2024 22:06

Implement 'DefinPInvokeMethod', save required/optional CustomModifier…
5c467a8
…s, fix bugs found

Add global method, get method impl and tests
f7c67bc

Implement DefineInitializedData(...) and UninitializedData(...), refa…
c09a884
…ctor field/method/type token logic because of global members

ghost added the area-System.Reflection.Emit label Jan 10, 2024

ghost assigned buyaa-n Jan 10, 2024

buyaa-n requested review from AaronRobinsonMSFT, jkotas and steveharter January 10, 2024 20:37

Merge conflicts
f0bcf1e

AaronRobinsonMSFT reviewed Jan 10, 2024
View reviewed changes

build-analysisBot mentioned this pull request Jan 11, 2024
pip fails to build wheels for cffi (gcc not found) in ubuntu.1804.armarch.open using image alpine-3.15-helix-arm32v7 dotnet/dnceng#1423
Closed
3 tasks

Apply feedbacks, fix RVA alignment
1be0fb3

buyaa-n force-pushed the more_impl branch from 02f269d to 1be0fb3Compare January 11, 2024 19:18

Update src/libraries/System.Reflection.Emit/src/System/Reflection/Emi…
9fbe2cf
…t/TypeBuilderImpl.cs Co-authored-by: Aaron Robinson <arobins@microsoft.com>

buyaa-n added 2 commits January 11, 2024 15:32

Load assemblies in unloadable context
408d7f8

Merge branch 'more_impl' of github.com:buyaa-n/runtime into more_impl
e6d9333

buyaa-n marked this pull request as ready for review January 11, 2024 23:38

buyaa-n requested a review from AaronRobinsonMSFT January 11, 2024 23:39

buyaa-n changed the title ~~Implement remaining unimplemented APIs for ***Builder types~~Implement remaining unimplemented APIs for Builder typesJan 11, 2024

build-analysisBot mentioned this pull request Jan 12, 2024
CollectionsMarshal.AsSpan assertion failure in System.Text.Json tests #96876
Closed

steveharter reviewed Jan 12, 2024
View reviewed changes

buyaa-nand others added 3 commits January 12, 2024 10:00

Add period to the messages
948447a
Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>

Apply feedback
7164991

Merge branch 'more_impl' of github.com:buyaa-n/runtime into more_impl
4cfa4b9

buyaa-n commented Jan 12, 2024
View reviewed changes

Comment thread...es/System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblySaveModuleBuilderTests.cs Outdated

build-analysisBot mentioned this pull request Jan 15, 2024
[browser][MT] GC deadlock #96190
Closed

buyaa-n added 3 commits January 15, 2024 21:07

Add test for DefineUninitializedData(...)
59673e0

Set parameter count to 0 for RtFieldInfo
bb1f5a7

Throw when member token is not populated when Module.Get***MetadataTo…
2627692
…ken methods called

build-analysisBot mentioned this pull request Jan 18, 2024
BasicEventSourceTests.TestsManifestGeneration test failing in CI #97103
Closed

buyaa-n requested a review from steveharter January 18, 2024 05:04

Retreiving standalone signature not supported on mono
f36b7cd

This was referenced Jan 18, 2024
BlobBuilder.Align(int) seems not working on mono #97172
Open
Tracking issue for remaining AssemblyBuilder.Save work in .NET 9 #92975
Closed

steveharter approved these changes Jan 19, 2024
View reviewed changes

Comment thread...es/System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblySaveModuleBuilderTests.cs Outdated

Create byte array with the size directly instead of null check
9889bc4

buyaa-n merged commit 62d33ee into dotnet:mainJan 19, 2024

buyaa-n deleted the more_impl branch January 19, 2024 21:33

github-actionsBot locked and limited conversation to collaborators Feb 19, 2024

	classTestAssemblyLoadContext:AssemblyLoadContext
	{
	publicTestAssemblyLoadContext():base(isCollectible:true)
	{
	}

	protectedoverrideAssembly?Load(AssemblyNamename)
	{
	returnnull;
	}
	}

Uh oh!

Conversation

buyaa-n commented Jan 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jan 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steveharterJan 12, 2024

Choose a reason for hiding this comment

Uh oh!

buyaa-nJan 12, 2024

Choose a reason for hiding this comment

Uh oh!

steveharterJan 12, 2024

Choose a reason for hiding this comment

Uh oh!

buyaa-nJan 12, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

buyaa-n commented Jan 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

buyaa-n commented Jan 10, 2024•
edited
Loading