[browser] remove legacy js interop by pavelsavara · Pull Request #96841 · dotnet/runtime

pavelsavara · 2024-01-11T14:45:43Z

Public

MONO and BINDING JS APIs
disableDotnet6Compatibility JS flag
doc for HEAPXXX on emscripten module
dotnet-legacy.d.ts
MSBuild property WasmEnableLegacyJsInterop and related trimming support for it
semi-public mono_wasm_invoke_js_blazor() and WebAssembly.JSInterop.InternalCalls.InvokeJS() ICAL

Internal

any internal C# classes like Runtime and JSObject extensions DataView ...
perf tests related to legacy interop
unit tests System.Runtime.InteropServices.JavaScript.Legacy.Tests
- moved timers.mjs, TimerTests
- moved HttpRequestMessageTest
- all modern scenarios are covered in System.Runtime.InteropServices.JavaScript.Tests
call_test_method used in some tests

TODO

debugger tests are still using bind_static_method[browser][debugger] fake bind_static_method #96899
upgrade Blazor for WBT, to contain [blazor][wasm] Remove legacy interop aspnetcore#52732

Fixes#90044

ghost · 2024-01-11T14:45:55Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Public

MONO and BINDING JS APIs
disableDotnet6Compatibility JS flag
doc for HEAPXXX on emscripten module
dotnet-legacy.d.ts
MSBuild property WasmEnableLegacyJsInterop and related trimming support for it
semi-public mono_wasm_invoke_js_blazor() and WebAssembly.JSInterop.InternalCalls.InvokeJS() ICAL

Internal

any internal C# classes like Runtime and JSObject extensions DataView ...
perf tests related to legacy interop
unit tests System.Runtime.InteropServices.JavaScript.Legacy.Tests
- moved timers.mjs, TimerTests
- moved HttpRequestMessageTest
- all modern scenarios are covered in System.Runtime.InteropServices.JavaScript.Tests
call_test_method used in some tests

TODO

fix debugger tests which are still using bind_static_method in debugger-driver.html

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`, `os-browser`
Milestone:	9.0.0

pavelsavara · 2024-01-14T19:17:24Z

/azp run runtime-wasm

azure-pipelines · 2024-01-14T19:17:42Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2024-01-14T21:55:54Z

@radical
In WBT I need Blazor version which contains dotnet/aspnetcore#52732, what do I need to do ?

radical · 2024-01-15T10:45:35Z

You need an installer which references that version or newer of aspnetcore. We update the installer once a day via the darc flow. Just watch for that.

pavelsavara · 2024-01-15T12:59:33Z

You need an installer which references that version or newer of aspnetcore. We update the installer once a day via the darc flow. Just watch for that.

The flow is aspnetcore -> sdk -> installer -> runtime, right ?

pavelsavara · 2024-01-18T12:15:37Z

maybe this #96896

pavelsavara · 2024-01-19T12:18:50Z

/azp run runtime-wasm

azure-pipelines · 2024-01-19T12:18:59Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf

Looks good to me 👍

pavelsavara · 2024-01-19T12:46:30Z

/azp run runtime-wasm

azure-pipelines · 2024-01-19T12:46:44Z

Azure Pipelines successfully started running 1 pipeline(s).

ilonatommy

I wonder, we left the legacy API in src/mono/wasm/Wasm.Build.Tests/data/test-main-7.0.js but the "dotnet-latest" we use for running wbt will not contain it anymore. @radical, do we ever run wbt with older dotnet?

pavelsavara · 2024-01-19T15:19:48Z

I filled #97217 for

Assertion: should not be reached at D:\a\_work\1\s\src\mono\mono\mini\mini-llvm.c:1394

radical · 2024-01-19T16:03:18Z

I wonder, we left the legacy API in src/mono/wasm/Wasm.Build.Tests/data/test-main-7.0.js but the "dotnet-latest" we use for running wbt will not contain it anymore. @radical, do we ever run wbt with older dotnet?

No. We can drop any 7.0 stuff.

radekdoulik · 2024-01-22T11:33:24Z

it looks like this caused large blazor startup regression

the range is
aca77bd...5a6135e

pavelsavara · 2024-01-22T11:55:06Z

The slowdown is strange, there is no new code in the startup sequence, just code removed.
Maybe something what was executed early is now executed later ?

There is also 80 KB reduction in uncompressed size, right ?

radekdoulik · 2024-01-22T12:16:50Z

It might be something broken with the UI startup, the time is very close to 20 seconds. So I wonder if it is related to some timeout being set to 20s.

The reduced size is great and is visible in the cold startup.

pavelsavara · 2024-01-22T13:16:08Z

I hope this will fix it #97305

Do we have same problem in the other benchmark suite too ?

radekdoulik · 2024-01-22T13:27:21Z

It is indeed a timeout

Benchmark started<br/> [main.js:98:21](http://localhost:8844/main.js)
waitFor blazor: Rendered Index.razor timed out [main.js:192:25](http://localhost:8844/main.js)
MONO_WASM: Saved interp_pgo table to cache [logging.ts:22:12](file:///Users/rodo/git/runtime/src/mono/browser/runtime/logging.ts)
waitFor blazor: Rendered Index.razor timed out [main.js:192:25](http://localhost:8844/main.js)
AppStart, Blazor First UI count: 1, per call: 20307ms, total: 20.307s<br/>

pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jan 11, 2024

pavelsavara added this to the 9.0.0 milestone Jan 11, 2024

pavelsavara requested a review from maraf January 11, 2024 14:45

pavelsavara self-assigned this Jan 11, 2024

build-analysisBot mentioned this pull request Jan 11, 2024
[wasm] Playwright failing #94240
Closed

This comment was marked as outdated.
Sign in to view

pavelsavara mentioned this pull request Jan 12, 2024
[browser][debugger] fake bind_static_method #96899
Merged

This was referenced Jan 14, 2024
[wasm][debugger] Debugger tests disabled #89409
Open
The active test run was aborted. Reason: Test host process crashed dotnet/dnceng#451
Closed

rebase
9bc6437

pavelsavara force-pushed the browser_remove_legacy_js_interop branch from fd9796d to 9bc6437Compare January 19, 2024 12:09

pavelsavara marked this pull request as ready for review January 19, 2024 12:18

pavelsavara requested a review from radical as a code owner January 19, 2024 12:18

pavelsavara requested review from kg, lewing and marek-safar as code owners January 19, 2024 12:18

maraf approved these changes Jan 19, 2024
View reviewed changes

fix
cf3dfe5

ilonatommy approved these changes Jan 19, 2024
View reviewed changes

pavelsavara mentioned this pull request Jan 19, 2024
[browser][AOT] convert the LLVM value V to DTYPE #97217
Closed

pavelsavara merged commit 8c3ee30 into dotnet:mainJan 19, 2024

pavelsavara deleted the browser_remove_legacy_js_interop branch January 19, 2024 15:23

build-analysisBot mentioned this pull request Jan 19, 2024
[MT][browser] TaskIDFromExternalContextTest fails, Task has a negative ID #91583
Closed

pavelsavara mentioned this pull request Jan 22, 2024
[browser] bump benchmarks to Net9 #97305
Merged

tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
[browser] remove legacy js interop (dotnet#96841)
f490040

radekdoulik mentioned this pull request Jan 24, 2024
[Perf] Linux/x64: 19 Regressions on 1/19/2024 7:45:16 PM dotnet/perf-autofiling-issues#27753
Open

github-actionsBot locked and limited conversation to collaborators Feb 22, 2024

Uh oh!

Conversation

pavelsavara commented Jan 11, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Public

Internal

TODO

Uh oh!

ghost commented Jan 11, 2024

Public

Internal

Uh oh!

This comment was marked as outdated.

pavelsavara commented Jan 14, 2024

Uh oh!

azure-pipelinesBot commented Jan 14, 2024

Uh oh!

pavelsavara commented Jan 14, 2024

Uh oh!

radical commented Jan 15, 2024

Uh oh!

pavelsavara commented Jan 15, 2024

Uh oh!

pavelsavara commented Jan 18, 2024

Uh oh!

pavelsavara commented Jan 19, 2024

Uh oh!

azure-pipelinesBot commented Jan 19, 2024

Uh oh!

maraf left a comment

Choose a reason for hiding this comment

Uh oh!

pavelsavara commented Jan 19, 2024

Uh oh!

azure-pipelinesBot commented Jan 19, 2024

Uh oh!

ilonatommy left a comment

Choose a reason for hiding this comment

Uh oh!

pavelsavara commented Jan 19, 2024

Uh oh!

radical commented Jan 19, 2024

Uh oh!

radekdoulik commented Jan 22, 2024

Uh oh!

pavelsavara commented Jan 22, 2024

Uh oh!

radekdoulik commented Jan 22, 2024

Uh oh!

pavelsavara commented Jan 22, 2024

Uh oh!

radekdoulik commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pavelsavara commented Jan 11, 2024•
edited
Loading