Skip to content

Preserve debug info for merged returns - #96870

Merged
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:PreservedMergedReturnDebugInfo
Jan 12, 2024
Merged

Preserve debug info for merged returns#96870
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:PreservedMergedReturnDebugInfo

Conversation

@BruceForstall

Copy link
Copy Markdown
Contributor

If converting a void GT_RETURN to a branch to a merged return block, keep it as a GT_NOP if it has debug info that should be preserved.

If converting a void GT_RETURN to a branch to a merged return
block, keep it as a GT_NOP if it has debug info that should
be preserved.
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 11, 2024
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

If converting a void GT_RETURN to a branch to a merged return block, keep it as a GT_NOP if it has debug info that should be preserved.

Author:BruceForstall
Assignees:BruceForstall
Labels:

area-CodeGen-coreclr

Milestone:-

@mikelle-rogersmikelle-rogers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes 89292

Comment threadsrc/coreclr/jit/morph.cpp
@mikelle-rogersmikelle-rogers linked an issue Jan 11, 2024 that may be closed by this pull request
@BruceForstall

Copy link
Copy Markdown
ContributorAuthor

@jakobbotsch PTAL
cc @dotnet/jit-contrib

@BruceForstall
BruceForstall merged commit 3f84acb into dotnet:mainJan 12, 2024
@BruceForstall
BruceForstall deleted the PreservedMergedReturnDebugInfo branch January 12, 2024 18:15
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
If converting a void GT_RETURN to a branch to a merged return
block, keep it as a GT_NOP if it has debug info that should
be preserved.
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to break on callback from unmanaged thread

3 participants

@BruceForstall@jakobbotsch@mikelle-rogers