Uh oh!
There was an error while loading. Please reload this page.
Make startup hooks kind of work with native AOT - #96894
Conversation
Fixesdotnet#96052. Since we compile startup hooks anyway, just add a call to it. It will be deadcoded by default. Can be enabled and then it will at least work for hooks that were part of the app. It will throw PNSE for random file paths.
ghost
commented
Jan 12, 2024
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsFixes #96052. Since we compile startup hooks anyway, just add a call to it. It will be deadcoded by default. Can be enabled and then it will at least work for hooks that were part of the app. It will throw PNSE for random file paths. Cc @dotnet/ilc-contrib
|
ivanpovazan
commented
Jan 12, 2024
cc: @lambdageek |
agocke
commented
Jan 12, 2024
Should we add a smoke test for this? |
MichalStrehovsky
commented
Jan 16, 2024
Filed #97020 on the System.IO test. And the System.Text.Json test is not actionable because no dump: |
This seems to be happening quite frequently in the CI. I have opened #97049 to have it tracked. |
Fixesdotnet#96052. Since we compile startup hooks anyway, just add a call to it. It will be deadcoded by default. Can be enabled and then it will at least work for hooks that were part of the app. It will throw PNSE for random file paths.
Fixes#96052.
Since we compile startup hooks anyway, just add a call to it. It will be deadcoded by default. Can be enabled and then it will at least work for hooks that were part of the app. It will throw PNSE for random file paths.
Cc @dotnet/ilc-contrib