Uh oh!
There was an error while loading. Please reload this page.
Adding vectorized implementations of Log to Vector64/128/256/512 - #96913
Merged
Conversation
ghost
commented
Jan 12, 2024
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsThis makes progress towards #93513
|
tannergooding
commented
Jan 12, 2024
MemberAuthor
CC. @stephentoub, @michaelgsharp for review. Will likely put up separate PRs for a few others over the weekend, like May also finish up several of the trig ones ( |
This was referenced Jan 13, 2024
Closed
stephentoub
commented
Jan 16, 2024
Member
I assume structurally this is a carbon-copy of #93513? |
tannergooding
commented
Jan 16, 2024
MemberAuthor
Yes, same general setup/considerations. Just for the Log method now instead of Log2 |
This was referenced Jan 16, 2024
stephentoub
approved these changes
Jan 17, 2024
tannergooding
commented
Jan 17, 2024
MemberAuthor
Test failures are known and tracked. |
tmds pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
…net#96913) * Adding vectorized implementations of Log to Vector64/128/256/512 * Accelerate TensorPrimitives.Log for double * Ensure the ref assembly is updated to include the new Log method * Fix the variance for one of the Log2 tests to account for the scalar fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes progress towards #93513