Skip to content

Add TaskCompletionSource.SetFromTask - #97077

Merged
stephentoub merged 1 commit into
dotnet:mainfrom
stephentoub:setfromtask
Jan 20, 2024
Merged

Add TaskCompletionSource.SetFromTask#97077
stephentoub merged 1 commit into
dotnet:mainfrom
stephentoub:setfromtask

Conversation

@stephentoub

@stephentoubstephentoub commented Jan 17, 2024

Copy link
Copy Markdown
Member

Closes#47998

@ghost

ghost commented Jan 17, 2024

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-threading-tasks
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #47998

Author:stephentoub
Assignees:-
Labels:

area-System.Threading.Tasks

Milestone:-

@ghost

ghost commented Jan 17, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub
stephentoub commented Jan 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Net.Requests/src/System/Net/TaskExtensions.cs Outdated
This was referenced Jan 17, 2024
Closed
Closed
@davidfowl

davidfowl commented Jan 17, 2024

Copy link
Copy Markdown
Member

Nice!

pavelsavara
pavelsavara approved these changes Jan 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/System.Runtime.sln Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Threading/Tasks/TaskCompletionSource.cs Outdated
This was referenced Jan 19, 2024
Closed
Closed
@build-analysisbuild-analysisBot mentioned this pull request Jan 20, 2024
Closed
@stephentoub
stephentoub merged commit ff93f2d into dotnet:mainJan 20, 2024
@stephentoub
stephentoub deleted the setfromtask branch January 20, 2024 11:30
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@stephentoub@tmds
Add TaskCompletionSource.SetFromTask (dotnet#97077)
5d8969a
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 20, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewing

Assignees

@stephentoubstephentoub

Labels

area-System.Threading.Tasksnew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider adding TaskCompletionSource.SetFromTask(Task)

3 participants

@stephentoub@davidfowl@pavelsavara