Skip to content

X86 unix fixes - #97089

Closed
t-mustafin wants to merge 5 commits into
dotnet:mainfrom
t-mustafin:x86_unix_fixes
Closed

X86 unix fixes#97089
t-mustafin wants to merge 5 commits into
dotnet:mainfrom
t-mustafin:x86_unix_fixes

Conversation

@t-mustafin

Copy link
Copy Markdown
Contributor

Make helloworld.dll work on x86 Linux.

cc @gbalykov@BruceForstall

BlockInit algorithm for x86 and x64 uses SIMD instructions so it shoud be disabled if FEATURE_SIMD instructions turned off.
FEATURE_SIMD for x86/Unix was turned off by dotnet/coreclr#8335
as temporary solve for dotnet#7061
which was fixed by dotnet/coreclr#8382.
So FEATURE_SIMD could be enabled for x86/Unix.
@ghostghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jan 17, 2024
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Make helloworld.dll work on x86 Linux.

cc @gbalykov@BruceForstall

Author:t-mustafin
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@t-mustafin
t-mustafin marked this pull request as draft January 17, 2024 12:56
@t-mustafin

Copy link
Copy Markdown
ContributorAuthor

I need to fix a few more problems to collect coreclr tests, make it draft for now.

Comment threadsrc/coreclr/vm/i386/stublinkerx86.cpp Outdated
@ghost

Copy link
Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 20, 2024
This pull request was closed.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@t-mustafin@BruceForstall