Skip to content

Use insGetPredicateType for SVE encodings - #97142

Merged
kunalspathak merged 4 commits into
dotnet:mainfrom
a74nh:insGetPredicateType_github
Jan 19, 2024
Merged

Use insGetPredicateType for SVE encodings#97142
kunalspathak merged 4 commits into
dotnet:mainfrom
a74nh:insGetPredicateType_github

Conversation

@a74nh

@a74nha74nh commented Jan 18, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

As suggested in #96992

Replaces uses of PredicateType in emitDispInsHelp() with uses of insGetPredicateType()

Only group IF_SVE_AH_3A remains (due to the encoding not being fixed).

No new diffs in the coreclr vs capstone output

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jan 18, 2024
@a74nh

a74nh commented Jan 18, 2024

Copy link
Copy Markdown
ContributorAuthor

@kunalspathak

@ghost

ghost commented Jan 18, 2024

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

As suggested in #96992

Replaces uses of PredicateType in emitDispInsHelp() with uses of insGetPredicateType()

Only group IF_SVE_AH_3A remains (due to the encoding not being fixed).

Author:a74nh
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@a74nha74nh mentioned this pull request Jan 18, 2024
Merged
This was referenced Jan 18, 2024
Open
Closed
@kunalspathakkunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Jan 18, 2024
@kunalspathak

kunalspathak commented Jan 18, 2024

Copy link
Copy Markdown
Contributor

@dotnet/arm64-contrib

kunalspathak
kunalspathak reviewed Jan 18, 2024
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some nit comments to get your thoughts on.

Comment threadsrc/coreclr/jit/emitarm64.cpp
Comment threadsrc/coreclr/jit/emitarm64.cpp Outdated
Comment threadsrc/coreclr/jit/emitarm64.cpp Outdated
kunalspathak
kunalspathak approved these changes Jan 19, 2024
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak
kunalspathak merged commit aca77bd into dotnet:mainJan 19, 2024
@a74nh
a74nh deleted the insGetPredicateType_github branch January 19, 2024 16:25
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@a74nh@tmds
Use insGetPredicateType for SVE encodings (dotnet#97142)
8c8a940
* Use insGetPredicateType for SVE encodings
* Add predicate as counter printing
* Pass type to emitPredicateRegName
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIarm-sveWork related to arm64 SVE/SVE2 supportcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a74nh@kunalspathak