Skip to content

[RISC-V] Enable R2RDump - #97156

Merged
jkotas merged 2 commits into
dotnet:mainfrom
tomeksowi:r2rdump
Jan 27, 2024
Merged

[RISC-V] Enable R2RDump#97156
jkotas merged 2 commits into
dotnet:mainfrom
tomeksowi:r2rdump

Conversation

@tomeksowi

@tomeksowitomeksowi commented Jan 18, 2024

Copy link
Copy Markdown
Member

@ghostghost added area-R2RDump-coreclr Ready-to-run image dump tool community-contribution Indicates that the PR has been added by a community member labels Jan 18, 2024
sirntar
sirntar approved these changes Jan 18, 2024
View reviewed changes

@sirntarsirntar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@build-analysisbuild-analysisBot mentioned this pull request Jan 18, 2024
Closed
wscho77
wscho77 approved these changes Jan 18, 2024
View reviewed changes

@wscho77wscho77 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clamp03clamp03 added the arch-riscv Related to the RISC-V architecture label Jan 19, 2024
@tomeksowi

tomeksowi commented Jan 23, 2024

Copy link
Copy Markdown
MemberAuthor

@trylek could you review this please? (the CI failures look unrelated to this PR)

@clamp03
clamp03 requested review from jkotas and trylekJanuary 27, 2024 02:38
jkotas
jkotas approved these changes Jan 27, 2024
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas
jkotas merged commit 08d9819 into dotnet:mainJan 27, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 26, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@trylektrylekAwaiting requested review from trylek
+6 more reviewers
@wscho77wscho77wscho77 approved these changes
@clamp03clamp03clamp03 approved these changes
@gbalykovgbalykovgbalykov approved these changes
@ashaurtaevashaurtaevashaurtaev approved these changes
@sirntarsirntarsirntar approved these changes
@BajtazarBajtazarBajtazar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tomeksowitomeksowi

Labels

arch-riscvRelated to the RISC-V architecturearea-R2RDump-coreclrReady-to-run image dump toolcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tomeksowi@wscho77@clamp03@jkotas@gbalykov@ashaurtaev@sirntar@Bajtazar