Skip to content

Intrinsify typeof(T).GetGenericTypeDefinition - #97159

Closed
Sergio0694 wants to merge 11 commits into
dotnet:mainfrom
Sergio0694:user/sergiopedri/get-generic-type-definition-intrinsic
Closed

Intrinsify typeof(T).GetGenericTypeDefinition#97159
Sergio0694 wants to merge 11 commits into
dotnet:mainfrom
Sergio0694:user/sergiopedri/get-generic-type-definition-intrinsic

Conversation

@Sergio0694

@Sergio0694Sergio0694 commented Jan 18, 2024

Copy link
Copy Markdown
Contributor

Contributes to #96898

Still work in progress, missing the managed implementation (and likely more stuff)

@ghostghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Jan 18, 2024
@ghost

ghost commented Jan 18, 2024

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #96898

Still work in progress, missing the managed implementation (and likely more stuff)

Author:Sergio0694
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@Sergio0694
Sergio0694force-pushed the user/sergiopedri/get-generic-type-definition-intrinsic branch from 1cdfe10 to 93ae46fCompareJanuary 18, 2024 16:50
@Sergio0694Sergio0694 mentioned this pull request Jan 18, 2024
Closed
@build-analysisbuild-analysisBot mentioned this pull request Jan 18, 2024
Closed
jkotas
jkotas reviewed Jan 18, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp Outdated
jkotas
jkotas reviewed Jan 18, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp Outdated
jkotas
jkotas reviewed Jan 18, 2024
View reviewed changes
Comment threadsrc/coreclr/inc/corinfo.h Outdated
@Sergio0694
Sergio0694force-pushed the user/sergiopedri/get-generic-type-definition-intrinsic branch from 1da492b to 839f4c3CompareJanuary 18, 2024 18:03
jkotas
jkotas reviewed Jan 18, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp Outdated
jkotas
jkotas reviewed Jan 18, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp Outdated
jkotas
jkotas reviewed Jan 18, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp
@build-analysisbuild-analysisBot mentioned this pull request Jan 18, 2024
Closed
@jkotas

jkotas commented Jan 22, 2024

Copy link
Copy Markdown
Member

#97272 needs to be fixed first before more System.Type methods are converted into intrinsics.

@ghostghost closed this Feb 21, 2024
@ghost

ghost commented Feb 21, 2024

Copy link
Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@EgorBoEgorBo reopened this Mar 11, 2024
@Sergio0694
Sergio0694force-pushed the user/sergiopedri/get-generic-type-definition-intrinsic branch from 9b608b4 to 7c1b5deCompareMarch 11, 2024 22:12
@build-analysisbuild-analysisBot mentioned this pull request Mar 12, 2024
Closed
3 tasks
@Sergio0694
Sergio0694force-pushed the user/sergiopedri/get-generic-type-definition-intrinsic branch from 7c1b5de to 7584128CompareMarch 12, 2024 17:52
@Sergio0694
Sergio0694 marked this pull request as ready for review March 12, 2024 18:54
@Sergio0694

Sergio0694 commented Mar 12, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Making this a draft so I can reuse isGenericType from #99555 after that one is merged.

@Sergio0694
Sergio0694 marked this pull request as draft March 12, 2024 21:07
@dotnet-policy-service

dotnet-policy-serviceBot commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas left review comments
@EgorBoEgorBoAwaiting requested review from EgorBo
@jakobbotschjakobbotschAwaiting requested review from jakobbotsch
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sergio0694@jkotas@jakobbotsch@EgorBo