Skip to content

NativeAOT: Ignore preferSize and always expand TLS - #97187

Merged
jkotas merged 2 commits into
dotnet:mainfrom
kunalspathak:EmitInlineTLSAccess
Jan 19, 2024
Merged

NativeAOT: Ignore preferSize and always expand TLS#97187
jkotas merged 2 commits into
dotnet:mainfrom
kunalspathak:EmitInlineTLSAccess

Conversation

@kunalspathak

Copy link
Copy Markdown
Contributor

Ignore the preferSize and always expand TLS. Relevant discussion in #89472 (comment)

Fixes: #97168

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 19, 2024
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Ignore the preferSize and always expand TLS. Relevant discussion in #89472 (comment)

Fixes: #97168

Author:kunalspathak
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@jkotas

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment threadsrc/coreclr/jit/helperexpansion.cpp Outdated
@jkotas

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas
jkotas merged commit d05b6c9 into dotnet:mainJan 19, 2024
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
* Always expand TLS for NativeAOT
* Update src/coreclr/jit/helperexpansion.cpp
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.NotImplementedException:: ILCompiler.DependencyAnalysis.ReadyToRunHelperNode.EmitInlineTLSAccess

2 participants

@kunalspathak@jkotas