Skip to content

Convert Array.CopySlow to managed - #97202

Merged
AaronRobinsonMSFT merged 25 commits into
dotnet:mainfrom
huoyaoyuan:array-copyslow
Jan 26, 2024
Merged

Convert Array.CopySlow to managed#97202
AaronRobinsonMSFT merged 25 commits into
dotnet:mainfrom
huoyaoyuan:array-copyslow

Conversation

@huoyaoyuan

@huoyaoyuanhuoyaoyuan commented Jan 19, 2024

Copy link
Copy Markdown
Member

Also removes a case of HELPER_METHOD_FRAME.

The performance should not be a problem. The main concern is size.
coreclr.dll: 4864KB->4861KB, corelib R2R: 13660KB->13672KB

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-VM-coreclr labels Jan 19, 2024
huoyaoyuan
huoyaoyuan commented Jan 19, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs Outdated
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs Outdated
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs Outdated
This was referenced Jan 19, 2024
Closed
Closed
@jkotas

jkotas commented Jan 19, 2024

Copy link
Copy Markdown
Member

It would be nice to make this as similar as possible to native AOT implementation (or even shared with native AOT).

This was referenced Jan 19, 2024
Closed
Closed
This was referenced Jan 21, 2024
Closed
Closed
This was referenced Jan 22, 2024
Closed
Open
MichalPetryka
MichalPetryka reviewed Jan 23, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs Outdated
huoyaoyuan
huoyaoyuan commented Jan 24, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs Outdated
jkotas
jkotas reviewed Jan 24, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs Outdated
jkotas
jkotas reviewed Jan 24, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs Outdated
This was referenced Jan 24, 2024
Closed
Open
Open
jkotas
jkotas approved these changes Jan 25, 2024
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

jkotas
jkotas approved these changes Jan 25, 2024•
edited
Loading
View reviewed changes
@jkotas

jkotas commented Jan 25, 2024

Copy link
Copy Markdown
Member

@AaronRobinsonMSFT Could you please take a look as well?

AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jan 26, 2024
View reviewed changes

@AaronRobinsonMSFTAaronRobinsonMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will finish later tonight.

Comment threadsrc/coreclr/classlibnative/bcltype/arraynative.h Outdated
Comment threadsrc/coreclr/classlibnative/bcltype/arraynative.cpp Outdated
Comment threadsrc/coreclr/classlibnative/bcltype/arraynative.cpp Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jan 26, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jan 26, 2024
View reviewed changes
Comment threadsrc/coreclr/classlibnative/bcltype/arraynative.cpp Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jan 26, 2024
View reviewed changes
Comment threadsrc/coreclr/classlibnative/bcltype/arraynative.cpp Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Jan 26, 2024
View reviewed changes

@AaronRobinsonMSFTAaronRobinsonMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@huoyaoyuan@AaronRobinsonMSFT
Update src/coreclr/classlibnative/bcltype/arraynative.cpp
4f442b1
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit ca703a1 into dotnet:mainJan 26, 2024
@huoyaoyuan
huoyaoyuan deleted the array-copyslow branch January 27, 2024 03:49
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 26, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
+1 more reviewer
@MichalPetrykaMichalPetrykaMichalPetryka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-VM-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huoyaoyuan@jkotas@AaronRobinsonMSFT@MichalPetryka