Uh oh!
There was an error while loading. Please reload this page.
Implement more ServicePoint properties - #97537
Conversation
ghost
commented
Jan 26, 2024
Tagging subscribers to this area: @dotnet/ncl Issue Detailsnull
|
liveans
commented
Jan 26, 2024
Maybe I can implement the PlaintextStreamFilter=(context,ct)=>{ServicePoint.IdleSince=DateTime.Now;returnValueTask.FromResult(context.PlaintextStream);}But not sure if this is a good idea, any suggestions @dotnet/ncl ? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…t.cs Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…se.cs Co-authored-by: Anton Firszov <antonfir@gmail.com>
MihaZupan
left a comment
There was a problem hiding this comment.
Left a couple questions + style changes, otherwise this looks good
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
liveans
commented
Feb 28, 2024
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Uh oh!
There was an error while loading. Please reload this page.
This reverts commit 7aa734f.
liveans
commented
Feb 28, 2024
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
liveans
commented
Mar 1, 2024
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liveans
commented
Mar 1, 2024
CI failures unrelated |
This PR implements:
HttpWebRequest:
ServicePoint:
ServicePoint but no effect (We're creating a new handler for every request if we have non-null
ServicePoint):These properties will matter in case we want to invest some work in caching of
HttpClientunderHttpWebRequest, the current implementation is straightforward and these properties are not gaining any advantage from it.