Skip to content

Add separate properties for keep-in-sync versions - #97643

Merged
ViktorHofer merged 6 commits into
dotnet:mainfrom
am11:feature/package-versioning
Feb 6, 2024
Merged

Add separate properties for keep-in-sync versions#97643
ViktorHofer merged 6 commits into
dotnet:mainfrom
am11:feature/package-versioning

Conversation

@am11

@am11am11 commented Jan 29, 2024

Copy link
Copy Markdown
Member

@ghostghost added area-HostModel community-contribution Indicates that the PR has been added by a community member labels Jan 29, 2024
@am11
am11 requested a review from ViktorHoferJanuary 29, 2024 14:11
@ghost

ghost commented Jan 29, 2024

Copy link
Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

Issue Details

#97021 (comment)

Author:am11
Assignees:-
Labels:

area-HostModel, community-contribution

Milestone:-

@ghost

ghost commented Jan 29, 2024

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

#97021 (comment)

Author:am11
Assignees:-
Labels:

area-Infrastructure, community-contribution

Milestone:-

@am11am11 mentioned this pull request Jan 29, 2024
Merged
@am11
am11force-pushed the feature/package-versioning branch 2 times, most recently from 401f846 to 96e5e8bCompareJanuary 29, 2024 16:03
ViktorHofer
ViktorHofer reviewed Jan 29, 2024
View reviewed changes
Comment threadeng/SourceBuildPrebuiltBaseline.xml Outdated
MichaelSimons
MichaelSimons reviewed Jan 29, 2024
View reviewed changes
Comment threadeng/Versions.props Outdated
@am11

am11 commented Jan 29, 2024

Copy link
Copy Markdown
MemberAuthor

Failures are known (per Build Analysis).

This was referenced Jan 29, 2024
Closed
Closed
Closed
akoeplinger
akoeplinger reviewed Jan 30, 2024
View reviewed changes
Comment threadsrc/tasks/Microsoft.NET.WebAssembly.Webcil/Microsoft.NET.WebAssembly.Webcil.csproj Outdated
@am11
am11 requested a review from maraf as a code ownerJanuary 30, 2024 20:44
@am11
am11force-pushed the feature/package-versioning branch from c9618be to 23129d8CompareJanuary 30, 2024 20:53
@am11
am11 requested a review from sbomer as a code ownerJanuary 30, 2024 20:53
@am11
am11force-pushed the feature/package-versioning branch from 23129d8 to b26a4a2CompareJanuary 30, 2024 20:56
This was referenced Jan 31, 2024
Open
Closed
Open
Closed
@akoeplinger

akoeplinger commented Jan 31, 2024•
edited
Loading

Copy link
Copy Markdown
Member

I've fixed the msbuild task projects to use NetCoreAppToolCurrent and NetFrameworkToolCurrent, we can leverage the transitive references for System.Reflection.Metadata from msbuild packages in those projects so we don't need to explicitly reference it.

ViktorHofer
ViktorHofer reviewed Jan 31, 2024
View reviewed changes
Comment threadeng/liveILLink.targets Outdated
@akoeplinger
akoeplingerforce-pushed the feature/package-versioning branch from b4b82fe to a040a48CompareJanuary 31, 2024 12:55
@am11

am11 commented Feb 6, 2024

Copy link
Copy Markdown
MemberAuthor

Extra changes by @akoeplinger reverted. Lets move them to a separate PR.

@am11
am11 requested a review from jkotasFebruary 6, 2024 05:16
This was referenced Feb 6, 2024
Closed
Closed
Closed
@ViktorHofer

ViktorHofer commented Feb 6, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@am11 do you have a back-up of @akoeplinger's changes?

ViktorHofer
ViktorHofer reviewed Feb 6, 2024
View reviewed changes
Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Microsoft.NET.HostModel.csproj Outdated
ViktorHofer
ViktorHofer reviewed Feb 6, 2024
View reviewed changes
Comment threadsrc/tasks/Microsoft.NET.WebAssembly.Webcil/Microsoft.NET.WebAssembly.Webcil.csproj Outdated
ViktorHofer
ViktorHofer reviewed Feb 6, 2024
View reviewed changes
Comment threadsrc/tasks/WasmAppBuilder/WasmAppBuilder.csproj Outdated
ViktorHofer
ViktorHofer reviewed Feb 6, 2024
View reviewed changes
Comment threadeng/Versions.props Outdated
ViktorHofer
ViktorHofer reviewed Feb 6, 2024
View reviewed changes
Comment threadeng/Versions.props Outdated
@am11

am11 commented Feb 6, 2024

Copy link
Copy Markdown
MemberAuthor

@am11 do you have a back-up of @akoeplinger's changes?

Yup:
image
so we can see it like this: https://github.com/dotnet/runtime/commits/421482baf82d2cb0887da31ad73a39b15afdb855

@ViktorHofer

ViktorHofer commented Feb 6, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Sweet, I didn't know that is possible on GH 👍

@ViktorHofer
ViktorHofer merged commit 994e272 into dotnet:mainFeb 6, 2024
KidiIT

This comment was marked as spam.

Sign in to view

lewing
lewing reviewed Feb 8, 2024
View reviewed changes
Comment threadeng/Versions.props
<SystemMemoryVersion>4.5.5</SystemMemoryVersion>
<SystemReflectionMetadataVersion>7.0.0</SystemReflectionMetadataVersion>
<SystemReflectionMetadataVersion>9.0.0-alpha.1.24072.1</SystemReflectionMetadataVersion>
<!-- Keep toolset versions in sync with dotnet/msbuild and dotnet/sdk -->

@lewinglewingFeb 8, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't the versions in msbuild or VS afaik

@lewinglewingFeb 8, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/dotnet/msbuild/blob/main/eng/Versions.props#L38-L39

https://github.com/dotnet/msbuild/blob/vs17.9/eng/Versions.props#L38-L39

@am11am11Feb 9, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see #97021 (comment) and #97643 (comment). TL;DR, we need to keep version of SRM in HostModel lower or equal (when everything is out of beta/preview) than MSBuild and SDK. SDK and runtime are currently using 7.0, MSBuild has moved to 8.0.

KidiIT

This comment was marked as spam.

Sign in to view

@lewing

lewing commented Feb 9, 2024

Copy link
Copy Markdown
Member

see #97836

@am11

am11 commented Feb 9, 2024

Copy link
Copy Markdown
MemberAuthor

see #97836

Is this the correct issue? Not seeing the relevance. 👀

KidiIT

This comment was marked as spam.

Sign in to view

@lewing

lewing commented Feb 10, 2024

Copy link
Copy Markdown
Member

see #97836

Is this the correct issue? Not seeing the relevance. 👀

nope, wrong paste buffer. apologies for the confusion

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing left review comments
@MichaelSimonsMichaelSimonsMichaelSimons left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@sbomersbomerAwaiting requested review from sbomersbomer is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
@jkotasjkotasAwaiting requested review from jkotas
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger is a code owner
+2 more reviewers
@KidiITKidiITKidiIT left review comments
@ashaurtaevashaurtaevashaurtaev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@am11@akoeplinger@ViktorHofer@lewing@MichaelSimons@ashaurtaev@KidiIT