Update MicrosoftBuildVersion to latest - #98006

Merged
ViktorHofer merged 7 commits into
dotnet:mainfrom
LoopedBard3:UpdateSystemSecurityCryptographyXml
Feb 8, 2024
Merged

Update MicrosoftBuildVersion to latest#98006
ViktorHofer merged 7 commits into
dotnet:mainfrom
LoopedBard3:UpdateSystemSecurityCryptographyXml

Conversation

@LoopedBard3

@LoopedBard3LoopedBard3 commented Feb 5, 2024

Copy link
Copy Markdown
Member

Update MicrosoftBuildVersion to latest to fix a component governance alert.

@LoopedBard3LoopedBard3 self-assigned this Feb 5, 2024
@ghost

ghost commented Feb 5, 2024

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Update MicrosoftBuildVersion to latest to fix a component governance alert.

Author:LoopedBard3
Assignees:LoopedBard3
Labels:

area-Infrastructure

Milestone:-

@build-analysisbuild-analysisBot mentioned this pull request Feb 5, 2024
Closed
This was referenced Feb 6, 2024
Closed
Open
Closed
This was referenced Feb 6, 2024
Closed
Closed
Open
Closed
Closed
@LoopedBard3
LoopedBard3 marked this pull request as ready for review February 6, 2024 18:11
ViktorHofer added a commit to dotnet/source-build-assets that referenced this pull request Feb 6, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies
765e047
... necessary for dotnet/runtime#98006
@ViktorHoferViktorHofer mentioned this pull request Feb 6, 2024
Merged
@ViktorHofer

ViktorHofer commented Feb 6, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Needs dotnet/source-build-assets#885 -> #98090

@ViktorHoferViktorHofer mentioned this pull request Feb 7, 2024
Closed
ViktorHofer added a commit to dotnet/source-build-assets that referenced this pull request Feb 7, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies (#885)
a739c05
* Add MSBuild 17.8.3 + dependencies
... necessary for dotnet/runtime#98006
* Add manual pragma warning disable as in dotnet/runtime
@ViktorHofer

ViktorHofer commented Feb 7, 2024

Copy link
Copy Markdown
Member

@ericstj@rainersigwald MSBuild exposes the internal type Microsoft.Build.Framework.IMetadataContainer in the Microsoft.Build.Framework reference assembly (from the NuGet package) but SBRP doesn't expose that because it's internal.

Why is internal type required? Its omission causes the build failures in this PR.

@build-analysisbuild-analysisBot mentioned this pull request Feb 7, 2024
Open
3 tasks
@ericstj

ericstj commented Feb 7, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Looks like this introduced the interface: dotnet/msbuild@f69319c

I suspect we're mixing assemblies here. Looks like we have TaskItem that claims it implements internal interface IMetadataContainer, but then we have a reference package for Microsoft.Build.Framework without IMetadataContainer. Looks like the compiler needs to resolve (all) interfaces whenever you cast from contrete type to interface.

Can we fix this by making sure we reference all live or all SBRP packages and not a mix? IIUC The interface lives in Microsoft.Build.Framework and the consumer is in Microsoft.Build.Utilities.

Update: we don't seem to be mixing assemblies. I see the following in the binlog.
image
I'm at a loss for how Microsoft.Build.Utilities.Core got a reference to IMetadataContainer if they were all built from SBRP.

@ericstj

ericstj commented Feb 7, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Oh, maybe it's because we don't actually have a 17.8.3 in SBRP so it pulled the real one. That explains it. https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/microsoft.build.utilities.core

Looks like we have a consistent set for 17.4.0, but not 17.8.3

image

@ViktorHofer

ViktorHofer commented Feb 7, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Hmm I wonder why the source-build flag doesn't report Microsoft.Build.Utilties.Core and Microsoft.Build.Tasks.Core 17.8.3 as new prebuilts. cc @dotnet/source-build-internal

Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?

@MichaelSimons

MichaelSimons commented Feb 7, 2024

Copy link
Copy Markdown
Member

Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?

Yes - prebuilt detection only runs upon a successful build.

@ViktorHoferViktorHofer mentioned this pull request Feb 8, 2024
Closed
@ViktorHofer

ViktorHofer commented Feb 8, 2024

Copy link
Copy Markdown
Member

Filed dotnet/source-build#4103 for prebuilt detection not running for failing builds.

ViktorHofer added a commit to dotnet/source-build-assets that referenced this pull request Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
323b156
Required for dotnet/runtime#98006
Follow-up on #885
@ViktorHoferViktorHofer mentioned this pull request Feb 8, 2024
Merged
MichaelSimons pushed a commit to dotnet/source-build-assets that referenced this pull request Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.…
6b94d15
…8.3 (#886)
* Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
Required for dotnet/runtime#98006
Follow-up on #885
* Update unrelated files
* Manual change because of attribute filtering by GenAPI
* Remove dependency from nuspec as well
@ViktorHofer

ViktorHofer commented Feb 8, 2024

Copy link
Copy Markdown
Member

Needs #98178

@ViktorHofer
ViktorHofer merged commit 0976796 into dotnet:mainFeb 8, 2024
@LoopedBard3
LoopedBard3 deleted the UpdateSystemSecurityCryptographyXml branch February 8, 2024 23:49
@steveisok

steveisok commented Feb 20, 2024

Copy link
Copy Markdown
Member

@LoopedBard3@ViktorHofer looks like we need to backport this to release/8.0, 7.0, and 6.0.

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 22, 2024
@ericstj

ericstj commented Apr 3, 2024

Copy link
Copy Markdown
Member

/backport to release/8.0

@github-actions

github-actionsBot commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/8542745559

@github-actionsgithub-actionsBot unlocked this conversation Apr 3, 2024
@github-actionsgithub-actionsBot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees

@LoopedBard3LoopedBard3

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LoopedBard3@ViktorHofer@ericstj@MichaelSimons@steveisok
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Update MicrosoftBuildVersion to latest - #98006
Merged
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Feb 8, 2024
Merged
Update MicrosoftBuildVersion to latest#98006
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Conversation
@LoopedBard3
@LoopedBard3LoopedBard3
commented
Feb 5, 2024

Copy link


Copy Markdown

Member
Update MicrosoftBuildVersion to latest to fix a component governance alert.
@LoopedBard3LoopedBard3
self-assigned this
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Update MicrosoftBuildVersion to latest to fix a component governance alert.
Author:LoopedBard3
Assignees:LoopedBard3
Labels:
area-Infrastructure
Milestone:-
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 5, 2024

Closed


This was referenced Feb 6, 2024

Closed


Open


Closed


This was referenced Feb 6, 2024

Closed


Closed


Open


Closed


Closed

@LoopedBard3
LoopedBard3
marked this pull request as ready for review
February 6, 2024 18:11
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 6, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies
765e047
... necessary for dotnet/runtime#98006
@ViktorHoferViktorHofer
mentioned this pull request
Feb 6, 2024
 Merged

@ViktorHofer
ViktorHofer
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Needs dotnet/source-build-assets#885 -> #98090
@ViktorHoferViktorHofer
mentioned this pull request
Feb 7, 2024
 Closed

ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 7, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies (#885)
a739c05
* Add MSBuild 17.8.3 + dependencies
... necessary for dotnet/runtime#98006
* Add manual pragma warning disable as in dotnet/runtime
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
@ericstj@rainersigwald MSBuild exposes the internal type Microsoft.Build.Framework.IMetadataContainer in the Microsoft.Build.Framework reference assembly (from the NuGet package) but SBRP doesn't expose that because it's internal.
Why is internal type required? Its omission causes the build failures in this PR.
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 7, 2024

Open

3 tasks
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Looks like this introduced the interface: dotnet/msbuild@f69319c
I suspect we're mixing assemblies here. Looks like we have TaskItem that claims it implements internal interface IMetadataContainer, but then we have a reference package for Microsoft.Build.Framework without IMetadataContainer. Looks like the compiler needs to resolve (all) interfaces whenever you cast from contrete type to interface.
Can we fix this by making sure we reference all live or all SBRP packages and not a mix? IIUC The interface lives in Microsoft.Build.Framework and the consumer is in Microsoft.Build.Utilities.
Update: we don't seem to be mixing assemblies. I see the following in the binlog.
image

I'm at a loss for how Microsoft.Build.Utilities.Core got a reference to IMetadataContainer if they were all built from SBRP.
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Oh, maybe it's because we don't actually have a 17.8.3 in SBRP so it pulled the real one. That explains it. https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/microsoft.build.utilities.core
Looks like we have a consistent set for 17.4.0, but not 17.8.3
image
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Hmm I wonder why the source-build flag doesn't report Microsoft.Build.Utilties.Core and Microsoft.Build.Tasks.Core 17.8.3 as new prebuilts. cc @dotnet/source-build-internal
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
@MichaelSimons
MichaelSimons
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
Yes - prebuilt detection only runs upon a successful build.
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024

Closed

@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Filed dotnet/source-build#4103 for prebuilt detection not running for failing builds.
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
323b156
Required for dotnet/runtime#98006
Follow-up on #885
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024
 Merged

MichaelSimons pushed a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.…
6b94d15
…8.3 (#886)
* Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
Required for dotnet/runtime#98006
Follow-up on #885
* Update unrelated files
* Manual change because of attribute filtering by GenAPI
* Remove dependency from nuspec as well
@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Needs #98178
@ViktorHofer
ViktorHofer
merged commit 0976796
into
dotnet:mainFeb 8, 2024
@LoopedBard3
LoopedBard3
deleted the

UpdateSystemSecurityCryptographyXml

branch
February 8, 2024 23:49
@steveisok
steveisok
commented
Feb 20, 2024

Copy link


Copy Markdown

Member
@LoopedBard3@ViktorHofer looks like we need to backport this to release/8.0, 7.0, and 6.0.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 22, 2024
@ericstj
ericstj
commented
Apr 3, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0
@github-actions
github-actionsBot
commented
Apr 3, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/8542745559
@github-actionsgithub-actionsBot
unlocked this conversation
Apr 3, 2024
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees

@LoopedBard3LoopedBard3

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LoopedBard3@ViktorHofer@ericstj@MichaelSimons@steveisok

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update MicrosoftBuildVersion to latest - #98006
Merged
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Feb 8, 2024
Merged
Update MicrosoftBuildVersion to latest#98006
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Conversation
@LoopedBard3
@LoopedBard3LoopedBard3
commented
Feb 5, 2024

Copy link


Copy Markdown

Member
Update MicrosoftBuildVersion to latest to fix a component governance alert.
@LoopedBard3LoopedBard3
self-assigned this
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Update MicrosoftBuildVersion to latest to fix a component governance alert.
Author:LoopedBard3
Assignees:LoopedBard3
Labels:
area-Infrastructure
Milestone:-
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 5, 2024

Closed


This was referenced Feb 6, 2024

Closed


Open


Closed


This was referenced Feb 6, 2024

Closed


Closed


Open


Closed


Closed

@LoopedBard3
LoopedBard3
marked this pull request as ready for review
February 6, 2024 18:11
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 6, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies
765e047
... necessary for dotnet/runtime#98006
@ViktorHoferViktorHofer
mentioned this pull request
Feb 6, 2024
 Merged

@ViktorHofer
ViktorHofer
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Needs dotnet/source-build-assets#885 -> #98090
@ViktorHoferViktorHofer
mentioned this pull request
Feb 7, 2024
 Closed

ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 7, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies (#885)
a739c05
* Add MSBuild 17.8.3 + dependencies
... necessary for dotnet/runtime#98006
* Add manual pragma warning disable as in dotnet/runtime
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
@ericstj@rainersigwald MSBuild exposes the internal type Microsoft.Build.Framework.IMetadataContainer in the Microsoft.Build.Framework reference assembly (from the NuGet package) but SBRP doesn't expose that because it's internal.
Why is internal type required? Its omission causes the build failures in this PR.
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 7, 2024

Open

3 tasks
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Looks like this introduced the interface: dotnet/msbuild@f69319c
I suspect we're mixing assemblies here. Looks like we have TaskItem that claims it implements internal interface IMetadataContainer, but then we have a reference package for Microsoft.Build.Framework without IMetadataContainer. Looks like the compiler needs to resolve (all) interfaces whenever you cast from contrete type to interface.
Can we fix this by making sure we reference all live or all SBRP packages and not a mix? IIUC The interface lives in Microsoft.Build.Framework and the consumer is in Microsoft.Build.Utilities.
Update: we don't seem to be mixing assemblies. I see the following in the binlog.
image

I'm at a loss for how Microsoft.Build.Utilities.Core got a reference to IMetadataContainer if they were all built from SBRP.
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Oh, maybe it's because we don't actually have a 17.8.3 in SBRP so it pulled the real one. That explains it. https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/microsoft.build.utilities.core
Looks like we have a consistent set for 17.4.0, but not 17.8.3
image
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Hmm I wonder why the source-build flag doesn't report Microsoft.Build.Utilties.Core and Microsoft.Build.Tasks.Core 17.8.3 as new prebuilts. cc @dotnet/source-build-internal
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
@MichaelSimons
MichaelSimons
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
Yes - prebuilt detection only runs upon a successful build.
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024

Closed

@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Filed dotnet/source-build#4103 for prebuilt detection not running for failing builds.
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
323b156
Required for dotnet/runtime#98006
Follow-up on #885
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024
 Merged

MichaelSimons pushed a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.…
6b94d15
…8.3 (#886)
* Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
Required for dotnet/runtime#98006
Follow-up on #885
* Update unrelated files
* Manual change because of attribute filtering by GenAPI
* Remove dependency from nuspec as well
@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Needs #98178
@ViktorHofer
ViktorHofer
merged commit 0976796
into
dotnet:mainFeb 8, 2024
@LoopedBard3
LoopedBard3
deleted the

UpdateSystemSecurityCryptographyXml

branch
February 8, 2024 23:49
@steveisok
steveisok
commented
Feb 20, 2024

Copy link


Copy Markdown

Member
@LoopedBard3@ViktorHofer looks like we need to backport this to release/8.0, 7.0, and 6.0.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 22, 2024
@ericstj
ericstj
commented
Apr 3, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0
@github-actions
github-actionsBot
commented
Apr 3, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/8542745559
@github-actionsgithub-actionsBot
unlocked this conversation
Apr 3, 2024
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees

@LoopedBard3LoopedBard3

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LoopedBard3@ViktorHofer@ericstj@MichaelSimons@steveisok

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update MicrosoftBuildVersion to latest - #98006
Merged
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Feb 8, 2024
Merged
Update MicrosoftBuildVersion to latest#98006
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Conversation
@LoopedBard3
@LoopedBard3LoopedBard3
commented
Feb 5, 2024

Copy link


Copy Markdown

Member
Update MicrosoftBuildVersion to latest to fix a component governance alert.
@LoopedBard3LoopedBard3
self-assigned this
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Update MicrosoftBuildVersion to latest to fix a component governance alert.
Author:LoopedBard3
Assignees:LoopedBard3
Labels:
area-Infrastructure
Milestone:-
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 5, 2024

Closed


This was referenced Feb 6, 2024

Closed


Open


Closed


This was referenced Feb 6, 2024

Closed


Closed


Open


Closed


Closed

@LoopedBard3
LoopedBard3
marked this pull request as ready for review
February 6, 2024 18:11
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 6, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies
765e047
... necessary for dotnet/runtime#98006
@ViktorHoferViktorHofer
mentioned this pull request
Feb 6, 2024
 Merged

@ViktorHofer
ViktorHofer
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Needs dotnet/source-build-assets#885 -> #98090
@ViktorHoferViktorHofer
mentioned this pull request
Feb 7, 2024
 Closed

ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 7, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies (#885)
a739c05
* Add MSBuild 17.8.3 + dependencies
... necessary for dotnet/runtime#98006
* Add manual pragma warning disable as in dotnet/runtime
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
@ericstj@rainersigwald MSBuild exposes the internal type Microsoft.Build.Framework.IMetadataContainer in the Microsoft.Build.Framework reference assembly (from the NuGet package) but SBRP doesn't expose that because it's internal.
Why is internal type required? Its omission causes the build failures in this PR.
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 7, 2024

Open

3 tasks
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Looks like this introduced the interface: dotnet/msbuild@f69319c
I suspect we're mixing assemblies here. Looks like we have TaskItem that claims it implements internal interface IMetadataContainer, but then we have a reference package for Microsoft.Build.Framework without IMetadataContainer. Looks like the compiler needs to resolve (all) interfaces whenever you cast from contrete type to interface.
Can we fix this by making sure we reference all live or all SBRP packages and not a mix? IIUC The interface lives in Microsoft.Build.Framework and the consumer is in Microsoft.Build.Utilities.
Update: we don't seem to be mixing assemblies. I see the following in the binlog.
image

I'm at a loss for how Microsoft.Build.Utilities.Core got a reference to IMetadataContainer if they were all built from SBRP.
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Oh, maybe it's because we don't actually have a 17.8.3 in SBRP so it pulled the real one. That explains it. https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/microsoft.build.utilities.core
Looks like we have a consistent set for 17.4.0, but not 17.8.3
image
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Hmm I wonder why the source-build flag doesn't report Microsoft.Build.Utilties.Core and Microsoft.Build.Tasks.Core 17.8.3 as new prebuilts. cc @dotnet/source-build-internal
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
@MichaelSimons
MichaelSimons
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
Yes - prebuilt detection only runs upon a successful build.
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024

Closed

@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Filed dotnet/source-build#4103 for prebuilt detection not running for failing builds.
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
323b156
Required for dotnet/runtime#98006
Follow-up on #885
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024
 Merged

MichaelSimons pushed a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.…
6b94d15
…8.3 (#886)
* Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
Required for dotnet/runtime#98006
Follow-up on #885
* Update unrelated files
* Manual change because of attribute filtering by GenAPI
* Remove dependency from nuspec as well
@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Needs #98178
@ViktorHofer
ViktorHofer
merged commit 0976796
into
dotnet:mainFeb 8, 2024
@LoopedBard3
LoopedBard3
deleted the

UpdateSystemSecurityCryptographyXml

branch
February 8, 2024 23:49
@steveisok
steveisok
commented
Feb 20, 2024

Copy link


Copy Markdown

Member
@LoopedBard3@ViktorHofer looks like we need to backport this to release/8.0, 7.0, and 6.0.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 22, 2024
@ericstj
ericstj
commented
Apr 3, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0
@github-actions
github-actionsBot
commented
Apr 3, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/8542745559
@github-actionsgithub-actionsBot
unlocked this conversation
Apr 3, 2024
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees

@LoopedBard3LoopedBard3

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LoopedBard3@ViktorHofer@ericstj@MichaelSimons@steveisok

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Update MicrosoftBuildVersion to latest - #98006
Merged
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Feb 8, 2024
Merged
Update MicrosoftBuildVersion to latest#98006
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Conversation
@LoopedBard3
@LoopedBard3LoopedBard3
commented
Feb 5, 2024

Copy link


Copy Markdown

Member
Update MicrosoftBuildVersion to latest to fix a component governance alert.
@LoopedBard3LoopedBard3
self-assigned this
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Update MicrosoftBuildVersion to latest to fix a component governance alert.
Author:LoopedBard3
Assignees:LoopedBard3
Labels:
area-Infrastructure
Milestone:-
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 5, 2024

Closed


This was referenced Feb 6, 2024

Closed


Open


Closed


This was referenced Feb 6, 2024

Closed


Closed


Open


Closed


Closed

@LoopedBard3
LoopedBard3
marked this pull request as ready for review
February 6, 2024 18:11
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 6, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies
765e047
... necessary for dotnet/runtime#98006
@ViktorHoferViktorHofer
mentioned this pull request
Feb 6, 2024
 Merged

@ViktorHofer
ViktorHofer
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Needs dotnet/source-build-assets#885 -> #98090
@ViktorHoferViktorHofer
mentioned this pull request
Feb 7, 2024
 Closed

ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 7, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies (#885)
a739c05
* Add MSBuild 17.8.3 + dependencies
... necessary for dotnet/runtime#98006
* Add manual pragma warning disable as in dotnet/runtime
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
@ericstj@rainersigwald MSBuild exposes the internal type Microsoft.Build.Framework.IMetadataContainer in the Microsoft.Build.Framework reference assembly (from the NuGet package) but SBRP doesn't expose that because it's internal.
Why is internal type required? Its omission causes the build failures in this PR.
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 7, 2024

Open

3 tasks
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Looks like this introduced the interface: dotnet/msbuild@f69319c
I suspect we're mixing assemblies here. Looks like we have TaskItem that claims it implements internal interface IMetadataContainer, but then we have a reference package for Microsoft.Build.Framework without IMetadataContainer. Looks like the compiler needs to resolve (all) interfaces whenever you cast from contrete type to interface.
Can we fix this by making sure we reference all live or all SBRP packages and not a mix? IIUC The interface lives in Microsoft.Build.Framework and the consumer is in Microsoft.Build.Utilities.
Update: we don't seem to be mixing assemblies. I see the following in the binlog.
image

I'm at a loss for how Microsoft.Build.Utilities.Core got a reference to IMetadataContainer if they were all built from SBRP.
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Oh, maybe it's because we don't actually have a 17.8.3 in SBRP so it pulled the real one. That explains it. https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/microsoft.build.utilities.core
Looks like we have a consistent set for 17.4.0, but not 17.8.3
image
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Hmm I wonder why the source-build flag doesn't report Microsoft.Build.Utilties.Core and Microsoft.Build.Tasks.Core 17.8.3 as new prebuilts. cc @dotnet/source-build-internal
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
@MichaelSimons
MichaelSimons
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
Yes - prebuilt detection only runs upon a successful build.
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024

Closed

@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Filed dotnet/source-build#4103 for prebuilt detection not running for failing builds.
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
323b156
Required for dotnet/runtime#98006
Follow-up on #885
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024
 Merged

MichaelSimons pushed a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.…
6b94d15
…8.3 (#886)
* Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
Required for dotnet/runtime#98006
Follow-up on #885
* Update unrelated files
* Manual change because of attribute filtering by GenAPI
* Remove dependency from nuspec as well
@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Needs #98178
@ViktorHofer
ViktorHofer
merged commit 0976796
into
dotnet:mainFeb 8, 2024
@LoopedBard3
LoopedBard3
deleted the

UpdateSystemSecurityCryptographyXml

branch
February 8, 2024 23:49
@steveisok
steveisok
commented
Feb 20, 2024

Copy link


Copy Markdown

Member
@LoopedBard3@ViktorHofer looks like we need to backport this to release/8.0, 7.0, and 6.0.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 22, 2024
@ericstj
ericstj
commented
Apr 3, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0
@github-actions
github-actionsBot
commented
Apr 3, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/8542745559
@github-actionsgithub-actionsBot
unlocked this conversation
Apr 3, 2024
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees

@LoopedBard3LoopedBard3

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LoopedBard3@ViktorHofer@ericstj@MichaelSimons@steveisok

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update MicrosoftBuildVersion to latest - #98006
Merged
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Feb 8, 2024
Merged
Update MicrosoftBuildVersion to latest#98006
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Conversation
@LoopedBard3
@LoopedBard3LoopedBard3
commented
Feb 5, 2024

Copy link


Copy Markdown

Member
Update MicrosoftBuildVersion to latest to fix a component governance alert.
@LoopedBard3LoopedBard3
self-assigned this
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Update MicrosoftBuildVersion to latest to fix a component governance alert.
Author:LoopedBard3
Assignees:LoopedBard3
Labels:
area-Infrastructure
Milestone:-
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 5, 2024

Closed


This was referenced Feb 6, 2024

Closed


Open


Closed


This was referenced Feb 6, 2024

Closed


Closed


Open


Closed


Closed

@LoopedBard3
LoopedBard3
marked this pull request as ready for review
February 6, 2024 18:11
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 6, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies
765e047
... necessary for dotnet/runtime#98006
@ViktorHoferViktorHofer
mentioned this pull request
Feb 6, 2024
 Merged

@ViktorHofer
ViktorHofer
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Needs dotnet/source-build-assets#885 -> #98090
@ViktorHoferViktorHofer
mentioned this pull request
Feb 7, 2024
 Closed

ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 7, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies (#885)
a739c05
* Add MSBuild 17.8.3 + dependencies
... necessary for dotnet/runtime#98006
* Add manual pragma warning disable as in dotnet/runtime
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
@ericstj@rainersigwald MSBuild exposes the internal type Microsoft.Build.Framework.IMetadataContainer in the Microsoft.Build.Framework reference assembly (from the NuGet package) but SBRP doesn't expose that because it's internal.
Why is internal type required? Its omission causes the build failures in this PR.
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 7, 2024

Open

3 tasks
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Looks like this introduced the interface: dotnet/msbuild@f69319c
I suspect we're mixing assemblies here. Looks like we have TaskItem that claims it implements internal interface IMetadataContainer, but then we have a reference package for Microsoft.Build.Framework without IMetadataContainer. Looks like the compiler needs to resolve (all) interfaces whenever you cast from contrete type to interface.
Can we fix this by making sure we reference all live or all SBRP packages and not a mix? IIUC The interface lives in Microsoft.Build.Framework and the consumer is in Microsoft.Build.Utilities.
Update: we don't seem to be mixing assemblies. I see the following in the binlog.
image

I'm at a loss for how Microsoft.Build.Utilities.Core got a reference to IMetadataContainer if they were all built from SBRP.
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Oh, maybe it's because we don't actually have a 17.8.3 in SBRP so it pulled the real one. That explains it. https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/microsoft.build.utilities.core
Looks like we have a consistent set for 17.4.0, but not 17.8.3
image
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Hmm I wonder why the source-build flag doesn't report Microsoft.Build.Utilties.Core and Microsoft.Build.Tasks.Core 17.8.3 as new prebuilts. cc @dotnet/source-build-internal
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
@MichaelSimons
MichaelSimons
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
Yes - prebuilt detection only runs upon a successful build.
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024

Closed

@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Filed dotnet/source-build#4103 for prebuilt detection not running for failing builds.
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
323b156
Required for dotnet/runtime#98006
Follow-up on #885
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024
 Merged

MichaelSimons pushed a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.…
6b94d15
…8.3 (#886)
* Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
Required for dotnet/runtime#98006
Follow-up on #885
* Update unrelated files
* Manual change because of attribute filtering by GenAPI
* Remove dependency from nuspec as well
@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Needs #98178
@ViktorHofer
ViktorHofer
merged commit 0976796
into
dotnet:mainFeb 8, 2024
@LoopedBard3
LoopedBard3
deleted the

UpdateSystemSecurityCryptographyXml

branch
February 8, 2024 23:49
@steveisok
steveisok
commented
Feb 20, 2024

Copy link


Copy Markdown

Member
@LoopedBard3@ViktorHofer looks like we need to backport this to release/8.0, 7.0, and 6.0.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 22, 2024
@ericstj
ericstj
commented
Apr 3, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0
@github-actions
github-actionsBot
commented
Apr 3, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/8542745559
@github-actionsgithub-actionsBot
unlocked this conversation
Apr 3, 2024
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees

@LoopedBard3LoopedBard3

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LoopedBard3@ViktorHofer@ericstj@MichaelSimons@steveisok

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update MicrosoftBuildVersion to latest - #98006
Merged
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Feb 8, 2024
Merged
Update MicrosoftBuildVersion to latest#98006
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Conversation
@LoopedBard3
@LoopedBard3LoopedBard3
commented
Feb 5, 2024

Copy link


Copy Markdown

Member
Update MicrosoftBuildVersion to latest to fix a component governance alert.
@LoopedBard3LoopedBard3
self-assigned this
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Update MicrosoftBuildVersion to latest to fix a component governance alert.
Author:LoopedBard3
Assignees:LoopedBard3
Labels:
area-Infrastructure
Milestone:-
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 5, 2024

Closed


This was referenced Feb 6, 2024

Closed


Open


Closed


This was referenced Feb 6, 2024

Closed


Closed


Open


Closed


Closed

@LoopedBard3
LoopedBard3
marked this pull request as ready for review
February 6, 2024 18:11
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 6, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies
765e047
... necessary for dotnet/runtime#98006
@ViktorHoferViktorHofer
mentioned this pull request
Feb 6, 2024
 Merged

@ViktorHofer
ViktorHofer
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Needs dotnet/source-build-assets#885 -> #98090
@ViktorHoferViktorHofer
mentioned this pull request
Feb 7, 2024
 Closed

ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 7, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies (#885)
a739c05
* Add MSBuild 17.8.3 + dependencies
... necessary for dotnet/runtime#98006
* Add manual pragma warning disable as in dotnet/runtime
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
@ericstj@rainersigwald MSBuild exposes the internal type Microsoft.Build.Framework.IMetadataContainer in the Microsoft.Build.Framework reference assembly (from the NuGet package) but SBRP doesn't expose that because it's internal.
Why is internal type required? Its omission causes the build failures in this PR.
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 7, 2024

Open

3 tasks
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Looks like this introduced the interface: dotnet/msbuild@f69319c
I suspect we're mixing assemblies here. Looks like we have TaskItem that claims it implements internal interface IMetadataContainer, but then we have a reference package for Microsoft.Build.Framework without IMetadataContainer. Looks like the compiler needs to resolve (all) interfaces whenever you cast from contrete type to interface.
Can we fix this by making sure we reference all live or all SBRP packages and not a mix? IIUC The interface lives in Microsoft.Build.Framework and the consumer is in Microsoft.Build.Utilities.
Update: we don't seem to be mixing assemblies. I see the following in the binlog.
image

I'm at a loss for how Microsoft.Build.Utilities.Core got a reference to IMetadataContainer if they were all built from SBRP.
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Oh, maybe it's because we don't actually have a 17.8.3 in SBRP so it pulled the real one. That explains it. https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/microsoft.build.utilities.core
Looks like we have a consistent set for 17.4.0, but not 17.8.3
image
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Hmm I wonder why the source-build flag doesn't report Microsoft.Build.Utilties.Core and Microsoft.Build.Tasks.Core 17.8.3 as new prebuilts. cc @dotnet/source-build-internal
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
@MichaelSimons
MichaelSimons
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
Yes - prebuilt detection only runs upon a successful build.
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024

Closed

@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Filed dotnet/source-build#4103 for prebuilt detection not running for failing builds.
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
323b156
Required for dotnet/runtime#98006
Follow-up on #885
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024
 Merged

MichaelSimons pushed a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.…
6b94d15
…8.3 (#886)
* Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
Required for dotnet/runtime#98006
Follow-up on #885
* Update unrelated files
* Manual change because of attribute filtering by GenAPI
* Remove dependency from nuspec as well
@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Needs #98178
@ViktorHofer
ViktorHofer
merged commit 0976796
into
dotnet:mainFeb 8, 2024
@LoopedBard3
LoopedBard3
deleted the

UpdateSystemSecurityCryptographyXml

branch
February 8, 2024 23:49
@steveisok
steveisok
commented
Feb 20, 2024

Copy link


Copy Markdown

Member
@LoopedBard3@ViktorHofer looks like we need to backport this to release/8.0, 7.0, and 6.0.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 22, 2024
@ericstj
ericstj
commented
Apr 3, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0
@github-actions
github-actionsBot
commented
Apr 3, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/8542745559
@github-actionsgithub-actionsBot
unlocked this conversation
Apr 3, 2024
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees

@LoopedBard3LoopedBard3

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LoopedBard3@ViktorHofer@ericstj@MichaelSimons@steveisok

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Update MicrosoftBuildVersion to latest - #98006
Merged
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Feb 8, 2024
Merged
Update MicrosoftBuildVersion to latest#98006
ViktorHofer merged 7 commits into
dotnet:mainfrom 
LoopedBard3:UpdateSystemSecurityCryptographyXml
Conversation
@LoopedBard3
@LoopedBard3LoopedBard3
commented
Feb 5, 2024

Copy link


Copy Markdown

Member
Update MicrosoftBuildVersion to latest to fix a component governance alert.
@LoopedBard3LoopedBard3
self-assigned this
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Update MicrosoftBuildVersion to latest to fix a component governance alert.
Author:LoopedBard3
Assignees:LoopedBard3
Labels:
area-Infrastructure
Milestone:-
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 5, 2024

Closed


This was referenced Feb 6, 2024

Closed


Open


Closed


This was referenced Feb 6, 2024

Closed


Closed


Open


Closed


Closed

@LoopedBard3
LoopedBard3
marked this pull request as ready for review
February 6, 2024 18:11
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 6, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies
765e047
... necessary for dotnet/runtime#98006
@ViktorHoferViktorHofer
mentioned this pull request
Feb 6, 2024
 Merged

@ViktorHofer
ViktorHofer
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Needs dotnet/source-build-assets#885 -> #98090
@ViktorHoferViktorHofer
mentioned this pull request
Feb 7, 2024
 Closed

ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 7, 2024
@ViktorHofer
Add MSBuild 17.8.3 + dependencies (#885)
a739c05
* Add MSBuild 17.8.3 + dependencies
... necessary for dotnet/runtime#98006
* Add manual pragma warning disable as in dotnet/runtime
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
@ericstj@rainersigwald MSBuild exposes the internal type Microsoft.Build.Framework.IMetadataContainer in the Microsoft.Build.Framework reference assembly (from the NuGet package) but SBRP doesn't expose that because it's internal.
Why is internal type required? Its omission causes the build failures in this PR.
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 7, 2024

Open

3 tasks
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Looks like this introduced the interface: dotnet/msbuild@f69319c
I suspect we're mixing assemblies here. Looks like we have TaskItem that claims it implements internal interface IMetadataContainer, but then we have a reference package for Microsoft.Build.Framework without IMetadataContainer. Looks like the compiler needs to resolve (all) interfaces whenever you cast from contrete type to interface.
Can we fix this by making sure we reference all live or all SBRP packages and not a mix? IIUC The interface lives in Microsoft.Build.Framework and the consumer is in Microsoft.Build.Utilities.
Update: we don't seem to be mixing assemblies. I see the following in the binlog.
image

I'm at a loss for how Microsoft.Build.Utilities.Core got a reference to IMetadataContainer if they were all built from SBRP.
@ericstj
ericstj
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Oh, maybe it's because we don't actually have a 17.8.3 in SBRP so it pulled the real one. That explains it. https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/microsoft.build.utilities.core
Looks like we have a consistent set for 17.4.0, but not 17.8.3
image
@ViktorHofer
ViktorHofer
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Hmm I wonder why the source-build flag doesn't report Microsoft.Build.Utilties.Core and Microsoft.Build.Tasks.Core 17.8.3 as new prebuilts. cc @dotnet/source-build-internal
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
@MichaelSimons
MichaelSimons
commented
Feb 7, 2024

Copy link


Copy Markdown

Member
Maybe because the build failed? I wonder if the prebuilt analysis should always run. It only needs project.assets.json so only the restore needs to succeed, right?
Yes - prebuilt detection only runs upon a successful build.
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024

Closed

@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Filed dotnet/source-build#4103 for prebuilt detection not running for failing builds.
ViktorHofer added a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
323b156
Required for dotnet/runtime#98006
Follow-up on #885
@ViktorHoferViktorHofer
mentioned this pull request
Feb 8, 2024
 Merged

MichaelSimons pushed a commit
to dotnet/source-build-assets
that referenced
this pull request
Feb 8, 2024
@ViktorHofer
Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.…
6b94d15
…8.3 (#886)
* Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3
Required for dotnet/runtime#98006
Follow-up on #885
* Update unrelated files
* Manual change because of attribute filtering by GenAPI
* Remove dependency from nuspec as well
@ViktorHofer
ViktorHofer
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
Needs #98178
@ViktorHofer
ViktorHofer
merged commit 0976796
into
dotnet:mainFeb 8, 2024
@LoopedBard3
LoopedBard3
deleted the

UpdateSystemSecurityCryptographyXml

branch
February 8, 2024 23:49
@steveisok
steveisok
commented
Feb 20, 2024

Copy link


Copy Markdown

Member
@LoopedBard3@ViktorHofer looks like we need to backport this to release/8.0, 7.0, and 6.0.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 22, 2024
@ericstj
ericstj
commented
Apr 3, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0
@github-actions
github-actionsBot
commented
Apr 3, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/8542745559
@github-actionsgithub-actionsBot
unlocked this conversation
Apr 3, 2024
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees

@LoopedBard3LoopedBard3

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LoopedBard3@ViktorHofer@ericstj@MichaelSimons@steveisok