Change stack size on all desktop platforms to at least 1.5MB - #98007

Merged
jkotas merged 21 commits into
dotnet:mainfrom
hamarb123:main8
Feb 12, 2024
Merged

Change stack size on all desktop platforms to at least 1.5MB#98007
jkotas merged 21 commits into
dotnet:mainfrom
hamarb123:main8

Conversation

@hamarb123

@hamarb123hamarb123 commented Feb 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#87879
Fixes#2084
Fixes#1417

Changes the stack size on desktop platforms to a certain minimum.

Specific changes we've landed on:

  • macOS secondary thread stack size is upped to match Windows thread size at 1.5MB (and other Apple platforms, mono was already 2MB for these since they're all 64-bit)
  • Windows NAOT is upped to the standard 1.5MB
  • Allow IlcDefaultStackSize to be used to specify the stack size for NAOT on all platforms

Plan:

  • Change stack size on all 64-bit desktop platforms to 4MB and add tests
  • Make sure tests all run
  • Make sure tests all pass
  • Remove API changes
  • Determine if we want to keep it at 4MB, and if not, reduce it, also determine if we want to change 32-bit platforms too
  • Re-enable any tests previously disabled due to stack size

(Already reverted) Note: I've currently made some changes to System.Reflection.Metadata's API, I don't plan to keep these - I had noticed that NAOT seemed to only be giving 1MB on Windows though when I built it a test console app, so I am seeing if it fixes that before doing a more proper fix.

@hamarb123
Change stack size
c02fb4d
- Change stack size to 4MB on 64-bit desktop
- Add tests to check stack size
@ghostghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation labels Feb 5, 2024
@ghost

ghost commented Feb 5, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@hamarb123
hamarb123 marked this pull request as draft February 5, 2024 23:06
This was referenced Feb 6, 2024
Closed
Closed
@hamarb123

hamarb123 commented Feb 6, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

(force push & empty commit were to workaround #98009)
(edit: it didn't work lol)

@jkotas

jkotas commented Feb 6, 2024

Copy link
Copy Markdown
Member

As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.

@jkotas
jkotas requested a review from janvorliFebruary 6, 2024 00:59
@jkotasjkotas added area-VM-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 6, 2024
This was referenced Feb 6, 2024
Closed
Closed
@hamarb123
Change tests and fix for NAOT
a473b2a
- Fix test definition
- Fix NAOT apps stack size
- Add `<UseAppHost>false</UseAppHost>` version of non-NAOT tests
@hamarb123
Fix tests
8c235d9
- Pre-emptively move second test project to a seperate folder to avoid build issues
@hamarb123
Move UseAppHost=false test to another folder
48b0a2a
This was referenced Feb 6, 2024
Closed
Open
@hamarb123

hamarb123 commented Feb 6, 2024

Copy link
Copy Markdown
ContributorAuthor

@janvorli what are your thoughts on the stack sizes we should change? I currently have them all at 4MB for 64-bit desktop platforms, but this is mainly for testing (not that I would complain if we ended up on this number 😆). Would you be happy with 2MB for all desktop platforms?

As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.

@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB). I think it is a good middle ground, and should be enough to account for the ever-expanding usage of the stack that I mentioned in #87879 (comment) for the time being (and we could obviously re-visit it in the future if we wanted to increase it again).

@hamarb123

hamarb123 commented Feb 6, 2024

Copy link
Copy Markdown
ContributorAuthor

I've found these 3 disabled tests due to macOS stack size, are there any others which I should re-enable with this fixed?

@jkotas

jkotas commented Feb 6, 2024

Copy link
Copy Markdown
Member

@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB

I don't see a good reason for changing the Windows stacksize. We would need to file a breaking change notice for it and it would be hard to come up with a good justification.

@hamarb123
hamarb123 marked this pull request as ready for review February 7, 2024 08:03
hamarb123
hamarb123 commented Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj Outdated
@runfoapprunfoappBot mentioned this pull request Feb 7, 2024
Open
jkotas
jkotas reviewed Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879/test87879.csproj Outdated
jkotas
jkotas reviewed Feb 7, 2024
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_threading.c Outdated
jkotas
jkotas reviewed Feb 8, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj Outdated
@build-analysisbuild-analysisBot mentioned this pull request Feb 8, 2024
Closed
@hamarb123
hamarb123 requested a review from jkotasFebruary 9, 2024 20:45
This was referenced Feb 9, 2024
Closed
Closed
jkotas
jkotas reviewed Feb 10, 2024
View reviewed changes
Comment threadsrc/tests/nativeaot/DesktopStackSize/DesktopStackSize.cs Outdated
jkotas
jkotas approved these changes Feb 10, 2024
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you!

@hamarb123
Apply feedback
3cf73dc
- Remove the NAOT specific test, since NAOT runs for the main test also
@jkotas

jkotas commented Feb 10, 2024

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines

azure-pipelinesBot commented Feb 10, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@hamarb123

hamarb123 commented Feb 10, 2024

Copy link
Copy Markdown
ContributorAuthor

Should runtime-extra-platforms be run also @jkotas? (I can't run it, but I would think it makes sense, right?)

@jkotas

jkotas commented Feb 12, 2024

Copy link
Copy Markdown
Member

I just wanted to double check that the new test is running as part of runtime-nativeaot-outerloop (confirmed - it does).

jkotas
jkotas approved these changes Feb 12, 2024
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas
jkotas merged commit e5df956 into dotnet:mainFeb 12, 2024
@jkotasjkotas mentioned this pull request Feb 15, 2024
Closed
@jaredparjaredpar mentioned this pull request Mar 5, 2024
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rolfbjarnerolfbjarnerolfbjarne left review comments
@vitek-karasvitek-karasvitek-karas left review comments
@ivanpovazanivanpovazanivanpovazan left review comments
@jkotasjkotasjkotas approved these changes
@janvorlijanvorliAwaiting requested review from janvorli
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
+1 more reviewer
@MichalPetrykaMichalPetrykaMichalPetryka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-VM-coreclrcommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects

None yet

Milestone

No milestone

6 participants

@hamarb123@jkotas@rolfbjarne@vitek-karas@MichalPetryka@ivanpovazan
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Change stack size on all desktop platforms to at least 1.5MB - #98007
Merged
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Feb 12, 2024
Merged
Change stack size on all desktop platforms to at least 1.5MB#98007
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Conversation
@hamarb123
@hamarb123hamarb123
commented
Feb 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#87879
Fixes#2084
Fixes#1417
Changes the stack size on desktop platforms to a certain minimum.
Specific changes we've landed on:
  • macOS secondary thread stack size is upped to match Windows thread size at 1.5MB (and other Apple platforms, mono was already 2MB for these since they're all 64-bit)
  • Windows NAOT is upped to the standard 1.5MB
  • Allow IlcDefaultStackSize to be used to specify the stack size for NAOT on all platforms
Plan:
  •  Change stack size on all 64-bit desktop platforms to 4MB and add tests
  •  Make sure tests all run
  •  Make sure tests all pass
  •  Remove API changes
  •  Determine if we want to keep it at 4MB, and if not, reduce it, also determine if we want to change 32-bit platforms too
  •  Re-enable any tests previously disabled due to stack size
(Already reverted) Note: I've currently made some changes to System.Reflection.Metadata's API, I don't plan to keep these - I had noticed that NAOT seemed to only be giving 1MB on Windows though when I built it a test console app, so I am seeing if it fixes that before doing a more proper fix.
@hamarb123
Change stack size
c02fb4d
- Change stack size to 4MB on 64-bit desktop
- Add tests to check stack size
@ghostghost
added

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
community-contribution
Indicates that the PR has been added by a community member
new-api-needs-documentation

labels
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@hamarb123
hamarb123
marked this pull request as draft
February 5, 2024 23:06

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
hamarb123
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
(force push & empty commit were to workaround #98009)

(edit: it didn't work lol)
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas
jkotas
requested a review
from janvorliFebruary 6, 2024 00:59
@jkotasjkotas
added

area-VM-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Feb 6, 2024

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
Change tests and fix for NAOT
a473b2a
- Fix test definition
- Fix NAOT apps stack size
- Add `<UseAppHost>false</UseAppHost>` version of non-NAOT tests
@hamarb123
Fix tests
8c235d9
- Pre-emptively move second test project to a seperate folder to avoid build issues
@hamarb123
Move UseAppHost=false test to another folder
48b0a2a

This was referenced Feb 6, 2024

Closed


Open

@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
@janvorli what are your thoughts on the stack sizes we should change? I currently have them all at 4MB for 64-bit desktop platforms, but this is mainly for testing (not that I would complain if we ended up on this number 😆). Would you be happy with 2MB for all desktop platforms?
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB). I think it is a good middle ground, and should be enough to account for the ever-expanding usage of the stack that I mentioned in #87879 (comment) for the time being (and we could obviously re-visit it in the future if we wanted to increase it again).
@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
I've found these 3 disabled tests due to macOS stack size, are there any others which I should re-enable with this fixed?
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB
I don't see a good reason for changing the Windows stacksize. We would need to file a breaking change notice for it and it would be hard to come up with a good justification.
@hamarb123
hamarb123
marked this pull request as ready for review
February 7, 2024 08:03
hamarb123
hamarb123
commented
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@runfoapprunfoappBot
mentioned this pull request
Feb 7, 2024

Open

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879/test87879.csproj
Outdated

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_threading.c
Outdated

jkotas
jkotas
reviewed
Feb 8, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 8, 2024

Closed

@hamarb123
hamarb123
requested a review
from jkotasFebruary 9, 2024 20:45

This was referenced Feb 9, 2024

Closed


Closed

jkotas
jkotas
reviewed
Feb 10, 2024
View reviewed changes
Comment threadsrc/tests/nativeaot/DesktopStackSize/DesktopStackSize.cs
Outdated

jkotas
jkotas
approved these changes
Feb 10, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you!
@hamarb123
Apply feedback
3cf73dc
- Remove the NAOT specific test, since NAOT runs for the main test also
@jkotas
jkotas
commented
Feb 10, 2024

Copy link


Copy Markdown

Member
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Feb 10, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@hamarb123
hamarb123
commented
Feb 10, 2024

Copy link


Copy Markdown

ContributorAuthor
Should runtime-extra-platforms be run also @jkotas? (I can't run it, but I would think it makes sense, right?)
@jkotas
jkotas
commented
Feb 12, 2024

Copy link


Copy Markdown

Member
I just wanted to double check that the new test is running as part of runtime-nativeaot-outerloop (confirmed - it does).
jkotas
jkotas
approved these changes
Feb 12, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
merged commit e5df956
into
dotnet:mainFeb 12, 2024
@jkotasjkotas
mentioned this pull request
Feb 15, 2024

Closed

@jaredparjaredpar
mentioned this pull request
Mar 5, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rolfbjarnerolfbjarnerolfbjarne left review comments
@vitek-karasvitek-karasvitek-karas left review comments
@ivanpovazanivanpovazanivanpovazan left review comments
@jkotasjkotasjkotas approved these changes
@janvorlijanvorliAwaiting requested review from janvorli
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@MichalPetrykaMichalPetrykaMichalPetryka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-VM-coreclrcommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone


No milestone


6 participants

@hamarb123@jkotas@rolfbjarne@vitek-karas@MichalPetryka@ivanpovazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Change stack size on all desktop platforms to at least 1.5MB - #98007
Merged
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Feb 12, 2024
Merged
Change stack size on all desktop platforms to at least 1.5MB#98007
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Conversation
@hamarb123
@hamarb123hamarb123
commented
Feb 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#87879
Fixes#2084
Fixes#1417
Changes the stack size on desktop platforms to a certain minimum.
Specific changes we've landed on:
  • macOS secondary thread stack size is upped to match Windows thread size at 1.5MB (and other Apple platforms, mono was already 2MB for these since they're all 64-bit)
  • Windows NAOT is upped to the standard 1.5MB
  • Allow IlcDefaultStackSize to be used to specify the stack size for NAOT on all platforms
Plan:
  •  Change stack size on all 64-bit desktop platforms to 4MB and add tests
  •  Make sure tests all run
  •  Make sure tests all pass
  •  Remove API changes
  •  Determine if we want to keep it at 4MB, and if not, reduce it, also determine if we want to change 32-bit platforms too
  •  Re-enable any tests previously disabled due to stack size
(Already reverted) Note: I've currently made some changes to System.Reflection.Metadata's API, I don't plan to keep these - I had noticed that NAOT seemed to only be giving 1MB on Windows though when I built it a test console app, so I am seeing if it fixes that before doing a more proper fix.
@hamarb123
Change stack size
c02fb4d
- Change stack size to 4MB on 64-bit desktop
- Add tests to check stack size
@ghostghost
added

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
community-contribution
Indicates that the PR has been added by a community member
new-api-needs-documentation

labels
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@hamarb123
hamarb123
marked this pull request as draft
February 5, 2024 23:06

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
hamarb123
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
(force push & empty commit were to workaround #98009)

(edit: it didn't work lol)
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas
jkotas
requested a review
from janvorliFebruary 6, 2024 00:59
@jkotasjkotas
added

area-VM-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Feb 6, 2024

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
Change tests and fix for NAOT
a473b2a
- Fix test definition
- Fix NAOT apps stack size
- Add `<UseAppHost>false</UseAppHost>` version of non-NAOT tests
@hamarb123
Fix tests
8c235d9
- Pre-emptively move second test project to a seperate folder to avoid build issues
@hamarb123
Move UseAppHost=false test to another folder
48b0a2a

This was referenced Feb 6, 2024

Closed


Open

@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
@janvorli what are your thoughts on the stack sizes we should change? I currently have them all at 4MB for 64-bit desktop platforms, but this is mainly for testing (not that I would complain if we ended up on this number 😆). Would you be happy with 2MB for all desktop platforms?
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB). I think it is a good middle ground, and should be enough to account for the ever-expanding usage of the stack that I mentioned in #87879 (comment) for the time being (and we could obviously re-visit it in the future if we wanted to increase it again).
@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
I've found these 3 disabled tests due to macOS stack size, are there any others which I should re-enable with this fixed?
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB
I don't see a good reason for changing the Windows stacksize. We would need to file a breaking change notice for it and it would be hard to come up with a good justification.
@hamarb123
hamarb123
marked this pull request as ready for review
February 7, 2024 08:03
hamarb123
hamarb123
commented
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@runfoapprunfoappBot
mentioned this pull request
Feb 7, 2024

Open

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879/test87879.csproj
Outdated

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_threading.c
Outdated

jkotas
jkotas
reviewed
Feb 8, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 8, 2024

Closed

@hamarb123
hamarb123
requested a review
from jkotasFebruary 9, 2024 20:45

This was referenced Feb 9, 2024

Closed


Closed

jkotas
jkotas
reviewed
Feb 10, 2024
View reviewed changes
Comment threadsrc/tests/nativeaot/DesktopStackSize/DesktopStackSize.cs
Outdated

jkotas
jkotas
approved these changes
Feb 10, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you!
@hamarb123
Apply feedback
3cf73dc
- Remove the NAOT specific test, since NAOT runs for the main test also
@jkotas
jkotas
commented
Feb 10, 2024

Copy link


Copy Markdown

Member
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Feb 10, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@hamarb123
hamarb123
commented
Feb 10, 2024

Copy link


Copy Markdown

ContributorAuthor
Should runtime-extra-platforms be run also @jkotas? (I can't run it, but I would think it makes sense, right?)
@jkotas
jkotas
commented
Feb 12, 2024

Copy link


Copy Markdown

Member
I just wanted to double check that the new test is running as part of runtime-nativeaot-outerloop (confirmed - it does).
jkotas
jkotas
approved these changes
Feb 12, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
merged commit e5df956
into
dotnet:mainFeb 12, 2024
@jkotasjkotas
mentioned this pull request
Feb 15, 2024

Closed

@jaredparjaredpar
mentioned this pull request
Mar 5, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rolfbjarnerolfbjarnerolfbjarne left review comments
@vitek-karasvitek-karasvitek-karas left review comments
@ivanpovazanivanpovazanivanpovazan left review comments
@jkotasjkotasjkotas approved these changes
@janvorlijanvorliAwaiting requested review from janvorli
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@MichalPetrykaMichalPetrykaMichalPetryka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-VM-coreclrcommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone


No milestone


6 participants

@hamarb123@jkotas@rolfbjarne@vitek-karas@MichalPetryka@ivanpovazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Change stack size on all desktop platforms to at least 1.5MB - #98007
Merged
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Feb 12, 2024
Merged
Change stack size on all desktop platforms to at least 1.5MB#98007
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Conversation
@hamarb123
@hamarb123hamarb123
commented
Feb 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#87879
Fixes#2084
Fixes#1417
Changes the stack size on desktop platforms to a certain minimum.
Specific changes we've landed on:
  • macOS secondary thread stack size is upped to match Windows thread size at 1.5MB (and other Apple platforms, mono was already 2MB for these since they're all 64-bit)
  • Windows NAOT is upped to the standard 1.5MB
  • Allow IlcDefaultStackSize to be used to specify the stack size for NAOT on all platforms
Plan:
  •  Change stack size on all 64-bit desktop platforms to 4MB and add tests
  •  Make sure tests all run
  •  Make sure tests all pass
  •  Remove API changes
  •  Determine if we want to keep it at 4MB, and if not, reduce it, also determine if we want to change 32-bit platforms too
  •  Re-enable any tests previously disabled due to stack size
(Already reverted) Note: I've currently made some changes to System.Reflection.Metadata's API, I don't plan to keep these - I had noticed that NAOT seemed to only be giving 1MB on Windows though when I built it a test console app, so I am seeing if it fixes that before doing a more proper fix.
@hamarb123
Change stack size
c02fb4d
- Change stack size to 4MB on 64-bit desktop
- Add tests to check stack size
@ghostghost
added

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
community-contribution
Indicates that the PR has been added by a community member
new-api-needs-documentation

labels
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@hamarb123
hamarb123
marked this pull request as draft
February 5, 2024 23:06

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
hamarb123
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
(force push & empty commit were to workaround #98009)

(edit: it didn't work lol)
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas
jkotas
requested a review
from janvorliFebruary 6, 2024 00:59
@jkotasjkotas
added

area-VM-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Feb 6, 2024

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
Change tests and fix for NAOT
a473b2a
- Fix test definition
- Fix NAOT apps stack size
- Add `<UseAppHost>false</UseAppHost>` version of non-NAOT tests
@hamarb123
Fix tests
8c235d9
- Pre-emptively move second test project to a seperate folder to avoid build issues
@hamarb123
Move UseAppHost=false test to another folder
48b0a2a

This was referenced Feb 6, 2024

Closed


Open

@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
@janvorli what are your thoughts on the stack sizes we should change? I currently have them all at 4MB for 64-bit desktop platforms, but this is mainly for testing (not that I would complain if we ended up on this number 😆). Would you be happy with 2MB for all desktop platforms?
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB). I think it is a good middle ground, and should be enough to account for the ever-expanding usage of the stack that I mentioned in #87879 (comment) for the time being (and we could obviously re-visit it in the future if we wanted to increase it again).
@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
I've found these 3 disabled tests due to macOS stack size, are there any others which I should re-enable with this fixed?
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB
I don't see a good reason for changing the Windows stacksize. We would need to file a breaking change notice for it and it would be hard to come up with a good justification.
@hamarb123
hamarb123
marked this pull request as ready for review
February 7, 2024 08:03
hamarb123
hamarb123
commented
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@runfoapprunfoappBot
mentioned this pull request
Feb 7, 2024

Open

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879/test87879.csproj
Outdated

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_threading.c
Outdated

jkotas
jkotas
reviewed
Feb 8, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 8, 2024

Closed

@hamarb123
hamarb123
requested a review
from jkotasFebruary 9, 2024 20:45

This was referenced Feb 9, 2024

Closed


Closed

jkotas
jkotas
reviewed
Feb 10, 2024
View reviewed changes
Comment threadsrc/tests/nativeaot/DesktopStackSize/DesktopStackSize.cs
Outdated

jkotas
jkotas
approved these changes
Feb 10, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you!
@hamarb123
Apply feedback
3cf73dc
- Remove the NAOT specific test, since NAOT runs for the main test also
@jkotas
jkotas
commented
Feb 10, 2024

Copy link


Copy Markdown

Member
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Feb 10, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@hamarb123
hamarb123
commented
Feb 10, 2024

Copy link


Copy Markdown

ContributorAuthor
Should runtime-extra-platforms be run also @jkotas? (I can't run it, but I would think it makes sense, right?)
@jkotas
jkotas
commented
Feb 12, 2024

Copy link


Copy Markdown

Member
I just wanted to double check that the new test is running as part of runtime-nativeaot-outerloop (confirmed - it does).
jkotas
jkotas
approved these changes
Feb 12, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
merged commit e5df956
into
dotnet:mainFeb 12, 2024
@jkotasjkotas
mentioned this pull request
Feb 15, 2024

Closed

@jaredparjaredpar
mentioned this pull request
Mar 5, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rolfbjarnerolfbjarnerolfbjarne left review comments
@vitek-karasvitek-karasvitek-karas left review comments
@ivanpovazanivanpovazanivanpovazan left review comments
@jkotasjkotasjkotas approved these changes
@janvorlijanvorliAwaiting requested review from janvorli
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@MichalPetrykaMichalPetrykaMichalPetryka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-VM-coreclrcommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone


No milestone


6 participants

@hamarb123@jkotas@rolfbjarne@vitek-karas@MichalPetryka@ivanpovazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Change stack size on all desktop platforms to at least 1.5MB - #98007
Merged
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Feb 12, 2024
Merged
Change stack size on all desktop platforms to at least 1.5MB#98007
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Conversation
@hamarb123
@hamarb123hamarb123
commented
Feb 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#87879
Fixes#2084
Fixes#1417
Changes the stack size on desktop platforms to a certain minimum.
Specific changes we've landed on:
  • macOS secondary thread stack size is upped to match Windows thread size at 1.5MB (and other Apple platforms, mono was already 2MB for these since they're all 64-bit)
  • Windows NAOT is upped to the standard 1.5MB
  • Allow IlcDefaultStackSize to be used to specify the stack size for NAOT on all platforms
Plan:
  •  Change stack size on all 64-bit desktop platforms to 4MB and add tests
  •  Make sure tests all run
  •  Make sure tests all pass
  •  Remove API changes
  •  Determine if we want to keep it at 4MB, and if not, reduce it, also determine if we want to change 32-bit platforms too
  •  Re-enable any tests previously disabled due to stack size
(Already reverted) Note: I've currently made some changes to System.Reflection.Metadata's API, I don't plan to keep these - I had noticed that NAOT seemed to only be giving 1MB on Windows though when I built it a test console app, so I am seeing if it fixes that before doing a more proper fix.
@hamarb123
Change stack size
c02fb4d
- Change stack size to 4MB on 64-bit desktop
- Add tests to check stack size
@ghostghost
added

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
community-contribution
Indicates that the PR has been added by a community member
new-api-needs-documentation

labels
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@hamarb123
hamarb123
marked this pull request as draft
February 5, 2024 23:06

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
hamarb123
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
(force push & empty commit were to workaround #98009)

(edit: it didn't work lol)
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas
jkotas
requested a review
from janvorliFebruary 6, 2024 00:59
@jkotasjkotas
added

area-VM-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Feb 6, 2024

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
Change tests and fix for NAOT
a473b2a
- Fix test definition
- Fix NAOT apps stack size
- Add `<UseAppHost>false</UseAppHost>` version of non-NAOT tests
@hamarb123
Fix tests
8c235d9
- Pre-emptively move second test project to a seperate folder to avoid build issues
@hamarb123
Move UseAppHost=false test to another folder
48b0a2a

This was referenced Feb 6, 2024

Closed


Open

@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
@janvorli what are your thoughts on the stack sizes we should change? I currently have them all at 4MB for 64-bit desktop platforms, but this is mainly for testing (not that I would complain if we ended up on this number 😆). Would you be happy with 2MB for all desktop platforms?
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB). I think it is a good middle ground, and should be enough to account for the ever-expanding usage of the stack that I mentioned in #87879 (comment) for the time being (and we could obviously re-visit it in the future if we wanted to increase it again).
@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
I've found these 3 disabled tests due to macOS stack size, are there any others which I should re-enable with this fixed?
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB
I don't see a good reason for changing the Windows stacksize. We would need to file a breaking change notice for it and it would be hard to come up with a good justification.
@hamarb123
hamarb123
marked this pull request as ready for review
February 7, 2024 08:03
hamarb123
hamarb123
commented
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@runfoapprunfoappBot
mentioned this pull request
Feb 7, 2024

Open

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879/test87879.csproj
Outdated

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_threading.c
Outdated

jkotas
jkotas
reviewed
Feb 8, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 8, 2024

Closed

@hamarb123
hamarb123
requested a review
from jkotasFebruary 9, 2024 20:45

This was referenced Feb 9, 2024

Closed


Closed

jkotas
jkotas
reviewed
Feb 10, 2024
View reviewed changes
Comment threadsrc/tests/nativeaot/DesktopStackSize/DesktopStackSize.cs
Outdated

jkotas
jkotas
approved these changes
Feb 10, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you!
@hamarb123
Apply feedback
3cf73dc
- Remove the NAOT specific test, since NAOT runs for the main test also
@jkotas
jkotas
commented
Feb 10, 2024

Copy link


Copy Markdown

Member
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Feb 10, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@hamarb123
hamarb123
commented
Feb 10, 2024

Copy link


Copy Markdown

ContributorAuthor
Should runtime-extra-platforms be run also @jkotas? (I can't run it, but I would think it makes sense, right?)
@jkotas
jkotas
commented
Feb 12, 2024

Copy link


Copy Markdown

Member
I just wanted to double check that the new test is running as part of runtime-nativeaot-outerloop (confirmed - it does).
jkotas
jkotas
approved these changes
Feb 12, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
merged commit e5df956
into
dotnet:mainFeb 12, 2024
@jkotasjkotas
mentioned this pull request
Feb 15, 2024

Closed

@jaredparjaredpar
mentioned this pull request
Mar 5, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rolfbjarnerolfbjarnerolfbjarne left review comments
@vitek-karasvitek-karasvitek-karas left review comments
@ivanpovazanivanpovazanivanpovazan left review comments
@jkotasjkotasjkotas approved these changes
@janvorlijanvorliAwaiting requested review from janvorli
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@MichalPetrykaMichalPetrykaMichalPetryka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-VM-coreclrcommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone


No milestone


6 participants

@hamarb123@jkotas@rolfbjarne@vitek-karas@MichalPetryka@ivanpovazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Change stack size on all desktop platforms to at least 1.5MB - #98007
Merged
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Feb 12, 2024
Merged
Change stack size on all desktop platforms to at least 1.5MB#98007
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Conversation
@hamarb123
@hamarb123hamarb123
commented
Feb 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#87879
Fixes#2084
Fixes#1417
Changes the stack size on desktop platforms to a certain minimum.
Specific changes we've landed on:
  • macOS secondary thread stack size is upped to match Windows thread size at 1.5MB (and other Apple platforms, mono was already 2MB for these since they're all 64-bit)
  • Windows NAOT is upped to the standard 1.5MB
  • Allow IlcDefaultStackSize to be used to specify the stack size for NAOT on all platforms
Plan:
  •  Change stack size on all 64-bit desktop platforms to 4MB and add tests
  •  Make sure tests all run
  •  Make sure tests all pass
  •  Remove API changes
  •  Determine if we want to keep it at 4MB, and if not, reduce it, also determine if we want to change 32-bit platforms too
  •  Re-enable any tests previously disabled due to stack size
(Already reverted) Note: I've currently made some changes to System.Reflection.Metadata's API, I don't plan to keep these - I had noticed that NAOT seemed to only be giving 1MB on Windows though when I built it a test console app, so I am seeing if it fixes that before doing a more proper fix.
@hamarb123
Change stack size
c02fb4d
- Change stack size to 4MB on 64-bit desktop
- Add tests to check stack size
@ghostghost
added

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
community-contribution
Indicates that the PR has been added by a community member
new-api-needs-documentation

labels
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@hamarb123
hamarb123
marked this pull request as draft
February 5, 2024 23:06

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
hamarb123
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
(force push & empty commit were to workaround #98009)

(edit: it didn't work lol)
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas
jkotas
requested a review
from janvorliFebruary 6, 2024 00:59
@jkotasjkotas
added

area-VM-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Feb 6, 2024

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
Change tests and fix for NAOT
a473b2a
- Fix test definition
- Fix NAOT apps stack size
- Add `<UseAppHost>false</UseAppHost>` version of non-NAOT tests
@hamarb123
Fix tests
8c235d9
- Pre-emptively move second test project to a seperate folder to avoid build issues
@hamarb123
Move UseAppHost=false test to another folder
48b0a2a

This was referenced Feb 6, 2024

Closed


Open

@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
@janvorli what are your thoughts on the stack sizes we should change? I currently have them all at 4MB for 64-bit desktop platforms, but this is mainly for testing (not that I would complain if we ended up on this number 😆). Would you be happy with 2MB for all desktop platforms?
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB). I think it is a good middle ground, and should be enough to account for the ever-expanding usage of the stack that I mentioned in #87879 (comment) for the time being (and we could obviously re-visit it in the future if we wanted to increase it again).
@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
I've found these 3 disabled tests due to macOS stack size, are there any others which I should re-enable with this fixed?
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB
I don't see a good reason for changing the Windows stacksize. We would need to file a breaking change notice for it and it would be hard to come up with a good justification.
@hamarb123
hamarb123
marked this pull request as ready for review
February 7, 2024 08:03
hamarb123
hamarb123
commented
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@runfoapprunfoappBot
mentioned this pull request
Feb 7, 2024

Open

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879/test87879.csproj
Outdated

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_threading.c
Outdated

jkotas
jkotas
reviewed
Feb 8, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 8, 2024

Closed

@hamarb123
hamarb123
requested a review
from jkotasFebruary 9, 2024 20:45

This was referenced Feb 9, 2024

Closed


Closed

jkotas
jkotas
reviewed
Feb 10, 2024
View reviewed changes
Comment threadsrc/tests/nativeaot/DesktopStackSize/DesktopStackSize.cs
Outdated

jkotas
jkotas
approved these changes
Feb 10, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you!
@hamarb123
Apply feedback
3cf73dc
- Remove the NAOT specific test, since NAOT runs for the main test also
@jkotas
jkotas
commented
Feb 10, 2024

Copy link


Copy Markdown

Member
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Feb 10, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@hamarb123
hamarb123
commented
Feb 10, 2024

Copy link


Copy Markdown

ContributorAuthor
Should runtime-extra-platforms be run also @jkotas? (I can't run it, but I would think it makes sense, right?)
@jkotas
jkotas
commented
Feb 12, 2024

Copy link


Copy Markdown

Member
I just wanted to double check that the new test is running as part of runtime-nativeaot-outerloop (confirmed - it does).
jkotas
jkotas
approved these changes
Feb 12, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
merged commit e5df956
into
dotnet:mainFeb 12, 2024
@jkotasjkotas
mentioned this pull request
Feb 15, 2024

Closed

@jaredparjaredpar
mentioned this pull request
Mar 5, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rolfbjarnerolfbjarnerolfbjarne left review comments
@vitek-karasvitek-karasvitek-karas left review comments
@ivanpovazanivanpovazanivanpovazan left review comments
@jkotasjkotasjkotas approved these changes
@janvorlijanvorliAwaiting requested review from janvorli
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@MichalPetrykaMichalPetrykaMichalPetryka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-VM-coreclrcommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone


No milestone


6 participants

@hamarb123@jkotas@rolfbjarne@vitek-karas@MichalPetryka@ivanpovazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Change stack size on all desktop platforms to at least 1.5MB - #98007
Merged
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Feb 12, 2024
Merged
Change stack size on all desktop platforms to at least 1.5MB#98007
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Conversation
@hamarb123
@hamarb123hamarb123
commented
Feb 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#87879
Fixes#2084
Fixes#1417
Changes the stack size on desktop platforms to a certain minimum.
Specific changes we've landed on:
  • macOS secondary thread stack size is upped to match Windows thread size at 1.5MB (and other Apple platforms, mono was already 2MB for these since they're all 64-bit)
  • Windows NAOT is upped to the standard 1.5MB
  • Allow IlcDefaultStackSize to be used to specify the stack size for NAOT on all platforms
Plan:
  •  Change stack size on all 64-bit desktop platforms to 4MB and add tests
  •  Make sure tests all run
  •  Make sure tests all pass
  •  Remove API changes
  •  Determine if we want to keep it at 4MB, and if not, reduce it, also determine if we want to change 32-bit platforms too
  •  Re-enable any tests previously disabled due to stack size
(Already reverted) Note: I've currently made some changes to System.Reflection.Metadata's API, I don't plan to keep these - I had noticed that NAOT seemed to only be giving 1MB on Windows though when I built it a test console app, so I am seeing if it fixes that before doing a more proper fix.
@hamarb123
Change stack size
c02fb4d
- Change stack size to 4MB on 64-bit desktop
- Add tests to check stack size
@ghostghost
added

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
community-contribution
Indicates that the PR has been added by a community member
new-api-needs-documentation

labels
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@hamarb123
hamarb123
marked this pull request as draft
February 5, 2024 23:06

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
hamarb123
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
(force push & empty commit were to workaround #98009)

(edit: it didn't work lol)
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas
jkotas
requested a review
from janvorliFebruary 6, 2024 00:59
@jkotasjkotas
added

area-VM-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Feb 6, 2024

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
Change tests and fix for NAOT
a473b2a
- Fix test definition
- Fix NAOT apps stack size
- Add `<UseAppHost>false</UseAppHost>` version of non-NAOT tests
@hamarb123
Fix tests
8c235d9
- Pre-emptively move second test project to a seperate folder to avoid build issues
@hamarb123
Move UseAppHost=false test to another folder
48b0a2a

This was referenced Feb 6, 2024

Closed


Open

@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
@janvorli what are your thoughts on the stack sizes we should change? I currently have them all at 4MB for 64-bit desktop platforms, but this is mainly for testing (not that I would complain if we ended up on this number 😆). Would you be happy with 2MB for all desktop platforms?
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB). I think it is a good middle ground, and should be enough to account for the ever-expanding usage of the stack that I mentioned in #87879 (comment) for the time being (and we could obviously re-visit it in the future if we wanted to increase it again).
@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
I've found these 3 disabled tests due to macOS stack size, are there any others which I should re-enable with this fixed?
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB
I don't see a good reason for changing the Windows stacksize. We would need to file a breaking change notice for it and it would be hard to come up with a good justification.
@hamarb123
hamarb123
marked this pull request as ready for review
February 7, 2024 08:03
hamarb123
hamarb123
commented
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@runfoapprunfoappBot
mentioned this pull request
Feb 7, 2024

Open

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879/test87879.csproj
Outdated

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_threading.c
Outdated

jkotas
jkotas
reviewed
Feb 8, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 8, 2024

Closed

@hamarb123
hamarb123
requested a review
from jkotasFebruary 9, 2024 20:45

This was referenced Feb 9, 2024

Closed


Closed

jkotas
jkotas
reviewed
Feb 10, 2024
View reviewed changes
Comment threadsrc/tests/nativeaot/DesktopStackSize/DesktopStackSize.cs
Outdated

jkotas
jkotas
approved these changes
Feb 10, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you!
@hamarb123
Apply feedback
3cf73dc
- Remove the NAOT specific test, since NAOT runs for the main test also
@jkotas
jkotas
commented
Feb 10, 2024

Copy link


Copy Markdown

Member
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Feb 10, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@hamarb123
hamarb123
commented
Feb 10, 2024

Copy link


Copy Markdown

ContributorAuthor
Should runtime-extra-platforms be run also @jkotas? (I can't run it, but I would think it makes sense, right?)
@jkotas
jkotas
commented
Feb 12, 2024

Copy link


Copy Markdown

Member
I just wanted to double check that the new test is running as part of runtime-nativeaot-outerloop (confirmed - it does).
jkotas
jkotas
approved these changes
Feb 12, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
merged commit e5df956
into
dotnet:mainFeb 12, 2024
@jkotasjkotas
mentioned this pull request
Feb 15, 2024

Closed

@jaredparjaredpar
mentioned this pull request
Mar 5, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rolfbjarnerolfbjarnerolfbjarne left review comments
@vitek-karasvitek-karasvitek-karas left review comments
@ivanpovazanivanpovazanivanpovazan left review comments
@jkotasjkotasjkotas approved these changes
@janvorlijanvorliAwaiting requested review from janvorli
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@MichalPetrykaMichalPetrykaMichalPetryka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-VM-coreclrcommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone


No milestone


6 participants

@hamarb123@jkotas@rolfbjarne@vitek-karas@MichalPetryka@ivanpovazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Change stack size on all desktop platforms to at least 1.5MB - #98007
Merged
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Feb 12, 2024
Merged
Change stack size on all desktop platforms to at least 1.5MB#98007
jkotas merged 21 commits into
dotnet:mainfrom 
hamarb123:main8
Conversation
@hamarb123
@hamarb123hamarb123
commented
Feb 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#87879
Fixes#2084
Fixes#1417
Changes the stack size on desktop platforms to a certain minimum.
Specific changes we've landed on:
  • macOS secondary thread stack size is upped to match Windows thread size at 1.5MB (and other Apple platforms, mono was already 2MB for these since they're all 64-bit)
  • Windows NAOT is upped to the standard 1.5MB
  • Allow IlcDefaultStackSize to be used to specify the stack size for NAOT on all platforms
Plan:
  •  Change stack size on all 64-bit desktop platforms to 4MB and add tests
  •  Make sure tests all run
  •  Make sure tests all pass
  •  Remove API changes
  •  Determine if we want to keep it at 4MB, and if not, reduce it, also determine if we want to change 32-bit platforms too
  •  Re-enable any tests previously disabled due to stack size
(Already reverted) Note: I've currently made some changes to System.Reflection.Metadata's API, I don't plan to keep these - I had noticed that NAOT seemed to only be giving 1MB on Windows though when I built it a test console app, so I am seeing if it fixes that before doing a more proper fix.
@hamarb123
Change stack size
c02fb4d
- Change stack size to 4MB on 64-bit desktop
- Add tests to check stack size
@ghostghost
added

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
community-contribution
Indicates that the PR has been added by a community member
new-api-needs-documentation

labels
Feb 5, 2024
@ghost
ghost
commented
Feb 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@hamarb123
hamarb123
marked this pull request as draft
February 5, 2024 23:06

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
hamarb123
commented
Feb 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
(force push & empty commit were to workaround #98009)

(edit: it didn't work lol)
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas
jkotas
requested a review
from janvorliFebruary 6, 2024 00:59
@jkotasjkotas
added

area-VM-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Feb 6, 2024

This was referenced Feb 6, 2024

Closed


Closed

@hamarb123
Change tests and fix for NAOT
a473b2a
- Fix test definition
- Fix NAOT apps stack size
- Add `<UseAppHost>false</UseAppHost>` version of non-NAOT tests
@hamarb123
Fix tests
8c235d9
- Pre-emptively move second test project to a seperate folder to avoid build issues
@hamarb123
Move UseAppHost=false test to another folder
48b0a2a

This was referenced Feb 6, 2024

Closed


Open

@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
@janvorli what are your thoughts on the stack sizes we should change? I currently have them all at 4MB for 64-bit desktop platforms, but this is mainly for testing (not that I would complain if we ended up on this number 😆). Would you be happy with 2MB for all desktop platforms?
As I have mentioned in #87879 (comment), I think that we should only fix macOS. Bumping the stack size on Windows is likely to introduce as many problems as it fixes.
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB). I think it is a good middle ground, and should be enough to account for the ever-expanding usage of the stack that I mentioned in #87879 (comment) for the time being (and we could obviously re-visit it in the future if we wanted to increase it again).
@hamarb123
hamarb123
commented
Feb 6, 2024

Copy link


Copy Markdown

ContributorAuthor
I've found these 3 disabled tests due to macOS stack size, are there any others which I should re-enable with this fixed?
@jkotas
jkotas
commented
Feb 6, 2024

Copy link


Copy Markdown

Member
@jkotas would you accept 2MB also? It is only marginally higher than the current Windows value (1.5MB
I don't see a good reason for changing the Windows stacksize. We would need to file a breaking change notice for it and it would be hard to come up with a good justification.
@hamarb123
hamarb123
marked this pull request as ready for review
February 7, 2024 08:03
hamarb123
hamarb123
commented
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@runfoapprunfoappBot
mentioned this pull request
Feb 7, 2024

Open

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879/test87879.csproj
Outdated

jkotas
jkotas
reviewed
Feb 7, 2024
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_threading.c
Outdated

jkotas
jkotas
reviewed
Feb 8, 2024
View reviewed changes
Comment threadsrc/tests/Regressions/coreclr/GitHub_87879_AppHost/test87879.csproj
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 8, 2024

Closed

@hamarb123
hamarb123
requested a review
from jkotasFebruary 9, 2024 20:45

This was referenced Feb 9, 2024

Closed


Closed

jkotas
jkotas
reviewed
Feb 10, 2024
View reviewed changes
Comment threadsrc/tests/nativeaot/DesktopStackSize/DesktopStackSize.cs
Outdated

jkotas
jkotas
approved these changes
Feb 10, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you!
@hamarb123
Apply feedback
3cf73dc
- Remove the NAOT specific test, since NAOT runs for the main test also
@jkotas
jkotas
commented
Feb 10, 2024

Copy link


Copy Markdown

Member
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Feb 10, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@hamarb123
hamarb123
commented
Feb 10, 2024

Copy link


Copy Markdown

ContributorAuthor
Should runtime-extra-platforms be run also @jkotas? (I can't run it, but I would think it makes sense, right?)
@jkotas
jkotas
commented
Feb 12, 2024

Copy link


Copy Markdown

Member
I just wanted to double check that the new test is running as part of runtime-nativeaot-outerloop (confirmed - it does).
jkotas
jkotas
approved these changes
Feb 12, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
merged commit e5df956
into
dotnet:mainFeb 12, 2024
@jkotasjkotas
mentioned this pull request
Feb 15, 2024

Closed

@jaredparjaredpar
mentioned this pull request
Mar 5, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Mar 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@rolfbjarnerolfbjarnerolfbjarne left review comments
@vitek-karasvitek-karasvitek-karas left review comments
@ivanpovazanivanpovazanivanpovazan left review comments
@jkotasjkotasjkotas approved these changes
@janvorlijanvorliAwaiting requested review from janvorli
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@MichalPetrykaMichalPetrykaMichalPetryka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-VM-coreclrcommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone


No milestone


6 participants

@hamarb123@jkotas@rolfbjarne@vitek-karas@MichalPetryka@ivanpovazan