Report unhandled exceptions/FailFast in event log by MichalStrehovsky · Pull Request #98152 · dotnet/runtime

MichalStrehovsky · 2024-02-08T12:18:32Z

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

ghost · 2024-02-08T12:18:37Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Author:	MichalStrehovsky
Assignees:	-
Labels:	`area-NativeAOT-coreclr`
Milestone:	-

Suchiman · 2024-02-08T12:33:10Z

+ _description.AppendLine("unknown");
+ }
+
+ _description.Append("CoreCLR Version: ");


CoreCLR?
Don't see a good enough reason to break people who parse this.

jkotas · 2024-02-08T13:01:47Z

+ if (exception != null && reason is not RhFailFastReason.AssertionFailure)
+ {
+ reporter.AddDescription($"{exception.GetType()}: {exception.Message}");
+ reporter.AddStackTrace(exception.StackTrace);


Computing the stack trace is a complicated operation and it is likely to crash again when things are corrupted. The existing console printing code is written in a way so that there is at least something printed to the console in this case, giving people clue what might have happened.

Moved it after writing to console.

jkotas · 2024-02-08T13:14:17Z

 // Maximum size for a string in event log entry
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768



Suggested change
// Maximum size for a string in event log entry
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768

jkotas · 2024-02-08T13:14:28Z

-// shorter in length. Hence, the change in size.
+// An event entry comprises of string to be written and event header information.
+// The total permissible length of the string and event header is 32K.
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842


Suggested change
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x7C62 // decimal 31842

jkotas · 2024-02-08T13:15:07Z

+ const int MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA = 0x7C62; // decimal 31842
+
+ // Continue to append to the buffer until we are full
+ if (!_bufferFull)
+ {
+ _description.AppendLine(s);
+
+ // Truncate the buffer if we have exceeded the limit based upon the OS we are on
+ if (_description.Length > MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
+ {
+ // Load the truncation message
+ string truncate = "\nThe remainder of the message was truncated.\n";
+
+ int truncCount = truncate.Length;
+
+ // Go back "truncCount" characters from the end of the string.
+ int ext = MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA - truncCount;


Suggested change
constintMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA-truncCount;
constintMAX_SIZE_EVENTLOG_ENTRY_STRING=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING-truncCount;

tommcdon · 2024-02-08T18:08:58Z

cc @Hoyos @mikem8361

jkotas

Thanks

MichalStrehovsky · 2024-02-08T12:18:32Z

Fixes#73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

ghost · 2024-02-08T12:18:37Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Author:	MichalStrehovsky
Assignees:	-
Labels:	`area-NativeAOT-coreclr`
Milestone:	-

Suchiman · 2024-02-08T12:33:10Z

+ _description.AppendLine("unknown");
+ }
+
+ _description.Append("CoreCLR Version: ");


CoreCLR?
Don't see a good enough reason to break people who parse this.

jkotas · 2024-02-08T13:01:47Z

+ if (exception != null && reason is not RhFailFastReason.AssertionFailure)
+ {
+ reporter.AddDescription($"{exception.GetType()}: {exception.Message}");
+ reporter.AddStackTrace(exception.StackTrace);


Computing the stack trace is a complicated operation and it is likely to crash again when things are corrupted. The existing console printing code is written in a way so that there is at least something printed to the console in this case, giving people clue what might have happened.

Moved it after writing to console.

jkotas · 2024-02-08T13:14:17Z

 // Maximum size for a string in event log entry
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768



Suggested change
// Maximum size for a string in event log entry
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768

jkotas · 2024-02-08T13:14:28Z

-// shorter in length. Hence, the change in size.
+// An event entry comprises of string to be written and event header information.
+// The total permissible length of the string and event header is 32K.
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842


Suggested change
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x7C62 // decimal 31842

jkotas · 2024-02-08T13:15:07Z

+ const int MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA = 0x7C62; // decimal 31842
+
+ // Continue to append to the buffer until we are full
+ if (!_bufferFull)
+ {
+ _description.AppendLine(s);
+
+ // Truncate the buffer if we have exceeded the limit based upon the OS we are on
+ if (_description.Length > MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
+ {
+ // Load the truncation message
+ string truncate = "\nThe remainder of the message was truncated.\n";
+
+ int truncCount = truncate.Length;
+
+ // Go back "truncCount" characters from the end of the string.
+ int ext = MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA - truncCount;


Suggested change
constintMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA-truncCount;
constintMAX_SIZE_EVENTLOG_ENTRY_STRING=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING-truncCount;

tommcdon · 2024-02-08T18:08:58Z

cc @Hoyos @mikem8361

jkotas

Thanks

MichalStrehovsky · 2024-02-08T12:18:32Z

Fixes#73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

ghost · 2024-02-08T12:18:37Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Author:	MichalStrehovsky
Assignees:	-
Labels:	`area-NativeAOT-coreclr`
Milestone:	-

Suchiman · 2024-02-08T12:33:10Z

+ _description.AppendLine("unknown");
+ }
+
+ _description.Append("CoreCLR Version: ");


CoreCLR?
Don't see a good enough reason to break people who parse this.

jkotas · 2024-02-08T13:01:47Z

+ if (exception != null && reason is not RhFailFastReason.AssertionFailure)
+ {
+ reporter.AddDescription($"{exception.GetType()}: {exception.Message}");
+ reporter.AddStackTrace(exception.StackTrace);


Computing the stack trace is a complicated operation and it is likely to crash again when things are corrupted. The existing console printing code is written in a way so that there is at least something printed to the console in this case, giving people clue what might have happened.

Moved it after writing to console.

jkotas · 2024-02-08T13:14:17Z

 // Maximum size for a string in event log entry
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768



Suggested change
// Maximum size for a string in event log entry
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768

jkotas · 2024-02-08T13:14:28Z

-// shorter in length. Hence, the change in size.
+// An event entry comprises of string to be written and event header information.
+// The total permissible length of the string and event header is 32K.
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842


Suggested change
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x7C62 // decimal 31842

jkotas · 2024-02-08T13:15:07Z

+ const int MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA = 0x7C62; // decimal 31842
+
+ // Continue to append to the buffer until we are full
+ if (!_bufferFull)
+ {
+ _description.AppendLine(s);
+
+ // Truncate the buffer if we have exceeded the limit based upon the OS we are on
+ if (_description.Length > MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
+ {
+ // Load the truncation message
+ string truncate = "\nThe remainder of the message was truncated.\n";
+
+ int truncCount = truncate.Length;
+
+ // Go back "truncCount" characters from the end of the string.
+ int ext = MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA - truncCount;


Suggested change
constintMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA-truncCount;
constintMAX_SIZE_EVENTLOG_ENTRY_STRING=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING-truncCount;

tommcdon · 2024-02-08T18:08:58Z

cc @Hoyos @mikem8361

jkotas

Thanks

MichalStrehovsky · 2024-02-08T12:18:32Z

Fixes#73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

ghost · 2024-02-08T12:18:37Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Author:	MichalStrehovsky
Assignees:	-
Labels:	`area-NativeAOT-coreclr`
Milestone:	-

Suchiman · 2024-02-08T12:33:10Z

+ _description.AppendLine("unknown");
+ }
+
+ _description.Append("CoreCLR Version: ");


CoreCLR?
Don't see a good enough reason to break people who parse this.

jkotas · 2024-02-08T13:01:47Z

+ if (exception != null && reason is not RhFailFastReason.AssertionFailure)
+ {
+ reporter.AddDescription($"{exception.GetType()}: {exception.Message}");
+ reporter.AddStackTrace(exception.StackTrace);


Computing the stack trace is a complicated operation and it is likely to crash again when things are corrupted. The existing console printing code is written in a way so that there is at least something printed to the console in this case, giving people clue what might have happened.

Moved it after writing to console.

jkotas · 2024-02-08T13:14:17Z

 // Maximum size for a string in event log entry
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768



Suggested change
// Maximum size for a string in event log entry
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768

jkotas · 2024-02-08T13:14:28Z

-// shorter in length. Hence, the change in size.
+// An event entry comprises of string to be written and event header information.
+// The total permissible length of the string and event header is 32K.
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842


Suggested change
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x7C62 // decimal 31842

jkotas · 2024-02-08T13:15:07Z

+ const int MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA = 0x7C62; // decimal 31842
+
+ // Continue to append to the buffer until we are full
+ if (!_bufferFull)
+ {
+ _description.AppendLine(s);
+
+ // Truncate the buffer if we have exceeded the limit based upon the OS we are on
+ if (_description.Length > MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
+ {
+ // Load the truncation message
+ string truncate = "\nThe remainder of the message was truncated.\n";
+
+ int truncCount = truncate.Length;
+
+ // Go back "truncCount" characters from the end of the string.
+ int ext = MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA - truncCount;


Suggested change
constintMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA-truncCount;
constintMAX_SIZE_EVENTLOG_ENTRY_STRING=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING-truncCount;

tommcdon · 2024-02-08T18:08:58Z

cc @Hoyos @mikem8361

jkotas

Thanks

MichalStrehovsky · 2024-02-08T12:18:32Z

Fixes#73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

ghost · 2024-02-08T12:18:37Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Author:	MichalStrehovsky
Assignees:	-
Labels:	`area-NativeAOT-coreclr`
Milestone:	-

Suchiman · 2024-02-08T12:33:10Z

+ _description.AppendLine("unknown");
+ }
+
+ _description.Append("CoreCLR Version: ");


CoreCLR?
Don't see a good enough reason to break people who parse this.

jkotas · 2024-02-08T13:01:47Z

+ if (exception != null && reason is not RhFailFastReason.AssertionFailure)
+ {
+ reporter.AddDescription($"{exception.GetType()}: {exception.Message}");
+ reporter.AddStackTrace(exception.StackTrace);


Computing the stack trace is a complicated operation and it is likely to crash again when things are corrupted. The existing console printing code is written in a way so that there is at least something printed to the console in this case, giving people clue what might have happened.

Moved it after writing to console.

jkotas · 2024-02-08T13:14:17Z

 // Maximum size for a string in event log entry
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768



Suggested change
// Maximum size for a string in event log entry
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768

jkotas · 2024-02-08T13:14:28Z

-// shorter in length. Hence, the change in size.
+// An event entry comprises of string to be written and event header information.
+// The total permissible length of the string and event header is 32K.
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842


Suggested change
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x7C62 // decimal 31842

jkotas · 2024-02-08T13:15:07Z

+ const int MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA = 0x7C62; // decimal 31842
+
+ // Continue to append to the buffer until we are full
+ if (!_bufferFull)
+ {
+ _description.AppendLine(s);
+
+ // Truncate the buffer if we have exceeded the limit based upon the OS we are on
+ if (_description.Length > MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
+ {
+ // Load the truncation message
+ string truncate = "\nThe remainder of the message was truncated.\n";
+
+ int truncCount = truncate.Length;
+
+ // Go back "truncCount" characters from the end of the string.
+ int ext = MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA - truncCount;


Suggested change
constintMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA-truncCount;
constintMAX_SIZE_EVENTLOG_ENTRY_STRING=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING-truncCount;

tommcdon · 2024-02-08T18:08:58Z

cc @Hoyos @mikem8361

jkotas

Thanks

MichalStrehovsky · 2024-02-08T12:18:32Z

Fixes#73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

ghost · 2024-02-08T12:18:37Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Author:	MichalStrehovsky
Assignees:	-
Labels:	`area-NativeAOT-coreclr`
Milestone:	-

Suchiman · 2024-02-08T12:33:10Z

+ _description.AppendLine("unknown");
+ }
+
+ _description.Append("CoreCLR Version: ");


CoreCLR?
Don't see a good enough reason to break people who parse this.

jkotas · 2024-02-08T13:01:47Z

+ if (exception != null && reason is not RhFailFastReason.AssertionFailure)
+ {
+ reporter.AddDescription($"{exception.GetType()}: {exception.Message}");
+ reporter.AddStackTrace(exception.StackTrace);


Computing the stack trace is a complicated operation and it is likely to crash again when things are corrupted. The existing console printing code is written in a way so that there is at least something printed to the console in this case, giving people clue what might have happened.

Moved it after writing to console.

jkotas · 2024-02-08T13:14:17Z

 // Maximum size for a string in event log entry
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768



Suggested change
// Maximum size for a string in event log entry
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768

jkotas · 2024-02-08T13:14:28Z

-// shorter in length. Hence, the change in size.
+// An event entry comprises of string to be written and event header information.
+// The total permissible length of the string and event header is 32K.
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842


Suggested change
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x7C62 // decimal 31842

jkotas · 2024-02-08T13:15:07Z

+ const int MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA = 0x7C62; // decimal 31842
+
+ // Continue to append to the buffer until we are full
+ if (!_bufferFull)
+ {
+ _description.AppendLine(s);
+
+ // Truncate the buffer if we have exceeded the limit based upon the OS we are on
+ if (_description.Length > MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
+ {
+ // Load the truncation message
+ string truncate = "\nThe remainder of the message was truncated.\n";
+
+ int truncCount = truncate.Length;
+
+ // Go back "truncCount" characters from the end of the string.
+ int ext = MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA - truncCount;


Suggested change
constintMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA-truncCount;
constintMAX_SIZE_EVENTLOG_ENTRY_STRING=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING-truncCount;

tommcdon · 2024-02-08T18:08:58Z

cc @Hoyos @mikem8361

jkotas

Thanks

MichalStrehovsky · 2024-02-08T12:18:32Z

Fixes#73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

ghost · 2024-02-08T12:18:37Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Author:	MichalStrehovsky
Assignees:	-
Labels:	`area-NativeAOT-coreclr`
Milestone:	-

Suchiman · 2024-02-08T12:33:10Z

+ _description.AppendLine("unknown");
+ }
+
+ _description.Append("CoreCLR Version: ");


CoreCLR?
Don't see a good enough reason to break people who parse this.

jkotas · 2024-02-08T13:01:47Z

+ if (exception != null && reason is not RhFailFastReason.AssertionFailure)
+ {
+ reporter.AddDescription($"{exception.GetType()}: {exception.Message}");
+ reporter.AddStackTrace(exception.StackTrace);


Computing the stack trace is a complicated operation and it is likely to crash again when things are corrupted. The existing console printing code is written in a way so that there is at least something printed to the console in this case, giving people clue what might have happened.

Moved it after writing to console.

jkotas · 2024-02-08T13:14:17Z

 // Maximum size for a string in event log entry
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768



Suggested change
// Maximum size for a string in event log entry
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768

jkotas · 2024-02-08T13:14:28Z

-// shorter in length. Hence, the change in size.
+// An event entry comprises of string to be written and event header information.
+// The total permissible length of the string and event header is 32K.
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842


Suggested change
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x7C62 // decimal 31842

jkotas · 2024-02-08T13:15:07Z

+ const int MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA = 0x7C62; // decimal 31842
+
+ // Continue to append to the buffer until we are full
+ if (!_bufferFull)
+ {
+ _description.AppendLine(s);
+
+ // Truncate the buffer if we have exceeded the limit based upon the OS we are on
+ if (_description.Length > MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
+ {
+ // Load the truncation message
+ string truncate = "\nThe remainder of the message was truncated.\n";
+
+ int truncCount = truncate.Length;
+
+ // Go back "truncCount" characters from the end of the string.
+ int ext = MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA - truncCount;


Suggested change
constintMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA-truncCount;
constintMAX_SIZE_EVENTLOG_ENTRY_STRING=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING-truncCount;

tommcdon · 2024-02-08T18:08:58Z

cc @Hoyos @mikem8361

jkotas

Thanks

MichalStrehovsky · 2024-02-08T12:18:32Z

Fixes#73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

ghost · 2024-02-08T12:18:37Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #73998.

EventReporter is basically taken from eventreporter.cpp in the VM.

Cc @tommcdon @mikem8361 @dotnet/ilc-contrib

Author:	MichalStrehovsky
Assignees:	-
Labels:	`area-NativeAOT-coreclr`
Milestone:	-

Suchiman · 2024-02-08T12:33:10Z

+ _description.AppendLine("unknown");
+ }
+
+ _description.Append("CoreCLR Version: ");


CoreCLR?
Don't see a good enough reason to break people who parse this.

jkotas · 2024-02-08T13:01:47Z

+ if (exception != null && reason is not RhFailFastReason.AssertionFailure)
+ {
+ reporter.AddDescription($"{exception.GetType()}: {exception.Message}");
+ reporter.AddStackTrace(exception.StackTrace);


Computing the stack trace is a complicated operation and it is likely to crash again when things are corrupted. The existing console printing code is written in a way so that there is at least something printed to the console in this case, giving people clue what might have happened.

Moved it after writing to console.

jkotas · 2024-02-08T13:14:17Z

 // Maximum size for a string in event log entry
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768



Suggested change
// Maximum size for a string in event log entry
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768

jkotas · 2024-02-08T13:14:28Z

-// shorter in length. Hence, the change in size.
+// An event entry comprises of string to be written and event header information.
+// The total permissible length of the string and event header is 32K.
 #define MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842


Suggested change
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842
#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x7C62 // decimal 31842

jkotas · 2024-02-08T13:15:07Z

+ const int MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA = 0x7C62; // decimal 31842
+
+ // Continue to append to the buffer until we are full
+ if (!_bufferFull)
+ {
+ _description.AppendLine(s);
+
+ // Truncate the buffer if we have exceeded the limit based upon the OS we are on
+ if (_description.Length > MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
+ {
+ // Load the truncation message
+ string truncate = "\nThe remainder of the message was truncated.\n";
+
+ int truncCount = truncate.Length;
+
+ // Go back "truncCount" characters from the end of the string.
+ int ext = MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA - truncCount;


Suggested change
constintMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA-truncCount;
constintMAX_SIZE_EVENTLOG_ENTRY_STRING=0x7C62;// decimal 31842
// Continue to append to the buffer until we are full
if(!_bufferFull)
{
_description.AppendLine(s);
// Truncate the buffer if we have exceeded the limit based upon the OS we are on
if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING)
{
// Load the truncation message
stringtruncate="\nThe remainder of the message was truncated.\n";
inttruncCount=truncate.Length;
// Go back "truncCount" characters from the end of the string.
intext=MAX_SIZE_EVENTLOG_ENTRY_STRING-truncCount;

tommcdon · 2024-02-08T18:08:58Z

cc @Hoyos @mikem8361

jkotas

Thanks

Report unhandled exceptions/FailFast in event log
c4a2a6f
Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

MichalStrehovsky added the area-NativeAOT-coreclr label Feb 8, 2024

ghost assigned MichalStrehovsky Feb 8, 2024

Suchiman reviewed Feb 8, 2024
View reviewed changes

jkotas reviewed Feb 8, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/EventReporter.cs Outdated

jkotas reviewed Feb 8, 2024
View reviewed changes

FB
39e8910

jkotas reviewed Feb 8, 2024
View reviewed changes

build-analysisBot mentioned this pull request Feb 8, 2024
PortableSourceBuild failures in runtime-dev-innerloop #98160
Closed

This was referenced Feb 8, 2024
Tracking issue for CI build timeouts #76454
Closed
Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049
Closed

FB
d929fd8

build-analysisBot mentioned this pull request Feb 12, 2024
[browser][MT] HttpClientCancelTest.SendAsync_Cancel_Success #98201
Closed

jkotas approved these changes Feb 12, 2024
View reviewed changes

MichalStrehovsky merged commit 271f5f1 into dotnet:mainFeb 12, 2024

MichalStrehovsky deleted the exn branch February 12, 2024 19:14

github-actionsBot locked and limited conversation to collaborators Mar 14, 2024

Report unhandled exceptions/FailFast in event log
c4a2a6f
Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

MichalStrehovsky added the area-NativeAOT-coreclr label Feb 8, 2024

ghost assigned MichalStrehovsky Feb 8, 2024

Suchiman reviewed Feb 8, 2024
View reviewed changes

jkotas reviewed Feb 8, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/EventReporter.cs Outdated

jkotas reviewed Feb 8, 2024
View reviewed changes

FB
39e8910

jkotas reviewed Feb 8, 2024
View reviewed changes

build-analysisBot mentioned this pull request Feb 8, 2024
PortableSourceBuild failures in runtime-dev-innerloop #98160
Closed

This was referenced Feb 8, 2024
Tracking issue for CI build timeouts #76454
Closed
Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049
Closed

FB
d929fd8

build-analysisBot mentioned this pull request Feb 12, 2024
[browser][MT] HttpClientCancelTest.SendAsync_Cancel_Success #98201
Closed

jkotas approved these changes Feb 12, 2024
View reviewed changes

MichalStrehovsky merged commit 271f5f1 into dotnet:mainFeb 12, 2024

MichalStrehovsky deleted the exn branch February 12, 2024 19:14

github-actionsBot locked and limited conversation to collaborators Mar 14, 2024

Report unhandled exceptions/FailFast in event log
c4a2a6f
Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

MichalStrehovsky added the area-NativeAOT-coreclr label Feb 8, 2024

ghost assigned MichalStrehovsky Feb 8, 2024

Suchiman reviewed Feb 8, 2024
View reviewed changes

jkotas reviewed Feb 8, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/EventReporter.cs Outdated

jkotas reviewed Feb 8, 2024
View reviewed changes

FB
39e8910

jkotas reviewed Feb 8, 2024
View reviewed changes

build-analysisBot mentioned this pull request Feb 8, 2024
PortableSourceBuild failures in runtime-dev-innerloop #98160
Closed

This was referenced Feb 8, 2024
Tracking issue for CI build timeouts #76454
Closed
Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049
Closed

FB
d929fd8

build-analysisBot mentioned this pull request Feb 12, 2024
[browser][MT] HttpClientCancelTest.SendAsync_Cancel_Success #98201
Closed

jkotas approved these changes Feb 12, 2024
View reviewed changes

MichalStrehovsky merged commit 271f5f1 into dotnet:mainFeb 12, 2024

MichalStrehovsky deleted the exn branch February 12, 2024 19:14

github-actionsBot locked and limited conversation to collaborators Mar 14, 2024

Report unhandled exceptions/FailFast in event log
c4a2a6f
Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

MichalStrehovsky added the area-NativeAOT-coreclr label Feb 8, 2024

ghost assigned MichalStrehovsky Feb 8, 2024

Suchiman reviewed Feb 8, 2024
View reviewed changes

jkotas reviewed Feb 8, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/EventReporter.cs Outdated

jkotas reviewed Feb 8, 2024
View reviewed changes

FB
39e8910

jkotas reviewed Feb 8, 2024
View reviewed changes

build-analysisBot mentioned this pull request Feb 8, 2024
PortableSourceBuild failures in runtime-dev-innerloop #98160
Closed

This was referenced Feb 8, 2024
Tracking issue for CI build timeouts #76454
Closed
Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049
Closed

FB
d929fd8

build-analysisBot mentioned this pull request Feb 12, 2024
[browser][MT] HttpClientCancelTest.SendAsync_Cancel_Success #98201
Closed

jkotas approved these changes Feb 12, 2024
View reviewed changes

MichalStrehovsky merged commit 271f5f1 into dotnet:mainFeb 12, 2024

MichalStrehovsky deleted the exn branch February 12, 2024 19:14

github-actionsBot locked and limited conversation to collaborators Mar 14, 2024

Report unhandled exceptions/FailFast in event log
c4a2a6f
Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

MichalStrehovsky added the area-NativeAOT-coreclr label Feb 8, 2024

ghost assigned MichalStrehovsky Feb 8, 2024

Suchiman reviewed Feb 8, 2024
View reviewed changes

jkotas reviewed Feb 8, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/EventReporter.cs Outdated

jkotas reviewed Feb 8, 2024
View reviewed changes

FB
39e8910

jkotas reviewed Feb 8, 2024
View reviewed changes

build-analysisBot mentioned this pull request Feb 8, 2024
PortableSourceBuild failures in runtime-dev-innerloop #98160
Closed

This was referenced Feb 8, 2024
Tracking issue for CI build timeouts #76454
Closed
Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049
Closed

FB
d929fd8

build-analysisBot mentioned this pull request Feb 12, 2024
[browser][MT] HttpClientCancelTest.SendAsync_Cancel_Success #98201
Closed

jkotas approved these changes Feb 12, 2024
View reviewed changes

MichalStrehovsky merged commit 271f5f1 into dotnet:mainFeb 12, 2024

MichalStrehovsky deleted the exn branch February 12, 2024 19:14

github-actionsBot locked and limited conversation to collaborators Mar 14, 2024

Report unhandled exceptions/FailFast in event log
c4a2a6f
Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

MichalStrehovsky added the area-NativeAOT-coreclr label Feb 8, 2024

ghost assigned MichalStrehovsky Feb 8, 2024

Suchiman reviewed Feb 8, 2024
View reviewed changes

jkotas reviewed Feb 8, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/EventReporter.cs Outdated

jkotas reviewed Feb 8, 2024
View reviewed changes

FB
39e8910

jkotas reviewed Feb 8, 2024
View reviewed changes

build-analysisBot mentioned this pull request Feb 8, 2024
PortableSourceBuild failures in runtime-dev-innerloop #98160
Closed

This was referenced Feb 8, 2024
Tracking issue for CI build timeouts #76454
Closed
Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049
Closed

FB
d929fd8

build-analysisBot mentioned this pull request Feb 12, 2024
[browser][MT] HttpClientCancelTest.SendAsync_Cancel_Success #98201
Closed

jkotas approved these changes Feb 12, 2024
View reviewed changes

MichalStrehovsky merged commit 271f5f1 into dotnet:mainFeb 12, 2024

MichalStrehovsky deleted the exn branch February 12, 2024 19:14

github-actionsBot locked and limited conversation to collaborators Mar 14, 2024

Report unhandled exceptions/FailFast in event log
c4a2a6f
Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

MichalStrehovsky added the area-NativeAOT-coreclr label Feb 8, 2024

ghost assigned MichalStrehovsky Feb 8, 2024

Suchiman reviewed Feb 8, 2024
View reviewed changes

jkotas reviewed Feb 8, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/EventReporter.cs Outdated

jkotas reviewed Feb 8, 2024
View reviewed changes

FB
39e8910

jkotas reviewed Feb 8, 2024
View reviewed changes

build-analysisBot mentioned this pull request Feb 8, 2024
PortableSourceBuild failures in runtime-dev-innerloop #98160
Closed

This was referenced Feb 8, 2024
Tracking issue for CI build timeouts #76454
Closed
Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049
Closed

FB
d929fd8

build-analysisBot mentioned this pull request Feb 12, 2024
[browser][MT] HttpClientCancelTest.SendAsync_Cancel_Success #98201
Closed

jkotas approved these changes Feb 12, 2024
View reviewed changes

MichalStrehovsky merged commit 271f5f1 into dotnet:mainFeb 12, 2024

MichalStrehovsky deleted the exn branch February 12, 2024 19:14

github-actionsBot locked and limited conversation to collaborators Mar 14, 2024

Report unhandled exceptions/FailFast in event log
c4a2a6f
Fixesdotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.

MichalStrehovsky added the area-NativeAOT-coreclr label Feb 8, 2024

ghost assigned MichalStrehovsky Feb 8, 2024

Suchiman reviewed Feb 8, 2024
View reviewed changes

jkotas reviewed Feb 8, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/EventReporter.cs Outdated

jkotas reviewed Feb 8, 2024
View reviewed changes

FB
39e8910

jkotas reviewed Feb 8, 2024
View reviewed changes

build-analysisBot mentioned this pull request Feb 8, 2024
PortableSourceBuild failures in runtime-dev-innerloop #98160
Closed

This was referenced Feb 8, 2024
Tracking issue for CI build timeouts #76454
Closed
Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049
Closed

FB
d929fd8

build-analysisBot mentioned this pull request Feb 12, 2024
[browser][MT] HttpClientCancelTest.SendAsync_Cancel_Success #98201
Closed

jkotas approved these changes Feb 12, 2024
View reviewed changes

MichalStrehovsky merged commit 271f5f1 into dotnet:mainFeb 12, 2024

MichalStrehovsky deleted the exn branch February 12, 2024 19:14

github-actionsBot locked and limited conversation to collaborators Mar 14, 2024

		// Maximum size for a string in event log entry
		#define MAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768

	// Maximum size for a string in event log entry
	#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768

	#defineMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842
	#defineMAX_SIZE_EVENTLOG_ENTRY_STRING 0x7C62 // decimal 31842

-constintMAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA=0x7C62;// decimal 31842
-// Continue to append to the buffer until we are full
-if(!_bufferFull)
-{
-_description.AppendLine(s);
-// Truncate the buffer if we have exceeded the limit based upon the OS we are on
-if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA)
-{
-// Load the truncation message
-stringtruncate="\nThe remainder of the message was truncated.\n";
-inttruncCount=truncate.Length;
-// Go back "truncCount" characters from the end of the string.
-intext=MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA-truncCount;
+constintMAX_SIZE_EVENTLOG_ENTRY_STRING=0x7C62;// decimal 31842
+// Continue to append to the buffer until we are full
+if(!_bufferFull)
+{
+_description.AppendLine(s);
+// Truncate the buffer if we have exceeded the limit based upon the OS we are on
+if(_description.Length>MAX_SIZE_EVENTLOG_ENTRY_STRING)
+{
+// Load the truncation message
+stringtruncate="\nThe remainder of the message was truncated.\n";
+inttruncCount=truncate.Length;
+// Go back "truncCount" characters from the end of the string.
+intext=MAX_SIZE_EVENTLOG_ENTRY_STRING-truncCount;

Uh oh!

Conversation

MichalStrehovsky commented Feb 8, 2024

Uh oh!

ghost commented Feb 8, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tommcdon commented Feb 8, 2024

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

MichalStrehovsky commented Feb 8, 2024

Uh oh!

ghost commented Feb 8, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tommcdon commented Feb 8, 2024

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

MichalStrehovsky commented Feb 8, 2024

Uh oh!

ghost commented Feb 8, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment