Uh oh!
There was an error while loading. Please reload this page.
[browser] Move reflection from JS to C# - #98391
Conversation
ghost
commented
Feb 13, 2024
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis decreases hazard of dealing with managed types in JS. Contributes to #98366
|
pavelsavara
commented
Feb 14, 2024
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pavelsavara
commented
Feb 14, 2024
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
commented
Feb 15, 2024
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
commented
Feb 15, 2024
I filled #98486 |
radekdoulik
commented
Feb 15, 2024
Looks like this change increased the cold browser template startup time, probably increased the size. The range is 741c0c8...c34474e ![]() Is there anything we can do to improve it? |
I think we should discuss this more, it pulls in a lot more managed code and the long term fix is different. |
pavelsavara
commented
Feb 15, 2024
We can move it back to C/mono, but call it from C# side. |
pavelsavara
commented
Feb 16, 2024
I moved it back to C, but called from the managed thread. #98534 Could you please check the perf with this ? @radekdoulik many thanks! |

This decreases hazard of dealing with managed types in JS.
It also reduces the need to
MONO_ENTER_GC_UNSAFEIt will allow to initiate
bind_assembly_exportsfrom UI to deputy thread.Allocate gc-roots for
monoStringToStringUnsafeearlier.Contributes to #98366