Uh oh!
There was an error while loading. Please reload this page.
[RISC-V] Remove unnecessary assertion from emitOutputInstr - #98484
Merged
Conversation
It fired a false positive when W^X was enabled
ghost
commented
Feb 15, 2024
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsRemove unnecessary assertion. It fired a false positive when W^X was enabled. Also, reuse emitOutputLong instead of creating our own for RISC-V. Part of #84834
|
clamp03
reviewed
Feb 15, 2024
Uh oh!
There was an error while loading. Please reload this page.
ryujit-bot
commented
Feb 15, 2024
Diff results for #98484Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64MinOpts (-0.01% to +0.00%)
Throughput diffs for osx/arm64 ran on windows/x64MinOpts (-0.00% to +0.01%)
Throughput diffs for windows/arm64 ran on windows/x64MinOpts (-0.01% to +0.00%)
Details here |
tomeksowiforce-pushed
the
fix-emitOutputInstr
branch
from
February 15, 2024 13:01
8a77f8a to
fbcd761CompareThere shouldn't be a problem when we introduce compressed instructions, VF2 supports unaligned stores (sw) Also, replace compile-time conditions with static_asserts.
clamp03
approved these changes
Feb 15, 2024
sirntar
approved these changes
Feb 15, 2024
ryujit-bot
commented
Feb 15, 2024
Diff results for #98484Throughput diffsThroughput diffs for osx/arm64 ran on windows/x64MinOpts (-0.00% to +0.01%)
Throughput diffs for windows/arm64 ran on windows/x64MinOpts (-0.01% to +0.00%)
Details here |
ryujit-bot
commented
Feb 15, 2024
Diff results for #98484Throughput diffsThroughput diffs for osx/arm64 ran on windows/x64MinOpts (-0.00% to +0.01%)
Throughput diffs for windows/arm64 ran on windows/x64MinOpts (-0.00% to +0.01%)
Details here |
tomeksowi
marked this pull request as ready for review
February 15, 2024 21:36
yurai007
approved these changes
Feb 16, 2024
Uh oh!
There was an error while loading. Please reload this page.
jakobbotsch
approved these changes
Feb 19, 2024
ryujit-bot
commented
Feb 19, 2024
brucehoult
commented
Mar 1, 2024
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary assertion introduced in #98226. It fired a false positive when W^X was enabled.
Part of #84834
cc @wscho77@HJLeee@clamp03@JongHeonChoi@t-mustafin@gbalykov@viewizard@ashaurtaev@brucehoult@sirntar@yurai007@Bajtazar@bartlomiejko