Skip to content

[browser][MT] Fix Promise cancelation - #99397

Merged
pavelsavara merged 7 commits into
dotnet:mainfrom
pavelsavara:browser_mt_gc_handle
Mar 8, 2024
Merged

[browser][MT] Fix Promise cancelation#99397
pavelsavara merged 7 commits into
dotnet:mainfrom
pavelsavara:browser_mt_gc_handle

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Mar 7, 2024

Copy link
Copy Markdown
Member
  • fixed compareExchangeI32 🤦‍♂️
  • unregister from FinalizationRegistry in upgrade_managed_proxy_to_strong_ref
  • more testing if the runtime is still running
  • testing if the promise holder is already disposed
  • added exit to RuntimeAPI
  • improve BlazorHosted WBT exit
  • make assert_runtime_running always throw, in order to really protect the code after it.
    • make it not configurable by dropping withAssertAfterExit

Contributes to #98721

- testing if the promise hoilder is already disposed
- added `exit` to `RuntimeAPI`
- unregister from `FinalizationRegistry` in `upgrade_managed_proxy_to_strong_ref`
- improve `BlazorHosted` WBT exit
@pavelsavara
pavelsavaraforce-pushed the browser_mt_gc_handle branch from 8d93f93 to ee24988CompareMarch 7, 2024 12:10
@pavelsavara
pavelsavara marked this pull request as ready for review March 8, 2024 06:38
@maraf

maraf commented Mar 8, 2024

Copy link
Copy Markdown
Member

Please, filter out the noise in SignalR test log
appsettings.json in server project

{
"Logging": {
"LogLevel": {
"Default": "Information",
"Microsoft.AspNetCore": "Warning"
}
}
}

@pavelsavara

This comment was marked as outdated.

@pavelsavara
pavelsavara merged commit 8e23fec into dotnet:mainMar 8, 2024
@pavelsavara
pavelsavara deleted the browser_mt_gc_handle branch March 8, 2024 16:34
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 9, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptos-browserBrowser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@maraf@ilonatommy