Skip to content

Add a parent check to the forward substitution tree walk - #99546

Merged
AndyAyersMS merged 2 commits into
dotnet:mainfrom
SingleAccretion:Fwd-Sub-Null-Check
Mar 12, 2024
Merged

Add a parent check to the forward substitution tree walk#99546
AndyAyersMS merged 2 commits into
dotnet:mainfrom
SingleAccretion:Fwd-Sub-Null-Check

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented Mar 11, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

In rather rare circumstances, we can see top-level LCL_VARs here. In the example from #99540, this happens due to an unused result from an inlined call.

Fixes#99540.

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 11, 2024
@dotnet-policy-service

dotnet-policy-serviceBot commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Mar 11, 2024
jakobbotsch
jakobbotsch reviewed Mar 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/forwardsub.cpp
@SingleAccretion

SingleAccretion commented Mar 11, 2024

Copy link
Copy Markdown
ContributorAuthor

SPMI failure looks infrastructural:

OSError: [Errno 28] No space left on device

No diffs as expected.

@SingleAccretionSingleAccretion changed the title Add a parent check to the forward subtitution tree walkAdd a parent check to the forward susbtitution tree walkMar 11, 2024
@SingleAccretionSingleAccretion changed the title Add a parent check to the forward susbtitution tree walkAdd a parent check to the forward substitution tree walkMar 11, 2024
@jakobbotsch

jakobbotsch commented Mar 12, 2024

Copy link
Copy Markdown
Member

cc @dotnet/jit-contrib

@AndyAyersMS
AndyAyersMS merged commit be0e14c into dotnet:mainMar 12, 2024
@SingleAccretion
SingleAccretion deleted the Fwd-Sub-Null-Check branch March 12, 2024 19:40
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 12, 2024
@adityamandaleekaadityamandaleeka mentioned this pull request Jun 2, 2025
Closed
@AndyAyersMS

AndyAyersMS commented Jun 3, 2025

Copy link
Copy Markdown
Member

/backport to release/8.0-staging

@github-actionsgithub-actionsBot unlocked this conversation Jun 3, 2025
@github-actions

github-actionsBot commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/15405819131

@github-actionsgithub-actionsBot locked as resolved and limited conversation to collaborators Jun 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch left review comments
@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Null dereference in forward subtitution

3 participants

@SingleAccretion@jakobbotsch@AndyAyersMS