Skip to content

Update native AOT static library guidance for .NET 8 - #6026

Merged
BillWagner merged 2 commits into
mainfrom
MichalStrehovsky-patch-1
Jul 27, 2023
Merged

Update native AOT static library guidance for .NET 8#6026
BillWagner merged 2 commits into
mainfrom
MichalStrehovsky-patch-1

Conversation

@MichalStrehovsky

@MichalStrehovskyMichalStrehovsky commented Jul 25, 2023

Copy link
Copy Markdown
Member

Summary

Reflects changes in dotnet/runtime#89291.

Cc @dotnet/ilc-contrib

@MichalStrehovsky
MichalStrehovsky requested a review from a team as a code ownerJuly 25, 2023 00:56
@MichalStrehovskyMichalStrehovsky mentioned this pull request Jul 25, 2023
Merged
@BillWagner

BillWagner commented Jul 25, 2023

Copy link
Copy Markdown
Member

Hi @MichalStrehovsky

Once you address the CI warnings, this is ready to merge.

@MichalStrehovsky

MichalStrehovsky commented Jul 25, 2023

Copy link
Copy Markdown
MemberAuthor

Hi @MichalStrehovsky

Once you address the CI warnings, this is ready to merge.

Is it possible to suppress the "inline html" warning. I need something to declutter the page. Or is there and equivalent of per-.net-version tabs?

BillWagner
BillWagner reviewed Jul 26, 2023
View reviewed changes

@BillWagnerBillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MichalStrehovsky

In this instance, let's disable the lint warning. There are zone pivots on the learn platform, but the sample readme files aren't published in that mode.

I added suggestions to disable and enable the warnings.

Once those are tested, I'll merge it.

Comment threadcore/nativeaot/NativeLibrary/README.md
Comment threadcore/nativeaot/NativeLibrary/README.md
@MichalStrehovsky@BillWagner
Apply suggestions from code review
3cf98d6
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
@MichalStrehovsky

MichalStrehovsky commented Jul 27, 2023

Copy link
Copy Markdown
MemberAuthor

I added suggestions to disable and enable the warnings.

Thank you! Looks like they did the trick!

@BillWagner
BillWagner merged commit 02e3c18 into mainJul 27, 2023
@BillWagner
BillWagner deleted the MichalStrehovsky-patch-1 branch July 27, 2023 13:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagnerBillWagnerBillWagner left review comments
@jkotasjkotasjkotas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@BillWagner@jkotas