Remove net472 containers by YuliiaKovalova · Pull Request #53547 · dotnet/sdk

YuliiaKovalova · 2026-03-20T15:25:13Z

Summary

Remove the net472 target from the Containers SDK (Microsoft.NET.Build.Containers), keeping only the .NET Core ($(SdkTargetFramework)) target.

The net472 build existed to support Visual Studio's Full-Framework MSBuild (MSBuildRuntimeType == Full). Now that VS uses .NET Runtime with HostObject support for container operations, the net472 target and all this infrastructure is no longer needed.

Fixes

dotnet/msbuild#11333

YuliiaKovalova · 2026-03-23T17:20:50Z

/azp run

azure-pipelines · 2026-03-23T17:21:00Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR removes the net472 target and associated packaging/test/layout infrastructure from the Containers SDK (Microsoft.NET.Build.Containers), aligning with the move away from Full Framework MSBuild for VS container operations.

Changes:

Drop multi-targeting ($(SdkTargetFramework);net472) for Microsoft.NET.Build.Containers and related integration tests, removing net472-only source/test shims.
Remove net472 task publishing/packaging outputs (layout + nupkg content) and update package content expectations accordingly.
Update the shipped .props to always point at the .NET (net10.0) task implementation.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/UnitTests.proj	Stops including Containers integration tests in the `TestFullMSBuild`/`net472` run.
test/Microsoft.NET.Build.Containers.IntegrationTests/PackageTests.cs	Updates dependency and nupkg content assertions to remove `tasks/net472` expectations.
test/Microsoft.NET.Build.Containers.IntegrationTests/Microsoft.NET.Build.Containers.IntegrationTests.csproj	Removes `net472` target and related conditional compilation setup.
test/Microsoft.NET.Build.Containers.IntegrationTests/FullFramework/CreateNewImageToolTaskTests.cs	Deletes Full Framework–specific tests for the removed ToolTask-based implementation.
src/Layout/redist/targets/GenerateLayout.targets	Removes publishing of `net472` task assets into the redist layout.
src/Layout/redist/targets/Crossgen.targets	Updates comment to reflect removal of `net472` components.
src/Containers/packaging/package.csproj	Removes `net472` packaging path and dependency harvesting for `net472` tasks.
src/Containers/packaging/build/Microsoft.NET.Build.Containers.props	Removes MSBuild runtime-based TFM selection; uses only `net10.0` tasks and updates `UsingTask` declarations.
src/Containers/Microsoft.NET.Build.Containers/net472Definitions.cs	Deletes `net472`-only polyfills (`IsExternalInit`, `NotNullWhenAttribute`).
src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImageToolTask.cs	Deletes the `net472` ToolTask-based shim implementation.
src/Containers/Microsoft.NET.Build.Containers/Tasks/ComputeDotnetBaseImageAndTag.cs	Removes now-unused `NETFRAMEWORK`-only `using` directives.
src/Containers/Microsoft.NET.Build.Containers/PublicAPI/net472/PublicAPI.Unshipped.txt	Removes `net472` public API baseline.
src/Containers/Microsoft.NET.Build.Containers/PublicAPI/net472/PublicAPI.Shipped.txt	Removes `net472` public API baseline header.
src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj	Removes `net472` TFM and all `net472`-specific compile/package reference conditionals.
src/Containers/Microsoft.NET.Build.Containers/ContainerHelpers.cs	Removes `NETFRAMEWORK`/`NET` conditional usings now that `net472` is gone.

baronfel · 2026-03-24T04:01:43Z

This looks correct, however anyone still using the Microsoft.Net.Build.Containers NuGet package and using an older version of VS will be broken if they upgrade. We need to stop publishing the package now that it's baked into the SDK too.

YuliiaKovalova · 2026-03-24T16:07:33Z

This looks correct, however anyone still using the Microsoft.Net.Build.Containers NuGet package and using an older version of VS will be broken if they upgrade. We need to stop publishing the package now that it's baked into the SDK too.

@marcpopMSFT & @mmitche could you please check this comment? Do you have any concerns regarding removing this package from publishing?

mmitche · 2026-03-24T17:08:38Z

This looks correct, however anyone still using the Microsoft.Net.Build.Containers NuGet package and using an older version of VS will be broken if they upgrade. We need to stop publishing the package now that it's baked into the SDK too.
@marcpopMSFT & @mmitche could you please check this comment? Do you have any concerns regarding removing this package from publishing?

Only concern is that it shows up as a package ref somewhere we don't expect, but we should find that in testing. Mark the package as non-shipping and I think that should about do it.

YuliiaKovalova · 2026-03-25T09:57:35Z

This looks correct, however anyone still using the Microsoft.Net.Build.Containers NuGet package and using an older version of VS will be broken if they upgrade. We need to stop publishing the package now that it's baked into the SDK too.
@marcpopMSFT & @mmitche could you please check this comment? Do you have any concerns regarding removing this package from publishing?
Only concern is that it shows up as a package ref somewhere we don't expect, but we should find that in testing. Mark the package as non-shipping and I think that should about do it.

Cool, thanks!
Done

baronfel · 2026-03-25T21:45:22Z

 <IsPackable>true</IsPackable>
- <IsShipping>true</IsShipping>
+ <IsShipping>false</IsShipping>
 <IsShippingPackage>true</IsShippingPackage>


@mmitche what's the difference/meaning of IsShipping vs IsShippingPackage? Are both needed?

IsShipping is broader than IsShippingPackage. IsShipping are used in projects where some assets produced are shipping while others are not: https://github.com/dotnet/arcade/blob/main/Documentation/ArcadeSdk.md#isshipping-isshippingassembly-isshippingpackage-isshippingvsix-bool
I would set IsShipping == false

YuliiaKovalova · 2026-04-08T17:20:19Z

hi @lbussell ,
Could you please review the changes?

YuliiaKovalova · 2026-04-08T19:06:24Z

hm , after pulling changes from the target branch the tests fail with
》C:\Program Files\Microsoft Visual Studio\18\Insiders\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1259,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.6.9 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [C:\h\w\AA3A097C\t\dotnetSdkTests\hepu34ny.vpu\MissingRefere---C53218B1\MissingReferenceAssemblies\MissingReferenceAssemblies.csproj]

https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-sdk-refs-pull-53547-merge-b36b34842dd1493ea8/Microsoft.NET.Build.Tests.dll.4/3/console.b0eae202.log?helixlogtype=result&skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2026-04-08T19%3A03%3A13Z&ske=2026-04-08T20%3A03%3A13Z&sks=b&skv=2026-02-06&sv=2026-02-06&se=2026-04-08T20%3A03%3A13Z&sr=b&sp=rl&sig=CbfG9rtbvtmyEysehbVKmhPJ5ybf3254LrHiDuVGres%3D

YuliiaKovalova · 2026-04-22T09:38:25Z

HI @DonnaChen888 ,

The reported failures aren't related to my changes, I see the same in https://github.com/dotnet/sdk/runs/72391515947

could you please force-merge it? I have an approval from containers maintainer.

DonnaChen888 · 2026-04-22T09:47:28Z

HI @DonnaChen888 ,
The reported failures aren't related to my changes, I see the same in https://github.com/dotnet/sdk/runs/72391515947
could you please force-merge it? I have an approval from containers maintainer.

Hi @marcpopMSFT, @dsplaisted, could you please take a look?

marcpopMSFT · 2026-04-24T21:17:02Z

@YuliiaKovalova you use the /ba-g comment and provide a justification for why the build analysis check should be green. This PR though should target 4xx as 3xx is now locked down.

Remove the net472 target from the Containers SDK (Microsoft.NET.Build.Containers), keeping only the .NET Core (SdkTargetFramework) target. The net472 build existed to support Visual Studio's Full-Framework MSBuild (MSBuildRuntimeType == Full). Now that VS uses .NET Runtime with HostObject support for container operations, the net472 target and all related infrastructure is no longer needed. Changes: - Remove net472 TFM from Microsoft.NET.Build.Containers.csproj - Delete CreateNewImageToolTask (ToolTask-based implementation) - Delete netframeworkDefinitions.cs (net472-only polyfills) - Remove ToolTask-related properties from targets/props - Remove net472 PublicAPI files - Delete FullFramework test suite (CreateNewImageToolTaskTests) - Exclude Containers from crossgenning in Crossgen.targets - Fix package.csproj: mark as non-shipping, update output paths Fixes: dotnet/msbuild#11333

github-actionsBot added the Area-Containers Related to dotnet SDK containers functionality label Mar 20, 2026

YuliiaKovalova changed the base branch from main to release/10.0.3xxMarch 23, 2026 12:35

YuliiaKovalova changed the title ~~remove net472 containers~~Remove net472 containersMar 23, 2026

YuliiaKovalova marked this pull request as ready for review March 23, 2026 17:14

YuliiaKovalova requested a review from a team as a code owner March 23, 2026 17:14

CopilotAI review requested due to automatic review settings March 23, 2026 17:14

Copilotstarted reviewing on behalf of YuliiaKovalova March 23, 2026 17:15 View session

CopilotAI reviewed Mar 23, 2026
View reviewed changes

Comment threadsrc/Containers/packaging/package.csproj Outdated

marcpopMSFT requested a review from lbussell March 24, 2026 20:22

baronfel reviewed Mar 25, 2026
View reviewed changes

This was referenced Mar 26, 2026
Template engine tests hitting known parallelism issue in GetVisualStudioInstances #44878
Closed
dotnet-watch tests failing #40006
Open

YuliiaKovalova requested a review from baronfel March 31, 2026 10:44

mthalman reviewed Apr 8, 2026
View reviewed changes

Comment threadsrc/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImage.cs

mthalman approved these changes Apr 9, 2026
View reviewed changes

build-analysisBot mentioned this pull request Apr 22, 2026
[Known Build Error] Microsoft.CodeAnalysis.NetAnalyzers.UnitTests.dll crash #54014
Closed

dsplaisted enabled auto-merge April 22, 2026 15:04

YuliiaKovalova changed the base branch from release/10.0.3xx to release/10.0.4xxApril 27, 2026 07:52

YuliiaKovalova force-pushed the dev/ykovalova/remove_net472_containers branch from 783f873 to 8f77039Compare April 27, 2026 08:08

dsplaisted merged commit 117fc71 into release/10.0.4xxApr 27, 2026
28 checks passed

dsplaisted deleted the dev/ykovalova/remove_net472_containers branch April 27, 2026 09:35

This was referenced Apr 27, 2026
[release/10.0.4xx] Source code updates from dotnet/sdk dotnet/dotnet#6285
Merged
[main] Source code updates from dotnet/sdk dotnet/dotnet#6389
Merged

Uh oh!

Conversation

YuliiaKovalova commented Mar 20, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Fixes

Uh oh!

YuliiaKovalova commented Mar 23, 2026

Uh oh!

azure-pipelinesBot commented Mar 23, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

baronfel commented Mar 24, 2026

Uh oh!

YuliiaKovalova commented Mar 24, 2026

Uh oh!

mmitche commented Mar 24, 2026

Uh oh!

YuliiaKovalova commented Mar 25, 2026

Uh oh!

baronfelMar 25, 2026

Choose a reason for hiding this comment

Uh oh!

mmitcheMar 26, 2026

Choose a reason for hiding this comment

Uh oh!

YuliiaKovalova commented Apr 8, 2026

Uh oh!

YuliiaKovalova commented Apr 8, 2026

Uh oh!

Uh oh!

YuliiaKovalova commented Apr 22, 2026

Uh oh!

DonnaChen888 commented Apr 22, 2026

Uh oh!

marcpopMSFT commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

YuliiaKovalova commented Mar 20, 2026•
edited
Loading