Helix proof of concept for unit tests by AdamYoblick · Pull Request #224 · dotnet/winforms

AdamYoblick · 2018-12-10T21:53:38Z

[3/6/2019]

A brief overview of the changes required here:

Add new step to send unit tests to helix (for this, I have abstracted away to a new file: eng/ci-helix-test.yml); accompanying work in ci.yml
Add dependency on Microsoft.DotNet.Helix.sdk from Arcade
Add dependencies to XUnit, XUnitAssert, XUnitRunnerConsole, XUnitRunnerVisualStudio, and XUnitExtensibilityExecution (all with the same version number)

additional changes along the way:

~~fix folder structure of System.Windows.Forms.Design.Tests to be have UnitTests in its path; accompanying sln change~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
~~add Moq reference to System.Windows.Forms.Design.Editors.csproj (it was missing)~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
temporary change to send-to-helix template while we wait for Allow Users ability to choose their own name for send-to-helix steps arcade#2153 to merge in

…tep for debugging

…port UI testing

… into dev/advolker/helix

zsd4yr · 2019-03-07T17:45:38Z

Big shoutout to @AdamYoblick for his work on this earlier and also @alexperovich for his assistance as well as support on the Arcade bits

zsd4yr · 2019-03-07T19:49:46Z

Waiting on #537

zsd4yr · 2019-03-07T19:51:09Z

@alexperovich would you mind reviewing these changes to get our unit tests on Arcade? We did most of this at the end together, so just looking for that little green check mark ✔️ 😉

Tanya-Solyanik · 2019-03-08T00:08:13Z

 ProcessStartInfo startInfo = new ProcessStartInfo();
 startInfo.FileName = Path.Combine(BinPath(), byPathFromBinToExe.Trim('\\'));
- startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;
+ startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;	// required


Consider adding the reason why this is required.

If only I remembered 😆 ... I'll figure it out

Right, this is why you want to explain comments like this one :). Maybe for the integration tests?

sharwell

Need to verify the impact on #514 before this is merged. Requesting a deferral on merging until 13 March 2019 so I have time to review and adjust if necessary.

JuditRose · 2019-03-08T16:55:38Z

+ <!-- XUnit-related unchanging dependencies -->
 <PropertyGroup>
- <AccessibilityPackageVersion>4.6.0-alpha-27122-5</AccessibilityPackageVersion>
+ <XUnitVersion>2.4.1-pre.build.4059</XUnitVersion>


With java applications we usually had a separate file to keep the version numbers that we are depending on in one place. Is it a best practice in dotnet apps as well? Can we move the dependencies version number into one place. I know it’s complitaced because of the different usage and file formats and all, just it would be nice to have dotner version, dotnet path, helix version, dotnet arcade version, xunit version, etc all in one place possibly grouped by what is using them, build, test, unit test, etc. Do es it makes sense?
I have no idea how hard it would be to do it? Would it worth it?

unfortunately, the yml files are the very first files run on the CI so build-time variables are not available yet, and for local builds these yml files are not run at all. I do not think there is a great place for them all.

impact on #514 tbd

This reverts commit 86bbead.

This reverts commit 8c8e04e.

* add creator, set to empty in internal, comment edits * helix token is secret AzDO pipeline variable * add xunit assert version * helix access token * helix source, differ from internal to public

AdamYoblick · 2018-12-10T21:53:38Z

[3/6/2019]

A brief overview of the changes required here:

Add new step to send unit tests to helix (for this, I have abstracted away to a new file: eng/ci-helix-test.yml); accompanying work in ci.yml
Add dependency on Microsoft.DotNet.Helix.sdk from Arcade
Add dependencies to XUnit, XUnitAssert, XUnitRunnerConsole, XUnitRunnerVisualStudio, and XUnitExtensibilityExecution (all with the same version number)

additional changes along the way:

~~fix folder structure of System.Windows.Forms.Design.Tests to be have UnitTests in its path; accompanying sln change~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
~~add Moq reference to System.Windows.Forms.Design.Editors.csproj (it was missing)~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
temporary change to send-to-helix template while we wait for Allow Users ability to choose their own name for send-to-helix steps arcade#2153 to merge in

…tep for debugging

…port UI testing

… into dev/advolker/helix

zsd4yr · 2019-03-07T17:45:38Z

Big shoutout to @AdamYoblick for his work on this earlier and also @alexperovich for his assistance as well as support on the Arcade bits

zsd4yr · 2019-03-07T19:49:46Z

Waiting on #537

zsd4yr · 2019-03-07T19:51:09Z

@alexperovich would you mind reviewing these changes to get our unit tests on Arcade? We did most of this at the end together, so just looking for that little green check mark ✔️ 😉

Tanya-Solyanik · 2019-03-08T00:08:13Z

 ProcessStartInfo startInfo = new ProcessStartInfo();
 startInfo.FileName = Path.Combine(BinPath(), byPathFromBinToExe.Trim('\\'));
- startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;
+ startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;	// required


Consider adding the reason why this is required.

If only I remembered 😆 ... I'll figure it out

Right, this is why you want to explain comments like this one :). Maybe for the integration tests?

sharwell

Need to verify the impact on #514 before this is merged. Requesting a deferral on merging until 13 March 2019 so I have time to review and adjust if necessary.

JuditRose · 2019-03-08T16:55:38Z

+ <!-- XUnit-related unchanging dependencies -->
 <PropertyGroup>
- <AccessibilityPackageVersion>4.6.0-alpha-27122-5</AccessibilityPackageVersion>
+ <XUnitVersion>2.4.1-pre.build.4059</XUnitVersion>


With java applications we usually had a separate file to keep the version numbers that we are depending on in one place. Is it a best practice in dotnet apps as well? Can we move the dependencies version number into one place. I know it’s complitaced because of the different usage and file formats and all, just it would be nice to have dotner version, dotnet path, helix version, dotnet arcade version, xunit version, etc all in one place possibly grouped by what is using them, build, test, unit test, etc. Do es it makes sense?
I have no idea how hard it would be to do it? Would it worth it?

unfortunately, the yml files are the very first files run on the CI so build-time variables are not available yet, and for local builds these yml files are not run at all. I do not think there is a great place for them all.

impact on #514 tbd

This reverts commit 86bbead.

This reverts commit 8c8e04e.

* add creator, set to empty in internal, comment edits * helix token is secret AzDO pipeline variable * add xunit assert version * helix access token * helix source, differ from internal to public

AdamYoblick · 2018-12-10T21:53:38Z

[3/6/2019]

A brief overview of the changes required here:

Add new step to send unit tests to helix (for this, I have abstracted away to a new file: eng/ci-helix-test.yml); accompanying work in ci.yml
Add dependency on Microsoft.DotNet.Helix.sdk from Arcade
Add dependencies to XUnit, XUnitAssert, XUnitRunnerConsole, XUnitRunnerVisualStudio, and XUnitExtensibilityExecution (all with the same version number)

additional changes along the way:

~~fix folder structure of System.Windows.Forms.Design.Tests to be have UnitTests in its path; accompanying sln change~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
~~add Moq reference to System.Windows.Forms.Design.Editors.csproj (it was missing)~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
temporary change to send-to-helix template while we wait for Allow Users ability to choose their own name for send-to-helix steps arcade#2153 to merge in

…tep for debugging

…port UI testing

… into dev/advolker/helix

zsd4yr · 2019-03-07T17:45:38Z

Big shoutout to @AdamYoblick for his work on this earlier and also @alexperovich for his assistance as well as support on the Arcade bits

zsd4yr · 2019-03-07T19:49:46Z

Waiting on #537

zsd4yr · 2019-03-07T19:51:09Z

@alexperovich would you mind reviewing these changes to get our unit tests on Arcade? We did most of this at the end together, so just looking for that little green check mark ✔️ 😉

Tanya-Solyanik · 2019-03-08T00:08:13Z

 ProcessStartInfo startInfo = new ProcessStartInfo();
 startInfo.FileName = Path.Combine(BinPath(), byPathFromBinToExe.Trim('\\'));
- startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;
+ startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;	// required


Consider adding the reason why this is required.

If only I remembered 😆 ... I'll figure it out

Right, this is why you want to explain comments like this one :). Maybe for the integration tests?

sharwell

Need to verify the impact on #514 before this is merged. Requesting a deferral on merging until 13 March 2019 so I have time to review and adjust if necessary.

JuditRose · 2019-03-08T16:55:38Z

+ <!-- XUnit-related unchanging dependencies -->
 <PropertyGroup>
- <AccessibilityPackageVersion>4.6.0-alpha-27122-5</AccessibilityPackageVersion>
+ <XUnitVersion>2.4.1-pre.build.4059</XUnitVersion>


With java applications we usually had a separate file to keep the version numbers that we are depending on in one place. Is it a best practice in dotnet apps as well? Can we move the dependencies version number into one place. I know it’s complitaced because of the different usage and file formats and all, just it would be nice to have dotner version, dotnet path, helix version, dotnet arcade version, xunit version, etc all in one place possibly grouped by what is using them, build, test, unit test, etc. Do es it makes sense?
I have no idea how hard it would be to do it? Would it worth it?

unfortunately, the yml files are the very first files run on the CI so build-time variables are not available yet, and for local builds these yml files are not run at all. I do not think there is a great place for them all.

impact on #514 tbd

This reverts commit 86bbead.

This reverts commit 8c8e04e.

* add creator, set to empty in internal, comment edits * helix token is secret AzDO pipeline variable * add xunit assert version * helix access token * helix source, differ from internal to public

AdamYoblick · 2018-12-10T21:53:38Z

[3/6/2019]

A brief overview of the changes required here:

Add new step to send unit tests to helix (for this, I have abstracted away to a new file: eng/ci-helix-test.yml); accompanying work in ci.yml
Add dependency on Microsoft.DotNet.Helix.sdk from Arcade
Add dependencies to XUnit, XUnitAssert, XUnitRunnerConsole, XUnitRunnerVisualStudio, and XUnitExtensibilityExecution (all with the same version number)

additional changes along the way:

~~fix folder structure of System.Windows.Forms.Design.Tests to be have UnitTests in its path; accompanying sln change~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
~~add Moq reference to System.Windows.Forms.Design.Editors.csproj (it was missing)~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
temporary change to send-to-helix template while we wait for Allow Users ability to choose their own name for send-to-helix steps arcade#2153 to merge in

…tep for debugging

…port UI testing

… into dev/advolker/helix

zsd4yr · 2019-03-07T17:45:38Z

Big shoutout to @AdamYoblick for his work on this earlier and also @alexperovich for his assistance as well as support on the Arcade bits

zsd4yr · 2019-03-07T19:49:46Z

Waiting on #537

zsd4yr · 2019-03-07T19:51:09Z

@alexperovich would you mind reviewing these changes to get our unit tests on Arcade? We did most of this at the end together, so just looking for that little green check mark ✔️ 😉

Tanya-Solyanik · 2019-03-08T00:08:13Z

 ProcessStartInfo startInfo = new ProcessStartInfo();
 startInfo.FileName = Path.Combine(BinPath(), byPathFromBinToExe.Trim('\\'));
- startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;
+ startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;	// required


Consider adding the reason why this is required.

If only I remembered 😆 ... I'll figure it out

Right, this is why you want to explain comments like this one :). Maybe for the integration tests?

sharwell

Need to verify the impact on #514 before this is merged. Requesting a deferral on merging until 13 March 2019 so I have time to review and adjust if necessary.

JuditRose · 2019-03-08T16:55:38Z

+ <!-- XUnit-related unchanging dependencies -->
 <PropertyGroup>
- <AccessibilityPackageVersion>4.6.0-alpha-27122-5</AccessibilityPackageVersion>
+ <XUnitVersion>2.4.1-pre.build.4059</XUnitVersion>


With java applications we usually had a separate file to keep the version numbers that we are depending on in one place. Is it a best practice in dotnet apps as well? Can we move the dependencies version number into one place. I know it’s complitaced because of the different usage and file formats and all, just it would be nice to have dotner version, dotnet path, helix version, dotnet arcade version, xunit version, etc all in one place possibly grouped by what is using them, build, test, unit test, etc. Do es it makes sense?
I have no idea how hard it would be to do it? Would it worth it?

unfortunately, the yml files are the very first files run on the CI so build-time variables are not available yet, and for local builds these yml files are not run at all. I do not think there is a great place for them all.

impact on #514 tbd

This reverts commit 86bbead.

This reverts commit 8c8e04e.

* add creator, set to empty in internal, comment edits * helix token is secret AzDO pipeline variable * add xunit assert version * helix access token * helix source, differ from internal to public

AdamYoblick · 2018-12-10T21:53:38Z

[3/6/2019]

A brief overview of the changes required here:

Add new step to send unit tests to helix (for this, I have abstracted away to a new file: eng/ci-helix-test.yml); accompanying work in ci.yml
Add dependency on Microsoft.DotNet.Helix.sdk from Arcade
Add dependencies to XUnit, XUnitAssert, XUnitRunnerConsole, XUnitRunnerVisualStudio, and XUnitExtensibilityExecution (all with the same version number)

additional changes along the way:

~~fix folder structure of System.Windows.Forms.Design.Tests to be have UnitTests in its path; accompanying sln change~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
~~add Moq reference to System.Windows.Forms.Design.Editors.csproj (it was missing)~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
temporary change to send-to-helix template while we wait for Allow Users ability to choose their own name for send-to-helix steps arcade#2153 to merge in

…tep for debugging

…port UI testing

… into dev/advolker/helix

zsd4yr · 2019-03-07T17:45:38Z

Big shoutout to @AdamYoblick for his work on this earlier and also @alexperovich for his assistance as well as support on the Arcade bits

zsd4yr · 2019-03-07T19:49:46Z

Waiting on #537

zsd4yr · 2019-03-07T19:51:09Z

@alexperovich would you mind reviewing these changes to get our unit tests on Arcade? We did most of this at the end together, so just looking for that little green check mark ✔️ 😉

Tanya-Solyanik · 2019-03-08T00:08:13Z

 ProcessStartInfo startInfo = new ProcessStartInfo();
 startInfo.FileName = Path.Combine(BinPath(), byPathFromBinToExe.Trim('\\'));
- startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;
+ startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;	// required


Consider adding the reason why this is required.

If only I remembered 😆 ... I'll figure it out

Right, this is why you want to explain comments like this one :). Maybe for the integration tests?

sharwell

Need to verify the impact on #514 before this is merged. Requesting a deferral on merging until 13 March 2019 so I have time to review and adjust if necessary.

JuditRose · 2019-03-08T16:55:38Z

+ <!-- XUnit-related unchanging dependencies -->
 <PropertyGroup>
- <AccessibilityPackageVersion>4.6.0-alpha-27122-5</AccessibilityPackageVersion>
+ <XUnitVersion>2.4.1-pre.build.4059</XUnitVersion>


With java applications we usually had a separate file to keep the version numbers that we are depending on in one place. Is it a best practice in dotnet apps as well? Can we move the dependencies version number into one place. I know it’s complitaced because of the different usage and file formats and all, just it would be nice to have dotner version, dotnet path, helix version, dotnet arcade version, xunit version, etc all in one place possibly grouped by what is using them, build, test, unit test, etc. Do es it makes sense?
I have no idea how hard it would be to do it? Would it worth it?

unfortunately, the yml files are the very first files run on the CI so build-time variables are not available yet, and for local builds these yml files are not run at all. I do not think there is a great place for them all.

impact on #514 tbd

This reverts commit 86bbead.

This reverts commit 8c8e04e.

* add creator, set to empty in internal, comment edits * helix token is secret AzDO pipeline variable * add xunit assert version * helix access token * helix source, differ from internal to public

AdamYoblick · 2018-12-10T21:53:38Z

[3/6/2019]

A brief overview of the changes required here:

Add new step to send unit tests to helix (for this, I have abstracted away to a new file: eng/ci-helix-test.yml); accompanying work in ci.yml
Add dependency on Microsoft.DotNet.Helix.sdk from Arcade
Add dependencies to XUnit, XUnitAssert, XUnitRunnerConsole, XUnitRunnerVisualStudio, and XUnitExtensibilityExecution (all with the same version number)

additional changes along the way:

~~fix folder structure of System.Windows.Forms.Design.Tests to be have UnitTests in its path; accompanying sln change~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
~~add Moq reference to System.Windows.Forms.Design.Editors.csproj (it was missing)~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
temporary change to send-to-helix template while we wait for Allow Users ability to choose their own name for send-to-helix steps arcade#2153 to merge in

…tep for debugging

…port UI testing

… into dev/advolker/helix

zsd4yr · 2019-03-07T17:45:38Z

Big shoutout to @AdamYoblick for his work on this earlier and also @alexperovich for his assistance as well as support on the Arcade bits

zsd4yr · 2019-03-07T19:49:46Z

Waiting on #537

zsd4yr · 2019-03-07T19:51:09Z

@alexperovich would you mind reviewing these changes to get our unit tests on Arcade? We did most of this at the end together, so just looking for that little green check mark ✔️ 😉

Tanya-Solyanik · 2019-03-08T00:08:13Z

 ProcessStartInfo startInfo = new ProcessStartInfo();
 startInfo.FileName = Path.Combine(BinPath(), byPathFromBinToExe.Trim('\\'));
- startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;
+ startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;	// required


Consider adding the reason why this is required.

If only I remembered 😆 ... I'll figure it out

Right, this is why you want to explain comments like this one :). Maybe for the integration tests?

sharwell

Need to verify the impact on #514 before this is merged. Requesting a deferral on merging until 13 March 2019 so I have time to review and adjust if necessary.

JuditRose · 2019-03-08T16:55:38Z

+ <!-- XUnit-related unchanging dependencies -->
 <PropertyGroup>
- <AccessibilityPackageVersion>4.6.0-alpha-27122-5</AccessibilityPackageVersion>
+ <XUnitVersion>2.4.1-pre.build.4059</XUnitVersion>


With java applications we usually had a separate file to keep the version numbers that we are depending on in one place. Is it a best practice in dotnet apps as well? Can we move the dependencies version number into one place. I know it’s complitaced because of the different usage and file formats and all, just it would be nice to have dotner version, dotnet path, helix version, dotnet arcade version, xunit version, etc all in one place possibly grouped by what is using them, build, test, unit test, etc. Do es it makes sense?
I have no idea how hard it would be to do it? Would it worth it?

unfortunately, the yml files are the very first files run on the CI so build-time variables are not available yet, and for local builds these yml files are not run at all. I do not think there is a great place for them all.

impact on #514 tbd

This reverts commit 86bbead.

This reverts commit 8c8e04e.

* add creator, set to empty in internal, comment edits * helix token is secret AzDO pipeline variable * add xunit assert version * helix access token * helix source, differ from internal to public

AdamYoblick · 2018-12-10T21:53:38Z

[3/6/2019]

A brief overview of the changes required here:

Add new step to send unit tests to helix (for this, I have abstracted away to a new file: eng/ci-helix-test.yml); accompanying work in ci.yml
Add dependency on Microsoft.DotNet.Helix.sdk from Arcade
Add dependencies to XUnit, XUnitAssert, XUnitRunnerConsole, XUnitRunnerVisualStudio, and XUnitExtensibilityExecution (all with the same version number)

additional changes along the way:

~~fix folder structure of System.Windows.Forms.Design.Tests to be have UnitTests in its path; accompanying sln change~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
~~add Moq reference to System.Windows.Forms.Design.Editors.csproj (it was missing)~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
temporary change to send-to-helix template while we wait for Allow Users ability to choose their own name for send-to-helix steps arcade#2153 to merge in

…tep for debugging

…port UI testing

… into dev/advolker/helix

zsd4yr · 2019-03-07T17:45:38Z

Big shoutout to @AdamYoblick for his work on this earlier and also @alexperovich for his assistance as well as support on the Arcade bits

zsd4yr · 2019-03-07T19:49:46Z

Waiting on #537

zsd4yr · 2019-03-07T19:51:09Z

@alexperovich would you mind reviewing these changes to get our unit tests on Arcade? We did most of this at the end together, so just looking for that little green check mark ✔️ 😉

Tanya-Solyanik · 2019-03-08T00:08:13Z

 ProcessStartInfo startInfo = new ProcessStartInfo();
 startInfo.FileName = Path.Combine(BinPath(), byPathFromBinToExe.Trim('\\'));
- startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;
+ startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;	// required


Consider adding the reason why this is required.

If only I remembered 😆 ... I'll figure it out

Right, this is why you want to explain comments like this one :). Maybe for the integration tests?

sharwell

Need to verify the impact on #514 before this is merged. Requesting a deferral on merging until 13 March 2019 so I have time to review and adjust if necessary.

JuditRose · 2019-03-08T16:55:38Z

+ <!-- XUnit-related unchanging dependencies -->
 <PropertyGroup>
- <AccessibilityPackageVersion>4.6.0-alpha-27122-5</AccessibilityPackageVersion>
+ <XUnitVersion>2.4.1-pre.build.4059</XUnitVersion>


With java applications we usually had a separate file to keep the version numbers that we are depending on in one place. Is it a best practice in dotnet apps as well? Can we move the dependencies version number into one place. I know it’s complitaced because of the different usage and file formats and all, just it would be nice to have dotner version, dotnet path, helix version, dotnet arcade version, xunit version, etc all in one place possibly grouped by what is using them, build, test, unit test, etc. Do es it makes sense?
I have no idea how hard it would be to do it? Would it worth it?

unfortunately, the yml files are the very first files run on the CI so build-time variables are not available yet, and for local builds these yml files are not run at all. I do not think there is a great place for them all.

impact on #514 tbd

This reverts commit 86bbead.

This reverts commit 8c8e04e.

* add creator, set to empty in internal, comment edits * helix token is secret AzDO pipeline variable * add xunit assert version * helix access token * helix source, differ from internal to public

AdamYoblick · 2018-12-10T21:53:38Z

[3/6/2019]

A brief overview of the changes required here:

Add new step to send unit tests to helix (for this, I have abstracted away to a new file: eng/ci-helix-test.yml); accompanying work in ci.yml
Add dependency on Microsoft.DotNet.Helix.sdk from Arcade
Add dependencies to XUnit, XUnitAssert, XUnitRunnerConsole, XUnitRunnerVisualStudio, and XUnitExtensibilityExecution (all with the same version number)

additional changes along the way:

~~fix folder structure of System.Windows.Forms.Design.Tests to be have UnitTests in its path; accompanying sln change~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
~~add Moq reference to System.Windows.Forms.Design.Editors.csproj (it was missing)~~ moved to 224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
temporary change to send-to-helix template while we wait for Allow Users ability to choose their own name for send-to-helix steps arcade#2153 to merge in

…tep for debugging

…port UI testing

… into dev/advolker/helix

zsd4yr · 2019-03-07T17:45:38Z

Big shoutout to @AdamYoblick for his work on this earlier and also @alexperovich for his assistance as well as support on the Arcade bits

zsd4yr · 2019-03-07T19:49:46Z

Waiting on #537

zsd4yr · 2019-03-07T19:51:09Z

@alexperovich would you mind reviewing these changes to get our unit tests on Arcade? We did most of this at the end together, so just looking for that little green check mark ✔️ 😉

Tanya-Solyanik · 2019-03-08T00:08:13Z

 ProcessStartInfo startInfo = new ProcessStartInfo();
 startInfo.FileName = Path.Combine(BinPath(), byPathFromBinToExe.Trim('\\'));
- startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;
+ startInfo.EnvironmentVariables["DOTNET_ROOT"] = dotnetPath;	// required


Consider adding the reason why this is required.

If only I remembered 😆 ... I'll figure it out

Right, this is why you want to explain comments like this one :). Maybe for the integration tests?

sharwell

Need to verify the impact on #514 before this is merged. Requesting a deferral on merging until 13 March 2019 so I have time to review and adjust if necessary.

JuditRose · 2019-03-08T16:55:38Z

+ <!-- XUnit-related unchanging dependencies -->
 <PropertyGroup>
- <AccessibilityPackageVersion>4.6.0-alpha-27122-5</AccessibilityPackageVersion>
+ <XUnitVersion>2.4.1-pre.build.4059</XUnitVersion>


With java applications we usually had a separate file to keep the version numbers that we are depending on in one place. Is it a best practice in dotnet apps as well? Can we move the dependencies version number into one place. I know it’s complitaced because of the different usage and file formats and all, just it would be nice to have dotner version, dotnet path, helix version, dotnet arcade version, xunit version, etc all in one place possibly grouped by what is using them, build, test, unit test, etc. Do es it makes sense?
I have no idea how hard it would be to do it? Would it worth it?

unfortunately, the yml files are the very first files run on the CI so build-time variables are not available yet, and for local builds these yml files are not run at all. I do not think there is a great place for them all.

impact on #514 tbd

This reverts commit 86bbead.

This reverts commit 8c8e04e.

* add creator, set to empty in internal, comment edits * helix token is secret AzDO pipeline variable * add xunit assert version * helix access token * helix source, differ from internal to public

Zachary Danzand others added 24 commits December 7, 2018 13:40

added functests project, added tests to open WinformsControlsTest tabs
6300d42

sdk magic .tests
80679a9

change to set environment variable before process start
d78d7e5

nit
7965f0c

yeah pair programming!
d8c0f44

please work tho
6feb911

Set yaml debug to true to help troubleshoot
491809a

why
5d54a79

shot in the dark but sure
cbdea61

even better, this time with feeling!
ae4f6d6

docs
782b668

changed func test config to debug and add 5 minute timeout to build s…
8713166
…tep for debugging

renaming folder structure to match csproj name
2a08804

left this change behind
88f2af9

debugging in yaml
92bcf59

testing
4676862

print out all env vars for debugging
4e60f0a

adding helix steps
285cec4

readd func tests proj to sln
4b78c5a

Merge branch 'master' into dev/zadanz/functional_xunit
5105634

Comment out func tests that are failing for now
304a181

change to agentPool that has agent running in interactive mode to sup…
85302d7
…port UI testing

re-enable unit tests on the machine and disable helix for now
6ac7fb7

initial try of unit tests through helix
7d93112

AdamYoblick requested a review from a team as a code owner December 10, 2018 21:53

AdamYoblickand others added 5 commits December 10, 2018 15:54

Merge branch 'master' into dev/advolker/helix
aec20f5

specify a dotnet cli version to use on helix machines
0b63f18

specify a dotnet cli version to use on helix machines
999a276

Merge branch 'dev/advolker/helix' ofhttps://github.com/dotnet/winforms…
576178d
… into dev/advolker/helix

Added helix sdk to global.json
5ccec95

Zachary Danz added 3 commits March 6, 2019 15:23

additional yml
ee9de87

fix name errors
53c2de3

rename, add naming
d5a444e

Merge branch 'master' into dev/advolker/helix
d716c3c

Tanya-Solyanik reviewed Mar 7, 2019
View reviewed changes

Comment threadeng/ci-helix-test.yml

zsd4yr self-assigned this Mar 7, 2019

zsd4yr mentioned this pull request Mar 7, 2019
224 small fixes: include moq in Sys.Win.Forms.Design.Editors; move Sys.Win.Forms.Design.Tests to UnitTests subdir #537
Merged

zsd4yr requested a review from alexperovich March 7, 2019 19:50

merge from master
a47fff8

alexperovich approved these changes Mar 7, 2019
View reviewed changes

Comment threadeng/ci-helix-test.yml Outdated

helix type
ab79587

Tanya-Solyanik reviewed Mar 8, 2019
View reviewed changes

Tanya-Solyanik approved these changes Mar 8, 2019
View reviewed changes

sharwell previously requested changes Mar 8, 2019
View reviewed changes

sharwell mentioned this pull request Mar 8, 2019
Establish Code Coverage for WinForms testing #514
Merged

JuditRose reviewed Mar 8, 2019
View reviewed changes

JuditRose approved these changes Mar 8, 2019
View reviewed changes

zsd4yr merged commit 86bbead into masterMar 8, 2019

zsd4yr deleted the dev/advolker/helix branch March 8, 2019 17:57

zsd4yr pushed a commit that referenced this pull request Mar 8, 2019
Revert "Helix proof of concept for unit tests (#224)"
65882a3
This reverts commit 86bbead.

zsd4yr added a commit that referenced this pull request Mar 8, 2019
Revert "Helix proof of concept for unit tests (#224)" (#545)
4d46ff4
This reverts commit 86bbead.

zsd4yr pushed a commit that referenced this pull request Mar 8, 2019
Revert "Helix proof of concept for unit tests (#224)"
8c8e04e
This reverts commit 86bbead.

zsd4yr pushed a commit that referenced this pull request Mar 8, 2019
Revert "Revert "Helix proof of concept for unit tests (#224)""
24eed41
This reverts commit 8c8e04e.

zsd4yr pushed a commit that referenced this pull request Mar 8, 2019
Revert "Revert "Helix proof of concept for unit tests (#224)""
8027c29
This reverts commit 8c8e04e.

ghost locked as resolved and limited conversation to collaborators Feb 8, 2022