Skip to content

[main] Update dependencies from dotnet/runtime - #7578

Merged
dreddy-work merged 5 commits into
mainfrom
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Aug 15, 2022
Merged

[main] Update dependencies from dotnet/runtime#7578
dreddy-work merged 5 commits into
mainfrom
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Aug 11, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: d9f5b309-084f-43b5-02de-08d8b80548e4
  • Build: 20220814.6
  • Date Produced: August 15, 2022 9:35:05 AM UTC
  • Commit: e680411c22e33f45821f4ae64365a2970b2430a6
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
5488352
…0810.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22410.9
@dotnet-maestro
dotnet-maestroBot requested a review from a team as a code ownerAugust 11, 2022 12:11
ghost
ghost previously approved these changes Aug 11, 2022
View reviewed changes

@ghostghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@RussKie

RussKie commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

It is building on the CI as well, but looks like a VB related test Microsoft.VisualBasic.Logging.Tests.LogTests.Write is failing:

Error message
System.NullReferenceException : Object reference not set to an instance of an object.
Stack trace
at Microsoft.VisualBasic.Logging.Tests.LogTests.Write() in /_/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Logging/LogTests.cs:line 24
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

@Tanya-SolyanikTanya-Solyanik mentioned this pull request Aug 12, 2022
Merged
@Tanya-Solyanik

Tanya-Solyanik commented Aug 12, 2022

Copy link
Copy Markdown
Contributor

@steveharter , it seems that winforms test failure is related to dotnet/runtime#73087 - if TraceSource is initialized from the config file, it does not initialize the default file listener, and test expects the default listener to be initialized. I suspect winforms should come up with a different way to detect initialization from a config fie, could you please suggest one?

@KlausLoeffelmann

KlausLoeffelmann commented Aug 12, 2022

Copy link
Copy Markdown
Member

@steveharter, @Tanya-Solyanik:
To be more precise, it is something in the Application Framework for/in Visual Basic, that's causing this, because it does an assumption, which I frankly don't understand:

https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170

image

This assumption is that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.

Now, what I don't understand: Why would (previously) GetSupportedAttributes only have been called, when the trace source was configured by a config file?

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
968e1e2
…0811.12
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22411.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
041bb13
…0813.1
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
362389b
…0813.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.9
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
878a76b
…0814.6
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22414.6
@dreddy-work

dreddy-work commented Aug 15, 2022

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelinesBot commented Aug 15, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@dreddy-work
dreddy-work enabled auto-merge (squash) August 15, 2022 21:10
@dreddy-work
dreddy-work merged commit 17f8241 into mainAug 15, 2022
@dreddy-work
dreddy-work deleted the darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f branch August 15, 2022 21:26
@ghostghost locked as resolved and limited conversation to collaborators Sep 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@dreddy-workdreddy-workdreddy-work approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RussKie@Tanya-Solyanik@KlausLoeffelmann@dreddy-work
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[main] Update dependencies from dotnet/runtime by dotnet-maestro[bot] · Pull Request #7578 · dotnet/winforms · GitHub
Skip to content
[main] Update dependencies from dotnet/runtime - #7578
Merged
dreddy-work merged 5 commits into
mainfrom 
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Aug 15, 2022
Merged
[main] Update dependencies from dotnet/runtime#7578
dreddy-work merged 5 commits into
mainfrom 
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: d9f5b309-084f-43b5-02de-08d8b80548e4
  • Build: 20220814.6
  • Date Produced: August 15, 2022 9:35:05 AM UTC
  • Commit: e680411c22e33f45821f4ae64365a2970b2430a6
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
5488352
…0810.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22410.9
@dotnet-maestro
dotnet-maestroBot
requested a review
from a team
as a code ownerAugust 11, 2022 12:11
ghost
ghost
previously approved these changes
Aug 11, 2022
View reviewed changes
@ghostghost
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!
@RussKie
RussKie
commented
Aug 11, 2022

Copy link


Copy Markdown

Contributor
It is building on the CI as well, but looks like a VB related test Microsoft.VisualBasic.Logging.Tests.LogTests.Write is failing:
Error message
System.NullReferenceException : Object reference not set to an instance of an object.
Stack trace
at Microsoft.VisualBasic.Logging.Tests.LogTests.Write() in /_/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Logging/LogTests.cs:line 24
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

@Tanya-SolyanikTanya-Solyanik
mentioned this pull request
Aug 12, 2022
 Merged

@Tanya-Solyanik
Tanya-Solyanik
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
@steveharter , it seems that winforms test failure is related to dotnet/runtime#73087 - if TraceSource is initialized from the config file, it does not initialize the default file listener, and test expects the default listener to be initialized. I suspect winforms should come up with a different way to detect initialization from a config fie, could you please suggest one?
@KlausLoeffelmann
KlausLoeffelmann
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
@steveharter, @Tanya-Solyanik:

To be more precise, it is something in the Application Framework for/in Visual Basic, that's causing this, because it does an assumption, which I frankly don't understand:
https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170
image
This assumption is that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.
Now, what I don't understand: Why would (previously) GetSupportedAttributes only have been called, when the trace source was configured by a config file?
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
968e1e2
…0811.12
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22411.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
041bb13
…0813.1
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
362389b
…0813.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.9
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
878a76b
…0814.6
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22414.6
@dreddy-work
dreddy-work
commented
Aug 15, 2022

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Aug 15, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dreddy-work
dreddy-work
enabled auto-merge (squash)
August 15, 2022 21:10
@dreddy-work
dreddy-work
merged commit 17f8241
into
mainAug 15, 2022
@dreddy-work
dreddy-work
deleted the

darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f

branch
August 15, 2022 21:26
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 15, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@dreddy-workdreddy-workdreddy-work approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@RussKie@Tanya-Solyanik@KlausLoeffelmann@dreddy-work

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[main] Update dependencies from dotnet/runtime by dotnet-maestro[bot] · Pull Request #7578 · dotnet/winforms · GitHub
Skip to content
[main] Update dependencies from dotnet/runtime - #7578
Merged
dreddy-work merged 5 commits into
mainfrom 
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Aug 15, 2022
Merged
[main] Update dependencies from dotnet/runtime#7578
dreddy-work merged 5 commits into
mainfrom 
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: d9f5b309-084f-43b5-02de-08d8b80548e4
  • Build: 20220814.6
  • Date Produced: August 15, 2022 9:35:05 AM UTC
  • Commit: e680411c22e33f45821f4ae64365a2970b2430a6
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
5488352
…0810.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22410.9
@dotnet-maestro
dotnet-maestroBot
requested a review
from a team
as a code ownerAugust 11, 2022 12:11
ghost
ghost
previously approved these changes
Aug 11, 2022
View reviewed changes
@ghostghost
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!
@RussKie
RussKie
commented
Aug 11, 2022

Copy link


Copy Markdown

Contributor
It is building on the CI as well, but looks like a VB related test Microsoft.VisualBasic.Logging.Tests.LogTests.Write is failing:
Error message
System.NullReferenceException : Object reference not set to an instance of an object.
Stack trace
at Microsoft.VisualBasic.Logging.Tests.LogTests.Write() in /_/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Logging/LogTests.cs:line 24
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

@Tanya-SolyanikTanya-Solyanik
mentioned this pull request
Aug 12, 2022
 Merged

@Tanya-Solyanik
Tanya-Solyanik
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
@steveharter , it seems that winforms test failure is related to dotnet/runtime#73087 - if TraceSource is initialized from the config file, it does not initialize the default file listener, and test expects the default listener to be initialized. I suspect winforms should come up with a different way to detect initialization from a config fie, could you please suggest one?
@KlausLoeffelmann
KlausLoeffelmann
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
@steveharter, @Tanya-Solyanik:

To be more precise, it is something in the Application Framework for/in Visual Basic, that's causing this, because it does an assumption, which I frankly don't understand:
https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170
image
This assumption is that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.
Now, what I don't understand: Why would (previously) GetSupportedAttributes only have been called, when the trace source was configured by a config file?
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
968e1e2
…0811.12
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22411.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
041bb13
…0813.1
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
362389b
…0813.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.9
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
878a76b
…0814.6
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22414.6
@dreddy-work
dreddy-work
commented
Aug 15, 2022

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Aug 15, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dreddy-work
dreddy-work
enabled auto-merge (squash)
August 15, 2022 21:10
@dreddy-work
dreddy-work
merged commit 17f8241
into
mainAug 15, 2022
@dreddy-work
dreddy-work
deleted the

darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f

branch
August 15, 2022 21:26
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 15, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@dreddy-workdreddy-workdreddy-work approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@RussKie@Tanya-Solyanik@KlausLoeffelmann@dreddy-work

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[main] Update dependencies from dotnet/runtime by dotnet-maestro[bot] · Pull Request #7578 · dotnet/winforms · GitHub
Skip to content
[main] Update dependencies from dotnet/runtime - #7578
Merged
dreddy-work merged 5 commits into
mainfrom 
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Aug 15, 2022
Merged
[main] Update dependencies from dotnet/runtime#7578
dreddy-work merged 5 commits into
mainfrom 
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: d9f5b309-084f-43b5-02de-08d8b80548e4
  • Build: 20220814.6
  • Date Produced: August 15, 2022 9:35:05 AM UTC
  • Commit: e680411c22e33f45821f4ae64365a2970b2430a6
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
5488352
…0810.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22410.9
@dotnet-maestro
dotnet-maestroBot
requested a review
from a team
as a code ownerAugust 11, 2022 12:11
ghost
ghost
previously approved these changes
Aug 11, 2022
View reviewed changes
@ghostghost
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!
@RussKie
RussKie
commented
Aug 11, 2022

Copy link


Copy Markdown

Contributor
It is building on the CI as well, but looks like a VB related test Microsoft.VisualBasic.Logging.Tests.LogTests.Write is failing:
Error message
System.NullReferenceException : Object reference not set to an instance of an object.
Stack trace
at Microsoft.VisualBasic.Logging.Tests.LogTests.Write() in /_/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Logging/LogTests.cs:line 24
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

@Tanya-SolyanikTanya-Solyanik
mentioned this pull request
Aug 12, 2022
 Merged

@Tanya-Solyanik
Tanya-Solyanik
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
@steveharter , it seems that winforms test failure is related to dotnet/runtime#73087 - if TraceSource is initialized from the config file, it does not initialize the default file listener, and test expects the default listener to be initialized. I suspect winforms should come up with a different way to detect initialization from a config fie, could you please suggest one?
@KlausLoeffelmann
KlausLoeffelmann
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
@steveharter, @Tanya-Solyanik:

To be more precise, it is something in the Application Framework for/in Visual Basic, that's causing this, because it does an assumption, which I frankly don't understand:
https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170
image
This assumption is that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.
Now, what I don't understand: Why would (previously) GetSupportedAttributes only have been called, when the trace source was configured by a config file?
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
968e1e2
…0811.12
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22411.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
041bb13
…0813.1
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
362389b
…0813.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.9
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
878a76b
…0814.6
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22414.6
@dreddy-work
dreddy-work
commented
Aug 15, 2022

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Aug 15, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dreddy-work
dreddy-work
enabled auto-merge (squash)
August 15, 2022 21:10
@dreddy-work
dreddy-work
merged commit 17f8241
into
mainAug 15, 2022
@dreddy-work
dreddy-work
deleted the

darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f

branch
August 15, 2022 21:26
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 15, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@dreddy-workdreddy-workdreddy-work approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@RussKie@Tanya-Solyanik@KlausLoeffelmann@dreddy-work

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[main] Update dependencies from dotnet/runtime by dotnet-maestro[bot] · Pull Request #7578 · dotnet/winforms · GitHub
Skip to content
[main] Update dependencies from dotnet/runtime - #7578
Merged
dreddy-work merged 5 commits into
mainfrom 
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Aug 15, 2022
Merged
[main] Update dependencies from dotnet/runtime#7578
dreddy-work merged 5 commits into
mainfrom 
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: d9f5b309-084f-43b5-02de-08d8b80548e4
  • Build: 20220814.6
  • Date Produced: August 15, 2022 9:35:05 AM UTC
  • Commit: e680411c22e33f45821f4ae64365a2970b2430a6
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
5488352
…0810.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22410.9
@dotnet-maestro
dotnet-maestroBot
requested a review
from a team
as a code ownerAugust 11, 2022 12:11
ghost
ghost
previously approved these changes
Aug 11, 2022
View reviewed changes
@ghostghost
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!
@RussKie
RussKie
commented
Aug 11, 2022

Copy link


Copy Markdown

Contributor
It is building on the CI as well, but looks like a VB related test Microsoft.VisualBasic.Logging.Tests.LogTests.Write is failing:
Error message
System.NullReferenceException : Object reference not set to an instance of an object.
Stack trace
at Microsoft.VisualBasic.Logging.Tests.LogTests.Write() in /_/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Logging/LogTests.cs:line 24
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

@Tanya-SolyanikTanya-Solyanik
mentioned this pull request
Aug 12, 2022
 Merged

@Tanya-Solyanik
Tanya-Solyanik
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
@steveharter , it seems that winforms test failure is related to dotnet/runtime#73087 - if TraceSource is initialized from the config file, it does not initialize the default file listener, and test expects the default listener to be initialized. I suspect winforms should come up with a different way to detect initialization from a config fie, could you please suggest one?
@KlausLoeffelmann
KlausLoeffelmann
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
@steveharter, @Tanya-Solyanik:

To be more precise, it is something in the Application Framework for/in Visual Basic, that's causing this, because it does an assumption, which I frankly don't understand:
https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170
image
This assumption is that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.
Now, what I don't understand: Why would (previously) GetSupportedAttributes only have been called, when the trace source was configured by a config file?
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
968e1e2
…0811.12
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22411.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
041bb13
…0813.1
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
362389b
…0813.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.9
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
878a76b
…0814.6
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22414.6
@dreddy-work
dreddy-work
commented
Aug 15, 2022

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Aug 15, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dreddy-work
dreddy-work
enabled auto-merge (squash)
August 15, 2022 21:10
@dreddy-work
dreddy-work
merged commit 17f8241
into
mainAug 15, 2022
@dreddy-work
dreddy-work
deleted the

darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f

branch
August 15, 2022 21:26
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 15, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@dreddy-workdreddy-workdreddy-work approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@RussKie@Tanya-Solyanik@KlausLoeffelmann@dreddy-work

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[main] Update dependencies from dotnet/runtime by dotnet-maestro[bot] · Pull Request #7578 · dotnet/winforms · GitHub
Skip to content
[main] Update dependencies from dotnet/runtime - #7578
Merged
dreddy-work merged 5 commits into
mainfrom 
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Aug 15, 2022
Merged
[main] Update dependencies from dotnet/runtime#7578
dreddy-work merged 5 commits into
mainfrom 
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: d9f5b309-084f-43b5-02de-08d8b80548e4
  • Build: 20220814.6
  • Date Produced: August 15, 2022 9:35:05 AM UTC
  • Commit: e680411c22e33f45821f4ae64365a2970b2430a6
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
5488352
…0810.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22410.9
@dotnet-maestro
dotnet-maestroBot
requested a review
from a team
as a code ownerAugust 11, 2022 12:11
ghost
ghost
previously approved these changes
Aug 11, 2022
View reviewed changes
@ghostghost
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!
@RussKie
RussKie
commented
Aug 11, 2022

Copy link


Copy Markdown

Contributor
It is building on the CI as well, but looks like a VB related test Microsoft.VisualBasic.Logging.Tests.LogTests.Write is failing:
Error message
System.NullReferenceException : Object reference not set to an instance of an object.
Stack trace
at Microsoft.VisualBasic.Logging.Tests.LogTests.Write() in /_/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Logging/LogTests.cs:line 24
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

@Tanya-SolyanikTanya-Solyanik
mentioned this pull request
Aug 12, 2022
 Merged

@Tanya-Solyanik
Tanya-Solyanik
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
@steveharter , it seems that winforms test failure is related to dotnet/runtime#73087 - if TraceSource is initialized from the config file, it does not initialize the default file listener, and test expects the default listener to be initialized. I suspect winforms should come up with a different way to detect initialization from a config fie, could you please suggest one?
@KlausLoeffelmann
KlausLoeffelmann
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
@steveharter, @Tanya-Solyanik:

To be more precise, it is something in the Application Framework for/in Visual Basic, that's causing this, because it does an assumption, which I frankly don't understand:
https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170
image
This assumption is that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.
Now, what I don't understand: Why would (previously) GetSupportedAttributes only have been called, when the trace source was configured by a config file?
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
968e1e2
…0811.12
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22411.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
041bb13
…0813.1
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
362389b
…0813.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.9
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
878a76b
…0814.6
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22414.6
@dreddy-work
dreddy-work
commented
Aug 15, 2022

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Aug 15, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dreddy-work
dreddy-work
enabled auto-merge (squash)
August 15, 2022 21:10
@dreddy-work
dreddy-work
merged commit 17f8241
into
mainAug 15, 2022
@dreddy-work
dreddy-work
deleted the

darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f

branch
August 15, 2022 21:26
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 15, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@dreddy-workdreddy-workdreddy-work approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@RussKie@Tanya-Solyanik@KlausLoeffelmann@dreddy-work

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[main] Update dependencies from dotnet/runtime by dotnet-maestro[bot] · Pull Request #7578 · dotnet/winforms · GitHub
Skip to content
[main] Update dependencies from dotnet/runtime - #7578
Merged
dreddy-work merged 5 commits into
mainfrom 
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Aug 15, 2022
Merged
[main] Update dependencies from dotnet/runtime#7578
dreddy-work merged 5 commits into
mainfrom 
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: d9f5b309-084f-43b5-02de-08d8b80548e4
  • Build: 20220814.6
  • Date Produced: August 15, 2022 9:35:05 AM UTC
  • Commit: e680411c22e33f45821f4ae64365a2970b2430a6
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
5488352
…0810.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22410.9
@dotnet-maestro
dotnet-maestroBot
requested a review
from a team
as a code ownerAugust 11, 2022 12:11
ghost
ghost
previously approved these changes
Aug 11, 2022
View reviewed changes
@ghostghost
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!
@RussKie
RussKie
commented
Aug 11, 2022

Copy link


Copy Markdown

Contributor
It is building on the CI as well, but looks like a VB related test Microsoft.VisualBasic.Logging.Tests.LogTests.Write is failing:
Error message
System.NullReferenceException : Object reference not set to an instance of an object.
Stack trace
at Microsoft.VisualBasic.Logging.Tests.LogTests.Write() in /_/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Logging/LogTests.cs:line 24
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

@Tanya-SolyanikTanya-Solyanik
mentioned this pull request
Aug 12, 2022
 Merged

@Tanya-Solyanik
Tanya-Solyanik
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
@steveharter , it seems that winforms test failure is related to dotnet/runtime#73087 - if TraceSource is initialized from the config file, it does not initialize the default file listener, and test expects the default listener to be initialized. I suspect winforms should come up with a different way to detect initialization from a config fie, could you please suggest one?
@KlausLoeffelmann
KlausLoeffelmann
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
@steveharter, @Tanya-Solyanik:

To be more precise, it is something in the Application Framework for/in Visual Basic, that's causing this, because it does an assumption, which I frankly don't understand:
https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170
image
This assumption is that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.
Now, what I don't understand: Why would (previously) GetSupportedAttributes only have been called, when the trace source was configured by a config file?
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
968e1e2
…0811.12
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22411.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
041bb13
…0813.1
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
362389b
…0813.9
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.9
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2022…
878a76b
…0814.6
Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22414.6
@dreddy-work
dreddy-work
commented
Aug 15, 2022

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Aug 15, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dreddy-work
dreddy-work
enabled auto-merge (squash)
August 15, 2022 21:10
@dreddy-work
dreddy-work
merged commit 17f8241
into
mainAug 15, 2022
@dreddy-work
dreddy-work
deleted the

darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f

branch
August 15, 2022 21:26
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 15, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@dreddy-workdreddy-workdreddy-work approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@RussKie@Tanya-Solyanik@KlausLoeffelmann@dreddy-work