Temporarily fix VB App Framework Logging. by KlausLoeffelmann · Pull Request #7590 · dotnet/winforms

KlausLoeffelmann · 2022-08-14T23:54:18Z

The runtime PR dotnet/runtime#73087 broke the Visual Basic Application Framework Logging.

https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170

The original assumption that this would work was, that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.

After discussing this with the WinForms Team and the VB PM, we're fixing this temporary in the runtime, by returning false unconditionally for Logging.Log.HasBeenConfigured. This assumes, that the trace source has NOT been configured by a config file. Configuring by a config file remains a broken scenario for VB My.Logging, until we will be getting a fix from the Runtime.

Microsoft Reviewers: Open in CodeFlow

… chnage.

Tanya-Solyanik · 2022-08-15T00:14:15Z

- [MethodImpl(MethodImplOptions.AggressiveInlining)]
- get => GetCachedSwitchValue(ScaleTopLevelFormMinMaxSizeForDpiSwitchName, ref s_scaleTopLevelFormMinMaxSizeForDpi);
- }
+ private const string AssumeVbLogClassWasConfiguredByConfigFileName = "System.Windows.Forms.AssumeVbLogClassWasConfiguredByConfigFile";


CS applications don't need this switch, why not put it into the VB assembly?

I wouldn't say this is language related?
It's not that the Application Framework can only be used by VB. So, for example, take a look at this:
https://stackoverflow.com/questions/59268557/where-is-the-winforms-application-framework-in-c-sharp-that-exists-in-vb-net
Also, I often saw even C# WPF apps using a few features from the VB App Framework to ease their life. It's a valid approach!

Application that benefits from this quirk, references AppFramework, right? Why doesn't this quirk belong to Applicationframework then?

Tanya-Solyanik · 2022-08-15T00:18:06Z

 If _listenerAttributes Is Nothing Then
 _listenerAttributes = Attributes
 End If
- Return _hasBeenInitializedFromConfigFile


I would had returned false here for the RC and would have worked on the proper fix, i.e. how to get if this was initialized from the config file.

I thought about this first. But then I thought, there is a good chance it will stay like this, and then we could have it right away.

there is a good chance it will stay like this,
Maybe runtime can add a protected property for us to look up?

RussKie · 2022-08-15T03:41:43Z

I don't quite understand the use cases, developer and user experiences. It would be great if you could provide more details explaining those. E.g., this is how a .NET Framework app worked, now ported to .NET 7 it'd work like this. Would a developer or use need to opt-in or opt-out?
Thank you

…orms.

KlausLoeffelmann · 2022-08-15T16:35:34Z

I pretty much explained the breaking change in the runtime which led to this.
I added a few lines of explanation in the introduction, what we did.
This needs to go in quick, to unblock us.

Tanya-Solyanik · 2022-08-15T17:53:36Z

I would prefer returning a false unconditionally because:
1 quirks are public APIs and it will be difficult to remove them when we have the fix
2. if an application enables logging in the config file, it has also to define a quirk in json file, this is inconvenient
3. we had not exhausted possibilities of a correct fix,

dreddy-work · 2022-08-15T20:32:29Z

Squash merge please. Or enable auto-merge (that is squash default)

Tanya-Solyanik · 2022-08-16T03:22:28Z

 End If
- Return _hasBeenInitializedFromConfigFile
+
+ ' TODO: This is a tempory fix, which will break configuring logging via file for the time being. See: https://github.com/dotnet/winforms/pull/7590


Did you open a follow up bug to get this fixed?

RussKie · 2022-08-16T03:29:08Z

@KlausLoeffelmann is this a breaking change that we need to document?

merriemcgaw · 2022-08-16T17:33:19Z

@RussKie yeah, probably. It would be a minute number of customers impacted but it's good to document it of course.

Tanya-Solyanik · 2022-08-18T00:02:05Z

app config was not enabled in the previous versions, so this is a regression from .NET framework but not from the previous release of Core

KlausLoeffelmann · 2022-08-14T23:54:18Z

The runtime PR dotnet/runtime#73087 broke the Visual Basic Application Framework Logging.

https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170

The original assumption that this would work was, that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.

After discussing this with the WinForms Team and the VB PM, we're fixing this temporary in the runtime, by returning false unconditionally for Logging.Log.HasBeenConfigured. This assumes, that the trace source has NOT been configured by a config file. Configuring by a config file remains a broken scenario for VB My.Logging, until we will be getting a fix from the Runtime.

Microsoft Reviewers: Open in CodeFlow

… chnage.

Tanya-Solyanik · 2022-08-15T00:14:15Z

- [MethodImpl(MethodImplOptions.AggressiveInlining)]
- get => GetCachedSwitchValue(ScaleTopLevelFormMinMaxSizeForDpiSwitchName, ref s_scaleTopLevelFormMinMaxSizeForDpi);
- }
+ private const string AssumeVbLogClassWasConfiguredByConfigFileName = "System.Windows.Forms.AssumeVbLogClassWasConfiguredByConfigFile";


CS applications don't need this switch, why not put it into the VB assembly?

I wouldn't say this is language related?
It's not that the Application Framework can only be used by VB. So, for example, take a look at this:
https://stackoverflow.com/questions/59268557/where-is-the-winforms-application-framework-in-c-sharp-that-exists-in-vb-net
Also, I often saw even C# WPF apps using a few features from the VB App Framework to ease their life. It's a valid approach!

Application that benefits from this quirk, references AppFramework, right? Why doesn't this quirk belong to Applicationframework then?

Tanya-Solyanik · 2022-08-15T00:18:06Z

 If _listenerAttributes Is Nothing Then
 _listenerAttributes = Attributes
 End If
- Return _hasBeenInitializedFromConfigFile


I would had returned false here for the RC and would have worked on the proper fix, i.e. how to get if this was initialized from the config file.

I thought about this first. But then I thought, there is a good chance it will stay like this, and then we could have it right away.

there is a good chance it will stay like this,
Maybe runtime can add a protected property for us to look up?

RussKie · 2022-08-15T03:41:43Z

I don't quite understand the use cases, developer and user experiences. It would be great if you could provide more details explaining those. E.g., this is how a .NET Framework app worked, now ported to .NET 7 it'd work like this. Would a developer or use need to opt-in or opt-out?
Thank you

…orms.

KlausLoeffelmann · 2022-08-15T16:35:34Z

I pretty much explained the breaking change in the runtime which led to this.
I added a few lines of explanation in the introduction, what we did.
This needs to go in quick, to unblock us.

Tanya-Solyanik · 2022-08-15T17:53:36Z

I would prefer returning a false unconditionally because:
1 quirks are public APIs and it will be difficult to remove them when we have the fix
2. if an application enables logging in the config file, it has also to define a quirk in json file, this is inconvenient
3. we had not exhausted possibilities of a correct fix,

dreddy-work · 2022-08-15T20:32:29Z

Squash merge please. Or enable auto-merge (that is squash default)

Tanya-Solyanik · 2022-08-16T03:22:28Z

 End If
- Return _hasBeenInitializedFromConfigFile
+
+ ' TODO: This is a tempory fix, which will break configuring logging via file for the time being. See: https://github.com/dotnet/winforms/pull/7590


Did you open a follow up bug to get this fixed?

RussKie · 2022-08-16T03:29:08Z

@KlausLoeffelmann is this a breaking change that we need to document?

merriemcgaw · 2022-08-16T17:33:19Z

@RussKie yeah, probably. It would be a minute number of customers impacted but it's good to document it of course.

Tanya-Solyanik · 2022-08-18T00:02:05Z

app config was not enabled in the previous versions, so this is a regression from .NET framework but not from the previous release of Core

KlausLoeffelmann · 2022-08-14T23:54:18Z

The runtime PR dotnet/runtime#73087 broke the Visual Basic Application Framework Logging.

https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170

The original assumption that this would work was, that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.

After discussing this with the WinForms Team and the VB PM, we're fixing this temporary in the runtime, by returning false unconditionally for Logging.Log.HasBeenConfigured. This assumes, that the trace source has NOT been configured by a config file. Configuring by a config file remains a broken scenario for VB My.Logging, until we will be getting a fix from the Runtime.

Microsoft Reviewers: Open in CodeFlow

… chnage.

Tanya-Solyanik · 2022-08-15T00:14:15Z

- [MethodImpl(MethodImplOptions.AggressiveInlining)]
- get => GetCachedSwitchValue(ScaleTopLevelFormMinMaxSizeForDpiSwitchName, ref s_scaleTopLevelFormMinMaxSizeForDpi);
- }
+ private const string AssumeVbLogClassWasConfiguredByConfigFileName = "System.Windows.Forms.AssumeVbLogClassWasConfiguredByConfigFile";


CS applications don't need this switch, why not put it into the VB assembly?

I wouldn't say this is language related?
It's not that the Application Framework can only be used by VB. So, for example, take a look at this:
https://stackoverflow.com/questions/59268557/where-is-the-winforms-application-framework-in-c-sharp-that-exists-in-vb-net
Also, I often saw even C# WPF apps using a few features from the VB App Framework to ease their life. It's a valid approach!

Application that benefits from this quirk, references AppFramework, right? Why doesn't this quirk belong to Applicationframework then?

Tanya-Solyanik · 2022-08-15T00:18:06Z

 If _listenerAttributes Is Nothing Then
 _listenerAttributes = Attributes
 End If
- Return _hasBeenInitializedFromConfigFile


I would had returned false here for the RC and would have worked on the proper fix, i.e. how to get if this was initialized from the config file.

I thought about this first. But then I thought, there is a good chance it will stay like this, and then we could have it right away.

there is a good chance it will stay like this,
Maybe runtime can add a protected property for us to look up?

RussKie · 2022-08-15T03:41:43Z

I don't quite understand the use cases, developer and user experiences. It would be great if you could provide more details explaining those. E.g., this is how a .NET Framework app worked, now ported to .NET 7 it'd work like this. Would a developer or use need to opt-in or opt-out?
Thank you

…orms.

KlausLoeffelmann · 2022-08-15T16:35:34Z

I pretty much explained the breaking change in the runtime which led to this.
I added a few lines of explanation in the introduction, what we did.
This needs to go in quick, to unblock us.

Tanya-Solyanik · 2022-08-15T17:53:36Z

I would prefer returning a false unconditionally because:
1 quirks are public APIs and it will be difficult to remove them when we have the fix
2. if an application enables logging in the config file, it has also to define a quirk in json file, this is inconvenient
3. we had not exhausted possibilities of a correct fix,

dreddy-work · 2022-08-15T20:32:29Z

Squash merge please. Or enable auto-merge (that is squash default)

Tanya-Solyanik · 2022-08-16T03:22:28Z

 End If
- Return _hasBeenInitializedFromConfigFile
+
+ ' TODO: This is a tempory fix, which will break configuring logging via file for the time being. See: https://github.com/dotnet/winforms/pull/7590


Did you open a follow up bug to get this fixed?

RussKie · 2022-08-16T03:29:08Z

@KlausLoeffelmann is this a breaking change that we need to document?

merriemcgaw · 2022-08-16T17:33:19Z

@RussKie yeah, probably. It would be a minute number of customers impacted but it's good to document it of course.

Tanya-Solyanik · 2022-08-18T00:02:05Z

app config was not enabled in the previous versions, so this is a regression from .NET framework but not from the previous release of Core

KlausLoeffelmann · 2022-08-14T23:54:18Z

The runtime PR dotnet/runtime#73087 broke the Visual Basic Application Framework Logging.

https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170

The original assumption that this would work was, that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.

After discussing this with the WinForms Team and the VB PM, we're fixing this temporary in the runtime, by returning false unconditionally for Logging.Log.HasBeenConfigured. This assumes, that the trace source has NOT been configured by a config file. Configuring by a config file remains a broken scenario for VB My.Logging, until we will be getting a fix from the Runtime.

Microsoft Reviewers: Open in CodeFlow

… chnage.

Tanya-Solyanik · 2022-08-15T00:14:15Z

- [MethodImpl(MethodImplOptions.AggressiveInlining)]
- get => GetCachedSwitchValue(ScaleTopLevelFormMinMaxSizeForDpiSwitchName, ref s_scaleTopLevelFormMinMaxSizeForDpi);
- }
+ private const string AssumeVbLogClassWasConfiguredByConfigFileName = "System.Windows.Forms.AssumeVbLogClassWasConfiguredByConfigFile";


CS applications don't need this switch, why not put it into the VB assembly?

I wouldn't say this is language related?
It's not that the Application Framework can only be used by VB. So, for example, take a look at this:
https://stackoverflow.com/questions/59268557/where-is-the-winforms-application-framework-in-c-sharp-that-exists-in-vb-net
Also, I often saw even C# WPF apps using a few features from the VB App Framework to ease their life. It's a valid approach!

Application that benefits from this quirk, references AppFramework, right? Why doesn't this quirk belong to Applicationframework then?

Tanya-Solyanik · 2022-08-15T00:18:06Z

 If _listenerAttributes Is Nothing Then
 _listenerAttributes = Attributes
 End If
- Return _hasBeenInitializedFromConfigFile


I would had returned false here for the RC and would have worked on the proper fix, i.e. how to get if this was initialized from the config file.

I thought about this first. But then I thought, there is a good chance it will stay like this, and then we could have it right away.

there is a good chance it will stay like this,
Maybe runtime can add a protected property for us to look up?

RussKie · 2022-08-15T03:41:43Z

I don't quite understand the use cases, developer and user experiences. It would be great if you could provide more details explaining those. E.g., this is how a .NET Framework app worked, now ported to .NET 7 it'd work like this. Would a developer or use need to opt-in or opt-out?
Thank you

…orms.

KlausLoeffelmann · 2022-08-15T16:35:34Z

I pretty much explained the breaking change in the runtime which led to this.
I added a few lines of explanation in the introduction, what we did.
This needs to go in quick, to unblock us.

Tanya-Solyanik · 2022-08-15T17:53:36Z

I would prefer returning a false unconditionally because:
1 quirks are public APIs and it will be difficult to remove them when we have the fix
2. if an application enables logging in the config file, it has also to define a quirk in json file, this is inconvenient
3. we had not exhausted possibilities of a correct fix,

dreddy-work · 2022-08-15T20:32:29Z

Squash merge please. Or enable auto-merge (that is squash default)

Tanya-Solyanik · 2022-08-16T03:22:28Z

 End If
- Return _hasBeenInitializedFromConfigFile
+
+ ' TODO: This is a tempory fix, which will break configuring logging via file for the time being. See: https://github.com/dotnet/winforms/pull/7590


Did you open a follow up bug to get this fixed?

RussKie · 2022-08-16T03:29:08Z

@KlausLoeffelmann is this a breaking change that we need to document?

merriemcgaw · 2022-08-16T17:33:19Z

@RussKie yeah, probably. It would be a minute number of customers impacted but it's good to document it of course.

Tanya-Solyanik · 2022-08-18T00:02:05Z

app config was not enabled in the previous versions, so this is a regression from .NET framework but not from the previous release of Core

KlausLoeffelmann · 2022-08-14T23:54:18Z

The runtime PR dotnet/runtime#73087 broke the Visual Basic Application Framework Logging.

https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170

The original assumption that this would work was, that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.

After discussing this with the WinForms Team and the VB PM, we're fixing this temporary in the runtime, by returning false unconditionally for Logging.Log.HasBeenConfigured. This assumes, that the trace source has NOT been configured by a config file. Configuring by a config file remains a broken scenario for VB My.Logging, until we will be getting a fix from the Runtime.

Microsoft Reviewers: Open in CodeFlow

… chnage.

Tanya-Solyanik · 2022-08-15T00:14:15Z

- [MethodImpl(MethodImplOptions.AggressiveInlining)]
- get => GetCachedSwitchValue(ScaleTopLevelFormMinMaxSizeForDpiSwitchName, ref s_scaleTopLevelFormMinMaxSizeForDpi);
- }
+ private const string AssumeVbLogClassWasConfiguredByConfigFileName = "System.Windows.Forms.AssumeVbLogClassWasConfiguredByConfigFile";


CS applications don't need this switch, why not put it into the VB assembly?

I wouldn't say this is language related?
It's not that the Application Framework can only be used by VB. So, for example, take a look at this:
https://stackoverflow.com/questions/59268557/where-is-the-winforms-application-framework-in-c-sharp-that-exists-in-vb-net
Also, I often saw even C# WPF apps using a few features from the VB App Framework to ease their life. It's a valid approach!

Application that benefits from this quirk, references AppFramework, right? Why doesn't this quirk belong to Applicationframework then?

Tanya-Solyanik · 2022-08-15T00:18:06Z

 If _listenerAttributes Is Nothing Then
 _listenerAttributes = Attributes
 End If
- Return _hasBeenInitializedFromConfigFile


I would had returned false here for the RC and would have worked on the proper fix, i.e. how to get if this was initialized from the config file.

I thought about this first. But then I thought, there is a good chance it will stay like this, and then we could have it right away.

there is a good chance it will stay like this,
Maybe runtime can add a protected property for us to look up?

RussKie · 2022-08-15T03:41:43Z

I don't quite understand the use cases, developer and user experiences. It would be great if you could provide more details explaining those. E.g., this is how a .NET Framework app worked, now ported to .NET 7 it'd work like this. Would a developer or use need to opt-in or opt-out?
Thank you

…orms.

KlausLoeffelmann · 2022-08-15T16:35:34Z

I pretty much explained the breaking change in the runtime which led to this.
I added a few lines of explanation in the introduction, what we did.
This needs to go in quick, to unblock us.

Tanya-Solyanik · 2022-08-15T17:53:36Z

I would prefer returning a false unconditionally because:
1 quirks are public APIs and it will be difficult to remove them when we have the fix
2. if an application enables logging in the config file, it has also to define a quirk in json file, this is inconvenient
3. we had not exhausted possibilities of a correct fix,

dreddy-work · 2022-08-15T20:32:29Z

Squash merge please. Or enable auto-merge (that is squash default)

Tanya-Solyanik · 2022-08-16T03:22:28Z

 End If
- Return _hasBeenInitializedFromConfigFile
+
+ ' TODO: This is a tempory fix, which will break configuring logging via file for the time being. See: https://github.com/dotnet/winforms/pull/7590


Did you open a follow up bug to get this fixed?

RussKie · 2022-08-16T03:29:08Z

@KlausLoeffelmann is this a breaking change that we need to document?

merriemcgaw · 2022-08-16T17:33:19Z

@RussKie yeah, probably. It would be a minute number of customers impacted but it's good to document it of course.

Tanya-Solyanik · 2022-08-18T00:02:05Z

app config was not enabled in the previous versions, so this is a regression from .NET framework but not from the previous release of Core

KlausLoeffelmann · 2022-08-14T23:54:18Z

The runtime PR dotnet/runtime#73087 broke the Visual Basic Application Framework Logging.

https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170

The original assumption that this would work was, that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.

After discussing this with the WinForms Team and the VB PM, we're fixing this temporary in the runtime, by returning false unconditionally for Logging.Log.HasBeenConfigured. This assumes, that the trace source has NOT been configured by a config file. Configuring by a config file remains a broken scenario for VB My.Logging, until we will be getting a fix from the Runtime.

Microsoft Reviewers: Open in CodeFlow

… chnage.

Tanya-Solyanik · 2022-08-15T00:14:15Z

- [MethodImpl(MethodImplOptions.AggressiveInlining)]
- get => GetCachedSwitchValue(ScaleTopLevelFormMinMaxSizeForDpiSwitchName, ref s_scaleTopLevelFormMinMaxSizeForDpi);
- }
+ private const string AssumeVbLogClassWasConfiguredByConfigFileName = "System.Windows.Forms.AssumeVbLogClassWasConfiguredByConfigFile";


CS applications don't need this switch, why not put it into the VB assembly?

I wouldn't say this is language related?
It's not that the Application Framework can only be used by VB. So, for example, take a look at this:
https://stackoverflow.com/questions/59268557/where-is-the-winforms-application-framework-in-c-sharp-that-exists-in-vb-net
Also, I often saw even C# WPF apps using a few features from the VB App Framework to ease their life. It's a valid approach!

Application that benefits from this quirk, references AppFramework, right? Why doesn't this quirk belong to Applicationframework then?

Tanya-Solyanik · 2022-08-15T00:18:06Z

 If _listenerAttributes Is Nothing Then
 _listenerAttributes = Attributes
 End If
- Return _hasBeenInitializedFromConfigFile


I would had returned false here for the RC and would have worked on the proper fix, i.e. how to get if this was initialized from the config file.

I thought about this first. But then I thought, there is a good chance it will stay like this, and then we could have it right away.

there is a good chance it will stay like this,
Maybe runtime can add a protected property for us to look up?

RussKie · 2022-08-15T03:41:43Z

I don't quite understand the use cases, developer and user experiences. It would be great if you could provide more details explaining those. E.g., this is how a .NET Framework app worked, now ported to .NET 7 it'd work like this. Would a developer or use need to opt-in or opt-out?
Thank you

…orms.

KlausLoeffelmann · 2022-08-15T16:35:34Z

I pretty much explained the breaking change in the runtime which led to this.
I added a few lines of explanation in the introduction, what we did.
This needs to go in quick, to unblock us.

Tanya-Solyanik · 2022-08-15T17:53:36Z

I would prefer returning a false unconditionally because:
1 quirks are public APIs and it will be difficult to remove them when we have the fix
2. if an application enables logging in the config file, it has also to define a quirk in json file, this is inconvenient
3. we had not exhausted possibilities of a correct fix,

dreddy-work · 2022-08-15T20:32:29Z

Squash merge please. Or enable auto-merge (that is squash default)

Tanya-Solyanik · 2022-08-16T03:22:28Z

 End If
- Return _hasBeenInitializedFromConfigFile
+
+ ' TODO: This is a tempory fix, which will break configuring logging via file for the time being. See: https://github.com/dotnet/winforms/pull/7590


Did you open a follow up bug to get this fixed?

RussKie · 2022-08-16T03:29:08Z

@KlausLoeffelmann is this a breaking change that we need to document?

merriemcgaw · 2022-08-16T17:33:19Z

@RussKie yeah, probably. It would be a minute number of customers impacted but it's good to document it of course.

Tanya-Solyanik · 2022-08-18T00:02:05Z

app config was not enabled in the previous versions, so this is a regression from .NET framework but not from the previous release of Core

KlausLoeffelmann · 2022-08-14T23:54:18Z

The runtime PR dotnet/runtime#73087 broke the Visual Basic Application Framework Logging.

https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170

The original assumption that this would work was, that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.

After discussing this with the WinForms Team and the VB PM, we're fixing this temporary in the runtime, by returning false unconditionally for Logging.Log.HasBeenConfigured. This assumes, that the trace source has NOT been configured by a config file. Configuring by a config file remains a broken scenario for VB My.Logging, until we will be getting a fix from the Runtime.

Microsoft Reviewers: Open in CodeFlow

… chnage.

Tanya-Solyanik · 2022-08-15T00:14:15Z

- [MethodImpl(MethodImplOptions.AggressiveInlining)]
- get => GetCachedSwitchValue(ScaleTopLevelFormMinMaxSizeForDpiSwitchName, ref s_scaleTopLevelFormMinMaxSizeForDpi);
- }
+ private const string AssumeVbLogClassWasConfiguredByConfigFileName = "System.Windows.Forms.AssumeVbLogClassWasConfiguredByConfigFile";


CS applications don't need this switch, why not put it into the VB assembly?

I wouldn't say this is language related?
It's not that the Application Framework can only be used by VB. So, for example, take a look at this:
https://stackoverflow.com/questions/59268557/where-is-the-winforms-application-framework-in-c-sharp-that-exists-in-vb-net
Also, I often saw even C# WPF apps using a few features from the VB App Framework to ease their life. It's a valid approach!

Application that benefits from this quirk, references AppFramework, right? Why doesn't this quirk belong to Applicationframework then?

Tanya-Solyanik · 2022-08-15T00:18:06Z

 If _listenerAttributes Is Nothing Then
 _listenerAttributes = Attributes
 End If
- Return _hasBeenInitializedFromConfigFile


I would had returned false here for the RC and would have worked on the proper fix, i.e. how to get if this was initialized from the config file.

I thought about this first. But then I thought, there is a good chance it will stay like this, and then we could have it right away.

there is a good chance it will stay like this,
Maybe runtime can add a protected property for us to look up?

RussKie · 2022-08-15T03:41:43Z

I don't quite understand the use cases, developer and user experiences. It would be great if you could provide more details explaining those. E.g., this is how a .NET Framework app worked, now ported to .NET 7 it'd work like this. Would a developer or use need to opt-in or opt-out?
Thank you

…orms.

KlausLoeffelmann · 2022-08-15T16:35:34Z

I pretty much explained the breaking change in the runtime which led to this.
I added a few lines of explanation in the introduction, what we did.
This needs to go in quick, to unblock us.

Tanya-Solyanik · 2022-08-15T17:53:36Z

I would prefer returning a false unconditionally because:
1 quirks are public APIs and it will be difficult to remove them when we have the fix
2. if an application enables logging in the config file, it has also to define a quirk in json file, this is inconvenient
3. we had not exhausted possibilities of a correct fix,

dreddy-work · 2022-08-15T20:32:29Z

Squash merge please. Or enable auto-merge (that is squash default)

Tanya-Solyanik · 2022-08-16T03:22:28Z

 End If
- Return _hasBeenInitializedFromConfigFile
+
+ ' TODO: This is a tempory fix, which will break configuring logging via file for the time being. See: https://github.com/dotnet/winforms/pull/7590


Did you open a follow up bug to get this fixed?

RussKie · 2022-08-16T03:29:08Z

@KlausLoeffelmann is this a breaking change that we need to document?

merriemcgaw · 2022-08-16T17:33:19Z

@RussKie yeah, probably. It would be a minute number of customers impacted but it's good to document it of course.

Tanya-Solyanik · 2022-08-18T00:02:05Z

app config was not enabled in the previous versions, so this is a regression from .NET framework but not from the previous release of Core

dreddy-workand others added 10 commits July 1, 2022 11:19

Draft
6f722cf

Draft chnages for risk assesment.
1af2b94

Introduce runtime-config settigns for opt-in or opt-out of a breaking…
4b07447
… chnage.

Merge branch 'main' into dev/dreddy/fix7251
b296123

Address review feedback.
8117534

Adress further feedback
96bfd93

Fix test and address review comments.
d0746ba

Test skip that was accidentally removed.
22ce594

Merge branch 'main' into FixVbLogging
6651e56

Patch Microsoft.VisualBasic.Logging.Log to unblock failing tests.
3931bea

ghost assigned KlausLoeffelmann Aug 14, 2022

ghost added the draft draft PR label Aug 15, 2022

Tanya-Solyanik reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/System.Windows.Forms.Primitives/src/System.Windows.Forms.Primitives.csproj Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

Copy LocalAppContextSwitches functionality to Microsoft.VisualBasic.F…
7dfca3d
…orms.

KlausLoeffelmann changed the title ~~Fix VB App Framework Logging.~~Temporarily fix VB App Framework Logging.Aug 15, 2022

Revert quirking, disable config file logging for My.Logging.Log.
68af597

KlausLoeffelmann marked this pull request as ready for review August 15, 2022 20:17

KlausLoeffelmann requested a review from a team as a code owner August 15, 2022 20:17

dreddy-work reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/Microsoft.VisualBasic.Forms/src/Microsoft.VisualBasic.Forms.vbproj

KlausLoeffelmann added 2 commits August 15, 2022 13:27

Reset file.
b6f08db

Remove redundant Imports statement.
bc0a179

dreddy-work approved these changes Aug 15, 2022
View reviewed changes

KlausLoeffelmann enabled auto-merge (squash) August 15, 2022 20:32

KlausLoeffelmann merged commit 205f434 into dotnet:mainAug 15, 2022

ghost added this to the 7.0 RC1 milestone Aug 15, 2022

ghost removed the draft draft PR label Aug 16, 2022

Tanya-Solyanik reviewed Aug 16, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Sep 17, 2022

KlausLoeffelmann deleted the FixVbLogging branch May 26, 2026 19:51

dreddy-workand others added 10 commits July 1, 2022 11:19

Draft
6f722cf

Draft chnages for risk assesment.
1af2b94

Introduce runtime-config settigns for opt-in or opt-out of a breaking…
4b07447
… chnage.

Merge branch 'main' into dev/dreddy/fix7251
b296123

Address review feedback.
8117534

Adress further feedback
96bfd93

Fix test and address review comments.
d0746ba

Test skip that was accidentally removed.
22ce594

Merge branch 'main' into FixVbLogging
6651e56

Patch Microsoft.VisualBasic.Logging.Log to unblock failing tests.
3931bea

ghost assigned KlausLoeffelmann Aug 14, 2022

ghost added the draft draft PR label Aug 15, 2022

Tanya-Solyanik reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/System.Windows.Forms.Primitives/src/System.Windows.Forms.Primitives.csproj Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

Copy LocalAppContextSwitches functionality to Microsoft.VisualBasic.F…
7dfca3d
…orms.

KlausLoeffelmann changed the title ~~Fix VB App Framework Logging.~~Temporarily fix VB App Framework Logging.Aug 15, 2022

Revert quirking, disable config file logging for My.Logging.Log.
68af597

KlausLoeffelmann marked this pull request as ready for review August 15, 2022 20:17

KlausLoeffelmann requested a review from a team as a code owner August 15, 2022 20:17

dreddy-work reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/Microsoft.VisualBasic.Forms/src/Microsoft.VisualBasic.Forms.vbproj

KlausLoeffelmann added 2 commits August 15, 2022 13:27

Reset file.
b6f08db

Remove redundant Imports statement.
bc0a179

dreddy-work approved these changes Aug 15, 2022
View reviewed changes

KlausLoeffelmann enabled auto-merge (squash) August 15, 2022 20:32

KlausLoeffelmann merged commit 205f434 into dotnet:mainAug 15, 2022

ghost added this to the 7.0 RC1 milestone Aug 15, 2022

ghost removed the draft draft PR label Aug 16, 2022

Tanya-Solyanik reviewed Aug 16, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Sep 17, 2022

KlausLoeffelmann deleted the FixVbLogging branch May 26, 2026 19:51

dreddy-workand others added 10 commits July 1, 2022 11:19

Draft
6f722cf

Draft chnages for risk assesment.
1af2b94

Introduce runtime-config settigns for opt-in or opt-out of a breaking…
4b07447
… chnage.

Merge branch 'main' into dev/dreddy/fix7251
b296123

Address review feedback.
8117534

Adress further feedback
96bfd93

Fix test and address review comments.
d0746ba

Test skip that was accidentally removed.
22ce594

Merge branch 'main' into FixVbLogging
6651e56

Patch Microsoft.VisualBasic.Logging.Log to unblock failing tests.
3931bea

ghost assigned KlausLoeffelmann Aug 14, 2022

ghost added the draft draft PR label Aug 15, 2022

Tanya-Solyanik reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/System.Windows.Forms.Primitives/src/System.Windows.Forms.Primitives.csproj Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

Copy LocalAppContextSwitches functionality to Microsoft.VisualBasic.F…
7dfca3d
…orms.

KlausLoeffelmann changed the title ~~Fix VB App Framework Logging.~~Temporarily fix VB App Framework Logging.Aug 15, 2022

Revert quirking, disable config file logging for My.Logging.Log.
68af597

KlausLoeffelmann marked this pull request as ready for review August 15, 2022 20:17

KlausLoeffelmann requested a review from a team as a code owner August 15, 2022 20:17

dreddy-work reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/Microsoft.VisualBasic.Forms/src/Microsoft.VisualBasic.Forms.vbproj

KlausLoeffelmann added 2 commits August 15, 2022 13:27

Reset file.
b6f08db

Remove redundant Imports statement.
bc0a179

dreddy-work approved these changes Aug 15, 2022
View reviewed changes

KlausLoeffelmann enabled auto-merge (squash) August 15, 2022 20:32

KlausLoeffelmann merged commit 205f434 into dotnet:mainAug 15, 2022

ghost added this to the 7.0 RC1 milestone Aug 15, 2022

ghost removed the draft draft PR label Aug 16, 2022

Tanya-Solyanik reviewed Aug 16, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Sep 17, 2022

KlausLoeffelmann deleted the FixVbLogging branch May 26, 2026 19:51

dreddy-workand others added 10 commits July 1, 2022 11:19

Draft
6f722cf

Draft chnages for risk assesment.
1af2b94

Introduce runtime-config settigns for opt-in or opt-out of a breaking…
4b07447
… chnage.

Merge branch 'main' into dev/dreddy/fix7251
b296123

Address review feedback.
8117534

Adress further feedback
96bfd93

Fix test and address review comments.
d0746ba

Test skip that was accidentally removed.
22ce594

Merge branch 'main' into FixVbLogging
6651e56

Patch Microsoft.VisualBasic.Logging.Log to unblock failing tests.
3931bea

ghost assigned KlausLoeffelmann Aug 14, 2022

ghost added the draft draft PR label Aug 15, 2022

Tanya-Solyanik reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/System.Windows.Forms.Primitives/src/System.Windows.Forms.Primitives.csproj Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

Copy LocalAppContextSwitches functionality to Microsoft.VisualBasic.F…
7dfca3d
…orms.

KlausLoeffelmann changed the title ~~Fix VB App Framework Logging.~~Temporarily fix VB App Framework Logging.Aug 15, 2022

Revert quirking, disable config file logging for My.Logging.Log.
68af597

KlausLoeffelmann marked this pull request as ready for review August 15, 2022 20:17

KlausLoeffelmann requested a review from a team as a code owner August 15, 2022 20:17

dreddy-work reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/Microsoft.VisualBasic.Forms/src/Microsoft.VisualBasic.Forms.vbproj

KlausLoeffelmann added 2 commits August 15, 2022 13:27

Reset file.
b6f08db

Remove redundant Imports statement.
bc0a179

dreddy-work approved these changes Aug 15, 2022
View reviewed changes

KlausLoeffelmann enabled auto-merge (squash) August 15, 2022 20:32

KlausLoeffelmann merged commit 205f434 into dotnet:mainAug 15, 2022

ghost added this to the 7.0 RC1 milestone Aug 15, 2022

ghost removed the draft draft PR label Aug 16, 2022

Tanya-Solyanik reviewed Aug 16, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Sep 17, 2022

KlausLoeffelmann deleted the FixVbLogging branch May 26, 2026 19:51

dreddy-workand others added 10 commits July 1, 2022 11:19

Draft
6f722cf

Draft chnages for risk assesment.
1af2b94

Introduce runtime-config settigns for opt-in or opt-out of a breaking…
4b07447
… chnage.

Merge branch 'main' into dev/dreddy/fix7251
b296123

Address review feedback.
8117534

Adress further feedback
96bfd93

Fix test and address review comments.
d0746ba

Test skip that was accidentally removed.
22ce594

Merge branch 'main' into FixVbLogging
6651e56

Patch Microsoft.VisualBasic.Logging.Log to unblock failing tests.
3931bea

ghost assigned KlausLoeffelmann Aug 14, 2022

ghost added the draft draft PR label Aug 15, 2022

Tanya-Solyanik reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/System.Windows.Forms.Primitives/src/System.Windows.Forms.Primitives.csproj Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

Copy LocalAppContextSwitches functionality to Microsoft.VisualBasic.F…
7dfca3d
…orms.

KlausLoeffelmann changed the title ~~Fix VB App Framework Logging.~~Temporarily fix VB App Framework Logging.Aug 15, 2022

Revert quirking, disable config file logging for My.Logging.Log.
68af597

KlausLoeffelmann marked this pull request as ready for review August 15, 2022 20:17

KlausLoeffelmann requested a review from a team as a code owner August 15, 2022 20:17

dreddy-work reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/Microsoft.VisualBasic.Forms/src/Microsoft.VisualBasic.Forms.vbproj

KlausLoeffelmann added 2 commits August 15, 2022 13:27

Reset file.
b6f08db

Remove redundant Imports statement.
bc0a179

dreddy-work approved these changes Aug 15, 2022
View reviewed changes

KlausLoeffelmann enabled auto-merge (squash) August 15, 2022 20:32

KlausLoeffelmann merged commit 205f434 into dotnet:mainAug 15, 2022

ghost added this to the 7.0 RC1 milestone Aug 15, 2022

ghost removed the draft draft PR label Aug 16, 2022

Tanya-Solyanik reviewed Aug 16, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Sep 17, 2022

KlausLoeffelmann deleted the FixVbLogging branch May 26, 2026 19:51

dreddy-workand others added 10 commits July 1, 2022 11:19

Draft
6f722cf

Draft chnages for risk assesment.
1af2b94

Introduce runtime-config settigns for opt-in or opt-out of a breaking…
4b07447
… chnage.

Merge branch 'main' into dev/dreddy/fix7251
b296123

Address review feedback.
8117534

Adress further feedback
96bfd93

Fix test and address review comments.
d0746ba

Test skip that was accidentally removed.
22ce594

Merge branch 'main' into FixVbLogging
6651e56

Patch Microsoft.VisualBasic.Logging.Log to unblock failing tests.
3931bea

ghost assigned KlausLoeffelmann Aug 14, 2022

ghost added the draft draft PR label Aug 15, 2022

Tanya-Solyanik reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/System.Windows.Forms.Primitives/src/System.Windows.Forms.Primitives.csproj Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

Copy LocalAppContextSwitches functionality to Microsoft.VisualBasic.F…
7dfca3d
…orms.

KlausLoeffelmann changed the title ~~Fix VB App Framework Logging.~~Temporarily fix VB App Framework Logging.Aug 15, 2022

Revert quirking, disable config file logging for My.Logging.Log.
68af597

KlausLoeffelmann marked this pull request as ready for review August 15, 2022 20:17

KlausLoeffelmann requested a review from a team as a code owner August 15, 2022 20:17

dreddy-work reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/Microsoft.VisualBasic.Forms/src/Microsoft.VisualBasic.Forms.vbproj

KlausLoeffelmann added 2 commits August 15, 2022 13:27

Reset file.
b6f08db

Remove redundant Imports statement.
bc0a179

dreddy-work approved these changes Aug 15, 2022
View reviewed changes

KlausLoeffelmann enabled auto-merge (squash) August 15, 2022 20:32

KlausLoeffelmann merged commit 205f434 into dotnet:mainAug 15, 2022

ghost added this to the 7.0 RC1 milestone Aug 15, 2022

ghost removed the draft draft PR label Aug 16, 2022

Tanya-Solyanik reviewed Aug 16, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Sep 17, 2022

KlausLoeffelmann deleted the FixVbLogging branch May 26, 2026 19:51

dreddy-workand others added 10 commits July 1, 2022 11:19

Draft
6f722cf

Draft chnages for risk assesment.
1af2b94

Introduce runtime-config settigns for opt-in or opt-out of a breaking…
4b07447
… chnage.

Merge branch 'main' into dev/dreddy/fix7251
b296123

Address review feedback.
8117534

Adress further feedback
96bfd93

Fix test and address review comments.
d0746ba

Test skip that was accidentally removed.
22ce594

Merge branch 'main' into FixVbLogging
6651e56

Patch Microsoft.VisualBasic.Logging.Log to unblock failing tests.
3931bea

ghost assigned KlausLoeffelmann Aug 14, 2022

ghost added the draft draft PR label Aug 15, 2022

Tanya-Solyanik reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/System.Windows.Forms.Primitives/src/System.Windows.Forms.Primitives.csproj Outdated

RussKie reviewed Aug 15, 2022
View reviewed changes

Comment thread...ystem.Windows.Forms.Primitives/src/System/LocalAppContextSwitches/LocalAppContextSwitches.cs Outdated

Copy LocalAppContextSwitches functionality to Microsoft.VisualBasic.F…
7dfca3d
…orms.

KlausLoeffelmann changed the title ~~Fix VB App Framework Logging.~~Temporarily fix VB App Framework Logging.Aug 15, 2022

Revert quirking, disable config file logging for My.Logging.Log.
68af597

KlausLoeffelmann marked this pull request as ready for review August 15, 2022 20:17

KlausLoeffelmann requested a review from a team as a code owner August 15, 2022 20:17

dreddy-work reviewed Aug 15, 2022
View reviewed changes

Comment threadsrc/Microsoft.VisualBasic.Forms/src/Microsoft.VisualBasic.Forms.vbproj

KlausLoeffelmann added 2 commits August 15, 2022 13:27

Reset file.
b6f08db

Remove redundant Imports statement.
bc0a179

dreddy-work approved these changes Aug 15, 2022
View reviewed changes

KlausLoeffelmann enabled auto-merge (squash) August 15, 2022 20:32

KlausLoeffelmann merged commit 205f434 into dotnet:mainAug 15, 2022

ghost added this to the 7.0 RC1 milestone Aug 15, 2022

ghost removed the draft draft PR label Aug 16, 2022

Tanya-Solyanik reviewed Aug 16, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Sep 17, 2022

KlausLoeffelmann deleted the FixVbLogging branch May 26, 2026 19:51

Uh oh!

Conversation

KlausLoeffelmann commented Aug 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RussKie commented Aug 15, 2022

Uh oh!

KlausLoeffelmann commented Aug 15, 2022

Uh oh!

Tanya-Solyanik commented Aug 15, 2022

Uh oh!

Uh oh!

dreddy-work commented Aug 15, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RussKie commented Aug 16, 2022

Uh oh!

merriemcgaw commented Aug 16, 2022

Uh oh!

Tanya-Solyanik commented Aug 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

KlausLoeffelmann commented Aug 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RussKie commented Aug 15, 2022

Uh oh!

KlausLoeffelmann commented Aug 15, 2022

Uh oh!

Tanya-Solyanik commented Aug 15, 2022

Uh oh!

Uh oh!

dreddy-work commented Aug 15, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KlausLoeffelmann commented Aug 14, 2022•
edited
Loading

dreddy-work commented Aug 15, 2022•
edited
Loading

KlausLoeffelmann commented Aug 14, 2022•
edited
Loading

dreddy-work commented Aug 15, 2022•
edited
Loading

KlausLoeffelmann commented Aug 14, 2022•
edited
Loading