Uh oh!
There was an error while loading. Please reload this page.
Enable nullability in StronglyTypedResourceBuilder - #9663
Merged
dreddy-work merged 2 commits intoSep 25, 2023
Conversation
| string valueAsString = node.GetValue((AssemblyName[])null).ToString(); | ||
| string typeName = node.GetValueTypeName((AssemblyName[]?)null)!; | ||
| Type? type = Type.GetType(typeName); | ||
| string? valueAsString = node.GetValue((AssemblyName[]?)null)!.ToString(); |
Member
There was a problem hiding this comment.
Why is this declared as nullable? you already use ! before converting it to oString()
ContributorAuthor
There was a problem hiding this comment.
ToString outputs a string?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 5, 2023
elachlan
commented
Aug 5, 2023
Contributor
@halgab do you plan to tackle the problems in runtime? |
halgab
commented
Aug 6, 2023
ContributorAuthor
The dotnet team started to discuss the issue again in dotnet/runtime#78036. I'm waiting to see where this discussion is going before offering my help to annotate System.CodeDom. |
halgabforce-pushed
the
StronglyTypedResourceBuilder-null
branch
from
August 7, 2023 20:24
970ae36 to
f5c2266Comparehalgabforce-pushed
the
StronglyTypedResourceBuilder-null
branch
2 times, most recently
from
August 15, 2023 12:13
72cd2f9 to
0caeec3Comparehalgab
commented
Aug 15, 2023
ContributorAuthor
Now that dotnet/runtime#90401 has been merged, I rebased and removed several occurences of |
halgabforce-pushed
the
StronglyTypedResourceBuilder-null
branch
from
September 20, 2023 09:23
0caeec3 to
b3d33caComparedreddy-work
approved these changes
Sep 22, 2023
dreddy-work
commented
Sep 25, 2023
Member
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to fix nullable annotations of
ResXDataNodein the process. This class was annotated for .Net 8, so it's not too late to make the changes without too much hassle.I also unearthed quite a few problems in the annotations of System.CodeDom that forced me to use the null forgiving operator more than I should normally have to.
Proposed changes
StronglyTypedResourceBuilderMicrosoft Reviewers: Open in CodeFlow