Skip to content

Add Developments#4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dqve merged 4 commits into from
Nov 9, 2022
Merged

Add Developments #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ba405e
Make filetype prop none required
dqve Nov 9, 2022
98ea2dd
Update file type.
dqve Nov 9, 2022
f516c52
Merge branch 'master' into developments
dqve Nov 9, 2022
410e72b
Updated dependencies to use react 16 and dded children to the button.
dqve Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,7 @@ Property | Type | Description
**id** | *string* | ID attribute of button element.
**className** | *string* | Class attribute of button element.
**buttonText** | *string* | Button text.

**children** | *element* | Child elements to render instead of the button text.

## Example

Expand Down
31 changes: 16 additions & 15 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
{
"name": "react-html-table-to-excel",
"version": "2.0.0",
"version": "3.0.0",
"description": "Small react component for converting and downloading HTML table to Excel file",
"main": "index.js",
"scripts": {
"build": "./node_modules/.bin/babel ./src/ReactHTMLTableToExcel.jsx -o index.js",
"prepublish": "npm run build",
"client:test": "NODE_ENV=test jest",
"client:test:watch": "NODE_ENV=test jest --watch"
"client:test": "jest",
"client:test:watch": "jest --watch"
},
"repository": {
"type": "git",
Expand DownExpand Up@@ -39,7 +39,7 @@
]
},
"peerDependencies": {
"react": "^15.x.x"
"react": "^16.x.x"
},
"devDependencies": {
"babel-cli": "^6.24.1",
Expand All@@ -48,20 +48,21 @@
"babel-preset-react": "^6.24.1",
"babel-preset-stage-0": "^6.24.1",
"chai": "^3.5.0",
"chai-enzyme": "^0.6.1",
"enzyme": "^2.8.2",
"eslint": "^3.19.0",
"eslint-config-airbnb": "^14.1.0",
"chai-enzyme": "^1.0.0-beta.1",
"enzyme": "^3.11.0",
"enzyme-adapter-react-16": "^1.15.6",
"eslint": "^8.18.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-plugin-import": "^2.2.0",
"eslint-plugin-jsx-a11y": "^5.0.1",
"eslint-plugin-react": "^7.0.0",
"jest": "^20.0.1",
"react": "^15.5.4",
"react-dom": "^15.5.4",
"react-test-renderer": "^15.5.4",
"eslint-plugin-jsx-a11y": "^6.6.0",
"eslint-plugin-react": "^7.30.1",
"jest": "^20.0.4",
"react": "^16.14.0",
"react-dom": "^16.14.0",
"react-test-renderer": "^16.14.0",
"sinon": "^2.2.0"
},
"dependencies": {
"prop-types": "^15.5.10"
"prop-types": "^15.8.1"
}
}
7 changes: 5 additions & 2 deletions src/ReactHTMLTableToExcel.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import PropTypes from 'prop-types';
const propTypes = {
table: PropTypes.string.isRequired,
filename: PropTypes.string.isRequired,
filetype: PropTypes.string,
sheet: PropTypes.string.isRequired,
id: PropTypes.string,
className: PropTypes.string,
Expand DownExpand Up@@ -50,7 +51,9 @@ class ReactHTMLTableToExcel extends Component {

const table = document.getElementById(this.props.table).outerHTML;
const sheet = String(this.props.sheet);
const filename = `${String(this.props.filename)}.xlsx`;
const filetype = String((this.props.filetype)?(this.props.filetype === 'xlsx'?'xlsx':'xls'):'xls')
const filename = `${String(this.props.filename) + '.' + filetype}`;


const uri = 'data:application/vnd.ms-excel;base64,';
const template =
Expand DownExpand Up@@ -101,7 +104,7 @@ class ReactHTMLTableToExcel extends Component {
type="button"
onClick={this.handleDownload}
>
{this.props.buttonText}
{this.props.children ? this.props.children : this.props.buttonText}
</button>
);
}
Expand Down
4 changes: 4 additions & 0 deletions test/index.test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
import React from 'react';
import chai, { expect } from 'chai';
import chaiEnzyme from 'chai-enzyme';
import { configure } from 'enzyme';
import Adapter from 'enzyme-adapter-react-16';
import { shallow } from 'enzyme';
import sinon from 'sinon';
import ReactHTMLTableToExcel from '../src/ReactHTMLTableToExcel';

configure({ adapter: new Adapter() });

chai.use(chaiEnzyme());

const props = {
Expand Down